23142 2009-01-06 12:16:57 -0800 ThreadGlobalData leaks seen on buildbot 2009-01-06 23:24:37 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://buildbotsafari.apple.com/build_results/post-build-leopard-leak-tests/4083/Leak/DumpRenderTree2-leaks.txt P2 Normal --- 1 ap ap slewis oldest_to_newest 104597 0 ap 2009-01-06 12:16:57 -0800 Looks like the per-thread value isn't available from within destructor on Mac OS X, even though we don't clear it yet. 104603 1 26467 ap 2009-01-06 12:33:23 -0800 Created attachment 26467 proposed fix 104662 2 26467 darin 2009-01-06 16:05:47 -0800 Comment on attachment 26467 proposed fix > + * wtf/ThreadSpecific.h: (WTF::::destroy): Temporarily reset the thread specific value > + to make getter work on Mac OS X. WTF::::destroy is not the name of the function. prepare-ChangeLog failed and needs human assistance. r=me 104692 3 ap 2009-01-06 23:24:37 -0800 Committed revision 39672. 26467 2009-01-06 12:33:23 -0800 2009-01-06 16:05:47 -0800 proposed fix ThreadSpecificLeaks.txt text/plain 1549 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NjU5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMDYgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzE0MgorICAgICAgICBUaHJlYWRHbG9iYWxEYXRhIGxlYWtzIHNlZW4gb24gYnVpbGRi b3QKKworICAgICAgICAqIHd0Zi9UaHJlYWRTcGVjaWZpYy5oOiAoV1RGOjo6OmRlc3Ryb3kpOiBU ZW1wb3JhcmlseSByZXNldCB0aGUgdGhyZWFkIHNwZWNpZmljIHZhbHVlCisgICAgICAgIHRvIG1h a2UgZ2V0dGVyIHdvcmsgb24gTWFjIE9TIFguCisKIDIwMDktMDEtMDYgIEFkYW0gUm9iZW4gIDxh cm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhvcGVmdWwgV2luZG93cyBjcmFzaC1vbi1sYXVu Y2ggZml4CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU3BlY2lmaWMuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU3BlY2lmaWMuaAkocmV2aXNpb24gMzk2 NTUpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkU3BlY2lmaWMuaAkod29ya2luZyBjb3B5 KQpAQCAtOTcsMTAgKzk3LDEyIEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQ+CiBpbmxpbmUgdm9pZCBU aHJlYWRTcGVjaWZpYzxUPjo6ZGVzdHJveSh2b2lkKiBwdHIpCiB7CiAgICAgRGF0YSogZGF0YSA9 IHN0YXRpY19jYXN0PERhdGEqPihwdHIpOworCisgICAgLy8gV2Ugd2FudCBnZXQoKSB0byBrZWVw IHdvcmtpbmcgd2hpbGUgZGF0YSBkZXN0cnVjdG9yIHdvcmtzLCBiZWNhdXNlIGl0IGNhbiBiZSBj YWxsZWQgaW5kaXJlY3RseSBieSB0aGUgZGVzdHJ1Y3Rvci4KKyAgICAvLyBTb21lIHB0aHJlYWRz IGltcGxlbWVudGF0aW9ucyB6ZXJvIG91dCB0aGUgcG9pbnRlciBiZWZvcmUgY2FsbGluZyBkZXN0 cm95KCksIHNvIHdlIHRlbXBvcmFyaWx5IHJlc2V0IGl0LgorICAgIHB0aHJlYWRfc2V0c3BlY2lm aWMoZGF0YS0+b3duZXItPm1fa2V5LCBwdHIpOwogICAgIGRhdGEtPnZhbHVlLT5+VCgpOwogICAg IGZhc3RGcmVlKGRhdGEtPnZhbHVlKTsKLSAgICAvLyBPbmx5IHJlc2V0IHRoZSBwb2ludGVyIGFm dGVyIHZhbHVlIGRlc3RydWN0b3IgZmluaXNoZXMgLSBvdGhlcndpc2UsIGNvZGUgaW4gZGVzdHJ1 Y3RvciBjb3VsZCB0cmlnZ2VyCi0gICAgLy8gcmUtY3JlYXRpb24gb2YgdGhlIG9iamVjdC4KICAg ICBwdGhyZWFkX3NldHNwZWNpZmljKGRhdGEtPm93bmVyLT5tX2tleSwgMCk7CiAgICAgZGVsZXRl IGRhdGE7CiB9Cg==