231417 2021-10-08 03:48:26 -0700 Refactor shouldAutofocus to only call trivial Document getters 2021-10-15 03:49:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 youennf youennf cdumez changseok darin esprehn+autocc ews-watchlist ggaren gyuyoung.kim mifenton ntim rniwa webkit-bug-importer oldest_to_newest 1801983 0 youennf 2021-10-08 03:48:26 -0700 Refactor shouldAutofocus to only call trivial Document getters 1801988 1 440590 youennf 2021-10-08 04:07:40 -0700 Created attachment 440590 Patch 1802367 2 440590 rniwa 2021-10-09 01:23:18 -0700 Comment on attachment 440590 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440590&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:210 > auto& document = element.document(); We really need to store this in Ref. r- because of this. 1804758 3 webkit-bug-importer 2021-10-15 03:49:16 -0700 <rdar://problem/84296162> 440590 2021-10-08 04:07:40 -0700 2021-10-09 01:23:18 -0700 Patch bug-231417-20211008130739.patch text/plain 7011 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMzMzc3MjJlNGRmZTNi ZmVmYzQ0MDMyY2VjNDdhZmVkMzZjNzFiNy4uNTdiZDUxNTE1MTM1MWMxOGYxMmViZDE2YzM3YjUw OWU2ZGE5ZmViZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTEwLTA4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWZhY3RvciBzaG91bGRB dXRvZm9jdXMgdG8gb25seSBjYWxsIHRyaXZpYWwgRG9jdW1lbnQgZ2V0dGVycworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNDE3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gaW1wcm92ZSBjb2RlIHJv YnVzdG5lc3MsIHdlIG1vdmUgbXV0YWJsZSBmdW5jdGlvbiBjYWxscyBvdXRzaWRlIG9mIHNob3Vs ZEF1dG9mb2N1cy4KKyAgICAgICAgV2UgcmVuYW1lIHNob3VsZEF1dG9mb2N1cyBpbnRvIGNvbXB1 dGVBdXRvZm9jdXNEZWNpc2lvbiB3aGljaCBub3cgcmV0dXJucyBhbiBlbnVtIGFuZCBvbmx5IGNh bGxzIHRyaXZpYWwgZ2V0dGVycy4KKyAgICAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlk QXR0YWNoUmVuZGVyZXJzIGlzIG5vdyBjYWxsaW5nIG11dGFibGUgZnVuY3Rpb25zIGJhc2VkIG9u IHRoZSByZXN1bHQgb2YgY29tcHV0ZUF1dG9mb2N1c0RlY2lzaW9uLgorCisgICAgICAgIE5vIGNo YW5nZSBvZiBiZWhhdmlvci4KKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVu dC5jcHA6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50Lmg6CisKIDIwMjEt MTAtMDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBz dXBwb3J0IGZvciBwcm9jZXNzaW5nIHB1c2ggZXZlbnRzIHdpdGhvdXQgc2VydmljZSB3b3JrZXIg Y2xpZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5j cHAKaW5kZXggOWIyNjk3NmE2MDM0YTgwNWZmMDlkYTY0NGY1NmMxMWVkOWZkYTFiYy4uY2UwZGU4 YTNlMzVjODgxMTgxMDRjYTBhMDkzZTE2ZWQ4ZDdlNDczNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0yMDEsNDMgKzIwMSwzMCBAQCB2 b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnJlcXVpcmVkU3RhdGVDaGFuZ2VkKCkKICAgICBp bnZhbGlkYXRlU3R5bGVGb3JTdWJ0cmVlKCk7CiB9CiAKLXN0YXRpYyBib29sIHNob3VsZEF1dG9m b2N1cyhjb25zdCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50JiBlbGVtZW50KQorZW51bSBjbGFzcyBB dXRvZm9jdXNEZWNpc2lvbiB7IE5vRm9jdXMsIEZvY3VzLCBCbG9ja2VkQXNTYW5kYm94ZWQsIEJs b2NrZWRBc0Nyb3NzT3JpZ2luIH07CitzdGF0aWMgQXV0b2ZvY3VzRGVjaXNpb24gY29tcHV0ZUF1 dG9mb2N1c0RlY2lzaW9uKGNvbnN0IEhUTUxGb3JtQ29udHJvbEVsZW1lbnQmIGVsZW1lbnQpCiB7 Ci0gICAgaWYgKCFlbGVtZW50LnJlbmRlcmVyKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICBpZiAoIWVsZW1lbnQuaGFzQXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihhdXRvZm9j dXNBdHRyKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlmICghZWxlbWVudC5yZW5kZXJl cigpIHx8ICFlbGVtZW50Lmhhc0F0dHJpYnV0ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24oYXV0b2Zv Y3VzQXR0cikgfHwgIWVsZW1lbnQuaXNDb25uZWN0ZWQoKSkKKyAgICAgICAgcmV0dXJuIEF1dG9m b2N1c0RlY2lzaW9uOjpOb0ZvY3VzOwogCiAgICAgYXV0byYgZG9jdW1lbnQgPSBlbGVtZW50LmRv Y3VtZW50KCk7Ci0gICAgaWYgKCFlbGVtZW50LmlzQ29ubmVjdGVkKCkgfHwgIWRvY3VtZW50LnJl bmRlclZpZXcoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGlmIChkb2N1bWVudC5pc1Nh bmRib3hlZChTYW5kYm94QXV0b21hdGljRmVhdHVyZXMpKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBU aGlzIG1lc3NhZ2Ugc2hvdWxkIGJlIG1vdmVkIG9mZiB0aGUgY29uc29sZSBvbmNlIGEgc29sdXRp b24gdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzI3NCBleGlz dHMuCi0gICAgICAgIGRvY3VtZW50LmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OlNl Y3VyaXR5LCBNZXNzYWdlTGV2ZWw6OkVycm9yLCAiQmxvY2tlZCBhdXRvZm9jdXNpbmcgb24gYSBm b3JtIGNvbnRyb2wgYmVjYXVzZSB0aGUgZm9ybSdzIGZyYW1lIGlzIHNhbmRib3hlZCBhbmQgdGhl ICdhbGxvdy1zY3JpcHRzJyBwZXJtaXNzaW9uIGlzIG5vdCBzZXQuIl9zKTsKLSAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgIH0KLSAgICBpZiAoIWRvY3VtZW50LmZyYW1lKCktPmlzTWFpbkZyYW1l KCkgJiYgIWRvY3VtZW50LnRvcE9yaWdpbigpLmlzU2FtZU9yaWdpbkRvbWFpbihkb2N1bWVudC5z ZWN1cml0eU9yaWdpbigpKSkgewotICAgICAgICBkb2N1bWVudC5hZGRDb25zb2xlTWVzc2FnZShN ZXNzYWdlU291cmNlOjpTZWN1cml0eSwgTWVzc2FnZUxldmVsOjpFcnJvciwgIkJsb2NrZWQgYXV0 b2ZvY3VzaW5nIG9uIGEgZm9ybSBjb250cm9sIGluIGEgY3Jvc3Mtb3JpZ2luIHN1YmZyYW1lLiJf cyk7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CisgICAgaWYgKCFkb2N1bWVudC5yZW5k ZXJWaWV3KCkpCisgICAgICAgIHJldHVybiBBdXRvZm9jdXNEZWNpc2lvbjo6Tm9Gb2N1czsKKyAg ICBpZiAoZG9jdW1lbnQuaXNTYW5kYm94ZWQoU2FuZGJveEF1dG9tYXRpY0ZlYXR1cmVzKSkKKyAg ICAgICAgcmV0dXJuIEF1dG9mb2N1c0RlY2lzaW9uOjpCbG9ja2VkQXNTYW5kYm94ZWQ7CisgICAg aWYgKCFkb2N1bWVudC5mcmFtZSgpLT5pc01haW5GcmFtZSgpICYmICFkb2N1bWVudC50b3BPcmln aW4oKS5pc1NhbWVPcmlnaW5Eb21haW4oZG9jdW1lbnQuc2VjdXJpdHlPcmlnaW4oKSkpCisgICAg ICAgIHJldHVybiBBdXRvZm9jdXNEZWNpc2lvbjo6QmxvY2tlZEFzQ3Jvc3NPcmlnaW47CiAKICAg ICBpZiAoZWxlbWVudC5oYXNBdXRvZm9jdXNlZCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Cisg ICAgICAgIHJldHVybiBBdXRvZm9jdXNEZWNpc2lvbjo6Tm9Gb2N1czsKIAotICAgIC8vIEZJWE1F OiBTaG91bGQgdGhpcyBzZXQgb2YgaGFzVGFnTmFtZSBjaGVja3MgYmUgcmVwbGFjZWQgYnkgYQot ICAgIC8vIHZpcnR1YWwgbWVtYmVyIGZ1bmN0aW9uPworICAgIC8vIEZJWE1FOiBTaG91bGQgdGhp cyBzZXQgb2YgaGFzVGFnTmFtZSBjaGVja3MgYmUgcmVwbGFjZWQgYnkgYSB2aXJ0dWFsIG1lbWJl ciBmdW5jdGlvbj8KICAgICBpZiAoaXM8SFRNTElucHV0RWxlbWVudD4oZWxlbWVudCkpCi0gICAg ICAgIHJldHVybiAhZG93bmNhc3Q8SFRNTElucHV0RWxlbWVudD4oZWxlbWVudCkuaXNJbnB1dFR5 cGVIaWRkZW4oKTsKLSAgICBpZiAoZWxlbWVudC5oYXNUYWdOYW1lKHNlbGVjdFRhZykpCi0gICAg ICAgIHJldHVybiB0cnVlOwotICAgIGlmIChlbGVtZW50Lmhhc1RhZ05hbWUoa2V5Z2VuVGFnKSkK LSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKGVsZW1lbnQuaGFzVGFnTmFtZShidXR0b25U YWcpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAoaXM8SFRNTFRleHRBcmVhRWxlbWVu dD4oZWxlbWVudCkpCi0gICAgICAgIHJldHVybiB0cnVlOworICAgICAgICByZXR1cm4gZG93bmNh c3Q8SFRNTElucHV0RWxlbWVudD4oZWxlbWVudCkuaXNJbnB1dFR5cGVIaWRkZW4oKSA/IEF1dG9m b2N1c0RlY2lzaW9uOjpOb0ZvY3VzIDogQXV0b2ZvY3VzRGVjaXNpb246OkZvY3VzOworICAgIGlm IChlbGVtZW50Lmhhc1RhZ05hbWUoc2VsZWN0VGFnKSB8fCBlbGVtZW50Lmhhc1RhZ05hbWUoa2V5 Z2VuVGFnKSB8fCBlbGVtZW50Lmhhc1RhZ05hbWUoYnV0dG9uVGFnKSB8fCBpczxIVE1MVGV4dEFy ZWFFbGVtZW50PihlbGVtZW50KSkKKyAgICAgICAgcmV0dXJuIEF1dG9mb2N1c0RlY2lzaW9uOjpG b2N1czsKIAotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gQXV0b2ZvY3VzRGVjaXNpb246 Ok5vRm9jdXM7CiB9CiAKIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlkQXR0YWNoUmVu ZGVyZXJzKCkKQEAgLTI0OCwyMCArMjM1LDM1IEBAIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVu dDo6ZGlkQXR0YWNoUmVuZGVyZXJzKCkKICAgICBpZiAocmVuZGVyZXIoKSkKICAgICAgICAgcmVu ZGVyZXIoKS0+dXBkYXRlRnJvbUVsZW1lbnQoKTsKIAotICAgIGlmIChzaG91bGRBdXRvZm9jdXMo KnRoaXMpKSB7Ci0gICAgICAgIHNldEF1dG9mb2N1c2VkKCk7CisgICAgc3dpdGNoIChjb21wdXRl QXV0b2ZvY3VzRGVjaXNpb24oKnRoaXMpKSB7CisgICAgY2FzZSBBdXRvZm9jdXNEZWNpc2lvbjo6 Tm9Gb2N1czoKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBBdXRvZm9jdXNEZWNpc2lvbjo6Rm9j dXM6CisgICAgICAgIGRvRm9jdXMoKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBBdXRvZm9j dXNEZWNpc2lvbjo6QmxvY2tlZEFzU2FuZGJveGVkOgorICAgICAgICAvLyBGSVhNRTogVGhpcyBt ZXNzYWdlIHNob3VsZCBiZSBtb3ZlZCBvZmYgdGhlIGNvbnNvbGUgb25jZSBhIHNvbHV0aW9uIHRv IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDMyNzQgZXhpc3RzLgor ICAgICAgICBkb2N1bWVudCgpLmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OlNlY3Vy aXR5LCBNZXNzYWdlTGV2ZWw6OkVycm9yLCAiQmxvY2tlZCBhdXRvZm9jdXNpbmcgb24gYSBmb3Jt IGNvbnRyb2wgYmVjYXVzZSB0aGUgZm9ybSdzIGZyYW1lIGlzIHNhbmRib3hlZCBhbmQgdGhlICdh bGxvdy1zY3JpcHRzJyBwZXJtaXNzaW9uIGlzIG5vdCBzZXQuIl9zKTsKKyAgICAgICAgYnJlYWs7 CisgICAgY2FzZSBBdXRvZm9jdXNEZWNpc2lvbjo6QmxvY2tlZEFzQ3Jvc3NPcmlnaW46CisgICAg ICAgIGRvY3VtZW50KCkuYWRkQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJjZTo6U2VjdXJpdHks IE1lc3NhZ2VMZXZlbDo6RXJyb3IsICJCbG9ja2VkIGF1dG9mb2N1c2luZyBvbiBhIGZvcm0gY29u dHJvbCBpbiBhIGNyb3NzLW9yaWdpbiBzdWJmcmFtZS4iX3MpOworICAgICAgICBicmVhazsKKyAg ICB9Cit9CiAKLSAgICAgICAgUmVmUHRyPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+IGVsZW1lbnQg PSB0aGlzOwotICAgICAgICBSZWZQdHIgZnJhbWVWaWV3ID0gZG9jdW1lbnQoKS52aWV3KCk7Ci0g ICAgICAgIGlmIChmcmFtZVZpZXcgJiYgZnJhbWVWaWV3LT5sYXlvdXRDb250ZXh0KCkuaXNJbkxh eW91dCgpKSB7Ci0gICAgICAgICAgICBmcmFtZVZpZXctPnF1ZXVlUG9zdExheW91dENhbGxiYWNr KFtlbGVtZW50XSB7Ci0gICAgICAgICAgICAgICAgZWxlbWVudC0+Zm9jdXMoeyBTZWxlY3Rpb25S ZXN0b3JhdGlvbk1vZGU6OlBsYWNlQ2FyZXRBdFN0YXJ0IH0pOwotICAgICAgICAgICAgfSk7Ci0g ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBTdHlsZTo6ZGVwcmVjYXRlZFF1ZXVlUG9zdFJl c29sdXRpb25DYWxsYmFjayhbZWxlbWVudF0gewotICAgICAgICAgICAgICAgIGVsZW1lbnQtPmZv Y3VzKHsgU2VsZWN0aW9uUmVzdG9yYXRpb25Nb2RlOjpQbGFjZUNhcmV0QXRTdGFydCB9KTsKLSAg ICAgICAgICAgIH0pOwotICAgICAgICB9Cit2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmRv Rm9jdXMoKQoreworICAgIHNldEF1dG9mb2N1c2VkKCk7CisKKyAgICBSZWZQdHIgZnJhbWVWaWV3 ID0gZG9jdW1lbnQoKS52aWV3KCk7CisgICAgaWYgKGZyYW1lVmlldyAmJiBmcmFtZVZpZXctPmxh eW91dENvbnRleHQoKS5pc0luTGF5b3V0KCkpIHsKKyAgICAgICAgZnJhbWVWaWV3LT5xdWV1ZVBv c3RMYXlvdXRDYWxsYmFjayhbZWxlbWVudCA9IFJlZiB7ICp0aGlzIH1dIHsKKyAgICAgICAgICAg IGVsZW1lbnQtPmZvY3VzKHsgU2VsZWN0aW9uUmVzdG9yYXRpb25Nb2RlOjpQbGFjZUNhcmV0QXRT dGFydCB9KTsKKyAgICAgICAgfSk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgU3R5bGU6OmRlcHJl Y2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2soW2VsZW1lbnQgPSBSZWYgeyAqdGhpcyB9 XSB7CisgICAgICAgICAgICBlbGVtZW50LT5mb2N1cyh7IFNlbGVjdGlvblJlc3RvcmF0aW9uTW9k ZTo6UGxhY2VDYXJldEF0U3RhcnQgfSk7CisgICAgICAgIH0pOwogICAgIH0KIH0KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRleCAyNWUzNDUwMGVh YWE2MGFjZmY5OTU0YzRmYWJlMzU3NTQ1ZmUyOTE1Li5jNjdkM2FhY2U0MGU0MDNhYzhjYTMwYTgw N2JiYTJjYTk0YjE3YjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3Jt Q29udHJvbEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuaApAQCAtMTg5LDYgKzE4OSw4IEBAIHByaXZhdGU6CiAKICAgICBib29sIG5lZWRz TW91c2VGb2N1c2FibGVRdWlyaygpIGNvbnN0OwogCisgICAgdm9pZCBkb0ZvY3VzKCk7CisKICAg ICBzdGQ6OnVuaXF1ZV9wdHI8VmFsaWRhdGlvbk1lc3NhZ2U+IG1fdmFsaWRhdGlvbk1lc3NhZ2U7 CiAgICAgCiAgICAgdW5zaWduZWQgbV9kZWxheWVkVXBkYXRlVmFsaWRpdHlDb3VudCB7IDAgfTsK