231405 2021-10-07 17:53:04 -0700 [GPU Process] Unique RenderingResourceIdentifiers Part 3: Uniquify in wakeUpAndApplyDisplayList 2021-10-08 09:32:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 217638 1 mmaxfield mmaxfield bfulgham cdumez simon.fraser webkit-bug-importer zalan oldest_to_newest 1801891 0 mmaxfield 2021-10-07 17:53:04 -0700 Apply https://commits.webkit.org/242676@main to wakeUpAndApplyDisplayList(). 1801892 1 webkit-bug-importer 2021-10-07 17:53:44 -0700 <rdar://problem/84008003> 1801893 2 440562 mmaxfield 2021-10-07 17:58:05 -0700 Created attachment 440562 Patch 1802124 3 ews-feeder 2021-10-08 09:32:11 -0700 Committed r283807 (242700@main): <https://commits.webkit.org/242700@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440562. 440562 2021-10-07 17:58:05 -0700 2021-10-08 09:32:13 -0700 Patch patch.diff text/plain 7281 mmaxfield ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTc0MTMzNTdlZWZmLi5lMTNlZTAzMDdkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjQgQEAKKzIwMjEtMTAtMDcgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxl LmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIFVuaXF1ZSBSZW5kZXJpbmdSZXNvdXJjZUlk ZW50aWZpZXJzIFBhcnQgMzogVW5pcXVpZnkgaW4gd2FrZVVwQW5kQXBwbHlEaXNwbGF5TGlzdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxNDA1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NDAwODAwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHNpbXBseSBhcHBsaWVzIHRoZSBzYW1lIHRy ZWF0bWVudCBpbiBodHRwczovL2NvbW1pdHMud2Via2l0Lm9yZy8yNDI2NzZAbWFpbiB0bworICAg ICAgICBSZW1vdGVSZW5kZXJpbmdCYWNrZW5kOjp3YWtlVXBBbmRBcHBseURpc3BsYXlMaXN0KCku IFRoaXMgaXMgYmVpbmcgZG9uZSBpbiBhIGZvbGxvdy11cAorICAgICAgICBwYXRjaCBiZWNhdXNl IGl0IHJlbGllcyBvbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMx NDAzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9y IGNoYW5nZS4KKworICAgICAgICAqIEdQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5n QmFja2VuZC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6Ondh a2VVcEFuZEFwcGx5RGlzcGxheUxpc3QpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVSZW5kZXJp bmdCYWNrZW5kOjp3YWtlVXBBbmRBcHBseURpc3BsYXlMaXN0V2l0aFF1YWxpZmllZElkZW50aWZp ZXIpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVSZW5kZXJpbmdCYWNrZW5kOjpyZXN1bWVGcm9t UGVuZGluZ1dha2V1cEluZm9ybWF0aW9uKToKKyAgICAgICAgKiBHUFVQcm9jZXNzL2dyYXBoaWNz L1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuaDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlUmVuZGVy aW5nQmFja2VuZDo6UGVuZGluZ1dha2V1cEluZm9ybWF0aW9uOjphcmd1bWVudHMgY29uc3QpOiBE ZWxldGVkLgorCiAyMDIxLTEwLTA3ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CiAKICAgICAgICAgW0dQVSBQcm9jZXNzXSBVbmlxdWUgUmVuZGVyaW5nUmVzb3VyY2VJ ZGVudGlmaWVycyBQYXJ0IDI6IFVucm9sbCBQZW5kaW5nV2FrZXVwSW5mb3JtYXRpb246OmFyZ3Vt ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90 ZVJlbmRlcmluZ0JhY2tlbmQuY3BwIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNz L1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCmluZGV4IGI3ZjBmZjg2ZTZmOC4uM2Y4NDUxY2Qx NTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3Rl UmVuZGVyaW5nQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBo aWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCkBAIC0zMzYsNiArMzM2LDEzIEBAIFJlZlB0 cjxJbWFnZUJ1ZmZlcj4gUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6bmV4dERlc3RpbmF0aW9uSW1h Z2VCdWZmZXJBZnRlckFwcGx5CiB9CiAKIHZvaWQgUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6d2Fr ZVVwQW5kQXBwbHlEaXNwbGF5TGlzdChjb25zdCBHUFVQcm9jZXNzV2FrZXVwTWVzc2FnZUFyZ3Vt ZW50cyYgYXJndW1lbnRzKQoreworICAgIC8vIEltbWVkaWF0ZWx5IHR1cm4gdGhlIFJlbmRlcmlu Z1Jlc291cmNlSWRlbnRpZmllciAod2hpY2ggaXMgZXJyb3ItcHJvbmUpIHRvIGEgUXVhbGlmaWVk UmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyLAorICAgIC8vIGFuZCB1c2UgYSBoZWxwZXIgZnVu Y3Rpb24gdG8gbWFrZSBzdXJlIHRoYXQgZG9uJ3QgYWNjaWRlbnRhbGx5IHVzZSB0aGUgUmVuZGVy aW5nUmVzb3VyY2VJZGVudGlmaWVyIChiZWNhdXNlIHRoZSBoZWxwZXIgZnVuY3Rpb24gY2FuJ3Qg c2VlIGl0KS4KKyAgICB3YWtlVXBBbmRBcHBseURpc3BsYXlMaXN0V2l0aFF1YWxpZmllZElkZW50 aWZpZXIoYXJndW1lbnRzLml0ZW1CdWZmZXJJZGVudGlmaWVyLCBhcmd1bWVudHMub2Zmc2V0LCB7 IGFyZ3VtZW50cy5kZXN0aW5hdGlvbkltYWdlQnVmZmVySWRlbnRpZmllciwgbV9ncHVDb25uZWN0 aW9uVG9XZWJQcm9jZXNzLT53ZWJQcm9jZXNzSWRlbnRpZmllcigpIH0sIGFyZ3VtZW50cy5yZWFz b24pOworfQorCit2b2lkIFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6Ondha2VVcEFuZEFwcGx5RGlz cGxheUxpc3RXaXRoUXVhbGlmaWVkSWRlbnRpZmllcihXZWJDb3JlOjpEaXNwbGF5TGlzdDo6SXRl bUJ1ZmZlcklkZW50aWZpZXIgaXRlbUJ1ZmZlcklkZW50aWZpZXIsIHVpbnQ2NF90IG9mZnNldCwg UXVhbGlmaWVkUmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyIGRlc3RpbmF0aW9uSW1hZ2VCdWZm ZXJJZGVudGlmaWVyLCBHUFVQcm9jZXNzV2FrZXVwUmVhc29uIHJlYXNvbikKIHsKICAgICBBU1NF UlQoIVJ1bkxvb3A6OmlzTWFpbigpKTsKIApAQCAtMzQzLDE0ICszNTAsMTQgQEAgdm9pZCBSZW1v dGVSZW5kZXJpbmdCYWNrZW5kOjp3YWtlVXBBbmRBcHBseURpc3BsYXlMaXN0KGNvbnN0IEdQVVBy b2Nlc3NXYWtldXBNZXMKIAogICAgIHVwZGF0ZUxhc3RLbm93blN0YXRlKFJlbW90ZVJlbmRlcmlu Z0JhY2tlbmRTdGF0ZTo6QmVnYW5SZXBsYXlpbmdEaXNwbGF5TGlzdCk7CiAKLSAgICBSZWZQdHIg ZGVzdGluYXRpb25JbWFnZUJ1ZmZlciA9IG1fcmVtb3RlUmVzb3VyY2VDYWNoZS5jYWNoZWRJbWFn ZUJ1ZmZlcihhcmd1bWVudHMuZGVzdGluYXRpb25JbWFnZUJ1ZmZlcklkZW50aWZpZXIpOworICAg IFJlZlB0ciBkZXN0aW5hdGlvbkltYWdlQnVmZmVyID0gbV9yZW1vdGVSZXNvdXJjZUNhY2hlLmNh Y2hlZEltYWdlQnVmZmVyKGRlc3RpbmF0aW9uSW1hZ2VCdWZmZXJJZGVudGlmaWVyLm9iamVjdCgp KTsKICAgICBNRVNTQUdFX0NIRUNLKGRlc3RpbmF0aW9uSW1hZ2VCdWZmZXIsICJNaXNzaW5nIGRl c3RpbmF0aW9uIGltYWdlIGJ1ZmZlciIpOwogCi0gICAgYXV0byBpbml0aWFsSGFuZGxlID0gbV9z aGFyZWREaXNwbGF5TGlzdEhhbmRsZXMuZ2V0KGFyZ3VtZW50cy5pdGVtQnVmZmVySWRlbnRpZmll cik7CisgICAgYXV0byBpbml0aWFsSGFuZGxlID0gbV9zaGFyZWREaXNwbGF5TGlzdEhhbmRsZXMu Z2V0KGl0ZW1CdWZmZXJJZGVudGlmaWVyKTsKICAgICBNRVNTQUdFX0NIRUNLKGluaXRpYWxIYW5k bGUsICJNaXNzaW5nIGluaXRpYWwgc2hhcmVkIGRpc3BsYXkgbGlzdCBoYW5kbGUiKTsKIAotICAg IExPR19XSVRIX1NUUkVBTShTaGFyZWREaXNwbGF5TGlzdHMsIHN0cmVhbSA8PCAiV2FraW5nIHVw IHRvIEl0ZW1zWyIgPDwgYXJndW1lbnRzLml0ZW1CdWZmZXJJZGVudGlmaWVyIDw8ICJdID0+IElt YWdlKCIgPDwgYXJndW1lbnRzLmRlc3RpbmF0aW9uSW1hZ2VCdWZmZXJJZGVudGlmaWVyIDw8ICIp IGF0ICIgPDwgYXJndW1lbnRzLm9mZnNldCk7Ci0gICAgZGVzdGluYXRpb25JbWFnZUJ1ZmZlciA9 IG5leHREZXN0aW5hdGlvbkltYWdlQnVmZmVyQWZ0ZXJBcHBseWluZ0Rpc3BsYXlMaXN0cygqZGVz dGluYXRpb25JbWFnZUJ1ZmZlciwgYXJndW1lbnRzLm9mZnNldCwgKmluaXRpYWxIYW5kbGUsIGFy Z3VtZW50cy5yZWFzb24pOworICAgIExPR19XSVRIX1NUUkVBTShTaGFyZWREaXNwbGF5TGlzdHMs IHN0cmVhbSA8PCAiV2FraW5nIHVwIHRvIEl0ZW1zWyIgPDwgaXRlbUJ1ZmZlcklkZW50aWZpZXIg PDwgIl0gPT4gSW1hZ2UoIiA8PCBkZXN0aW5hdGlvbkltYWdlQnVmZmVySWRlbnRpZmllci5vYmpl Y3QoKSA8PCAiKSBhdCAiIDw8IG9mZnNldCk7CisgICAgZGVzdGluYXRpb25JbWFnZUJ1ZmZlciA9 IG5leHREZXN0aW5hdGlvbkltYWdlQnVmZmVyQWZ0ZXJBcHBseWluZ0Rpc3BsYXlMaXN0cygqZGVz dGluYXRpb25JbWFnZUJ1ZmZlciwgb2Zmc2V0LCAqaW5pdGlhbEhhbmRsZSwgcmVhc29uKTsKIAog ICAgIC8vIEZJWE1FOiBBbGwgdGhlIGNhbGxlcnMgcGFzcyBtX3BlbmRpbmdXYWtldXBJbmZvJ3Mg ZmllbGRzIHNvIHRoZSBib2R5IG9mIHRoaXMgZnVuY3Rpb24gc2hvdWxkIGp1c3QgYmUgdGhpcyBs b29wLgogICAgIHdoaWxlIChkZXN0aW5hdGlvbkltYWdlQnVmZmVyICYmIG1fcGVuZGluZ1dha2V1 cEluZm8pIHsKQEAgLTYxNyw5ICs2MjQsMTIgQEAgdm9pZCBSZW1vdGVSZW5kZXJpbmdCYWNrZW5k OjpkaWRDcmVhdGVTaGFyZWREaXNwbGF5TGlzdEhhbmRsZVdpdGhRdWFsaWZpZWRJZGVudGkKIAog dm9pZCBSZW1vdGVSZW5kZXJpbmdCYWNrZW5kOjpyZXN1bWVGcm9tUGVuZGluZ1dha2V1cEluZm9y bWF0aW9uKCkKIHsKLSAgICBhdXRvIGFyZ3VtZW50cyA9IG1fcGVuZGluZ1dha2V1cEluZm8tPmFy Z3VtZW50cygpOworICAgIGF1dG8gaXRlbUJ1ZmZlcklkZW50aWZpZXIgPSBtX3BlbmRpbmdXYWtl dXBJbmZvLT5pdGVtQnVmZmVySWRlbnRpZmllcjsKKyAgICBhdXRvIG9mZnNldCA9IG1fcGVuZGlu Z1dha2V1cEluZm8tPm9mZnNldDsKKyAgICBRdWFsaWZpZWRSZW5kZXJpbmdSZXNvdXJjZUlkZW50 aWZpZXIgZGVzdGluYXRpb25JbWFnZUJ1ZmZlcklkZW50aWZpZXIgeyBtX3BlbmRpbmdXYWtldXBJ bmZvLT5kZXN0aW5hdGlvbkltYWdlQnVmZmVySWRlbnRpZmllciwgbV9ncHVDb25uZWN0aW9uVG9X ZWJQcm9jZXNzLT53ZWJQcm9jZXNzSWRlbnRpZmllcigpIH07CisgICAgYXV0byByZWFzb24gPSBt X3BlbmRpbmdXYWtldXBJbmZvLT5yZWFzb247CiAgICAgbV9wZW5kaW5nV2FrZXVwSW5mbyA9IHN0 ZDo6bnVsbG9wdDsKLSAgICB3YWtlVXBBbmRBcHBseURpc3BsYXlMaXN0KGFyZ3VtZW50cyk7Cisg ICAgd2FrZVVwQW5kQXBwbHlEaXNwbGF5TGlzdFdpdGhRdWFsaWZpZWRJZGVudGlmaWVyKGl0ZW1C dWZmZXJJZGVudGlmaWVyLCBvZmZzZXQsIGRlc3RpbmF0aW9uSW1hZ2VCdWZmZXJJZGVudGlmaWVy LCByZWFzb24pOwogfQogCiB2b2lkIFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6OmRpZENyZWF0ZU1h c2tJbWFnZUJ1ZmZlcihJbWFnZUJ1ZmZlciYgaW1hZ2VCdWZmZXIpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZC5oIGIv U291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQu aAppbmRleCA3NDRjOTQxNGU1MjQuLjY1YjQ0YWM1MWJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuaAorKysgYi9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZC5o CkBAIC0xNTEsNiArMTUxLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGRpZENyZWF0ZVNoYXJlZERp c3BsYXlMaXN0SGFuZGxlKFdlYkNvcmU6OkRpc3BsYXlMaXN0OjpJdGVtQnVmZmVySWRlbnRpZmll ciwgY29uc3QgU2hhcmVkTWVtb3J5OjpJUENIYW5kbGUmLCBXZWJDb3JlOjpSZW5kZXJpbmdSZXNv dXJjZUlkZW50aWZpZXIgZGVzdGluYXRpb25CdWZmZXJJZGVudGlmaWVyKTsKIAogICAgIC8vIFJl Y2VpdmVkIG1lc3NhZ2VzIHRyYW5zbGF0ZWQgdG8gdXNlIFF1YWxpZmllZFJlbmRlcmluZ1Jlc291 cmNlSWRlbnRpZmllci4KKyAgICB2b2lkIHdha2VVcEFuZEFwcGx5RGlzcGxheUxpc3RXaXRoUXVh bGlmaWVkSWRlbnRpZmllcihXZWJDb3JlOjpEaXNwbGF5TGlzdDo6SXRlbUJ1ZmZlcklkZW50aWZp ZXIsIHVpbnQ2NF90IG9mZnNldCwgUXVhbGlmaWVkUmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVy LCBHUFVQcm9jZXNzV2FrZXVwUmVhc29uKTsKICAgICB2b2lkIGNyZWF0ZUltYWdlQnVmZmVyV2l0 aFF1YWxpZmllZElkZW50aWZpZXIoY29uc3QgV2ViQ29yZTo6RmxvYXRTaXplJiBsb2dpY2FsU2l6 ZSwgV2ViQ29yZTo6UmVuZGVyaW5nTW9kZSwgZmxvYXQgcmVzb2x1dGlvblNjYWxlLCBjb25zdCBX ZWJDb3JlOjpEZXN0aW5hdGlvbkNvbG9yU3BhY2UmLCBXZWJDb3JlOjpQaXhlbEZvcm1hdCwgUXVh bGlmaWVkUmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyKTsKICAgICB2b2lkIGdldERhdGFVUkxG b3JJbWFnZUJ1ZmZlcldpdGhRdWFsaWZpZWRJZGVudGlmaWVyKGNvbnN0IFN0cmluZyYgbWltZVR5 cGUsIHN0ZDo6b3B0aW9uYWw8ZG91YmxlPiBxdWFsaXR5LCBXZWJDb3JlOjpQcmVzZXJ2ZVJlc29s dXRpb24sIFF1YWxpZmllZFJlbmRlcmluZ1Jlc291cmNlSWRlbnRpZmllciwgQ29tcGxldGlvbkhh bmRsZXI8dm9pZChTdHJpbmcmJik+JiYpOwogICAgIHZvaWQgZ2V0RGF0YUZvckltYWdlQnVmZmVy V2l0aFF1YWxpZmllZElkZW50aWZpZXIoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgc3RkOjpvcHRp b25hbDxkb3VibGU+IHF1YWxpdHksIFF1YWxpZmllZFJlbmRlcmluZ1Jlc291cmNlSWRlbnRpZmll ciwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChWZWN0b3I8dWludDhfdD4mJik+JiYpOwpAQCAtMTg0 LDExICsxODUsNiBAQCBwcml2YXRlOgogICAgICAgICBzdGQ6Om9wdGlvbmFsPFdlYkNvcmU6OlJl bmRlcmluZ1Jlc291cmNlSWRlbnRpZmllcj4gbWlzc2luZ0NhY2hlZFJlc291cmNlSWRlbnRpZmll cjsKICAgICAgICAgUmVtb3RlUmVuZGVyaW5nQmFja2VuZFN0YXRlIHN0YXRlIHsgUmVtb3RlUmVu ZGVyaW5nQmFja2VuZFN0YXRlOjpJbml0aWFsaXplZCB9OwogCi0gICAgICAgIEdQVVByb2Nlc3NX YWtldXBNZXNzYWdlQXJndW1lbnRzIGFyZ3VtZW50cygpIGNvbnN0Ci0gICAgICAgIHsKLSAgICAg ICAgICAgIHJldHVybiB7IGl0ZW1CdWZmZXJJZGVudGlmaWVyLCBvZmZzZXQsIGRlc3RpbmF0aW9u SW1hZ2VCdWZmZXJJZGVudGlmaWVyLCByZWFzb24gfTsKLSAgICAgICAgfQotCiAgICAgICAgIGJv b2wgc2hvdWxkUGVyZm9ybVdha2V1cChXZWJDb3JlOjpSZW5kZXJpbmdSZXNvdXJjZUlkZW50aWZp ZXIgaWRlbnRpZmllcikgY29uc3QKICAgICAgICAgewogICAgICAgICAgICAgcmV0dXJuIGRlc3Rp bmF0aW9uSW1hZ2VCdWZmZXJJZGVudGlmaWVyID09IGlkZW50aWZpZXIK