231376 2021-10-07 10:57:49 -0700 CSSProperties.json should not require a 'converter' for color properties 2021-10-14 15:50:36 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi esprehn+autocc ews-watchlist glenn gyuyoung.kim joepeck koivisto macpherson menard simon.fraser webkit-bug-importer oldest_to_newest 1801667 0 akeerthi 2021-10-07 10:57:49 -0700 ... 1801900 1 akeerthi 2021-10-07 19:00:24 -0700 Renamed from "makeprop.pl should support 'auto-functions' for color properties", since it technically already does. The only issue was an incorrect value setter, which can be fixed by specifying a 'converter'. However, I feel 'converter' is redundant for 'color-property', given that we already know we need to cover to a Color. 1801901 2 akeerthi 2021-10-07 19:00:46 -0700 (In reply to Aditya Keerthi from comment #1) > Renamed from "makeprop.pl should support 'auto-functions' for color > properties", since it technically already does. The only issue was an > incorrect value setter, which can be fixed by specifying a 'converter'. > > However, I feel 'converter' is redundant for 'color-property', given that we > already know we need to cover to a Color. s/cover/convert/ 1801902 3 440565 akeerthi 2021-10-07 19:04:27 -0700 Created attachment 440565 Patch 1804349 4 webkit-bug-importer 2021-10-14 10:58:15 -0700 <rdar://problem/84264255> 1804382 5 440565 koivisto 2021-10-14 11:40:32 -0700 Comment on attachment 440565 Patch nice! 1804556 6 ews-feeder 2021-10-14 15:50:32 -0700 Committed r284207 (243018@main): <https://commits.webkit.org/243018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440565. 440565 2021-10-07 19:04:27 -0700 2021-10-14 15:50:34 -0700 Patch bug-231376-20211007190426.patch text/plain 7385 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM1MDYzYjJkMzRlMzRi YWNhZDgxMDVjOWFiYjVkNDExMjhmY2VkYS4uNWFiYTEwNWRkZmYwZjI1Yjg2NTRhODAwZjczZGNi M2NmODBhZTE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDIxLTEwLTA3ICBBZGl0 eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KKworICAgICAgICBDU1NQcm9wZXJ0aWVz Lmpzb24gc2hvdWxkIG5vdCByZXF1aXJlIGEgJ2NvbnZlcnRlcicgZm9yIGNvbG9yIHByb3BlcnRp ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTM3 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyODM3 NDIgdXNlZCBTdHlsZUJ1aWxkZXJDdXN0b20gdG8gaW1wbGVtZW50ICdhY2NlbnQtY29sb3InIGFz CisgICAgICAgIHNwZWNpZnlpbmcgJ2F1dG8tZnVuY3Rpb25zJyBhbmQgJ2NvbG9yLXByb3BlcnR5 JyByZXN1bHRlZCBpbiBhbgorICAgICAgICBpbmNvcnJlY3QgdmFsdWUgc2V0dGVyLgorCisgICAg ICAgIFVwb24gZnVydGhlciBpbnZlc3RpZ2F0aW9uLCBzcGVjaWZ5aW5nICdjb252ZXJ0ZXI6IFNW R0NvbG9yJworICAgICAgICBzb2x2ZWQgdGhlIGlzc3VlLCBhcyB0aGUgQ1NTUHJpbWl0aXZlVmFs dWUgd2FzIHRoZW4gY29ycmVjdGx5CisgICAgICAgIGNvbnZlcnRlZCBpbnRvIGEgQ29sb3IuCisK KyAgICAgICAgUmF0aGVyIHRoYW4gcmVuYW1pbmcgdGhlIGNvbnZlcnRlciBmb3IgdXNlIHdpdGgg bm9uLVNWRyBjb2xvcgorICAgICAgICBwcm9wZXJ0aWVzLCB0aGlzIHBhdGNoIHJlbW92ZXMgdGhl IGV4aXN0aW5nIGNvbG9yIGNvbnZlcnRlciBlbnRpcmVseSwKKyAgICAgICAgYXMgdGhlIG5lZWQg Zm9yIGNvbG9yIGNvbnZlcnNpb24gY2FuIGJlIGluZmVycmVkIGZyb20gdGhlIGV4aXN0ZW5jZQor ICAgICAgICBvZiAnY29sb3ItcHJvcGVydHknLgorCisgICAgICAgICogY3NzL0NTU1Byb3BlcnRp ZXMuanNvbjoKKworICAgICAgICBSZW1vdmUgbm93IHVuZWNlc3NhcnkgJ2NvbnZlcnRlcicsIGFu ZCB1c2UgJ2F1dG8tZnVuY3Rpb25zJyBmb3IKKyAgICAgICAgJ2FjY2VudC1jb2xvcicgcmF0aGVy IHRoYW4gJ2N1c3RvbScuCisKKyAgICAgICAgKiBjc3MvbWFrZXByb3AucGw6CisgICAgICAgIChn ZW5lcmF0ZVZhbHVlU2V0dGVyKToKKworICAgICAgICBQZXJmb3JtIENvbG9yIGNvbnZlcnNpb24g ZnJvbSBDU1NQcmltaXRpdmVWYWx1ZSBpZiAnY29sb3ItcHJvcGVydHknCisgICAgICAgIGlzIHNw ZWNpZmllZC4KKworICAgICAgICAqIHN0eWxlL1N0eWxlQnVpbGRlckNvbnZlcnRlci5oOgorICAg ICAgICAoV2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJDb252ZXJ0ZXI6OmNvbnZlcnRTVkdDb2xvcik6 IERlbGV0ZWQuCisgICAgICAgICogc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmg6CisgICAgICAg IChXZWJDb3JlOjpTdHlsZTo6QnVpbGRlckN1c3RvbTo6YXBwbHlJbml0aWFsQWNjZW50Q29sb3Ip OiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OkJ1aWxkZXJDdXN0b206OmFwcGx5 SW5oZXJpdEFjY2VudENvbG9yKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpC dWlsZGVyQ3VzdG9tOjphcHBseVZhbHVlQWNjZW50Q29sb3IpOiBEZWxldGVkLgorCiAyMDIxLTEw LTA3ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg c3VwcG9ydCBmb3IgJy13ZWJraXQtYXBwZWFyYW5jZTogYXV0bycKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0aWVzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UHJvcGVydGllcy5qc29uCmluZGV4IGIzODg0ODMxNzA5MGU5MzYxZDNjZjdkMmJhYTk0YmU4MzRj YzQ0ZDguLjg0NjQ5MWFlNGRlNWM4NmNmZDc2YjBkZjYxMTg0MzliZjkxZWMyODQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0aWVzLmpzb24KKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU1Byb3BlcnRpZXMuanNvbgpAQCAtMjE5LDggKzIxOSw4IEBACiAgICAgICAg ICJhY2NlbnQtY29sb3IiOiB7CiAgICAgICAgICAgICAiaW5oZXJpdGVkIjogdHJ1ZSwKICAgICAg ICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7CisgICAgICAgICAgICAgICAgImF1dG8tZnVu Y3Rpb25zIjogdHJ1ZSwKICAgICAgICAgICAgICAgICAiY29sb3ItcHJvcGVydHkiOiB0cnVlLAot ICAgICAgICAgICAgICAgICJjdXN0b20iOiAiQWxsIiwKICAgICAgICAgICAgICAgICAic2V0dGlu Z3MtZmxhZyI6ICJhY2NlbnRDb2xvckVuYWJsZWQiCiAgICAgICAgICAgICB9LAogICAgICAgICAg ICAgInN0YXR1cyI6IHsKQEAgLTI3NDgsNyArMjc0OCw2IEBACiAgICAgICAgIH0sCiAgICAgICAg ICJmbG9vZC1jb2xvciI6IHsKICAgICAgICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7Ci0g ICAgICAgICAgICAgICAgImNvbnZlcnRlciI6ICJTVkdDb2xvciIsCiAgICAgICAgICAgICAgICAg InN2ZyI6IHRydWUsCiAgICAgICAgICAgICAgICAgImNvbG9yLXByb3BlcnR5IjogdHJ1ZQogICAg ICAgICAgICAgfSwKQEAgLTMwMjQsNyArMzAyMyw2IEBACiAgICAgICAgIH0sCiAgICAgICAgICJs aWdodGluZy1jb2xvciI6IHsKICAgICAgICAgICAgICJjb2RlZ2VuLXByb3BlcnRpZXMiOiB7Ci0g ICAgICAgICAgICAgICAgImNvbnZlcnRlciI6ICJTVkdDb2xvciIsCiAgICAgICAgICAgICAgICAg InN2ZyI6IHRydWUsCiAgICAgICAgICAgICAgICAgImNvbG9yLXByb3BlcnR5IjogdHJ1ZQogICAg ICAgICAgICAgfQpAQCAtNDEzNCw3ICs0MTMyLDYgQEAKICAgICAgICAgfSwKICAgICAgICAgInN0 b3AtY29sb3IiOiB7CiAgICAgICAgICAgICAiY29kZWdlbi1wcm9wZXJ0aWVzIjogewotICAgICAg ICAgICAgICAgICJjb252ZXJ0ZXIiOiAiU1ZHQ29sb3IiLAogICAgICAgICAgICAgICAgICJzdmci OiB0cnVlLAogICAgICAgICAgICAgICAgICJjb2xvci1wcm9wZXJ0eSI6IHRydWUKICAgICAgICAg ICAgIH0sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKaW5kZXggMmNjZjZlZDVkYzY0YTBmOGJjODY3MWMw M2M3YzAwZmIxYmMwOWJiZC4uZmQ5NjZmNWIyNmFhN2EzMjdlMDc0MTg4Nzg2NzVhNWYzNzQxZmU1 NCAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbApAQCAtMTMxMyw2ICsxMzEzLDggQEAgc3ViIGdlbmVy YXRlVmFsdWVTZXR0ZXIgewogICB9IGVsc2lmIChleGlzdHMoJHByb3BlcnRpZXNXaXRoU3R5bGVC dWlsZGVyT3B0aW9uc3skbmFtZX17ImNvbmRpdGlvbmFsLWNvbnZlcnRlciJ9KSkgewogICAgICRz ZXR0ZXJDb250ZW50IC49ICRpbmRlbnQgLiAiICAgIGF1dG8gY29udmVydGVkVmFsdWUgPSBCdWls ZGVyQ29udmVydGVyOjpjb252ZXJ0IiAuICRwcm9wZXJ0aWVzV2l0aFN0eWxlQnVpbGRlck9wdGlv bnN7JG5hbWV9eyJjb25kaXRpb25hbC1jb252ZXJ0ZXIifSAuICIoYnVpbGRlclN0YXRlLCB2YWx1 ZSk7XG4iOwogICAgICRjb252ZXJ0ZWRWYWx1ZSA9ICJXVEZNb3ZlKGNvbnZlcnRlZFZhbHVlLnZh bHVlKCkpIjsKKyAgfSBlbHNpZiAoJG5hbWVJc0NvbG9yUHJvcGVydHl7JG5hbWV9KSB7CisgICAg JGNvbnZlcnRlZFZhbHVlID0gY29sb3JGcm9tUHJpbWl0aXZlVmFsdWUoImRvd25jYXN0PENTU1By aW1pdGl2ZVZhbHVlPih2YWx1ZSkiKTsKICAgfSBlbHNlIHsKICAgICAkY29udmVydGVkVmFsdWUg PSAiZG93bmNhc3Q8Q1NTUHJpbWl0aXZlVmFsdWU+KHZhbHVlKSI7CiAgIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlckNvbnZlcnRlci5oIGIvU291cmNlL1dl YkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ29udmVydGVyLmgKaW5kZXggMGQwMTA4MmQzOTA2MzUz NDNhMmFhZTZkYzBkNDQ4YWJlNjRjYmRlNC4uMGVlYjk0YzNkZjBhZDI5ZDQ4M2EyNjFlYWJkZTE4 YmI0OTlkYzA5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVy Q29udmVydGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ29udmVy dGVyLmgKQEAgLTE0NSw3ICsxNDUsNiBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhaW50T3JkZXIg Y29udmVydFBhaW50T3JkZXIoQnVpbGRlclN0YXRlJiwgY29uc3QgQ1NTVmFsdWUmKTsKICAgICBz dGF0aWMgZmxvYXQgY29udmVydE9wYWNpdHkoQnVpbGRlclN0YXRlJiwgY29uc3QgQ1NTVmFsdWUm KTsKICAgICBzdGF0aWMgU3RyaW5nIGNvbnZlcnRTVkdVUklSZWZlcmVuY2UoQnVpbGRlclN0YXRl JiwgY29uc3QgQ1NTVmFsdWUmKTsKLSAgICBzdGF0aWMgQ29sb3IgY29udmVydFNWR0NvbG9yKEJ1 aWxkZXJTdGF0ZSYsIGNvbnN0IENTU1ZhbHVlJik7CiAgICAgc3RhdGljIFN0eWxlU2VsZkFsaWdu bWVudERhdGEgY29udmVydFNlbGZPckRlZmF1bHRBbGlnbm1lbnREYXRhKEJ1aWxkZXJTdGF0ZSYs IGNvbnN0IENTU1ZhbHVlJik7CiAgICAgc3RhdGljIFN0eWxlQ29udGVudEFsaWdubWVudERhdGEg Y29udmVydENvbnRlbnRBbGlnbm1lbnREYXRhKEJ1aWxkZXJTdGF0ZSYsIGNvbnN0IENTU1ZhbHVl Jik7CiAgICAgc3RhdGljIEdseXBoT3JpZW50YXRpb24gY29udmVydEdseXBoT3JpZW50YXRpb24o QnVpbGRlclN0YXRlJiwgY29uc3QgQ1NTVmFsdWUmKTsKQEAgLTE0MzIsMTEgKzE0MzEsNiBAQCBp bmxpbmUgU3RyaW5nIEJ1aWxkZXJDb252ZXJ0ZXI6OmNvbnZlcnRTVkdVUklSZWZlcmVuY2UoQnVp bGRlclN0YXRlJiBidWlsZGVyU3RhdAogICAgIHJldHVybiBTVkdVUklSZWZlcmVuY2U6OmZyYWdt ZW50SWRlbnRpZmllckZyb21JUklTdHJpbmcocywgYnVpbGRlclN0YXRlLmRvY3VtZW50KCkpOwog fQogCi1pbmxpbmUgQ29sb3IgQnVpbGRlckNvbnZlcnRlcjo6Y29udmVydFNWR0NvbG9yKEJ1aWxk ZXJTdGF0ZSYgYnVpbGRlclN0YXRlLCBjb25zdCBDU1NWYWx1ZSYgdmFsdWUpCi17Ci0gICAgcmV0 dXJuIGJ1aWxkZXJTdGF0ZS5jb2xvckZyb21QcmltaXRpdmVWYWx1ZShkb3duY2FzdDxDU1NQcmlt aXRpdmVWYWx1ZT4odmFsdWUpKTsKLX0KLQogaW5saW5lIFN0eWxlU2VsZkFsaWdubWVudERhdGEg QnVpbGRlckNvbnZlcnRlcjo6Y29udmVydFNlbGZPckRlZmF1bHRBbGlnbm1lbnREYXRhKEJ1aWxk ZXJTdGF0ZSYsIGNvbnN0IENTU1ZhbHVlJiB2YWx1ZSkKIHsKICAgICBTdHlsZVNlbGZBbGlnbm1l bnREYXRhIGFsaWdubWVudERhdGEgPSBSZW5kZXJTdHlsZTo6aW5pdGlhbFNlbGZBbGlnbm1lbnQo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlckN1c3RvbS5o IGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ3VzdG9tLmgKaW5kZXggYmQwMGZk OTUxMDM1MzljNzU2ZTMzMmUxZDE1YjQ4ODMyNmRhZWVkYS4uZWY5NWE4ZmIzYTBkNDJmOTQyMmUy MTE3Y2Q2MjRjZjJhMmVmOTI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5 bGVCdWlsZGVyQ3VzdG9tLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVy Q3VzdG9tLmgKQEAgLTcxLDcgKzcxLDYgQEAgaW5saW5lIEdhcExlbmd0aCBmb3J3YXJkSW5oZXJp dGVkVmFsdWUoY29uc3QgR2FwTGVuZ3RoJiB2YWx1ZSkgeyBhdXRvIGNvcHkgPSB2YWwKIGNsYXNz IEJ1aWxkZXJDdXN0b20gewogcHVibGljOgogICAgIC8vIEN1c3RvbSBoYW5kbGluZyBvZiBpbmhl cml0LCBpbml0aWFsIGFuZCB2YWx1ZSBzZXR0aW5nLgotICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VT VE9NX0hBTkRMRVJTKEFjY2VudENvbG9yKTsKICAgICBERUNMQVJFX1BST1BFUlRZX0NVU1RPTV9I QU5ETEVSUyhBc3BlY3RSYXRpbyk7CiAgICAgREVDTEFSRV9QUk9QRVJUWV9DVVNUT01fSEFORExF UlMoQm9yZGVySW1hZ2VPdXRzZXQpOwogICAgIERFQ0xBUkVfUFJPUEVSVFlfQ1VTVE9NX0hBTkRM RVJTKEJvcmRlckltYWdlUmVwZWF0KTsKQEAgLTc5NCwyOSArNzkzLDYgQEAgaW5saW5lIHZvaWQg QnVpbGRlckN1c3RvbTo6YXBwbHlWYWx1ZU91dGxpbmVTdHlsZShCdWlsZGVyU3RhdGUmIGJ1aWxk ZXJTdGF0ZSwgQ1MKICAgICBidWlsZGVyU3RhdGUuc3R5bGUoKS5zZXRPdXRsaW5lU3R5bGUocHJp bWl0aXZlVmFsdWUpOwogfQogCi1pbmxpbmUgdm9pZCBCdWlsZGVyQ3VzdG9tOjphcHBseUluaXRp YWxBY2NlbnRDb2xvcihCdWlsZGVyU3RhdGUmIGJ1aWxkZXJTdGF0ZSkKLXsKLSAgICBidWlsZGVy U3RhdGUuc3R5bGUoKS5zZXRIYXNBdXRvQWNjZW50Q29sb3IoKTsKLX0KLQotaW5saW5lIHZvaWQg QnVpbGRlckN1c3RvbTo6YXBwbHlJbmhlcml0QWNjZW50Q29sb3IoQnVpbGRlclN0YXRlJiBidWls ZGVyU3RhdGUpCi17Ci0gICAgQ29sb3IgY29sb3IgPSBidWlsZGVyU3RhdGUucGFyZW50U3R5bGUo KS5hY2NlbnRDb2xvcigpOwotICAgIGlmIChidWlsZGVyU3RhdGUucGFyZW50U3R5bGUoKS5oYXNB dXRvQWNjZW50Q29sb3IoKSkKLSAgICAgICAgYnVpbGRlclN0YXRlLnN0eWxlKCkuc2V0SGFzQXV0 b0FjY2VudENvbG9yKCk7Ci0gICAgZWxzZQotICAgICAgICBidWlsZGVyU3RhdGUuc3R5bGUoKS5z ZXRBY2NlbnRDb2xvcihjb2xvcik7Ci19Ci0KLWlubGluZSB2b2lkIEJ1aWxkZXJDdXN0b206OmFw cGx5VmFsdWVBY2NlbnRDb2xvcihCdWlsZGVyU3RhdGUmIGJ1aWxkZXJTdGF0ZSwgQ1NTVmFsdWUm IHZhbHVlKQotewotICAgIGF1dG8mIHByaW1pdGl2ZVZhbHVlID0gZG93bmNhc3Q8Q1NTUHJpbWl0 aXZlVmFsdWU+KHZhbHVlKTsKLSAgICBpZiAocHJpbWl0aXZlVmFsdWUudmFsdWVJRCgpID09IENT U1ZhbHVlQXV0bykKLSAgICAgICAgYnVpbGRlclN0YXRlLnN0eWxlKCkuc2V0SGFzQXV0b0FjY2Vu dENvbG9yKCk7Ci0gICAgZWxzZQotICAgICAgICBidWlsZGVyU3RhdGUuc3R5bGUoKS5zZXRBY2Nl bnRDb2xvcihidWlsZGVyU3RhdGUuY29sb3JGcm9tUHJpbWl0aXZlVmFsdWUocHJpbWl0aXZlVmFs dWUpKTsKLX0KLQogaW5saW5lIHZvaWQgQnVpbGRlckN1c3RvbTo6YXBwbHlJbml0aWFsQ2FyZXRD b2xvcihCdWlsZGVyU3RhdGUmIGJ1aWxkZXJTdGF0ZSkKIHsKICAgICBpZiAoYnVpbGRlclN0YXRl LmFwcGx5UHJvcGVydHlUb1JlZ3VsYXJTdHlsZSgpKQo=