231363 2021-10-07 09:17:21 -0700 [LFC][Integration] Use optimized InlineContent::boxesForRect for hit testing 2021-10-08 03:22:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto koivisto bfulgham darin simon.fraser webkit-bug-importer zalan oldest_to_newest 1801620 0 koivisto 2021-10-07 09:17:21 -0700 faster hit testing 1801624 1 440504 koivisto 2021-10-07 09:23:35 -0700 Created attachment 440504 Patch 1801682 2 ews-feeder 2021-10-07 11:32:56 -0700 Committed r283726 (242650@main): <https://commits.webkit.org/242650@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440504. 1801683 3 webkit-bug-importer 2021-10-07 11:33:18 -0700 <rdar://problem/83991388> 1801689 4 darin 2021-10-07 11:38:23 -0700 Is IteratorRange itself not reversible? Can we make it reversible? 1801706 5 koivisto 2021-10-07 12:15:25 -0700 (In reply to Darin Adler from comment #4) > Is IteratorRange itself not reversible? Can we make it reversible? It is not and it would be nice if it was. Reversibility depends on the iterator capabilities so a generic reversible version is probably slightly trickier. 1801717 6 darin 2021-10-07 12:31:53 -0700 (In reply to Antti Koivisto from comment #5) > It is not and it would be nice if it was. Reversibility depends on the > iterator capabilities so a generic reversible version is probably slightly > trickier. One idea is to specialize it so it’s reversible when the iterators are pointers. Over time could use better template meta programming to make it reversible in even more cases. 1801981 7 koivisto 2021-10-08 03:22:15 -0700 Turns out it wasn't difficult at all, bug 231415. 440504 2021-10-07 09:23:35 -0700 2021-10-07 11:32:57 -0700 Patch bug-231363-20211007192334.patch text/plain 4742 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJjNWYyOTZiYzljMTk3 MDNiMjg4YmRiOGVmZjg1YTM0YTM1N2VkMi4uNzZmMTljZDNiMGJiMjM4N2U4YjEwNzcxMzFjNjRm NTY3YjU3MTQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTEwLTA3ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlv bl0gVXNlIG9wdGltaXplZCBJbmxpbmVDb250ZW50Ojpib3hlc0ZvclJlY3QgZm9yIGhpdCB0ZXN0 aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEz NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IG1ha2VzIGhpdCB0ZXN0aW5nIGxhcmdlIGJsb2NrcyBmYXN0ZXIuCisKKyAgICAgICAgKiBsYXlv dXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpJbmxpbmVDb250ZW50Ojpib3hlc0ZvclJl Y3QgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OiBjb25zdCk6 IERlbGV0ZWQuCisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9u SW5saW5lQ29udGVudC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246Oklu bGluZUNvbnRlbnQ6OkJveFJhbmdlOjpiZWdpbiBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpM YXlvdXRJbnRlZ3JhdGlvbjo6SW5saW5lQ29udGVudDo6Qm94UmFuZ2U6OmVuZCBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6SW5saW5lQ29udGVudDo6Qm94UmFu Z2U6OnJiZWdpbiBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6 SW5saW5lQ29udGVudDo6Qm94UmFuZ2U6OnJlbmQgY29uc3QpOgorCisgICAgICAgIEFkZCBhIHJl dmVyc2FibGUgaXRlcmF0b3IuCisKKyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0 SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dEludGVn cmF0aW9uOjpMaW5lTGF5b3V0OjpoaXRUZXN0KToKKworICAgICAgICBIaXQgdGVzdCB1c2luZyBi b3hlc0ZvclJlY3QuCisKIDIwMjEtMTAtMDcgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gSW5saW5lRGlzcGxheTo6Qm94IHNob3VsZCBiZSBhYmxl IHRvIHRlbGwgaWYgaXQncyB0aGUgZmlyc3Qgb3IgdGhlIGxhc3QgYm94IHdpdGhpbiB0aGUgYXNz b2NpYXRlZCBMYXlvdXQ6OkJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL0xheW91dEludGVncmF0aW9uSW5saW5lQ29udGVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50LmNw cAppbmRleCA0NjUzMmU2NjNjODdlZGZhN2ZmZmViNTIyNGYwMzA1MmE5NmNhNjNjLi5hZmJkNDQ4 ZTM0YjlkNDgzOWUwNTNmZmNiYWM1NjQxYzYxOTcwMDFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRp b25JbmxpbmVDb250ZW50LmNwcApAQCAtNDcsNyArNDcsNyBAQCBib29sIElubGluZUNvbnRlbnQ6 Omhhc0NvbnRlbnQoKSBjb25zdAogICAgIHJldHVybiBib3hlcy5zaXplKCkgPiAxOwogfTsKIAot V1RGOjpJdGVyYXRvclJhbmdlPGNvbnN0IElubGluZURpc3BsYXk6OkJveCo+IElubGluZUNvbnRl bnQ6OmJveGVzRm9yUmVjdChjb25zdCBMYXlvdXRSZWN0JiByZWN0KSBjb25zdAorYXV0byBJbmxp bmVDb250ZW50Ojpib3hlc0ZvclJlY3QoY29uc3QgTGF5b3V0UmVjdCYgcmVjdCkgY29uc3QgLT4g Qm94UmFuZ2UKIHsKICAgICBpZiAoYm94ZXMuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4geyBu dWxscHRyLCBudWxscHRyIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50 ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25JbmxpbmVDb250ZW50LmgKaW5k ZXggZjZkNmM1ZGY4MThmNzVlNTVjMTA4ZWZlYjIyNTY4Zjc4YzBmYWQ1NS4uYWMzNDQxOGYyNjk3 ZDcyY2VjNDIyYzk0MjgzYjI1NWRjYjljNzFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uSW5saW5lQ29udGVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbklubGlu ZUNvbnRlbnQuaApAQCAtNjYsNyArNjYsMjAgQEAgc3RydWN0IElubGluZUNvbnRlbnQgOiBwdWJs aWMgUmVmQ291bnRlZDxJbmxpbmVDb250ZW50PiB7CiAgICAgYm9vbCBoYXNDb250ZW50KCkgY29u c3Q7CiAgICAgCiAgICAgY29uc3QgTGluZSYgbGluZUZvckJveChjb25zdCBJbmxpbmVEaXNwbGF5 OjpCb3gmIGJveCkgY29uc3QgeyByZXR1cm4gbGluZXNbYm94LmxpbmVJbmRleCgpXTsgfQotICAg IFdURjo6SXRlcmF0b3JSYW5nZTxjb25zdCBJbmxpbmVEaXNwbGF5OjpCb3gqPiBib3hlc0ZvclJl Y3QoY29uc3QgTGF5b3V0UmVjdCYpIGNvbnN0OworCisgICAgc3RydWN0IEJveFJhbmdlIHsKKyAg ICAgICAgdXNpbmcgcmV2ZXJzZV9pdGVyYXRvciA9IHN0ZDo6cmV2ZXJzZV9pdGVyYXRvcjxjb25z dCBJbmxpbmVEaXNwbGF5OjpCb3gqPjsKKworICAgICAgICBjb25zdCBJbmxpbmVEaXNwbGF5OjpC b3gqIHJhbmdlQmVnaW47CisgICAgICAgIGNvbnN0IElubGluZURpc3BsYXk6OkJveCogcmFuZ2VF bmQ7CisKKyAgICAgICAgYXV0byBiZWdpbigpIGNvbnN0IHsgcmV0dXJuIHJhbmdlQmVnaW47IH0K KyAgICAgICAgYXV0byBlbmQoKSBjb25zdCB7IHJldHVybiByYW5nZUVuZDsgfQorICAgICAgICBh dXRvIHJiZWdpbigpIGNvbnN0IHsgcmV0dXJuIHJldmVyc2VfaXRlcmF0b3IgeyByYW5nZUVuZCAg fTsgfQorICAgICAgICBhdXRvIHJlbmQoKSBjb25zdCB7IHJldHVybiByZXZlcnNlX2l0ZXJhdG9y IHsgcmFuZ2VCZWdpbiB9OyB9CisgICAgfTsKKyAgICBCb3hSYW5nZSBib3hlc0ZvclJlY3QoY29u c3QgTGF5b3V0UmVjdCYpIGNvbnN0OworCiAgICAgdm9pZCBzaHJpbmtUb0ZpdCgpOwogCiAgICAg Y29uc3QgTGluZUxheW91dCYgbGluZUxheW91dCgpIGNvbnN0IHsgcmV0dXJuICptX2xpbmVMYXlv dXQ7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggYjdkNzQwZGZkNTZm OWI4YzVkYjdkNGY2ZWIxNTk5MDNlNGY0ODRlNy4uMmUxZjhjNWZiMWE1YmNmNTBkNDE5MTNjYTJm M2ViMDg0MTk2YTBiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0 aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKQEAgLTUz MywxMCArNTMzLDExIEBAIGJvb2wgTGluZUxheW91dDo6aGl0VGVzdChjb25zdCBIaXRUZXN0UmVx dWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBjCiAgICAgaWYgKCFtX2lubGlu ZUNvbnRlbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGF1dG8mIGlubGluZUNvbnRl bnQgPSAqbV9pbmxpbmVDb250ZW50OworICAgIGF1dG8gaGl0VGVzdEJvdW5kaW5nQm94ID0gbG9j YXRpb25JbkNvbnRhaW5lci5ib3VuZGluZ0JveCgpOworICAgIGhpdFRlc3RCb3VuZGluZ0JveC5t b3ZlQnkoLWFjY3VtdWxhdGVkT2Zmc2V0KTsKKyAgICBhdXRvIGJveFJhbmdlID0gbV9pbmxpbmVD b250ZW50LT5ib3hlc0ZvclJlY3QoaGl0VGVzdEJvdW5kaW5nQm94KTsKIAotICAgIC8vIEZJWE1F OiBUaGlzIHNob3VsZCBkbyBzb21ldGhpbmcgZWZmaWNpZW50IHRvIGZpbmQgdGhlIGJveCByYW5n ZS4KLSAgICBmb3IgKGF1dG8mIGJveCA6IFdURjo6bWFrZVJldmVyc2VkUmFuZ2UoaW5saW5lQ29u dGVudC5ib3hlcykpIHsKKyAgICBmb3IgKGF1dG8mIGJveCA6IFdURjo6bWFrZVJldmVyc2VkUmFu Z2UoYm94UmFuZ2UpKSB7CiAgICAgICAgIGF1dG8mIHJlbmRlcmVyID0gbV9ib3hUcmVlLnJlbmRl cmVyRm9yTGF5b3V0Qm94KGJveC5sYXlvdXRCb3goKSk7CiAKICAgICAgICAgaWYgKCFib3guaXNS b290SW5saW5lQm94KCkgJiYgaXM8UmVuZGVyTGF5ZXJNb2RlbE9iamVjdD4ocmVuZGVyZXIpICYm IGRvd25jYXN0PFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KHJlbmRlcmVyKS5oYXNTZWxmUGFpbnRp bmdMYXllcigpKQo=