231327 2021-10-06 13:21:01 -0700 Rewrite LayoutTests/plugins/object-onfocus-mutation-crash.html to stop relying on autofocus 2021-10-06 13:48:22 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203139 1 ntim ntim cdumez webkit-bug-importer oldest_to_newest 1801292 0 ntim 2021-10-06 13:21:01 -0700 This test mostly tests onfocus and <object>, we don't need it to use autofocus. The new autofocus timing will be async so we don't want this test to break with the new autofocus behavior implemented. 1801293 1 ntim 2021-10-06 13:21:42 -0700 See also bug 231219 for similar changes in other tests. 1801300 2 440428 ntim 2021-10-06 13:25:04 -0700 Created attachment 440428 Patch 1801306 3 440428 cdumez 2021-10-06 13:29:07 -0700 Comment on attachment 440428 Patch This seems to completely disable the test. This test was introduced to cover a code change in HTMLObjectElement/HTMLPlugInImageElement and it is no longer covered since you're dropping the object element.. 1801313 4 440428 cdumez 2021-10-06 13:35:28 -0700 Comment on attachment 440428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440428&action=review > LayoutTests/plugins/object-onfocus-mutation-crash.html:4 > +<object data="a"> Oh, I misread. You merely moved the <object> > LayoutTests/plugins/object-onfocus-mutation-crash.html:22 > + finish(); Any reason we can't keep calling finish asynchronously? 1801315 5 ntim 2021-10-06 13:36:37 -0700 (In reply to Chris Dumez from comment #4) > Comment on attachment 440428 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440428&action=review > > > LayoutTests/plugins/object-onfocus-mutation-crash.html:4 > > +<object data="a"> > > Oh, I misread. You merely moved the <object> > > > LayoutTests/plugins/object-onfocus-mutation-crash.html:22 > > + finish(); > > Any reason we can't keep calling finish asynchronously? No reason, just looks cleaner without the setTimeout, but I can add it back. 1801317 6 440434 ntim 2021-10-06 13:39:48 -0700 Created attachment 440434 [fast-cq] Patch 1801322 7 ntim 2021-10-06 13:47:25 -0700 Committed r283657 (242602@main): <https://commits.webkit.org/242602@main> 1801324 8 webkit-bug-importer 2021-10-06 13:48:22 -0700 <rdar://problem/83950034> 440428 2021-10-06 13:25:04 -0700 2021-10-06 13:35:28 -0700 Patch bug-231327-20211006222503.patch text/plain 1871 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNjQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTlmMjkyYjQ3NWE2YjdjYTliYjM1 MjljYThjZGVhM2MwODVmYjJlOC4uMDg2ODBkODc2OTZhMmYxMzA0ZDgxMTBiNzkwYWZlNTQ4Y2E1 N2Q1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTA2ICBUaW0gTmd1eWVuICA8bnRp bUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV3cml0ZSBwbHVnaW5zL29iamVjdC1vbmZvY3VzLW11 dGF0aW9uLWNyYXNoLmh0bWwgdG8gc3RvcCByZWx5aW5nIG9uIGF1dG9mb2N1cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMzI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IG1vc3RseSB0 ZXN0cyBvbmZvY3VzIGFuZCA8b2JqZWN0Piwgd2UgZG9uJ3QgbmVlZCBpdCB0byB1c2UgYXV0b2Zv Y3VzLgorICAgICAgICBUaGUgbmV3IGF1dG9mb2N1cyB0aW1pbmcgd2lsbCBiZSBhc3luYyBzbyB3 ZSBkb24ndCB3YW50IHRoaXMgdGVzdCB0byBicmVhayB3aXRoIHRoZSBuZXcKKyAgICAgICAgYmVo YXZpb3IgaW1wbGVtZW50ZWQuIFVzZSBpbnB1dC5mb2N1cygpIGluc3RlYWQuCisKKyAgICAgICAg KiBwbHVnaW5zL29iamVjdC1vbmZvY3VzLW11dGF0aW9uLWNyYXNoLmh0bWw6CisKIDIwMjEtMTAt MDYgIEF5dW1pIEtvamltYSAgPGF5dW1pX2tvamltYUBhcHBsZS5jb20+CiAKICAgICAgICAgWyBp T1MgMTUgXSBmYXN0L3RleHQvYWNjZXNzaWJpbGl0eS1ib2xkLXN5c3RlbS1mb250LTIuaHRtbCBp cyBpbWFnZSBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9vYmplY3Qt b25mb2N1cy1tdXRhdGlvbi1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9vYmplY3Qt b25mb2N1cy1tdXRhdGlvbi1jcmFzaC5odG1sCmluZGV4IGI1ODJhZjY5OTFjOTE3ZWNkZGY3ZThk MjY1ZmE0MTkwODBlZmJjMzQuLjUyMmUyODBmYTcyYzk1ODRlOWM1MzAwOWZjNmY2ZWY3YzA5YjA5 Y2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdpbnMvb2JqZWN0LW9uZm9jdXMtbXV0YXRp b24tY3Jhc2guaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL29iamVjdC1vbmZvY3VzLW11 dGF0aW9uLWNyYXNoLmh0bWwKQEAgLTEsMTIgKzEsMTcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0 bWw+CiA8Ym9keT4KKzxvYmplY3QgZGF0YT0iYSI+CisgICAgPGlucHV0IGlkPSJpbnB1dCIgb25m b2N1cz0iY3Jhc2goKSI+Cis8L29iamVjdD4KIDxzY3JpcHQ+CiBpZiAod2luZG93LnRlc3RSdW5u ZXIpIHsKICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKICAgICB0ZXN0UnVubmVyLndhaXRV bnRpbERvbmUoKTsKIH0KIAoraW5wdXQuZm9jdXMoKTsKKwogZnVuY3Rpb24gZmluaXNoKCkgewog ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25l KCk7CkBAIC0xNCwxMSArMTksOCBAQCBmdW5jdGlvbiBmaW5pc2goKSB7CiAKIGZ1bmN0aW9uIGNy YXNoKCkgewogICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIlBBU1MuIFdlYktpdCBkaWRu J3QgY3Jhc2guIjsKLSAgICBzZXRUaW1lb3V0KCJmaW5pc2goKSIsIDApOworICAgIGZpbmlzaCgp OwogfQogPC9zY3JpcHQ+Ci08b2JqZWN0IGRhdGE9ImEiPgotPGlucHV0IGF1dG9mb2N1cz0iIiBv bmZvY3VzPSJjcmFzaCgpIj4KLTwvb2JqZWN0PgogPC9ib2R5PgogPC9odG1sPgo= 440434 2021-10-06 13:39:48 -0700 2021-10-06 13:47:28 -0700 [fast-cq] Patch bug-231327-20211006223947.patch text/plain 1768 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNjQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTlmMjkyYjQ3NWE2YjdjYTliYjM1 MjljYThjZGVhM2MwODVmYjJlOC4uYzFmY2JhN2I2N2E3MjMyMGE4YTBkZDg0OGU3NDdjNmJhNzVh YzBlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTEwLTA2ICBUaW0gTmd1eWVuICA8bnRp bUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV3cml0ZSBwbHVnaW5zL29iamVjdC1vbmZvY3VzLW11 dGF0aW9uLWNyYXNoLmh0bWwgdG8gc3RvcCByZWx5aW5nIG9uIGF1dG9mb2N1cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMzI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgVGhpcyB0ZXN0IG1vc3RseSB0ZXN0 cyBvbmZvY3VzIGFuZCA8b2JqZWN0Piwgd2UgZG9uJ3QgbmVlZCBpdCB0byB1c2UgYXV0b2ZvY3Vz LgorICAgICAgICBUaGUgbmV3IGF1dG9mb2N1cyB0aW1pbmcgd2lsbCBiZSBhc3luYyBzbyB3ZSBk b24ndCB3YW50IHRoaXMgdGVzdCB0byBicmVhayB3aXRoIHRoZSBuZXcKKyAgICAgICAgYmVoYXZp b3IgaW1wbGVtZW50ZWQuIFVzZSBpbnB1dC5mb2N1cygpIGluc3RlYWQuCisKKyAgICAgICAgKiBw bHVnaW5zL29iamVjdC1vbmZvY3VzLW11dGF0aW9uLWNyYXNoLmh0bWw6CisKIDIwMjEtMTAtMDYg IEF5dW1pIEtvamltYSAgPGF5dW1pX2tvamltYUBhcHBsZS5jb20+CiAKICAgICAgICAgWyBpT1Mg MTUgXSBmYXN0L3RleHQvYWNjZXNzaWJpbGl0eS1ib2xkLXN5c3RlbS1mb250LTIuaHRtbCBpcyBp bWFnZSBmYWlsaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9vYmplY3Qtb25m b2N1cy1tdXRhdGlvbi1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9vYmplY3Qtb25m b2N1cy1tdXRhdGlvbi1jcmFzaC5odG1sCmluZGV4IGI1ODJhZjY5OTFjOTE3ZWNkZGY3ZThkMjY1 ZmE0MTkwODBlZmJjMzQuLjBhMmI3ZmQwZTA1NGJhOGU3Zjg1NjlkZTM2ZTRiZTIyY2Y5YjY2OGIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsdWdpbnMvb2JqZWN0LW9uZm9jdXMtbXV0YXRpb24t Y3Jhc2guaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL29iamVjdC1vbmZvY3VzLW11dGF0 aW9uLWNyYXNoLmh0bWwKQEAgLTEsMTIgKzEsMTcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+ CiA8Ym9keT4KKzxvYmplY3QgZGF0YT0iYSI+CisgICAgPGlucHV0IGlkPSJpbnB1dCIgb25mb2N1 cz0iY3Jhc2goKSI+Cis8L29iamVjdD4KIDxzY3JpcHQ+CiBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKICAgICB0ZXN0UnVubmVyLndhaXRVbnRp bERvbmUoKTsKIH0KIAoraW5wdXQuZm9jdXMoKTsKKwogZnVuY3Rpb24gZmluaXNoKCkgewogICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7 CkBAIC0xNyw4ICsyMiw1IEBAIGZ1bmN0aW9uIGNyYXNoKCkgewogICAgIHNldFRpbWVvdXQoImZp bmlzaCgpIiwgMCk7CiB9CiA8L3NjcmlwdD4KLTxvYmplY3QgZGF0YT0iYSI+Ci08aW5wdXQgYXV0 b2ZvY3VzPSIiIG9uZm9jdXM9ImNyYXNoKCkiPgotPC9vYmplY3Q+CiA8L2JvZHk+CiA8L2h0bWw+ Cg==