23127 2009-01-05 19:27:14 -0800 Misuses of pango_coverage_get and pango_coverage_from_bytes. 2009-01-08 04:34:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 poincare webkit-unassigned oldest_to_newest 104521 0 poincare 2009-01-05 19:27:14 -0800 The second argument of pango_coverage_get should be a Unicode character. The first argument of pango_coverage_from_bytes should be binary data generated from pango_coverage_to_bytes. 104522 1 26449 poincare 2009-01-05 19:34:39 -0800 Created attachment 26449 Proposed patch 104808 2 zecke 2009-01-07 16:34:54 -0800 It looks right, is there any way to test it? 104816 3 26449 zecke 2009-01-07 16:48:24 -0800 Comment on attachment 26449 Proposed patch > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 39635) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2009-01-05 Hiroyuki Ikezoe <poincare@ikezoe.net> > + > + Reviewed by NOBODY (OOPS!). > + > + Invoke pango_coverage_get with each Unicode character. please don't use tabs. Could you please also tell me what is broken with the other way of doing it? How you spotted it? 104828 4 poincare 2009-01-07 18:02:34 -0800 (In reply to comment #2) > It looks right, is there any way to test it? Unfortunately no. I found the issue when I read the code to solve bug #18546. Actually I can not reproduce bug #18546, so I *just* read the code. 104829 5 26517 poincare 2009-01-07 18:05:19 -0800 Created attachment 26517 expand tabs in ChangeLog. 104860 6 26517 zecke 2009-01-08 03:50:07 -0800 Comment on attachment 26517 expand tabs in ChangeLog. You shouldn't set r=+ yourself. :) 104864 7 zecke 2009-01-08 04:34:20 -0800 Landed in r39701. Let us see how this is working out. 26449 2009-01-05 19:34:39 -0800 2009-01-07 18:05:19 -0800 Proposed patch webkit_pango_coverage_fix.diff text/plain 1701 poincare SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTYzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDUgIEhpcm95dWtpIElrZXpvZSAgPHBvaW5jYXJlQGlr ZXpvZS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlJbnZv a2UgcGFuZ29fY292ZXJhZ2VfZ2V0IHdpdGggZWFjaCBVbmljb2RlIGNoYXJhY3Rlci4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMjcKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9TaW1wbGVGb250RGF0YVBhbmdvLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNpbXBsZUZvbnREYXRhOjpjb250YWluc0NoYXJhY3RlcnMpOgorCiAy MDA5LTAxLTA1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L1NpbXBsZUZvbnREYXRhUGFuZ28uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3RrL1NpbXBsZUZvbnREYXRhUGFuZ28uY3BwCShyZXZpc2lvbiAzOTYzNSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL1NpbXBsZUZvbnREYXRhUGFuZ28uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05NywxOSArOTcsMTYgQEAgYm9vbCBTaW1wbGVGb250RGF0YTo6Y29u dGFpbnNDaGFyYWN0ZXJzKAogewogICAgIGJvb2wgcmVzdWx0ID0gdHJ1ZTsKIAotICAgIFBhbmdv Q292ZXJhZ2UqIHJlcXVlc3RlZCA9IHBhbmdvX2NvdmVyYWdlX2Zyb21fYnl0ZXMoKGd1Y2hhciop Y2hhcmFjdGVycywgbGVuZ3RoKTsKLSAgICBQYW5nb0NvdmVyYWdlKiBhdmFpbGFibGUgPSBwYW5n b19mb250X2dldF9jb3ZlcmFnZShtX2ZvbnQubV9mb250LCBwYW5nb19sYW5ndWFnZV9nZXRfZGVm YXVsdCgpKTsKLSAgICBwYW5nb19jb3ZlcmFnZV9tYXgocmVxdWVzdGVkLCBhdmFpbGFibGUpOwor ICAgIFBhbmdvQ292ZXJhZ2UqIGNvdmVyYWdlID0gcGFuZ29fZm9udF9nZXRfY292ZXJhZ2UobV9m b250Lm1fZm9udCwgcGFuZ29fbGFuZ3VhZ2VfZ2V0X2RlZmF1bHQoKSk7CiAKICAgICBmb3IgKGlu dCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIGlmIChQQU5HT19DT1ZFUkFHRV9O T05FID09IHBhbmdvX2NvdmVyYWdlX2dldChyZXF1ZXN0ZWQsIGkpKSB7CisgICAgICAgIGlmIChQ QU5HT19DT1ZFUkFHRV9OT05FID09IHBhbmdvX2NvdmVyYWdlX2dldChjb3ZlcmFnZSwgY2hhcmFj dGVyc1tpXSkpIHsKICAgICAgICAgICAgIHJlc3VsdCA9IGZhbHNlOwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KICAgICB9CiAKLSAgICBwYW5nb19jb3ZlcmFnZV91bnJlZihyZXF1ZXN0 ZWQpOwotICAgIHBhbmdvX2NvdmVyYWdlX3VucmVmKGF2YWlsYWJsZSk7CisgICAgcGFuZ29fY292 ZXJhZ2VfdW5yZWYoY292ZXJhZ2UpOwogCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K 26517 2009-01-07 18:05:19 -0800 2009-01-07 18:05:19 -0800 expand tabs in ChangeLog. webkit_pango_coverage_fix.diff text/plain 1711 poincare SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTY5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDcgIEhpcm95dWtpIElrZXpvZSAgPHBvaW5jYXJlQGlr ZXpvZS5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTI3CisKKyAgICAg ICAgSW52b2tlIHBhbmdvX2NvdmVyYWdlX2dldCB3aXRoIGVhY2ggVW5pY29kZSBjaGFyYWN0ZXIu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvU2ltcGxlRm9udERhdGFQYW5nby5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6Y29udGFpbnNDaGFyYWN0ZXJz KToKKwogMjAwOS0wMS0wNyAgQ2hyaXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2d0ay9TaW1wbGVGb250RGF0YVBhbmdvLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9TaW1wbGVGb250RGF0YVBhbmdvLmNwcAkocmV2aXNpb24g Mzk2OTQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9TaW1wbGVGb250RGF0YVBh bmdvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTcsMTkgKzk3LDE2IEBAIGJvb2wgU2ltcGxlRm9u dERhdGE6OmNvbnRhaW5zQ2hhcmFjdGVycygKIHsKICAgICBib29sIHJlc3VsdCA9IHRydWU7CiAK LSAgICBQYW5nb0NvdmVyYWdlKiByZXF1ZXN0ZWQgPSBwYW5nb19jb3ZlcmFnZV9mcm9tX2J5dGVz KChndWNoYXIqKWNoYXJhY3RlcnMsIGxlbmd0aCk7Ci0gICAgUGFuZ29Db3ZlcmFnZSogYXZhaWxh YmxlID0gcGFuZ29fZm9udF9nZXRfY292ZXJhZ2UobV9mb250Lm1fZm9udCwgcGFuZ29fbGFuZ3Vh Z2VfZ2V0X2RlZmF1bHQoKSk7Ci0gICAgcGFuZ29fY292ZXJhZ2VfbWF4KHJlcXVlc3RlZCwgYXZh aWxhYmxlKTsKKyAgICBQYW5nb0NvdmVyYWdlKiBjb3ZlcmFnZSA9IHBhbmdvX2ZvbnRfZ2V0X2Nv dmVyYWdlKG1fZm9udC5tX2ZvbnQsIHBhbmdvX2xhbmd1YWdlX2dldF9kZWZhdWx0KCkpOwogCiAg ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW5ndGg7IGkrKykgewotICAgICAgICBpZiAoUEFOR09f Q09WRVJBR0VfTk9ORSA9PSBwYW5nb19jb3ZlcmFnZV9nZXQocmVxdWVzdGVkLCBpKSkgeworICAg ICAgICBpZiAoUEFOR09fQ09WRVJBR0VfTk9ORSA9PSBwYW5nb19jb3ZlcmFnZV9nZXQoY292ZXJh Z2UsIGNoYXJhY3RlcnNbaV0pKSB7CiAgICAgICAgICAgICByZXN1bHQgPSBmYWxzZTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQogCi0gICAgcGFuZ29fY292ZXJhZ2VfdW5y ZWYocmVxdWVzdGVkKTsKLSAgICBwYW5nb19jb3ZlcmFnZV91bnJlZihhdmFpbGFibGUpOworICAg IHBhbmdvX2NvdmVyYWdlX3VucmVmKGNvdmVyYWdlKTsKIAogICAgIHJldHVybiByZXN1bHQ7CiB9 Cg==