231199 2021-10-04 16:28:24 -0700 Style checker should check spacing inside braces with elements in them 2021-10-06 08:58:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 philip.chimento webkit-unassigned ews-watchlist glenn jbedard webkit-bug-importer xan.lopez oldest_to_newest 1800286 0 philip.chimento 2021-10-04 16:28:24 -0700 Style checker should check spacing inside braces with elements in them 1800287 1 440121 philip.chimento 2021-10-04 16:32:43 -0700 Created attachment 440121 Patch 1800288 2 philip.chimento 2021-10-04 16:34:09 -0700 (Inspired by https://bugs.webkit.org/show_bug.cgi?id=229826#c14) 1801117 3 ews-feeder 2021-10-06 08:57:58 -0700 Committed r283625 (242577@main): <https://commits.webkit.org/242577@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440121. 1801118 4 webkit-bug-importer 2021-10-06 08:58:18 -0700 <rdar://problem/83936146> 440121 2021-10-04 16:32:43 -0700 2021-10-06 08:57:59 -0700 Patch bug-231199-20211004163242.patch text/plain 7245 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMzQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjJmNDI2MjNiODViMjJhOGRiOGJmMDNlMmY1MThkNDg5 OTU1NWM0ZC4uNzBhMWIyMjJkNDg2NTMxZDZkNzRmZjg5ZmMzYzVlNmNmMjA5MzkwMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDIxLTEwLTA0ICBQaGlsaXAgQ2hpbWVudG8gIDxwY2hpbWVudG9AaWdhbGlhLmNvbT4K KworICAgICAgICBTdHlsZSBjaGVja2VyIHNob3VsZCBjaGVjayBzcGFjaW5nIGluc2lkZSBicmFj ZXMgd2l0aCBlbGVtZW50cyBpbiB0aGVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMzExOTkKKworICAgICAgICBJbiBvcmRlciB0byBhdXRvbWF0ZSB0 aGlzIGFuZCBwcmV2ZW50IHJldmlld2VycyBmcm9tIGhhdmluZyB0byBjb21tZW50CisgICAgICAg IG9uIGl0LCBlbnN1cmUgdGhhdCBzcGFjZXMgYXJlIHJlcXVpcmVkIGJ5IHdlYmtpdC1jaGVjay1z dHlsZSBpbnNpZGUgb2YKKyAgICAgICAgYnJhY2VzIHdpdGggZWxlbWVudHMgaW4gdGhlbSAoZS5n LiwgaW5pdGlhbGl6ZXIgbGlzdHMuKQorCisgICAgICAgIEluIG9yZGVyIHRvIGF2b2lkIGZhbHNl IHBvc2l0aXZlcywgaWdub3JlIGJyYWNlIHNwYWNpbmcgaWYgdGhlIGJyYWNlcworICAgICAgICBh cmUgc3Vycm91bmRlZCBieSBkb3VibGUtcXVvdGVzIG9uIHRoZSBzYW1lIGxpbmUsIGFzc3VtaW5n IHRoYXQgbWVhbnMKKyAgICAgICAgaXQncyBsaWtlbHkgdGhlIGJyYWNlcyBhcmUgaW5zaWRlIGEg c3RyaW5nLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVj a19zcGFjaW5nKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weToKKyAgICAgICAgKENwcFN0eWxlVGVzdCk6CisgICAgICAgIChOb05vblZp cnR1YWxEZXN0cnVjdG9yc1Rlc3QpOgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3RfaW5k ZW50YXRpb24pOgorCiAyMDIxLTA5LTMwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlp QHNvbnkuY29tPgogCiAgICAgICAgIFB5dGhvbiAzIGZhaWxzIHRvIHJ1biBydW4tYnVpbHRpbnMt Z2VuZXJhdG9yLXRlc3RzIDogTW9kdWxlTm90Rm91bmRFcnJvcjogTm8gbW9kdWxlIG5hbWVkICdi dWlsdGluc19tb2RlbCcKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKaW5kZXggOGY3YWQwMjQ5NTcwMTJiMjBiMWFkMDFjMzNjYzlhY2NhYjY1NmRlMi4uODk4 NWY5MTk3MmU5Y2NmMWJkNTVkZWMyMjk4YWRiZjM3ODllNWE2MiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIzMzQsMTEgKzIzMzQsMjUgQEAg ZGVmIGNoZWNrX3NwYWNpbmcoZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZmlsZV9zdGF0ZSwgZXJyb3IpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3 aGl0ZXNwYWNlL2JyYWNrZXRzJywgNSwKICAgICAgICAgICAgICAgICAgICdFeHRyYSBzcGFjZSBi ZWZvcmUgWy4nKQogCi0gICAgIyBUaGVyZSBzaG91bGQgYWx3YXlzIGJlIGEgc2luZ2xlIHNwYWNl IGluIGJldHdlZW4gYnJhY2VzIG9uIHRoZSBzYW1lIGxpbmUuCi0gICAgaWYgc2VhcmNoKHInXHtc fScsIGxpbmUpOgotICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2Vz JywgNSwgJ01pc3Npbmcgc3BhY2UgaW5zaWRlIHsgfS4nKQotICAgIGlmIHNlYXJjaChyJ1x7XHNc cytcfScsIGxpbmUpOgotICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJh Y2VzJywgNSwgJ1RvbyBtYW55IHNwYWNlcyBpbnNpZGUgeyB9LicpCisgICAgIyBUcnkgdG8gYXZv aWQgZmFsc2UgcG9zaXRpdmVzIHdoZW4gYnJhY2VzIGFyZSBpbnNpZGUgb2YgYSBzdHJpbmcKKyAg ICBpZiBub3Qgc2VhcmNoKHInIlteIl0qXHsuKlx9W14iXSoiJywgbGluZSk6CisgICAgICAgICMg VGhlcmUgc2hvdWxkIGFsd2F5cyBiZSBhIHNpbmdsZSBzcGFjZSBpbiBiZXR3ZWVuIGJyYWNlcyBv biB0aGUgc2FtZQorICAgICAgICAjIGxpbmUuCisgICAgICAgIGlmIHNlYXJjaChyJ1x7XH0nLCBs aW5lKToKKyAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMn LCA1LCAnTWlzc2luZyBzcGFjZSBpbnNpZGUgeyB9LicpCisgICAgICAgIGlmIHNlYXJjaChyJ1x7 XHNccytcfScsIGxpbmUpOgorICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNw YWNlL2JyYWNlcycsIDUsICdUb28gbWFueSBzcGFjZXMgaW5zaWRlIHsgfS4nKQorCisgICAgICAg ICMgQWxzbyBhIHNpbmdsZSBzcGFjZSBpbnNpZGUgb2YgYnJhY2VzIHdpdGggYW4gaW5pdGlhbGl6 ZXIgdmFsdWUgaW5zaWRlCisgICAgICAgICMgb2YgdGhlbS4KKyAgICAgICAgaWYgc2VhcmNoKHIn XHtbXlxzXH1dJywgbGluZSk6CisgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRl c3BhY2UvYnJhY2VzJywgNSwgJ01pc3Npbmcgc3BhY2UgYWZ0ZXIgey4nKQorICAgICAgICBpZiBz ZWFyY2gocidbXlxzXHtdXH0nLCBsaW5lKToKKyAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVy LCAnd2hpdGVzcGFjZS9icmFjZXMnLCA1LCAnTWlzc2luZyBzcGFjZSBiZWZvcmUgfS4nKQorICAg ICAgICBpZiBzZWFyY2gocidce1xzXHMrW15cc1x9XScsIGxpbmUpOgorICAgICAgICAgICAgZXJy b3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2JyYWNlcycsIDUsICdUb28gbWFueSBzcGFjZXMg YWZ0ZXIgey4nKQorICAgICAgICBpZiBzZWFyY2gocidbXlxzXHtdXHNcK1x9JywgbGluZSk6Cisg ICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2VzJywgNSwgJ1Rv byBtYW55IHNwYWNlcyBiZWZvcmUgfS4nKQogCiAgICAgIyBZb3Ugc2hvdWxkbid0IGhhdmUgYSBz cGFjZSBiZWZvcmUgYSBzZW1pY29sb24gYXQgdGhlIGVuZCBvZiB0aGUgbGluZS4KICAgICAjIFRo ZXJlJ3MgYSBzcGVjaWFsIGNhc2UgZm9yICJmb3IiIHNpbmNlIHRoZSBzdHlsZSBndWlkZSBhbGxv d3Mgc3BhY2UgYmVmb3JlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IGQwZTcwY2M2YWFjZTgzNmUyODZjOTZmM2Uw ODEzMTFmMThhMjdmZTMuLjJkMGQ2NTc1NjgzMTE1Y2M3MTlkZjFhNDhlNTliODFjMGEzNzRlM2Ig MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5CkBAIC0xODQ0LDcgKzE4NDQsNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAgICAgICAn JydcCiAgICAgICAgICAgICBjb25zdCBpbnQgZm9vW10gPQotICAgICAgICAgICAgICAgIHsxLCAy LCAzIH07JycnLAorICAgICAgICAgICAgICAgIHsgMSwgMiwgMyB9OycnJywKICAgICAgICAgICAg ICcnKQogICAgICAgICAjIEZvciBzaW5nbGUgbGluZSwgdW5tYXRjaGVkICd9JyB3aXRoIGEgJzsn IGlzIGlnbm9yZWQgKG5vdCBlbm91Z2ggY29udGV4dCkKICAgICAgICAgc2VsZi5hc3NlcnRfbXVs dGlfbGluZV9saW50KApAQCAtMjE1MCw2ICsyMTUwLDI0IEBAIGNsYXNzIENwcFN0eWxlVGVzdChD cHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIHsgfScsICcn KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAge30nLCAnTWlzc2luZyBzcGFjZSBpbnNp ZGUgeyB9LiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNV0nKQogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCcgICAgeyAgIH0nLCAnVG9vIG1hbnkgc3BhY2VzIGluc2lkZSB7IH0uICBbd2hpdGVzcGFj ZS9icmFjZXNdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICB9JywgJycpICAj IGNsb3NpbmcgYnJhY2UgYnkgaXRzZWxmIGlzIGZpbmUKKyAgICAgICAgc2VsZi5hc3NlcnRfbGlu dCgnICAgIGludDY0X3QgezB4ZmZmZmZmZmYgfScsICdNaXNzaW5nIHNwYWNlIGFmdGVyIHsuICBb d2hpdGVzcGFjZS9icmFjZXNdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICBp bnQ2NF90IHsgMHhmZmZmZmZmZn0nLCAnTWlzc2luZyBzcGFjZSBiZWZvcmUgfS4gIFt3aGl0ZXNw YWNlL2JyYWNlc10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIGludDY0X3Qg eyAweGZmZmZmZmZmIH0nLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIEludFR1 cGxlIHsxLCAyIH0nLCAnTWlzc2luZyBzcGFjZSBhZnRlciB7LiAgW3doaXRlc3BhY2UvYnJhY2Vz XSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgSW50VHVwbGUgeyAxLCAyfScs ICdNaXNzaW5nIHNwYWNlIGJlZm9yZSB9LiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNV0nKQorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgSW50VHVwbGUgeyAxLCAyIH0nLCAnJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnICAgIGludCBhWzJdWzJdID0ge3sgMSwgMiB9LCB7IDMsIDQg fSB9OycsICdNaXNzaW5nIHNwYWNlIGFmdGVyIHsuICBbd2hpdGVzcGFjZS9icmFjZXNdIFs1XScp CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICBpbnQgYVsyXVsyXSA9IHsgezEsIDIgfSwg eyAzLCA0IH0gfTsnLCAnTWlzc2luZyBzcGFjZSBhZnRlciB7LiAgW3doaXRlc3BhY2UvYnJhY2Vz XSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgaW50IGFbMl1bMl0gPSB7IHsg MSwgMiB9LCB7MywgNCB9IH07JywgJ01pc3Npbmcgc3BhY2UgYWZ0ZXIgey4gIFt3aGl0ZXNwYWNl L2JyYWNlc10gWzVdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIGludCBhWzJdWzJd ID0geyB7IDEsIDJ9LCB7IDMsIDQgfSB9OycsICdNaXNzaW5nIHNwYWNlIGJlZm9yZSB9LiAgW3do aXRlc3BhY2UvYnJhY2VzXSBbNV0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgaW50 IGFbMl1bMl0gPSB7IHsgMSwgMiB9LCB7IDMsIDR9IH07JywgJ01pc3Npbmcgc3BhY2UgYmVmb3Jl IH0uICBbd2hpdGVzcGFjZS9icmFjZXNdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQo JyAgICBpbnQgYVsyXVsyXSA9IHsgeyAxLCAyIH0sIHsgMywgNCB9fTsnLCAnTWlzc2luZyBzcGFj ZSBiZWZvcmUgfS4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzVdJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgnICAgIGludCBhWzJdWzJdID0geyB7IDEsIDIgfSwgeyAzLCA0IH0gfTsnLCAnJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIFN0clBhaXIgeyJzdHJpbmdzIiwgImluc2lk ZSIgfScsICdNaXNzaW5nIHNwYWNlIGFmdGVyIHsuICBbd2hpdGVzcGFjZS9icmFjZXNdIFs1XScp CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICBTdHJQYWlyIHsgInN0cmluZ3MiLCAiaW5z aWRlIn0nLCAnTWlzc2luZyBzcGFjZSBiZWZvcmUgfS4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzVd JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIFN0clBhaXIgeyAic3RyaW5ncyIsICJp bnNpZGUiIH0nLCAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIGZvbygie2JyYWNl cyBpbiBhIHN0cmluZ30iKTsnLCAnJykKIAogICAgIGRlZiB0ZXN0X3NwYWNpbmdfYmVmb3JlX2Jy YWNrZXRzKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdkZWxldGUgW10gYmFzZTsn LCAnJykKQEAgLTQwNTgsNyArNDA3Niw3IEBAIGNsYXNzIE5vTm9uVmlydHVhbERlc3RydWN0b3Jz VGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgRk9PX1RXTwogICAg ICAgICAgICAgICAgIH07CiAgICAgICAgICAgICAgICAgZW51bSB7IEZPT19PTkUgfTsKLSAgICAg ICAgICAgICAgICBlbnVtIHtGb29PbmUsIGZvb1R3b307CisgICAgICAgICAgICAgICAgZW51bSB7 IEZvb09uZSwgZm9vVHdvIH07CiAgICAgICAgICAgICAgICAgZW51bSB7CiAgICAgICAgICAgICAg ICAgICAgIEZPT19PTkUKICAgICAgICAgICAgICAgICB9OycnJywKQEAgLTQxMTAsNyArNDEyOCw3 IEBAIGNsYXNzIE5vTm9uVmlydHVhbERlc3RydWN0b3JzVGVzdChDcHBTdHlsZVRlc3RCYXNlKToK ICAgICAgICAgICAgICAgICAgICAgRk9PX1RXTwogICAgICAgICAgICAgICAgIH07CiAgICAgICAg ICAgICAgICAgZW51bSBjbGFzcyBGb28geyBGT09fT05FIH07Ci0gICAgICAgICAgICAgICAgZW51 bSBjbGFzcyBGb28ge0Zvb09uZSwgZm9vVHdvfTsKKyAgICAgICAgICAgICAgICBlbnVtIGNsYXNz IEZvbyB7IEZvb09uZSwgZm9vVHdvIH07CiAgICAgICAgICAgICAgICAgZW51bSBjbGFzcyBGb28g ewogICAgICAgICAgICAgICAgICAgICBGT09fT05FCiAgICAgICAgICAgICAgICAgfTsnJycsCkBA IC00NDg2LDcgKzQ1MDQsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFz ZSk6CiAgICAgICAgICAgICAnbmFtZXNwYWNlIFdlYkNvcmUge1xuJwogICAgICAgICAgICAgJyNk ZWZpbmUgYWJjKHgpIHg7IFxcXG4nCiAgICAgICAgICAgICAnICAgIHhcbicKLSAgICAgICAgICAg ICcgICAgdm9pZCogeDsnCisgICAgICAgICAgICAnICAgIHZvaWQqIHg7XG4nCiAgICAgICAgICAg ICAnfScsCiAgICAgICAgICAgICAnQ29kZSBpbnNpZGUgYSBuYW1lc3BhY2Ugc2hvdWxkIG5vdCBi ZSBpbmRlbnRlZC4gIFt3aGl0ZXNwYWNlL2luZGVudF0gWzRdJywKICAgICAgICAgICAgICdmb28u Y3BwJykK