23119 2009-01-05 08:49:00 -0800 Provide a way for the fonts to prohibit complex text handling 2009-04-08 16:11:47 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All NEW P2 Normal --- 1 brettw brettw aroben jshin mitz oldest_to_newest 104435 0 brettw 2009-01-05 08:49:00 -0800 I'm trying to fix a not uncommon crash in Chromium which probably also affects Safari on Windows: http://code.google.com/p/chromium/issues/detail?id=3950 It happens inside Uniscribe and is a bug in Windows when doing complex text shaping on bad fonts. Mozilla worked around this bug, and we probably want to do the same. See https://bugzilla.mozilla.org/show_bug.cgi?id=418384 The solution is to (1) detect if a font is Type1 and don't do shaping on it, and (2) if placement ever fails on the complex script path, force the font to use the non-complex code path. I think having a flag to Font that is queried when determining how to draw the text should be sufficient. Each port can be in charge of setting the flag (or not) as necessary. 104454 1 brettw 2009-01-05 10:23:11 -0800 Actually, it looks like Chrome already handles the "placement error" case reported in the Mozilla bug (by just not showing the text), so it shouldn't crash. I assume our crashes are a result of doing this on PostScript fonts? 104730 2 mitz 2009-01-07 11:15:31 -0800 A test case (probably involving a font attached to the bug or otherwise obtainable) will be helpful. 104731 3 brettw 2009-01-07 11:17:51 -0800 I tried the Mozilla test case on my Vista computer and it worked OK. It could be MS fixed the bug in very recent versions. I'm going to look for an older computer to try.