231188 2021-10-04 12:16:10 -0700 [clang 13] Suppress sign comparison warnings 2021-10-19 12:50:03 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke cdumez achristensen cdumez ews-watchlist hi joepeck keith_miller mark.lam msaboff pangle saam tzagallo webkit-bug-importer oldest_to_newest 1800163 0 basuke 2021-10-04 12:16:10 -0700 C:/PSDev/webkit/Source/JavaScriptCore\inspector/remote/socket/RemoteInspectorSocket.cpp:273:68: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] if (FileSystem::readFromFile(handle, buffer.data(), *size) == *size) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~ 1 warning generated. 1802734 1 webkit-bug-importer 2021-10-11 12:17:24 -0700 <rdar://problem/84110570> 1806153 2 441756 cdumez 2021-10-19 10:54:08 -0700 Created attachment 441756 Patch 1806247 3 ews-feeder 2021-10-19 12:49:58 -0700 Committed r284480 (243239@main): <https://commits.webkit.org/243239@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441756. 441756 2021-10-19 10:54:08 -0700 2021-10-19 12:50:00 -0700 Patch bug-231188-20211019105407.patch text/plain 1678 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MjhjZTYyYjhiYzQwZTVhMTUzNGQ2MjU3MjUzOGUxOTVhMTM2N2E0Li5jYWE4MTZiZTUzZjZhY2Y0 MTYzZDJkNDI5MWEyMTUxOGIxZWJkMGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMS0xMC0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIFtjbGFuZyAxM10gU3VwcHJlc3Mgc2lnbiBjb21wYXJpc29uIHdhcm5pbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzExODgKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg0MTEwNTcwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3Rl SW5zcGVjdG9yU29ja2V0LmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9y OjpiYWNrZW5kQ29tbWFuZHMgY29uc3QpOgorCiAyMDIxLTEwLTE4ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgV2FzbSBUYWJsZSBjYW4gdGFrZSBhcmJpdHJh cnkgZGVmYXVsdCB2YWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvclNvY2tldC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU29ja2V0 LmNwcAppbmRleCA1YjFlOGFkMzRiYWZjYWFmMjljOTI1NTBiNmJiMTRkOWY2ZDk2NzkzLi45YTY4 NzY1N2M4NmJiNWY1NDQyMTg5NDY2ZTg3Yjg5ZGUwZDVjMjNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yU29j a2V0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2Nr ZXQvUmVtb3RlSW5zcGVjdG9yU29ja2V0LmNwcApAQCAtMjcwLDcgKzI3MCw4IEBAIFN0cmluZyBS ZW1vdGVJbnNwZWN0b3I6OmJhY2tlbmRDb21tYW5kcygpIGNvbnN0CiAgICAgU3RyaW5nIHJlc3Vs dDsKICAgICBpZiAoYXV0byBzaXplID0gRmlsZVN5c3RlbTo6ZmlsZVNpemUoaGFuZGxlKSkgewog ICAgICAgICBWZWN0b3I8TENoYXI+IGJ1ZmZlcigqc2l6ZSk7Ci0gICAgICAgIGlmIChGaWxlU3lz dGVtOjpyZWFkRnJvbUZpbGUoaGFuZGxlLCBidWZmZXIuZGF0YSgpLCAqc2l6ZSkgPT0gKnNpemUp CisgICAgICAgIGludCBieXRlc1JlYWQgPSBGaWxlU3lzdGVtOjpyZWFkRnJvbUZpbGUoaGFuZGxl LCBidWZmZXIuZGF0YSgpLCAqc2l6ZSk7CisgICAgICAgIGlmIChieXRlc1JlYWQgPj0gMCAmJiBz dGF0aWNfY2FzdDx1aW50NjRfdD4oYnl0ZXNSZWFkKSA9PSAqc2l6ZSkKICAgICAgICAgICAgIHJl c3VsdCA9IFN0cmluZzo6YWRvcHQoV1RGTW92ZShidWZmZXIpKTsKICAgICB9CiAgICAgRmlsZVN5 c3RlbTo6Y2xvc2VGaWxlKGhhbmRsZSk7Cg==