231186 2021-10-04 11:53:36 -0700 Don't use namespace WebCore::XPath at global scope 2021-10-06 11:02:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231302 1 achristensen achristensen basuke ross.kirsling sam webkit-bug-importer oldest_to_newest 1800152 0 achristensen 2021-10-04 11:53:36 -0700 Don't use namespace WebCore::XPath at global scope 1800155 1 440084 achristensen 2021-10-04 11:55:14 -0700 Created attachment 440084 Patch 1800157 2 basuke 2021-10-04 11:57:30 -0700 I'm checking right now. 1800182 3 basuke 2021-10-04 12:47:35 -0700 In PlayStation port, it still has these compile errors: C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:58: error: expected ')' bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:140:24: note: to match this '(' bool strokeContains(const FloatPoint&, const Function<void(GraphicsContext&)>& strokeStyleApplier) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:48: error: expected ')' FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const; ^ C:/PSDev/webkit/Source/WebCore/platform/graphics\Path.h:146:33: note: to match this '(' FloatRect strokeBoundingRect(const Function<void(GraphicsContext&)>& strokeStyleApplier = { }) const; ^ 2 errors generated. 1800261 4 ross.kirsling 2021-10-04 15:46:45 -0700 Perhaps the issue is the remaining `using namespace`s at XPathGrammar.y:51? 1801190 5 ews-feeder 2021-10-06 11:00:09 -0700 Committed r283635 (242586@main): <https://commits.webkit.org/242586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440084. 1801192 6 webkit-bug-importer 2021-10-06 11:01:22 -0700 <rdar://problem/83942126> 440084 2021-10-04 11:55:14 -0700 2021-10-06 11:00:11 -0700 Patch bug-231186-20211004115513.patch text/plain 4627 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhjN2VhNmVhNDQ4Nzg1 NmMzYjkzMDEzOWE1Y2ZkMTdlYTcxZmRlOC4uODRhMWFiYWQ1Njk0NmU5NTNhOGQzMWY0Y2U0YmUw ZDkwYmM1M2ZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTA0ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRG9uJ3Qg dXNlIG5hbWVzcGFjZSBXZWJDb3JlOjpYUGF0aCBhdCBnbG9iYWwgc2NvcGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTE4NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGNhdXNlcyBwcm9ibGVtcyB3 aXRoIHVuaWZpZWQgYnVpbGRzLCB3aGljaCBnZXQgY29uZnVzZWQgYmV0d2VlbiBXZWJDb3JlOjpY UGF0aDo6RnVuY3Rpb24gYW5kIFdURjo6RnVuY3Rpb24uCisKKyAgICAgICAgKiB4bWwvWFBhdGhH cmFtbWFyLmNwcDoKKyAgICAgICAgKiB4bWwvWFBhdGhHcmFtbWFyLmg6CisgICAgICAgICogeG1s L1hQYXRoR3JhbW1hci55OgorICAgICAgICAqIHhtbC9YUGF0aFBhcnNlci5jcHA6CisKIDIwMjEt MTAtMDQgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBtYWNjYXRhbHlzdCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEdy YW1tYXIuY3BwCmluZGV4IDA4NzVhNWVjZmZhOWM2N2U2MGMxYWY2NmM5MGM3MDk1ZmU3YmQxMDQu LjBkNDg4NjdhOThmNmU0MzEyODJmMzIwNGRlNTBkNmYyMDk0MDM3NDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3ht bC9YUGF0aEdyYW1tYXIuY3BwCkBAIC0xNzgsMTUgKzE3OCwxNSBAQCB1c2luZyBuYW1lc3BhY2Ug WFBhdGg7CiB0eXBlZGVmIHVuaW9uIFlZU1RZUEUKICNsaW5lIDYwICJXZWJDb3JlL3htbC9YUGF0 aEdyYW1tYXIueSIKIHsgCi0gICAgTnVtZXJpY09wOjpPcGNvZGUgbnVtZXJpY09wY29kZTsgCi0g ICAgRXFUZXN0T3A6Ok9wY29kZSBlcXVhbGl0eVRlc3RPcGNvZGU7CisgICAgV2ViQ29yZTo6WFBh dGg6Ok51bWVyaWNPcDo6T3Bjb2RlIG51bWVyaWNPcGNvZGU7CisgICAgV2ViQ29yZTo6WFBhdGg6 OkVxVGVzdE9wOjpPcGNvZGUgZXF1YWxpdHlUZXN0T3Bjb2RlOwogICAgIFN0cmluZ0ltcGwqIHN0 cmluZzsKLSAgICBTdGVwOjpBeGlzIGF4aXM7Ci0gICAgTG9jYXRpb25QYXRoKiBsb2NhdGlvblBh dGg7Ci0gICAgU3RlcDo6Tm9kZVRlc3QqIG5vZGVUZXN0OwotICAgIFZlY3RvcjxzdGQ6OnVuaXF1 ZV9wdHI8RXhwcmVzc2lvbj4+KiBleHByZXNzaW9uVmVjdG9yOwotICAgIFN0ZXAqIHN0ZXA7Ci0g ICAgRXhwcmVzc2lvbiogZXhwcmVzc2lvbjsgCisgICAgV2ViQ29yZTo6WFBhdGg6OlN0ZXA6OkF4 aXMgYXhpczsKKyAgICBXZWJDb3JlOjpYUGF0aDo6TG9jYXRpb25QYXRoKiBsb2NhdGlvblBhdGg7 CisgICAgV2ViQ29yZTo6WFBhdGg6OlN0ZXA6Ok5vZGVUZXN0KiBub2RlVGVzdDsKKyAgICBWZWN0 b3I8c3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OlhQYXRoOjpFeHByZXNzaW9uPj4qIGV4cHJlc3Np b25WZWN0b3I7CisgICAgV2ViQ29yZTo6WFBhdGg6OlN0ZXAqIHN0ZXA7CisgICAgV2ViQ29yZTo6 WFBhdGg6OkV4cHJlc3Npb24qIGV4cHJlc3Npb247CiB9CiAvKiBMaW5lIDE5MyBvZiB5YWNjLmMu ICAqLwogI2xpbmUgMTkwICIuL1hQYXRoR3JhbW1hci5jcHAiCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLmggYi9Tb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhHcmFt bWFyLmgKaW5kZXggMzliOTZjYTI0ODAyNDU1NTA2N2QyZDMxYWIwODY0YzBmYmQ0YzFhNy4uYzFk YmI2ZjIxYTE5MjE4NjZmMDBjN2Q5ZWNlZWJiM2FkMGRkZTM3MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUveG1sL1hQYXRoR3JhbW1hci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0 aEdyYW1tYXIuaApAQCAtOTQsMTUgKzk0LDE1IEBACiB0eXBlZGVmIHVuaW9uIFlZU1RZUEUKICNs aW5lIDYwICJXZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIueSIKIHsgCi0gICAgTnVtZXJpY09wOjpP cGNvZGUgbnVtZXJpY09wY29kZTsgCi0gICAgRXFUZXN0T3A6Ok9wY29kZSBlcXVhbGl0eVRlc3RP cGNvZGU7CisgICAgV2ViQ29yZTo6WFBhdGg6Ok51bWVyaWNPcDo6T3Bjb2RlIG51bWVyaWNPcGNv ZGU7CisgICAgV2ViQ29yZTo6WFBhdGg6OkVxVGVzdE9wOjpPcGNvZGUgZXF1YWxpdHlUZXN0T3Bj b2RlOwogICAgIFN0cmluZ0ltcGwqIHN0cmluZzsKLSAgICBTdGVwOjpBeGlzIGF4aXM7Ci0gICAg TG9jYXRpb25QYXRoKiBsb2NhdGlvblBhdGg7Ci0gICAgU3RlcDo6Tm9kZVRlc3QqIG5vZGVUZXN0 OwotICAgIFZlY3RvcjxzdGQ6OnVuaXF1ZV9wdHI8RXhwcmVzc2lvbj4+KiBleHByZXNzaW9uVmVj dG9yOwotICAgIFN0ZXAqIHN0ZXA7Ci0gICAgRXhwcmVzc2lvbiogZXhwcmVzc2lvbjsgCisgICAg V2ViQ29yZTo6WFBhdGg6OlN0ZXA6OkF4aXMgYXhpczsKKyAgICBXZWJDb3JlOjpYUGF0aDo6TG9j YXRpb25QYXRoKiBsb2NhdGlvblBhdGg7CisgICAgV2ViQ29yZTo6WFBhdGg6OlN0ZXA6Ok5vZGVU ZXN0KiBub2RlVGVzdDsKKyAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OlhQYXRo OjpFeHByZXNzaW9uPj4qIGV4cHJlc3Npb25WZWN0b3I7CisgICAgV2ViQ29yZTo6WFBhdGg6OlN0 ZXAqIHN0ZXA7CisgICAgV2ViQ29yZTo6WFBhdGg6OkV4cHJlc3Npb24qIGV4cHJlc3Npb247CiB9 CiAvKiBMaW5lIDE1Mjkgb2YgeWFjYy5jLiAgKi8KICNsaW5lIDEwNyAiLi9YUGF0aEdyYW1tYXIu aHBwIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hQYXRoR3JhbW1hci55IGIvU291 cmNlL1dlYkNvcmUveG1sL1hQYXRoR3JhbW1hci55CmluZGV4IGI3NTFhNjFiYTNmNDIyMjQwZTdj MGJlMGU0ZjVkNjEzZTJmN2E1NWIuLmU0MDVkM2E0MzA1NTcyMjdlOTRiZGFiYTVjMjA1ZGIzY2Uy MDFlMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIueQorKysg Yi9Tb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLnkKQEAgLTU4LDE1ICs1OCwxNSBAQCB1 c2luZyBuYW1lc3BhY2UgWFBhdGg7CiAlcGFyc2UtcGFyYW0geyBQYXJzZXImIHBhcnNlciB9CiAK ICV1bmlvbiB7IAotICAgIE51bWVyaWNPcDo6T3Bjb2RlIG51bWVyaWNPcGNvZGU7IAotICAgIEVx VGVzdE9wOjpPcGNvZGUgZXF1YWxpdHlUZXN0T3Bjb2RlOworICAgIFdlYkNvcmU6OlhQYXRoOjpO dW1lcmljT3A6Ok9wY29kZSBudW1lcmljT3Bjb2RlOworICAgIFdlYkNvcmU6OlhQYXRoOjpFcVRl c3RPcDo6T3Bjb2RlIGVxdWFsaXR5VGVzdE9wY29kZTsKICAgICBTdHJpbmdJbXBsKiBzdHJpbmc7 Ci0gICAgU3RlcDo6QXhpcyBheGlzOwotICAgIExvY2F0aW9uUGF0aCogbG9jYXRpb25QYXRoOwot ICAgIFN0ZXA6Ok5vZGVUZXN0KiBub2RlVGVzdDsKLSAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRy PEV4cHJlc3Npb24+PiogZXhwcmVzc2lvblZlY3RvcjsKLSAgICBTdGVwKiBzdGVwOwotICAgIEV4 cHJlc3Npb24qIGV4cHJlc3Npb247IAorICAgIFdlYkNvcmU6OlhQYXRoOjpTdGVwOjpBeGlzIGF4 aXM7CisgICAgV2ViQ29yZTo6WFBhdGg6OkxvY2F0aW9uUGF0aCogbG9jYXRpb25QYXRoOworICAg IFdlYkNvcmU6OlhQYXRoOjpTdGVwOjpOb2RlVGVzdCogbm9kZVRlc3Q7CisgICAgVmVjdG9yPHN0 ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpYUGF0aDo6RXhwcmVzc2lvbj4+KiBleHByZXNzaW9uVmVj dG9yOworICAgIFdlYkNvcmU6OlhQYXRoOjpTdGVwKiBzdGVwOworICAgIFdlYkNvcmU6OlhQYXRo OjpFeHByZXNzaW9uKiBleHByZXNzaW9uOwogfQogJWxlZnQgPG51bWVyaWNPcGNvZGU+IE1VTE9Q CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aFBhcnNlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS94bWwvWFBhdGhQYXJzZXIuY3BwCmluZGV4IDg5ZjdlZDlkNzIyZjJhOWZjMTU5 YzlkZDViZWZmZDAzYzEzN2ZhZmIuLmNlMmQwODE1MmM2YmQyNTBjY2U4OTE4NmI5MDgwYjg3Y2Zk MzYxNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aFBhcnNlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUveG1sL1hQYXRoUGFyc2VyLmNwcApAQCAtMzcsOCArMzcsNiBAQAog I2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdI YXNoLmg+CiAKLXVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOjpYUGF0aDsKLQogZXh0ZXJuIGludCB4 cGF0aHl5cGFyc2UoV2ViQ29yZTo6WFBhdGg6OlBhcnNlciYpOwogCiAjaW5jbHVkZSAiWFBhdGhH cmFtbWFyLmgiCg==