231112 2021-10-01 16:47:20 -0700 Some layout tests with Japanese glyphs fail if Japanese is included in the system "Preferred Languages" settings 2021-10-03 10:11:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser mmaxfield ap mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1799633 0 simon.fraser 2021-10-01 16:47:20 -0700 I had Japanse in my list of "Preferred Languages" in the Language & Region system settings on Big Sur, and this causes a subset of layout tests to fail, including: fast/ruby/ruby-justification.html fast/text/backslash-to-yen-sign-euc.html and tests with "ideograph" in the name. We need to fix WTR to make tests pass independently of system language settings. 1799660 1 mmaxfield 2021-10-01 17:36:39 -0700 I can reproduce this. 1799663 2 mmaxfield 2021-10-01 17:38:25 -0700 Fixing DRT would be super difficult (bordering on "impossible") here. Fixing WKTR is probably not very difficult. We already have infrastructure for mocking the system font. We probably should just always enable that infrastructure. 1799674 3 439946 mmaxfield 2021-10-01 18:40:45 -0700 Created attachment 439946 Patch 1799861 4 ews-feeder 2021-10-03 10:10:52 -0700 Committed r283468 (242445@main): <https://commits.webkit.org/242445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439946. 1799862 5 webkit-bug-importer 2021-10-03 10:11:19 -0700 <rdar://problem/83815251> 439946 2021-10-01 18:40:45 -0700 2021-10-03 10:10:53 -0700 Patch bug-231112-20211001184044.patch text/plain 1340 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzNDEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWZiMzY5NzQ4OTBhM2IxNjEwNDhjNzY4MzczMzc4OTQ4 YjY2NmI1My4uNzljYzZkYjYwMzBmOTc2NmRjMTA3NDZkOWJkMzM4ZGVjOWM4M2Y1NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIxLTEwLTAxICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgU29tZSBsYXlvdXQgdGVzdHMgd2l0aCBKYXBhbmVzZSBnbHlwaHMgZmFpbCBp ZiBKYXBhbmVzZSBpcyBpbmNsdWRlZCBpbiB0aGUgc3lzdGVtICJQcmVmZXJyZWQgTGFuZ3VhZ2Vz IiBzZXR0aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjMxMTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU2ltcGx5IHNldCB0aGUgZGVmYXVsdCBsb2NhbGUgdG8gZW4tVVMuIFRlc3RzIGNhbiBzdGls bCBvdmVycmlkZSBpdC4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMu Y3BwOgorICAgICAgICAoV1RSOjpUZXN0T3B0aW9uczo6ZGVmYXVsdHMpOgorCiAyMDIxLTEwLTAx ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2Via2l0 Y29yZXB5XSBBZGQgVGFza1Bvb2wgKEZvbGxvdy11cCBmaXgpCmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL1Rlc3RPcHRpb25zLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv VGVzdE9wdGlvbnMuY3BwCmluZGV4IGE1NjM1NjBlMGNjYTM5OWU4YjAwNGZmYWM0ZGUzMmQ0Y2I1 MDgzNmIuLjY4N2ZhYmRlMmM4ZmY2YWFmN2JhM2U1YmRjMzE0ZjZiNzUyYWRkMjMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMuY3BwCisrKyBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMuY3BwCkBAIC0xNzksNyArMTc5LDcgQEAgY29uc3Qg VGVzdEZlYXR1cmVzJiBUZXN0T3B0aW9uczo6ZGVmYXVsdHMoKQogICAgICAgICAgICAgeyAic3Rh bmRhbG9uZVdlYkFwcGxpY2F0aW9uVVJMIiwgeyB9IH0sCiAgICAgICAgIH07CiAgICAgICAgIGZl YXR1cmVzLnN0cmluZ1ZlY3RvclRlc3RSdW5uZXJGZWF0dXJlcyA9IHsKLSAgICAgICAgICAgIHsg Imxhbmd1YWdlIiwgeyB9IH0sCisgICAgICAgICAgICB7ICJsYW5ndWFnZSIsIHsgImVuLVVTIiB9 IH0sCiAgICAgICAgIH07CiAgICAgfQogICAgIAo=