231101 2021-10-01 13:56:46 -0700 [WinCairo] Support run-jsc-stress-tests without posix commands 2021-10-07 14:30:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned angelos aperez webkit-bug-importer oldest_to_newest 1799526 0 stephan.szabo 2021-10-01 13:56:46 -0700 A change was made to collect up the status files that is using "find" which is failing on native windows without posix commands. Probably will need to add an alternate path using Dir.glob for --ruby-runner (and maybe for playstation as well? Need to check) 1799547 1 439912 stephan.szabo 2021-10-01 14:25:05 -0700 Created attachment 439912 Patch 1800091 2 angelos 2021-10-04 09:48:29 -0700 Oops. Patch looks reasonable. Minor nit: looks like you can avoid repeating Dir.chdir by hoisting it out of the if/else? Even more minor nit: you can implement a class StatusFileEnumerator def each_line Dir.glob("#{STATUS_FILE_PREFIX}*").each do |name| if File.size(name) > 0 line = File.open(name).first yield "./#{name} #{line}" end end end end and then do something like Dir.chdir($runnerDir) { statusFileEnumerator = StatusFileEnumerator.new if $testRunnerType != :ruby and $testWriter != "playstation" statusFileEnumerator = IO.popen(find_cmd) end statuFileEnumerator.each_line { | line | processStatusLine(map, line) } } but that might be overkill :-) 1800110 3 440073 stephan.szabo 2021-10-04 10:21:06 -0700 Created attachment 440073 Patch Updated and I went with the class version, tried it on a tiny test subset on windows native and going to see if EWS is happy (hoping that there's some bot that will exercise this). 1800112 4 angelos 2021-10-04 10:25:39 -0700 Yah, the EWS JSC bots for armv7 should take this path. 1800188 5 440092 stephan.szabo 2021-10-04 12:59:55 -0700 Created attachment 440092 Patch 1800772 6 440092 aperez 2021-10-05 14:36:43 -0700 Comment on attachment 440092 Patch Hello, and thanks for the patch. I think this is going in the right direction, but I have a couple of suggestions to make it even better. Please read on below :) View in context: https://bugs.webkit.org/attachment.cgi?id=440092&action=review > Tools/Scripts/run-jsc-stress-tests:2334 > + def each_line I suppose this function could be just a function; there is no need to put it inside a class, right? > Tools/Scripts/run-jsc-stress-tests:2367 > + statusFileEnumerator.each_line { I would completely remove the usage of the “find” command and use the same code that uses Ruby functions to locate and read the result files. The advantages would be having only one code path to maintain that works for all ports, and avoiding spawning a bunch of subprocesses here. 1800777 7 stephan.szabo 2021-10-05 14:43:40 -0700 (In reply to Adrian Perez from comment #6) > Comment on attachment 440092 [details] > Patch > > Hello, and thanks for the patch. I think this is going in the right > direction, but I have a couple of suggestions to make it even better. > Please read on below :) > > View in context: > https://bugs.webkit.org/attachment.cgi?id=440092&action=review > > > Tools/Scripts/run-jsc-stress-tests:2334 > > + def each_line > > I suppose this function could be just a function; there is no > need to put it inside a class, right? Hmm, probably. Ruby isn't high on my list of languages, so I figured that it was suggested as a class to make it look similar to the popen output. If we don't switch between them per the below, then even the function might not be strictly necessary. > > Tools/Scripts/run-jsc-stress-tests:2367 > > + statusFileEnumerator.each_line { > > I would completely remove the usage of the “find” command and use the > same code that uses Ruby functions to locate and read the result files. > The advantages would be having only one code path to maintain that works > for all ports, and avoiding spawning a bunch of subprocesses here. I'd thought about that, but I wasn't sure how to best manage that with the $remote codepath and was concerned that it might be wanted to keep the same code between the local non-windows and remote case, but I can change either way. 1800809 8 440282 stephan.szabo 2021-10-05 15:35:34 -0700 Created attachment 440282 Patch for EWS testing Checking a version without find on EWS. 1801123 9 angelos 2021-10-06 09:12:21 -0700 (In reply to Adrian Perez from comment #6) > Comment on attachment 440092 [details] > Patch > > Hello, and thanks for the patch. I think this is going in the right > direction, but I have a couple of suggestions to make it even better. > Please read on below :) Thanks for taking a look Adrian, IMHO you're more right than you think :-) > View in context: > https://bugs.webkit.org/attachment.cgi?id=440092&action=review > > > Tools/Scripts/run-jsc-stress-tests:2334 > > + def each_line > > I suppose this function could be just a function; there is no > need to put it inside a class, right? The reason I suggested a class is so that it would be interchangeable with the IO object produced by IO.popen(find_cmd). Technically you could wrap /that/ in a function so as to have a common interface. I thought it was more idiomatic that way. Opinions may differ. > > Tools/Scripts/run-jsc-stress-tests:2367 > > + statusFileEnumerator.each_line { > > I would completely remove the usage of the “find” command and use the > same code that uses Ruby functions to locate and read the result files. > The advantages would be having only one code path to maintain that works > for all ports, and avoiding spawning a bunch of subprocesses here. The reason I didn't suggest that is I introduced find_cmd locally so as to share the local code with the one dealing with remote boxes. This way, changes to this part of the code would automatically apply to the "remote" code as well. I didn't realize when replying, but this implicitly prioritizes the find-based remote code path over the ruby-based non-posix code path. However, I think the choice here is clear: the find code should be much slower (because of all those sh invocations), so we should go with the ruby version for the local case (though measuring would be nice at some point). 1801226 10 440399 stephan.szabo 2021-10-06 11:48:58 -0700 Created attachment 440399 Patch version using find on remote and ruby local 1801558 11 angelos 2021-10-07 03:04:03 -0700 (In reply to Stephan Szabo from comment #10) > Created attachment 440399 [details] > Patch version using find on remote and ruby local Looks good. 1801567 12 aperez 2021-10-07 04:58:28 -0700 (In reply to Angelos Oikonomopoulos from comment #11) > (In reply to Stephan Szabo from comment #10) > > Created attachment 440399 [details] > > Patch version using find on remote and ruby local > > Looks good. LGTM, but you haven't set the r? or cq? flags. Do you still want to change anything in the patch before approving it, or may I set r+ and cq+ on it? :) 1801616 13 stephan.szabo 2021-10-07 08:50:16 -0700 Sorry about that, I sometimes wait for EWS to come back before setting r? and kept waiting on the jsc-*-tests results and meant to set it yesterday. 1801712 14 440399 aperez 2021-10-07 12:29:32 -0700 Comment on attachment 440399 Patch version using find on remote and ruby local Let me know if you need a committer 1801714 15 aperez 2021-10-07 12:30:23 -0700 (In reply to Adrian Perez from comment #14) > Comment on attachment 440399 [details] > Patch version using find on remote and ruby local > > Let me know if you need a committer ...to set r+ But then I noticed you are a committer yourself :) 1801716 16 aperez 2021-10-07 12:31:21 -0700 (In reply to Stephan Szabo from comment #13) > Sorry about that, I sometimes wait for EWS to come back before setting r? > and kept waiting on the jsc-*-tests results and meant to set it yesterday. No problem at all! Sometimes I also set r? without setting cq? and wait for the EWS to be green before changing to cq+ even if a reviewer had approved already the patch. =) 1801789 17 ews-feeder 2021-10-07 14:29:47 -0700 Committed r283745 (242667@main): <https://commits.webkit.org/242667@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440399. 1801790 18 webkit-bug-importer 2021-10-07 14:30:20 -0700 <rdar://problem/83999466> 439912 2021-10-01 14:25:05 -0700 2021-10-04 10:21:06 -0700 Patch 231101.1.diff text/plain 1922 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmY0 MjYyM2I4NWIuLmE4NmM0NTJhM2FmNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTAxICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBv cnQgcnVuLWpzYy1zdHJlc3MtdGVzdHMgd2l0aG91dCBwb3NpeCBjb21tYW5kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGNv bGxlY3RpbmcgdGhlIHRlc3QgcmVzdWx0IGZpbGVzIHdoZW4gbm90IG9uCisgICAgICAgIGEgcG9z aXggaG9zdCBwbGF0Zm9ybSBieSByb3VnaGx5IGVtdWxhdGluZyB0aGUgZmluZCBjb21tYW5kCisg ICAgICAgIGN1cnJlbnQgdXNlZCBpbiBydWJ5IGNvZGUgd2hlbiB1c2luZyB0aGUgcnVieS1ydW5u ZXIgb3IKKyAgICAgICAgZm9yIHBsYXlzdGF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMS0wOS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1 aWx0aW5zLWdlbmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBu YW1lZCAnYnVpbHRpbnNfbW9kZWwnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBl MDgxNmRjMDU2MWIuLmFiOGEyOGQ3OWIxMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yMzQ4LDEyICsyMzQ4LDIzIEBAIGRlZiBnZXRTdGF0dXNNYXAobWFwPXt9KQogICAgICAg ICAgICAgfQogICAgICAgICB9CiAgICAgZWxzZQotICAgICAgICBEaXIuY2hkaXIoJHJ1bm5lckRp cikgewotICAgICAgICAgICAgSU8ucG9wZW4oZmluZF9jbWQpLmVhY2hfbGluZSB7Ci0gICAgICAg ICAgICAgICAgfCBsaW5lIHwKLSAgICAgICAgICAgICAgICBwcm9jZXNzU3RhdHVzTGluZShtYXAs IGxpbmUpCisgICAgICAgIGlmICR0ZXN0UnVubmVyVHlwZSA9PSA6cnVieSBvciAkdGVzdFdyaXRl ciA9PSAicGxheXN0YXRpb24iCisgICAgICAgICAgICBEaXIuY2hkaXIoJHJ1bm5lckRpcikgewor ICAgICAgICAgICAgICAgIERpci5nbG9iKCIje1NUQVRVU19GSUxFX1BSRUZJWH0qIikuZWFjaCBk byB8bmFtZXwKKyAgICAgICAgICAgICAgICAgICAgaWYgRmlsZS5zaXplKG5hbWUpID4gMAorICAg ICAgICAgICAgICAgICAgICAgICAgbGluZSA9IEZpbGUub3BlbihuYW1lKS5maXJzdAorICAgICAg ICAgICAgICAgICAgICAgICAgcHJvY2Vzc1N0YXR1c0xpbmUobWFwLCAiLi8je25hbWV9ICN7bGlu ZX0iKQorICAgICAgICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgICAgICBlbmQKICAgICAg ICAgICAgIH0KLSAgICAgICAgfQorICAgICAgICBlbHNlCisgICAgICAgICAgICBEaXIuY2hkaXIo JHJ1bm5lckRpcikgeworICAgICAgICAgICAgICAgIElPLnBvcGVuKGZpbmRfY21kKS5lYWNoX2xp bmUgeworICAgICAgICAgICAgICAgICAgICB8IGxpbmUgfAorICAgICAgICAgICAgICAgICAgICBw cm9jZXNzU3RhdHVzTGluZShtYXAsIGxpbmUpCisgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgfQorICAgICAgICBlbmQKICAgICBlbmQKICAgICBtYXAKIGVuZAo= 440073 2021-10-04 10:21:06 -0700 2021-10-04 12:59:55 -0700 Patch 231101.2.diff text/plain 2041 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmY0 MjYyM2I4NWIuLmE4NmM0NTJhM2FmNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTAxICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBv cnQgcnVuLWpzYy1zdHJlc3MtdGVzdHMgd2l0aG91dCBwb3NpeCBjb21tYW5kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGNv bGxlY3RpbmcgdGhlIHRlc3QgcmVzdWx0IGZpbGVzIHdoZW4gbm90IG9uCisgICAgICAgIGEgcG9z aXggaG9zdCBwbGF0Zm9ybSBieSByb3VnaGx5IGVtdWxhdGluZyB0aGUgZmluZCBjb21tYW5kCisg ICAgICAgIGN1cnJlbnQgdXNlZCBpbiBydWJ5IGNvZGUgd2hlbiB1c2luZyB0aGUgcnVieS1ydW5u ZXIgb3IKKyAgICAgICAgZm9yIHBsYXlzdGF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMS0wOS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1 aWx0aW5zLWdlbmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBu YW1lZCAnYnVpbHRpbnNfbW9kZWwnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBl MDgxNmRjMDU2MWIuLjlmYWQyMjEzOGEyMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yMzMwLDYgKzIzMzAsMTcgQEAgZGVmIHByb2Nlc3NTdGF0dXNMaW5lKG1hcCwgbGluZSkK ICAgICBlbmQKIGVuZAogCitjbGFzcyBTdGF0dXNGaWxlRW51bWVyYXRvcgorICAgIGRlZiBlYWNo X2xpbmUKKyAgICAgICAgRGlyLmdsb2IoIiN7U1RBVFVTX0ZJTEVfUFJFRklYfSoiKS5lYWNoIGRv IHxuYW1lfAorICAgICAgICAgICAgaWYgRmlsZS5zaXplKG5hbWUpID4gMAorICAgICAgICAgICAg ICAgIGxpbmUgPSBGaWxlLm9wZW4obmFtZSkuZmlyc3QKKyAgICAgICAgICAgICAgICB5aWVsZCAi Li8je25hbWV9ICN7bGluZX0iCisgICAgICAgICAgICBlbmQKKyAgICAgICAgZW5kCisgICAgZW5k CitlbmQKKwogZGVmIGdldFN0YXR1c01hcChtYXA9e30pCiAgICAgZmluZF9jbWQgPSAiZmluZCAu IC1tYXhkZXB0aCAxIC1uYW1lIFwiI3tTVEFUVVNfRklMRV9QUkVGSVh9KlwiIC1hIC1zaXplICsw YyAtZXhlYyBzaCAtYyBcInByaW50ZiBcXFwiJXMgXFxcIiB7fTsgY2F0IHt9XCIgXFw7IgogICAg IGlmICRyZW1vdGUKQEAgLTIzNDksNyArMjM2MCwxMSBAQCBkZWYgZ2V0U3RhdHVzTWFwKG1hcD17 fSkKICAgICAgICAgfQogICAgIGVsc2UKICAgICAgICAgRGlyLmNoZGlyKCRydW5uZXJEaXIpIHsK LSAgICAgICAgICAgIElPLnBvcGVuKGZpbmRfY21kKS5lYWNoX2xpbmUgeworICAgICAgICAgICAg c3RhdHVzRmlsZUVudW1lcmF0b3IgPSBTdGF0dXNGaWxlRW51bWVyYXRvci5uZXcKKyAgICAgICAg ICAgIGlmICR0ZXN0UnVubmVyVHlwZSAhPSA6cnVieSBhbmQgJHRlc3RXcml0ZXIgIT0gInBsYXlz dGF0aW9uIgorICAgICAgICAgICAgICAgIHN0YXR1c0ZpbGVFbnVtZXJhdG9yID0gSU8ucG9wZW4o ZmluZF9jbWQpCisgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIHN0YXR1c0ZpbGVFbnVtZXJh dG9yLmVhY2hfbGluZSB7CiAgICAgICAgICAgICAgICAgfCBsaW5lIHwKICAgICAgICAgICAgICAg ICBwcm9jZXNzU3RhdHVzTGluZShtYXAsIGxpbmUpCiAgICAgICAgICAgICB9Cg== 440092 2021-10-04 12:59:55 -0700 2021-10-05 14:36:43 -0700 Patch 231101.2.diff text/plain 2041 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmY0 MjYyM2I4NWIuLmE4NmM0NTJhM2FmNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTAxICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBv cnQgcnVuLWpzYy1zdHJlc3MtdGVzdHMgd2l0aG91dCBwb3NpeCBjb21tYW5kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGNv bGxlY3RpbmcgdGhlIHRlc3QgcmVzdWx0IGZpbGVzIHdoZW4gbm90IG9uCisgICAgICAgIGEgcG9z aXggaG9zdCBwbGF0Zm9ybSBieSByb3VnaGx5IGVtdWxhdGluZyB0aGUgZmluZCBjb21tYW5kCisg ICAgICAgIGN1cnJlbnQgdXNlZCBpbiBydWJ5IGNvZGUgd2hlbiB1c2luZyB0aGUgcnVieS1ydW5u ZXIgb3IKKyAgICAgICAgZm9yIHBsYXlzdGF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMS0wOS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1 aWx0aW5zLWdlbmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBu YW1lZCAnYnVpbHRpbnNfbW9kZWwnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBl MDgxNmRjMDU2MWIuLjlmYWQyMjEzOGEyMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yMzMwLDYgKzIzMzAsMTcgQEAgZGVmIHByb2Nlc3NTdGF0dXNMaW5lKG1hcCwgbGluZSkK ICAgICBlbmQKIGVuZAogCitjbGFzcyBTdGF0dXNGaWxlRW51bWVyYXRvcgorICAgIGRlZiBlYWNo X2xpbmUKKyAgICAgICAgRGlyLmdsb2IoIiN7U1RBVFVTX0ZJTEVfUFJFRklYfSoiKS5lYWNoIGRv IHxuYW1lfAorICAgICAgICAgICAgaWYgRmlsZS5zaXplKG5hbWUpID4gMAorICAgICAgICAgICAg ICAgIGxpbmUgPSBGaWxlLm9wZW4obmFtZSkuZmlyc3QKKyAgICAgICAgICAgICAgICB5aWVsZCAi Li8je25hbWV9ICN7bGluZX0iCisgICAgICAgICAgICBlbmQKKyAgICAgICAgZW5kCisgICAgZW5k CitlbmQKKwogZGVmIGdldFN0YXR1c01hcChtYXA9e30pCiAgICAgZmluZF9jbWQgPSAiZmluZCAu IC1tYXhkZXB0aCAxIC1uYW1lIFwiI3tTVEFUVVNfRklMRV9QUkVGSVh9KlwiIC1hIC1zaXplICsw YyAtZXhlYyBzaCAtYyBcInByaW50ZiBcXFwiJXMgXFxcIiB7fTsgY2F0IHt9XCIgXFw7IgogICAg IGlmICRyZW1vdGUKQEAgLTIzNDksNyArMjM2MCwxMSBAQCBkZWYgZ2V0U3RhdHVzTWFwKG1hcD17 fSkKICAgICAgICAgfQogICAgIGVsc2UKICAgICAgICAgRGlyLmNoZGlyKCRydW5uZXJEaXIpIHsK LSAgICAgICAgICAgIElPLnBvcGVuKGZpbmRfY21kKS5lYWNoX2xpbmUgeworICAgICAgICAgICAg c3RhdHVzRmlsZUVudW1lcmF0b3IgPSBTdGF0dXNGaWxlRW51bWVyYXRvci5uZXcKKyAgICAgICAg ICAgIGlmICR0ZXN0UnVubmVyVHlwZSAhPSA6cnVieSBhbmQgJHRlc3RXcml0ZXIgIT0gInBsYXlz dGF0aW9uIgorICAgICAgICAgICAgICAgIHN0YXR1c0ZpbGVFbnVtZXJhdG9yID0gSU8ucG9wZW4o ZmluZF9jbWQpCisgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIHN0YXR1c0ZpbGVFbnVtZXJh dG9yLmVhY2hfbGluZSB7CiAgICAgICAgICAgICAgICAgfCBsaW5lIHwKICAgICAgICAgICAgICAg ICBwcm9jZXNzU3RhdHVzTGluZShtYXAsIGxpbmUpCiAgICAgICAgICAgICB9Cg== 440282 2021-10-05 15:35:34 -0700 2021-10-05 15:35:34 -0700 Patch for EWS testing 231101.3.diff text/plain 2767 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmY0 MjYyM2I4NWIuLmE4NmM0NTJhM2FmNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTAxICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBv cnQgcnVuLWpzYy1zdHJlc3MtdGVzdHMgd2l0aG91dCBwb3NpeCBjb21tYW5kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGNv bGxlY3RpbmcgdGhlIHRlc3QgcmVzdWx0IGZpbGVzIHdoZW4gbm90IG9uCisgICAgICAgIGEgcG9z aXggaG9zdCBwbGF0Zm9ybSBieSByb3VnaGx5IGVtdWxhdGluZyB0aGUgZmluZCBjb21tYW5kCisg ICAgICAgIGN1cnJlbnQgdXNlZCBpbiBydWJ5IGNvZGUgd2hlbiB1c2luZyB0aGUgcnVieS1ydW5u ZXIgb3IKKyAgICAgICAgZm9yIHBsYXlzdGF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMS0wOS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1 aWx0aW5zLWdlbmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBu YW1lZCAnYnVpbHRpbnNfbW9kZWwnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBl MDgxNmRjMDU2MWIuLjkwYThhNGFkZTJlMSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yMzMxLDggKzIzMzEsOCBAQCBkZWYgcHJvY2Vzc1N0YXR1c0xpbmUobWFwLCBsaW5lKQog ZW5kCiAKIGRlZiBnZXRTdGF0dXNNYXAobWFwPXt9KQotICAgIGZpbmRfY21kID0gImZpbmQgLiAt bWF4ZGVwdGggMSAtbmFtZSBcIiN7U1RBVFVTX0ZJTEVfUFJFRklYfSpcIiAtYSAtc2l6ZSArMGMg LWV4ZWMgc2ggLWMgXCJwcmludGYgXFxcIiVzIFxcXCIge307IGNhdCB7fVwiIFxcOyIKICAgICBp ZiAkcmVtb3RlCisgICAgICAgIHJ1YnlfY21kID0gInJ1YnkgLWUgJ0Rpci5nbG9iKFwiI3tTVEFU VVNfRklMRV9QUkVGSVh9KlwiKS5lYWNoIGRvIHxuYW1lfCBpZiBGaWxlLnNpemUobmFtZSkgPiAw IHRoZW4gbGluZSA9IEZpbGUub3BlbihuYW1lKS5maXJzdDsgcHJpbnQoXCIuL1wje25hbWV9IFwj e2xpbmV9XCIpIGVuZCBlbmQnIgogICAgICAgICAjIE5vdGU6IGhlcmUgd2UncmUgdXNpbmcgJHJl bW90ZUhvc3RzIChpbnN0ZWFkIG9mIGdldHRpbmcgdGhlCiAgICAgICAgICMgbGlzdCBvZiBsaXZl IHJlbW90ZUhvc3RzIGZyb20gdGhlIGNhbGxlciwgYmVjYXVzZSB0aGVyZSBtYXkKICAgICAgICAg IyB3ZWxsIGJlIHRlc3QgcmVzdWx0cyBvbiBhIHJlbW90ZUhvc3QgdGhhdCBnb3QgcmVib290ZWQK QEAgLTIzNDEsNyArMjM0MSw3IEBAIGRlZiBnZXRTdGF0dXNNYXAobWFwPXt9KQogICAgICAgICAk cmVtb3RlSG9zdHMuZWFjaF93aXRoX2luZGV4IHsKICAgICAgICAgICAgIHwgaG9zdCwgcmVtb3Rl SW5kZXggfAogICAgICAgICAgICAgcnVubmVyRGlyID0gIiN7aG9zdC5yZW1vdGVEaXJlY3Rvcnl9 LyN7JG91dHB1dERpci5iYXNlbmFtZX0vLnJ1bm5lciIKLSAgICAgICAgICAgIG91dHB1dCA9IHNz aFJlYWQoImlmIHRlc3QgLWQgI3tydW5uZXJEaXJ9OyB0aGVuIGNkICN7cnVubmVyRGlyfTsgZWxz ZSBmYWxzZTsgZmkgJiYgIiArIGZpbmRfY21kLCBob3N0LCA6aWdub3JlRmFpbHVyZSA9PiB0cnVl KQorICAgICAgICAgICAgb3V0cHV0ID0gc3NoUmVhZCgiaWYgdGVzdCAtZCAje3J1bm5lckRpcn07 IHRoZW4gY2QgI3tydW5uZXJEaXJ9OyBlbHNlIGZhbHNlOyBmaSAmJiAiICsgcnVieV9jbWQsIGhv c3QsIDppZ25vcmVGYWlsdXJlID0+IHRydWUpCiAgICAgICAgICAgICBvdXRwdXQuc3BsaXQoL1xu LykuZWFjaCB7CiAgICAgICAgICAgICAgICAgfCBsaW5lIHwKICAgICAgICAgICAgICAgICBwcm9j ZXNzU3RhdHVzTGluZShtYXAsIGxpbmUpCkBAIC0yMzQ5LDEwICsyMzQ5LDEyIEBAIGRlZiBnZXRT dGF0dXNNYXAobWFwPXt9KQogICAgICAgICB9CiAgICAgZWxzZQogICAgICAgICBEaXIuY2hkaXIo JHJ1bm5lckRpcikgewotICAgICAgICAgICAgSU8ucG9wZW4oZmluZF9jbWQpLmVhY2hfbGluZSB7 Ci0gICAgICAgICAgICAgICAgfCBsaW5lIHwKLSAgICAgICAgICAgICAgICBwcm9jZXNzU3RhdHVz TGluZShtYXAsIGxpbmUpCi0gICAgICAgICAgICB9CisgICAgICAgICAgICBEaXIuZ2xvYigiI3tT VEFUVVNfRklMRV9QUkVGSVh9KiIpLmVhY2ggZG8gfG5hbWV8CisgICAgICAgICAgICAgICAgaWYg RmlsZS5zaXplKG5hbWUpID4gMAorICAgICAgICAgICAgICAgICAgICBsaW5lID0gRmlsZS5vcGVu KG5hbWUpLmZpcnN0CisgICAgICAgICAgICAgICAgICAgIHByb2Nlc3NTdGF0dXNMaW5lKG1hcCwg Ii4vI3tuYW1lfSAje2xpbmV9IikKKyAgICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIGVu ZAogICAgICAgICB9CiAgICAgZW5kCiAgICAgbWFwCg== 440399 2021-10-06 11:48:58 -0700 2021-10-07 14:29:48 -0700 Patch version using find on remote and ruby local 231101.4.diff text/plain 1546 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmY0 MjYyM2I4NWIuLmE4NmM0NTJhM2FmNCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTAxICBTdGVwaGFuIFN6 YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBv cnQgcnVuLWpzYy1zdHJlc3MtdGVzdHMgd2l0aG91dCBwb3NpeCBjb21tYW5kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMTAxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIGNv bGxlY3RpbmcgdGhlIHRlc3QgcmVzdWx0IGZpbGVzIHdoZW4gbm90IG9uCisgICAgICAgIGEgcG9z aXggaG9zdCBwbGF0Zm9ybSBieSByb3VnaGx5IGVtdWxhdGluZyB0aGUgZmluZCBjb21tYW5kCisg ICAgICAgIGN1cnJlbnQgdXNlZCBpbiBydWJ5IGNvZGUgd2hlbiB1c2luZyB0aGUgcnVieS1ydW5u ZXIgb3IKKyAgICAgICAgZm9yIHBsYXlzdGF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0czoKKwogMjAyMS0wOS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBQeXRob24gMyBmYWlscyB0byBydW4gcnVuLWJ1 aWx0aW5zLWdlbmVyYXRvci10ZXN0cyA6IE1vZHVsZU5vdEZvdW5kRXJyb3I6IE5vIG1vZHVsZSBu YW1lZCAnYnVpbHRpbnNfbW9kZWwnCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBl MDgxNmRjMDU2MWIuLjRiYmJhMmM1M2M1ZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4t anNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3Rz CkBAIC0yMzQ5LDEwICsyMzQ5LDEyIEBAIGRlZiBnZXRTdGF0dXNNYXAobWFwPXt9KQogICAgICAg ICB9CiAgICAgZWxzZQogICAgICAgICBEaXIuY2hkaXIoJHJ1bm5lckRpcikgewotICAgICAgICAg ICAgSU8ucG9wZW4oZmluZF9jbWQpLmVhY2hfbGluZSB7Ci0gICAgICAgICAgICAgICAgfCBsaW5l IHwKLSAgICAgICAgICAgICAgICBwcm9jZXNzU3RhdHVzTGluZShtYXAsIGxpbmUpCi0gICAgICAg ICAgICB9CisgICAgICAgICAgICBEaXIuZ2xvYigiI3tTVEFUVVNfRklMRV9QUkVGSVh9KiIpLmVh Y2ggZG8gfG5hbWV8CisgICAgICAgICAgICAgICAgaWYgRmlsZS5zaXplKG5hbWUpID4gMAorICAg ICAgICAgICAgICAgICAgICBsaW5lID0gRmlsZS5vcGVuKG5hbWUpLmZpcnN0CisgICAgICAgICAg ICAgICAgICAgIHByb2Nlc3NTdGF0dXNMaW5lKG1hcCwgIi4vI3tuYW1lfSAje2xpbmV9IikKKyAg ICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIGVuZAogICAgICAgICB9CiAgICAgZW5kCiAg ICAgbWFwCg==