231091 2021-10-01 11:27:02 -0700 [JSC][32bit] Remove a bunch of compiler warnings 2021-10-06 02:36:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned clopez ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer xan.lopez oldest_to_newest 1799420 0 xan.lopez 2021-10-01 11:27:02 -0700 + cmake --build /home/igalia/xlopez/WebKit/WebKitBuild/Debug --config Debug -- jsc testb3 testair testapi testmasm testdfg -j32 [658/1694] Building C object Source/ThirdParty/capstone/CMakeFiles/capstone.dir/Source/cs.c.o ../../Source/ThirdParty/capstone/Source/cs.c: In function 'cs_disasm': ../../Source/ThirdParty/capstone/Source/cs.c:1015:26: warning: cast increases required alignment of target type [-Wcast-align] 1015 | insn_cache = (cs_insn *)((char *)total + sizeof(cs_insn) * c); | ^ [864/1694] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f0a787a9-3.cpp.o In file included from JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f0a787a9-3.cpp:6: ../../Source/JavaScriptCore/bytecode/CodeBlock.cpp: In member function 'bool JSC::CodeBlock::isConstantOwnedByUnlinkedCodeBlock(JSC::VirtualRegister) const': ../../Source/JavaScriptCore/bytecode/CodeBlock.cpp:953:1: warning: control reaches end of non-void function [-Wreturn-type] 953 | } | ^ [867/1694] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-11.cpp.o In file included from JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-11.cpp:4: ../../Source/JavaScriptCore/dfg/DFGOSRExit.cpp: In static member function 'static void JSC::DFG::OSRExit::compileExit(JSC::CCallHelpers&, JSC::VM&, const JSC::DFG::OSRExit&, const JSC::Operands<JSC::ValueRecovery>&, JSC::DFG::SpeculationRecovery*)': ../../Source/JavaScriptCore/dfg/DFGOSRExit.cpp:566:12: warning: variable 'firstTmpToRestoreEarly' set but not used [-Wunused-but-set-variable] 566 | size_t firstTmpToRestoreEarly = operands.size() - operands.numberOfTmps(); | ^~~~~~~~~~~~~~~~~~~~~~ [924/1694] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-3a3c4ec0-5.cpp.o In file included from JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-3a3c4ec0-5.cpp:7: ../../Source/JavaScriptCore/jit/JITOpcodes32_64.cpp: In member function 'void JSC::JIT::emit_op_enter(const JSC::Instruction*)': ../../Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1096:81: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare] 1096 | for (int i = CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters(); i < m_profiledCodeBlock->numVars(); ++i) | ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [971/1694] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT.cpp.o ../../Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::speculateNumber(JSC::DFG::Edge)': ../../Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:11272:37: warning: comparison between types 'JSC::JSValue::<unnamed enum>' and 'JSC::JSValue::<unnamed enum>' [-Wsign-compare] 11272 | static_assert(JSValue::Int32Tag >= JSValue::LowestTag, "Int32Tag is included in >= JSValue::LowestTag range."); | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::speculateMisc(JSC::DFG::Edge, JSC::JSValueRegs)': ../../Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:11919:37: warning: comparison between types 'JSC::JSValue::<unnamed enum>' and 'JSC::JSValue::<unnamed enum>' [-Wsign-compare] 11919 | static_assert(JSValue::Int32Tag >= JSValue::UndefinedTag, "Int32Tag is included in >= JSValue::UndefinedTag range."); | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ [1694/1694] Linking CXX executable bin/testmasm The one about Int32Tag is not trivial, so I'll let it be. Patch incoming for the rest. 1799425 1 439883 xan.lopez 2021-10-01 11:30:18 -0700 Created attachment 439883 v1 1800995 2 440346 xan.lopez 2021-10-06 01:35:59 -0700 Created attachment 440346 v2 patch to land. 1801003 3 ews-feeder 2021-10-06 02:35:25 -0700 Committed r283608 (242560@main): <https://commits.webkit.org/242560@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440346. 1801004 4 webkit-bug-importer 2021-10-06 02:36:17 -0700 <rdar://problem/83924827> 439883 2021-10-01 11:30:18 -0700 2021-10-06 01:35:59 -0700 v1 0001-JSC-32bit-Remove-a-bunch-of-compiler-warnings.patch text/plain 4407 xan.lopez RnJvbSBjYTdjYjdkYjAyOWFiN2NhYzljMzNiMGFlYzM4MGQwZTIxNjUxOWE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogRnJpLCAxIE9jdCAyMDIxIDIwOjI0OjIyICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ11bMzJiaXRdIFJlbW92ZSBhIGJ1bmNoIG9mIGNvbXBpbGVyIHdhcm5pbmdzCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMDkxCgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKEpTQzo6Q29kZUJs b2NrOjppc0NvbnN0YW50T3duZWRCeVVubGlua2VkQ29kZUJsb2NrIGNvbnN0KTogbWFrZQp0aGUg ZnVuY3Rpb24gcmV0dXJuIGEgZGVmYXVsdCB2YWx1ZS4gQWxzbyBhc3NlcnQgaW4gdGhlIGRlZmF1 bHQKY2FzZSBmb3IgdGhlIHN3aXRjaCwgc2luY2UgaXQgY292ZXJzIGFsbCB0aGUgcG9zc2liaWxp dGVzIChhcyBvZgpub3cpLgoqIGRmZy9ERkdPU1JFeGl0LmNwcDoKKEpTQzo6REZHOjpPU1JFeGl0 Ojpjb21waWxlRXhpdCk6IHNpbGVuY2Ugd2FybmluZyBhYm91dCB1bnVzZWQKdmFyaWFibGUsIGl0 J3Mgbm90IHVzZWQgaW4gMzItYml0LgoqIGppdC9KSVRPcGNvZGVzMzJfNjQuY3BwOgooSlNDOjpK SVQ6OmVtaXRfb3BfZW50ZXIpOiB1c2UgYW4gdW5zaWduZWQgaW50IGZvciB0aGUgbG9vcCBjb3Vu dC4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAx OCArKysrKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwICB8ICA0ICsrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhp dC5jcHAgICAgICB8ICAxICsKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMy XzY0LmNwcCB8ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAwYzU2M2MyZmVlMmQuLjA4Mjk3 NTkzZWY1OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEt MTAtMDEgIFhhbiBMw7NwZXogIDx4YW5AaWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXVszMmJp dF0gUmVtb3ZlIGEgYnVuY2ggb2YgY29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTA5MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoK KyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjppc0NvbnN0YW50T3duZWRCeVVubGlua2VkQ29kZUJs b2NrIGNvbnN0KTogbWFrZQorICAgICAgICB0aGUgZnVuY3Rpb24gcmV0dXJuIGEgZGVmYXVsdCB2 YWx1ZS4gQWxzbyBhc3NlcnQgaW4gdGhlIGRlZmF1bHQKKyAgICAgICAgY2FzZSBmb3IgdGhlIHN3 aXRjaCwgc2luY2UgaXQgY292ZXJzIGFsbCB0aGUgcG9zc2liaWxpdGVzIChhcyBvZgorICAgICAg ICBub3cpLgorICAgICAgICAqIGRmZy9ERkdPU1JFeGl0LmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpPU1JFeGl0Ojpjb21waWxlRXhpdCk6IHNpbGVuY2Ugd2FybmluZyBhYm91dCB1bnVzZWQKKyAg ICAgICAgdmFyaWFibGUsIGl0J3Mgbm90IHVzZWQgaW4gMzItYml0LgorICAgICAgICAqIGppdC9K SVRPcGNvZGVzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfZW50ZXIpOiB1 c2UgYW4gdW5zaWduZWQgaW50IGZvciB0aGUgbG9vcCBjb3VudC4KKwogMjAyMS0xMC0wMSAgT2xp dmllciBCbGluICA8b2xpdmllci5ibGluQHNvZnRhdGhvbWUuY29tPgogCiAgICAgICAgIFtKU0Nd W0dMaWJdIEZpeCB0eXBvIGluIFdyYXBwZXJNYXAgY3JlYXRpb24gbWV0aG9kcwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAppbmRleCBmZjFiZGNkNzA0NDcu LmFmYjMyNTlkNjBlOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0NvZGVCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVC bG9jay5jcHAKQEAgLTk0OSw3ICs5NDksMTEgQEAgYm9vbCBDb2RlQmxvY2s6OmlzQ29uc3RhbnRP d25lZEJ5VW5saW5rZWRDb2RlQmxvY2soVmlydHVhbFJlZ2lzdGVyIHJlZykgY29uc3QKICAgICB9 CiAgICAgY2FzZSBTb3VyY2VDb2RlUmVwcmVzZW50YXRpb246OkxpbmtUaW1lQ29uc3RhbnQ6CiAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKICAgICB9CisKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIFZlY3Rvcjx1bnNpZ25l ZD4gQ29kZUJsb2NrOjpzZXRDb25zdGFudFJlZ2lzdGVycyhjb25zdCBGaXhlZFZlY3RvcjxXcml0 ZUJhcnJpZXI8VW5rbm93bj4+JiBjb25zdGFudHMsIGNvbnN0IEZpeGVkVmVjdG9yPFNvdXJjZUNv ZGVSZXByZXNlbnRhdGlvbj4mIGNvbnN0YW50c1NvdXJjZUNvZGVSZXByZXNlbnRhdGlvbikKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDExMWQyM2FhM2Y1OS4u NzEwMDAyNGRmMTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09T UkV4aXQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAK QEAgLTYwNiw2ICs2MDYsNyBAQCB2b2lkIE9TUkV4aXQ6OmNvbXBpbGVFeGl0KENDYWxsSGVscGVy cyYgaml0LCBWTSYgdm0sIGNvbnN0IE9TUkV4aXQmIGV4aXQsIGNvbnN0CiAgICAgICAgICAgICAg ICAgaml0LnN0b3JlNjQoR1BSSW5mbzo6cmVnVDAsIHNjcmF0Y2ggKyBpbmRleCk7CiAgICAgICAg ICAgICB9CiAjZWxzZSAvLyBub3QgVVNFKEpTVkFMVUU2NCkKKyAgICAgICAgICAgIFVOVVNFRF9W QVJJQUJMRShmaXJzdFRtcFRvUmVzdG9yZUVhcmx5KTsKICAgICAgICAgICAgIGppdC5zdG9yZTMy KAogICAgICAgICAgICAgICAgIEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKHJlY292ZXJ5 LmNvbnN0YW50KCkudGFnKCkpLAogICAgICAgICAgICAgICAgICZiaXR3aXNlX2Nhc3Q8RW5jb2Rl ZFZhbHVlRGVzY3JpcHRvcio+KHNjcmF0Y2ggKyBpbmRleCktPmFzQml0cy50YWcpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwCmluZGV4IGM0YzI4MDlk ODc2MS4uYTgxZDNkMTA0ZDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wY29kZXMzMl82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRP cGNvZGVzMzJfNjQuY3BwCkBAIC0xMDkzLDcgKzEwOTMsNyBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9l bnRlcihjb25zdCBJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIC8vIEV2ZW4g dGhvdWdoIEpJVCBjb2RlIGRvZXNuJ3QgdXNlIHRoZW0sIHdlIGluaXRpYWxpemUgb3VyIGNvbnN0 YW50CiAgICAgLy8gcmVnaXN0ZXJzIHRvIHphcCBzdGFsZSBwb2ludGVycywgdG8gYXZvaWQgdW5u ZWNlc3NhcmlseSBwcm9sb25naW5nCiAgICAgLy8gb2JqZWN0IGxpZmV0aW1lIGFuZCBpbmNyZWFz aW5nIEdDIHByZXNzdXJlLgotICAgIGZvciAoaW50IGkgPSBDb2RlQmxvY2s6OmxsaW50QmFzZWxp bmVDYWxsZWVTYXZlU3BhY2VBc1ZpcnR1YWxSZWdpc3RlcnMoKTsgaSA8IG1fcHJvZmlsZWRDb2Rl QmxvY2stPm51bVZhcnMoKTsgKytpKQorICAgIGZvciAodW5zaWduZWQgaSA9IENvZGVCbG9jazo6 bGxpbnRCYXNlbGluZUNhbGxlZVNhdmVTcGFjZUFzVmlydHVhbFJlZ2lzdGVycygpOyBpIDwgbV9w cm9maWxlZENvZGVCbG9jay0+bnVtVmFycygpOyArK2kpCiAgICAgICAgIGVtaXRTdG9yZSh2aXJ0 dWFsUmVnaXN0ZXJGb3JMb2NhbChpKSwganNVbmRlZmluZWQoKSk7CiAKICAgICBKSVRTbG93UGF0 aENhbGwgc2xvd1BhdGhDYWxsKHRoaXMsIGN1cnJlbnRJbnN0cnVjdGlvbiwgc2xvd19wYXRoX2Vu dGVyKTsKLS0gCjIuMzEuMQoK 440346 2021-10-06 01:35:59 -0700 2021-10-06 02:35:27 -0700 v2 0001-JSC-32bit-Remove-a-bunch-of-compiler-warnings.patch text/plain 3198 xan.lopez RnJvbSBiZmYwYzU2MGVmMmJhY2Y0OGJlOGNhOTBmMmQwODE0ODAyMzQ5MGZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogRnJpLCAxIE9jdCAyMDIxIDIwOjI0OjIyICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ11bMzJiaXRdIFJlbW92ZSBhIGJ1bmNoIG9mIGNvbXBpbGVyIHdhcm5pbmdzCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMDkxCgpSZXZpZXdlZCBi eSBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJlei4KCiogZGZnL0RGR09TUkV4aXQuY3BwOgooSlND OjpERkc6Ok9TUkV4aXQ6OmNvbXBpbGVFeGl0KTogc2lsZW5jZSB3YXJuaW5nIGFib3V0IHVudXNl ZAp2YXJpYWJsZSwgaXQncyBub3QgdXNlZCBpbiAzMi1iaXQuCiogaml0L0pJVE9wY29kZXMzMl82 NC5jcHA6CihKU0M6OkpJVDo6ZW1pdF9vcF9lbnRlcik6IHVzZSBhbiB1bnNpZ25lZCBpbnQgZm9y IHRoZSBsb29wIGNvdW50LgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAg ICAgICAgICAgICB8IDEzICsrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT1NSRXhpdC5jcHAgICAgICB8ICAxICsKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3Bjb2RlczMyXzY0LmNwcCB8ICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5ZjlkYmUxMmJm YzkuLjgzZTc3Yjg2NDAwZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMjEtMTAtMDEgIFhhbiBMw7NwZXogIDx4YW5AaWdhbGlhLmNvbT4KKworICAgICAgICBb SlNDXVszMmJpdF0gUmVtb3ZlIGEgYnVuY2ggb2YgY29tcGlsZXIgd2FybmluZ3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTA5MQorCisgICAgICAg IFJldmlld2VkIGJ5IENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6LgorCisgICAgICAgICogZGZn L0RGR09TUkV4aXQuY3BwOgorICAgICAgICAoSlNDOjpERkc6Ok9TUkV4aXQ6OmNvbXBpbGVFeGl0 KTogc2lsZW5jZSB3YXJuaW5nIGFib3V0IHVudXNlZAorICAgICAgICB2YXJpYWJsZSwgaXQncyBu b3QgdXNlZCBpbiAzMi1iaXQuCisgICAgICAgICogaml0L0pJVE9wY29kZXMzMl82NC5jcHA6Cisg ICAgICAgIChKU0M6OkpJVDo6ZW1pdF9vcF9lbnRlcik6IHVzZSBhbiB1bnNpZ25lZCBpbnQgZm9y IHRoZSBsb29wIGNvdW50LgorCiAyMDIxLTEwLTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBw bGUuY29tPgogCiAgICAgICAgIERvbid0IHBhc3MgRG9udEJ1aWxkU3RyaW5ncyB0byBuZXh0IHRv a2VuIGFmdGVyIHBhcnNpbmcgYW4gZW1wdHkgcGFyYW1ldGVyIGxpc3QKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCmluZGV4IDExMWQyM2FhM2Y1OS4uNzEwMDAyNGRmMTkz IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXQuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhpdC5jcHAKQEAgLTYwNiw2ICs2 MDYsNyBAQCB2b2lkIE9TUkV4aXQ6OmNvbXBpbGVFeGl0KENDYWxsSGVscGVycyYgaml0LCBWTSYg dm0sIGNvbnN0IE9TUkV4aXQmIGV4aXQsIGNvbnN0CiAgICAgICAgICAgICAgICAgaml0LnN0b3Jl NjQoR1BSSW5mbzo6cmVnVDAsIHNjcmF0Y2ggKyBpbmRleCk7CiAgICAgICAgICAgICB9CiAjZWxz ZSAvLyBub3QgVVNFKEpTVkFMVUU2NCkKKyAgICAgICAgICAgIFVOVVNFRF9WQVJJQUJMRShmaXJz dFRtcFRvUmVzdG9yZUVhcmx5KTsKICAgICAgICAgICAgIGppdC5zdG9yZTMyKAogICAgICAgICAg ICAgICAgIEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKHJlY292ZXJ5LmNvbnN0YW50KCku dGFnKCkpLAogICAgICAgICAgICAgICAgICZiaXR3aXNlX2Nhc3Q8RW5jb2RlZFZhbHVlRGVzY3Jp cHRvcio+KHNjcmF0Y2ggKyBpbmRleCktPmFzQml0cy50YWcpOwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwCmluZGV4IGY0NWNlMGY2NjY1Ny4uMTQyMGQx OTc2YTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMz Ml82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQu Y3BwCkBAIC0xMDgzLDcgKzEwODMsNyBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9lbnRlcihjb25zdCBJ bnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIC8vIEV2ZW4gdGhvdWdoIEpJVCBj b2RlIGRvZXNuJ3QgdXNlIHRoZW0sIHdlIGluaXRpYWxpemUgb3VyIGNvbnN0YW50CiAgICAgLy8g cmVnaXN0ZXJzIHRvIHphcCBzdGFsZSBwb2ludGVycywgdG8gYXZvaWQgdW5uZWNlc3NhcmlseSBw cm9sb25naW5nCiAgICAgLy8gb2JqZWN0IGxpZmV0aW1lIGFuZCBpbmNyZWFzaW5nIEdDIHByZXNz dXJlLgotICAgIGZvciAoaW50IGkgPSBDb2RlQmxvY2s6OmxsaW50QmFzZWxpbmVDYWxsZWVTYXZl U3BhY2VBc1ZpcnR1YWxSZWdpc3RlcnMoKTsgaSA8IG1fcHJvZmlsZWRDb2RlQmxvY2stPm51bVZh cnMoKTsgKytpKQorICAgIGZvciAodW5zaWduZWQgaSA9IENvZGVCbG9jazo6bGxpbnRCYXNlbGlu ZUNhbGxlZVNhdmVTcGFjZUFzVmlydHVhbFJlZ2lzdGVycygpOyBpIDwgbV9wcm9maWxlZENvZGVC bG9jay0+bnVtVmFycygpOyArK2kpCiAgICAgICAgIGVtaXRTdG9yZSh2aXJ0dWFsUmVnaXN0ZXJG b3JMb2NhbChpKSwganNVbmRlZmluZWQoKSk7CiAKICAgICBKSVRTbG93UGF0aENhbGwgc2xvd1Bh dGhDYWxsKHRoaXMsIGN1cnJlbnRJbnN0cnVjdGlvbiwgc2xvd19wYXRoX2VudGVyKTsKLS0gCjIu MzIuMAoK