231046 2021-09-30 16:30:09 -0700 [iOS] Add message filter in the WebContent process' sandbox 2021-10-11 01:14:47 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham gavin.p mazander webkit-bug-importer oldest_to_newest 1799076 0 pvollan 2021-09-30 16:30:09 -0700 Add IOKit message filter in the WebContent process' sandbox on iOS. 1799077 1 webkit-bug-importer 2021-09-30 16:32:31 -0700 <rdar://problem/83743661> 1799082 2 439793 pvollan 2021-09-30 16:35:13 -0700 Created attachment 439793 Patch 1799343 3 439793 bfulgham 2021-10-01 09:27:59 -0700 Comment on attachment 439793 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439793&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:106 > + (allow (with telemetry) iokit-external-method Do we need telemetry on those two method numbers? Or should the telemetry be for any remaining denials? 1799544 4 pvollan 2021-10-01 14:17:35 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 439793 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=439793&action=review > > r=me > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:106 > > + (allow (with telemetry) iokit-external-method > > Do we need telemetry on those two method numbers? Or should the telemetry be > for any remaining denials? I think this rule will give us telemetry for both. Or am I mistaken? Thanks for reviewing! 1802529 5 440760 pvollan 2021-10-11 00:19:50 -0700 Created attachment 440760 Patch 1802536 6 ews-feeder 2021-10-11 01:14:46 -0700 Committed r283886 (242763@main): <https://commits.webkit.org/242763@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440760. 439793 2021-09-30 16:35:13 -0700 2021-10-11 00:19:45 -0700 Patch bug-231046-20210930163509.patch text/plain 1630 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODMzNDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA5LTMwICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFkZCBtZXNzYWdlIGZpbHRlciBp biB0aGUgV2ViQ29udGVudCBwcm9jZXNzJyBzYW5kYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEwNDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzgzNzQzNjYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBJT0tpdCBtZXNzYWdlIGZpbHRlciBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzJyBz YW5kYm94IG9uIGlPUy4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9z L2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbjoKKwogMjAyMS0wOS0zMCAgQ2hyaXN0 b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5jb20+CiAKICAgICAgICAgRml4ICFFTkFCTEUo V0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKSBidWlsZCBhZnRlciByMjgzMzE5CkluZGV4OiBTb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu V2ViQ29udGVudC5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbgkocmV2 aXNpb24gMjgzMTk2KQorKysgU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IuaW4JKHdvcmtpbmcgY29weSkKQEAg LTEwMSw5ICsxMDEsMTQgQEAKICAgICAgICAgICAgIChhcHBseS1tZXNzYWdlLWZpbHRlcgogICAg ICAgICAgICAgICAgIChkZW55ICh3aXRoIHRlbGVtZXRyeSkKICAgICAgICAgICAgICAgICAgICAg aW9raXQtYXN5bmMtZXh0ZXJuYWwtbWV0aG9kCisgICAgICAgICAgICAgICAgICAgIGlva2l0LWV4 dGVybmFsLW1ldGhvZAogICAgICAgICAgICAgICAgICAgICBpb2tpdC1leHRlcm5hbC10cmFwKQot ICAgICAgICAgICAgICAgIChhbGxvdyAod2l0aCB0ZWxlbWV0cnkpCi0gICAgICAgICAgICAgICAg ICAgIGlva2l0LWV4dGVybmFsLW1ldGhvZCkKKyAgICAgICAgICAgICAgICAoYWxsb3cgKHdpdGgg dGVsZW1ldHJ5KSBpb2tpdC1leHRlcm5hbC1tZXRob2QKKyAgICAgICAgICAgICAgICAgICAgKGlv a2l0LW1ldGhvZC1udW1iZXIKKyAgICAgICAgICAgICAgICAgICAgICAgIDgKKyAgICAgICAgICAg ICAgICAgICAgICAgIDI4CisgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICAgICAp CiAgICAgICAgICAgICApCiAgICAgICAgICkKICAgICApCg== 440760 2021-10-11 00:19:50 -0700 2021-10-11 01:14:46 -0700 Patch bug-231046-20211011091948.patch text/plain 1619 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODMzNzQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTEwLTExICBQZXIgQXJuZSBW b2xsYW4gPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFkZCBtZXNzYWdlIGZp bHRlciBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzJyBzYW5kYm94CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEwNDYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzgzNzQzNjYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisK KyAgICAgICAgQWRkIElPS2l0IG1lc3NhZ2UgZmlsdGVyIGluIHRoZSBXZWJDb250ZW50IHByb2Nl c3MnIHNhbmRib3ggb24gaU9TLgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiLmluOgorCiAyMDIxLTEwLTAxICBQ ZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTZW5kIExhdW5j aCBTZXJ2aWNlcyBkYXRhYmFzZSB0byBHUFUgcHJvY2VzcwpJbmRleDogU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IuaW4JKHJldmlzaW9uIDI4MzM3 NCkKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5XZWJDb250ZW50LnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsOSArMTAx LDE0IEBACiAgICAgICAgICAgICAoYXBwbHktbWVzc2FnZS1maWx0ZXIKICAgICAgICAgICAgICAg ICAoZGVueSAod2l0aCB0ZWxlbWV0cnkpCiAgICAgICAgICAgICAgICAgICAgIGlva2l0LWFzeW5j LWV4dGVybmFsLW1ldGhvZAorICAgICAgICAgICAgICAgICAgICBpb2tpdC1leHRlcm5hbC1tZXRo b2QKICAgICAgICAgICAgICAgICAgICAgaW9raXQtZXh0ZXJuYWwtdHJhcCkKLSAgICAgICAgICAg ICAgICAoYWxsb3cgKHdpdGggdGVsZW1ldHJ5KQotICAgICAgICAgICAgICAgICAgICBpb2tpdC1l eHRlcm5hbC1tZXRob2QpCisgICAgICAgICAgICAgICAgKGFsbG93ICh3aXRoIHRlbGVtZXRyeSkg aW9raXQtZXh0ZXJuYWwtbWV0aG9kCisgICAgICAgICAgICAgICAgICAgIChpb2tpdC1tZXRob2Qt bnVtYmVyCisgICAgICAgICAgICAgICAgICAgICAgICA4CisgICAgICAgICAgICAgICAgICAgICAg ICAyOAorICAgICAgICAgICAgICAgICAgICApCisgICAgICAgICAgICAgICAgKQogICAgICAgICAg ICAgKQogICAgICAgICApCiAgICAgKQo=