231042 2021-09-30 15:57:16 -0700 Upgrade GCC requirement to 8.3.0 2021-09-30 17:27:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki annulen darin ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ryuan.choi saam sergio tzagallo webkit-bug-importer oldest_to_newest 1799060 0 ysuzuki 2021-09-30 15:57:16 -0700 Upgrade GCC requirement to 8.3.0 1799062 1 439788 ysuzuki 2021-09-30 15:58:51 -0700 Created attachment 439788 Patch 1799097 2 439788 darin 2021-09-30 17:03:21 -0700 Comment on attachment 439788 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439788&action=review > Source/JavaScriptCore/runtime/ConfigFile.cpp:492 > #if COMPILER(GCC) > -#if GCC_VERSION_AT_LEAST(8, 0, 0) > IGNORE_WARNINGS_BEGIN("stringop-truncation") > -#endif > #endif IGNORE_GCC_WARNINGS_BEGIN > Source/JavaScriptCore/runtime/ConfigFile.cpp:496 > #if COMPILER(GCC) > -#if GCC_VERSION_AT_LEAST(8, 0, 0) > IGNORE_WARNINGS_END > -#endif > #endif IGNORE_GCC_WARNINGS_END > ChangeLog:9 > + Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian stable (buster) right now. > + This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields. Default initializers for bitfields! 1799099 3 439788 ysuzuki 2021-09-30 17:23:13 -0700 Comment on attachment 439788 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439788&action=review Thanks! >> Source/JavaScriptCore/runtime/ConfigFile.cpp:492 >> #endif > > IGNORE_GCC_WARNINGS_BEGIN That's nice! Changed. >> Source/JavaScriptCore/runtime/ConfigFile.cpp:496 >> #endif > > IGNORE_GCC_WARNINGS_END Ditto. 1799100 4 ysuzuki 2021-09-30 17:23:44 -0700 This only affects on GCC builders, and gtk / wpe are green. Landing. 1799102 5 ysuzuki 2021-09-30 17:26:37 -0700 Committed r283348 (242361@main): <https://commits.webkit.org/242361@main> 1799104 6 webkit-bug-importer 2021-09-30 17:27:17 -0700 <rdar://problem/83745622> 439788 2021-09-30 15:58:51 -0700 2021-09-30 17:03:21 -0700 Patch bug-231042-20210930155850.patch text/plain 3282 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NzY3ODM5NzRkYTYwYWI5NGIzM2M3OGY2YWIyOTU3YmJmM2VjMTQ5Li45ODEzNGQwY2I5YzY3MDdk NTdkNjY3ZTc1Y2QxMzdjOGZiODAwN2VjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMS0wOS0zMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFVwZ3JhZGUgR0NDIHJlcXVpcmVtZW50IHRvIDguMy4wCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEwNDIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvQ29uZmlnRmls ZS5jcHA6CisgICAgICAgIChKU0M6OkNvbmZpZ0ZpbGU6OmNhbm9uaWNhbGl6ZVBhdGhzKToKKwog MjAyMS0wOS0zMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBU aGUgREZHL0ZUTCBuZWVkIHRvIGJlIGF3YXJlIHRoYXQgUHJveHkncyBjYW4gcHJvZHVjZSAiZnVu Y3Rpb24iIGZvciB0eXBlb2YgYW5kIG1pZ2h0IGJlIGNhbGxhYmxlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db25maWdGaWxlLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3BwCmluZGV4IGNkZjFhNjgyZDQxMmQ3ZjJkNDg1 NTM1YTY2ZDI2ZTc4NjI2Y2IyMmEuLmM1ZWRmZDJjYWE0MTk4MmViM2FlZTJjNzJlNTUyMjBiMmJk MzY2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbmZpZ0Zp bGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbmZpZ0ZpbGUuY3Bw CkBAIC00ODgsMTUgKzQ4OCwxMSBAQCB2b2lkIENvbmZpZ0ZpbGU6OmNhbm9uaWNhbGl6ZVBhdGhz KCkKICAgICAgICAgICAgICAgICBpZiAoc2hvdWxkQWRkUGF0aFNlcGFyYXRvcikKICAgICAgICAg ICAgICAgICAgICAgc3RybmNhdChmaWxlbmFtZUJ1ZmZlciwgIi8iLCAyKTsgLy8gUm9vbSBmb3Ig Jy8nIHBsdXMgTlVMCiAjaWYgQ09NUElMRVIoR0NDKQotI2lmIEdDQ19WRVJTSU9OX0FUX0xFQVNU KDgsIDAsIDApCiAgICAgICAgICAgICAgICAgSUdOT1JFX1dBUk5JTkdTX0JFR0lOKCJzdHJpbmdv cC10cnVuY2F0aW9uIikKLSNlbmRpZgogI2VuZGlmCiAgICAgICAgICAgICAgICAgc3RybmNhdChm aWxlbmFtZUJ1ZmZlciwgbV9maWxlbmFtZSwgc2l6ZW9mKGZpbGVuYW1lQnVmZmVyKSAtIHN0cmxl bihmaWxlbmFtZUJ1ZmZlcikgLSAxKTsKICNpZiBDT01QSUxFUihHQ0MpCi0jaWYgR0NDX1ZFUlNJ T05fQVRfTEVBU1QoOCwgMCwgMCkKICAgICAgICAgICAgICAgICBJR05PUkVfV0FSTklOR1NfRU5E Ci0jZW5kaWYKICNlbmRpZgogICAgICAgICAgICAgICAgIHN0cm5jcHkobV9maWxlbmFtZSwgZmls ZW5hbWVCdWZmZXIsIHNfbWF4UGF0aExlbmd0aCk7CiAgICAgICAgICAgICAgICAgbV9maWxlbmFt ZVtzX21heFBhdGhMZW5ndGhdID0gJ1wwJzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJL aXRDb21tb24uY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0Q29tbW9uLmNtYWtlCmluZGV4IGVj MjgxYWY2MWIwY2QzZWNjZGQxZWIxMjk4ZTJiYTc2YWM5ZjQxYjkuLjIzZDAxNTQ5OWZlZjc4Zjll MmQ0NmRmZTY0ZTdiYWEyNWQzYmJmN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJLaXRD b21tb24uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQpAQCAtNjMs OCArNjMsOCBAQCBpZiAoTk9UIEhBU19SVU5fV0VCS0lUX0NPTU1PTikKICAgICBlbmRpZiAoKQog CiAgICAgaWYgKCR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lEfSBTVFJFUVVBTCAiR05VIikKLSAgICAg ICAgaWYgKCR7Q01BS0VfQ1hYX0NPTVBJTEVSX1ZFUlNJT059IFZFUlNJT05fTEVTUyAiNy4zLjAi KQotICAgICAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiR0NDIDcuMyBvciBuZXdlciBpcyBy ZXF1aXJlZCB0byBidWlsZCBXZWJLaXQuIFVzZSBhIG5ld2VyIEdDQyB2ZXJzaW9uIG9yIENsYW5n LiIpCisgICAgICAgIGlmICgke0NNQUtFX0NYWF9DT01QSUxFUl9WRVJTSU9OfSBWRVJTSU9OX0xF U1MgIjguMy4wIikKKyAgICAgICAgICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIkdDQyA4LjMgb3Ig bmV3ZXIgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0LiBVc2UgYSBuZXdlciBHQ0MgdmVyc2lv biBvciBDbGFuZy4iKQogICAgICAgICBlbmRpZiAoKQogICAgIGVuZGlmICgpCiAKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyOWEyMmNiYWQxZTRkNDhiODcyZWU2OGQw NmE4YTNmZWNiYzM4ZDNkLi45ZmNiZmVhZmNhYzA4NGE2NTI2ODQ4MGM2ODIxNTU3NWJiYzkyMDNl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMjEtMDktMzAgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAg ICBVcGdyYWRlIEdDQyByZXF1aXJlbWVudCB0byA4LjMuMAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMxMDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFzZWQgb24gdGhlIHJvYWRtYXBbMV0sIHdlIHVw Z3JhZGUgR0NDIHJlcXVpcmVtZW50IHRvIDguMy4wLCB3aGljaCBpcyBkZWZhdWx0IEdDQyBpbiBE ZWJpYW4gc3RhYmxlIChidXN0ZXIpIHJpZ2h0IG5vdy4KKyAgICAgICAgVGhpcyBwYXZlcyB0aGUg d2F5IHRvIGVuYWJsaW5nIHNvbWUgb2YgdXNlZnVsIEMrKzIwIGZlYXR1cmVzLCBlLmcuIGRlZmF1 bHQgaW5pdGlhbGl6ZXIgZm9yIGJpdGZpZWxkcy4KKworICAgICAgICBbMV06IGh0dHBzOi8vdHJh Yy53ZWJraXQub3JnL3dpa2kvV2ViS2l0R1RLL0dDQ1JlcXVpcmVtZW50CisKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvV2ViS2l0Q29tbW9uLmNtYWtlOgorCiAyMDIxLTA5LTI5ICBLaW1tbyBLaW5u dW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gY2FudmFz LmNhcHR1cmVTdHJlYW0oKSBmYWlscyBmb3IgV2ViR0wK