231038 2021-09-30 14:14:05 -0700 Web Inspector: Audit: testForLinkLabels Accessibility audit should ignore anchors if aria-hidden 2021-10-28 09:28:13 -0700 1 1 1 Unclassified WebKit Web Inspector Safari 15 All All RESOLVED FIXED InRadar P2 Normal --- 1 bugmenot rcaliman bburg cfleizach ews-watchlist hi inspector-bugzilla-changes kevin_neal pangle rcaliman webkit-bug-importer oldest_to_newest 1799024 0 bugmenot 2021-09-30 14:14:05 -0700 Currently, the Accessibility audit "testForLinkLabels" applies to anchors even if aria-hidden="true". This makes little sense, since a aria-label has no effect if the element is aria-hidden. Steps to Reproduce 1. Create an HTML file with an anchor that has the aria-hidden attribute set to "true", e.g. <a aria-hidden="true" tabindex="-1" href="#">foobar</a> 2. Run the Audit Expected Result testForLinkLabels passes. Actual Result testForLinkLabels fails. 1799566 1 kevin_neal 2021-10-01 15:00:01 -0700 Thank you for filing. The appropriate engineers have been notified. 1799567 2 webkit-bug-importer 2021-10-01 15:00:14 -0700 <rdar://problem/83783868> 1808831 3 442483 rcaliman 2021-10-26 06:25:17 -0700 Created attachment 442483 Patch v1.0 1808832 4 rcaliman 2021-10-26 06:29:03 -0700 If the link has text content, it will be used as the label. A better test case is to skip the text completely: ``` <a aria-hidden="true" tabindex="-1" href="#"></a> ``` 1808864 5 442483 pangle 2021-10-26 08:33:05 -0700 Comment on attachment 442483 Patch v1.0 Can we add a test case to `LayoutTests/inspector/audit/run-accessibility.html`? 1809696 6 pangle 2021-10-28 09:15:27 -0700 (In reply to Patrick Angle from comment #5) > Comment on attachment 442483 [details] > Patch v1.0 > > Can we add a test case to > `LayoutTests/inspector/audit/run-accessibility.html`? Discussed with Razvan offline; I was incorrect - these tests test the special WebInspectorAudit.Accessibility functions, not the audits themselves. 1809700 7 442483 bburg 2021-10-28 09:24:31 -0700 Comment on attachment 442483 Patch v1.0 rs=me 1809703 8 ews-feeder 2021-10-28 09:28:10 -0700 Committed r284986 (243633@main): <https://commits.webkit.org/243633@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442483. 442483 2021-10-26 06:25:17 -0700 2021-10-28 09:28:11 -0700 Patch v1.0 bug-231038-20211026152516.patch text/plain 1973 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRmZmZlMDEzMGM0NzExZTExNmU5MDU3ZTA4OWVj YmEzZjMzMDFkMTQuLmNmOGY4N2Q5OTVhZjM0ZGJhYTA4MzAxMTgwMGFhOTYzNzAxYzA3ZmQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTEwLTI2ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBdWRpdDogdGVzdEZvckxpbmtMYWJlbHMgQWNjZXNzaWJpbGl0eSBhdWRpdCBzaG91bGQgaWdu b3JlIGFuY2hvcnMgaWYgYXJpYS1oaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzMTAzOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODM3ODM4 Njg+CisKKyAgICAgICAgVXBkYXRlIGB0ZXN0Rm9yTGlua0xhYmVsc2AgYWNjZXNzaWJpbGl0eSBh dWRpdCB0ZXN0IHRvIGV4Y2x1ZGUgaGlkZGVuIGxpbmtzLgorICAgICAgICBTZWUgYEFjY2Vzc2li aWxpdHlPYmplY3QtPmlzSGlkZGVuKClgCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL05vbk1pbmlmaWVkL0RlZmF1bHRBdWRp dHMuanM6CisgICAgICAgIChXSS5EZWZhdWx0QXVkaXRzLnRlc3RGb3JMaW5rTGFiZWxzKToKKwog MjAyMS0xMC0yMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAg W2Nzcy12YWx1ZXMtNF0gU3VwcG9ydCBzbWFsbCAoc3YqKSwgbGFyZ2UgKGx2KikgYW5kIGR5bmFt aWMgKGR2Kikgdmlld3BvcnQgdW5pdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL05vbk1pbmlmaWVkL0RlZmF1bHRBdWRpdHMuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Ob25NaW5pZmllZC9EZWZhdWx0QXVkaXRzLmpzCmlu ZGV4IGEyZTU0ODU0MDc1NjI0MjI4NDNhNjU4NmZmNzEzZDc4ZjJkY2JkYTEuLmEwYTFkNWFkM2M3 YmE3OThiNWFlMDI4OTA0YTQ5NmE2Y2ZhYTY3OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL05vbk1pbmlmaWVkL0RlZmF1bHRBdWRpdHMuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTm9uTWluaWZpZWQvRGVmYXVsdEF1 ZGl0cy5qcwpAQCAtMjM4LDcgKzIzOCwxMCBAQCBXSS5EZWZhdWx0QXVkaXRzLnRlc3RGb3JNdWx0 aXBsZUJhbm5lcnMgPSBmdW5jdGlvbigpIHsKIAogV0kuRGVmYXVsdEF1ZGl0cy50ZXN0Rm9yTGlu a0xhYmVscyA9IGZ1bmN0aW9uKCkgewogICAgIGxldCBsaW5rcyA9IFdlYkluc3BlY3RvckF1ZGl0 LkFjY2Vzc2liaWxpdHkuZ2V0RWxlbWVudHNCeUNvbXB1dGVkUm9sZSgibGluayIpOwotICAgIGxl dCBkb21Ob2RlcyA9IGxpbmtzLmZpbHRlcigobGluaykgPT4gIVdlYkluc3BlY3RvckF1ZGl0LkFj Y2Vzc2liaWxpdHkuZ2V0Q29tcHV0ZWRQcm9wZXJ0aWVzKGxpbmspLmxhYmVsKTsKKyAgICBsZXQg ZG9tTm9kZXMgPSBsaW5rcy5maWx0ZXIoKGxpbmspID0+IHsKKyAgICAgICAgbGV0IHByb3BlcnRp ZXMgPSBXZWJJbnNwZWN0b3JBdWRpdC5BY2Nlc3NpYmlsaXR5LmdldENvbXB1dGVkUHJvcGVydGll cyhsaW5rKTsKKyAgICAgICAgcmV0dXJuICFwcm9wZXJ0aWVzLmxhYmVsICYmICFwcm9wZXJ0aWVz LmhpZGRlbjsKKyAgICB9KTsKICAgICByZXR1cm4ge2xldmVsOiBkb21Ob2Rlcy5sZW5ndGggPyAi ZmFpbCIgOiAicGFzcyIsIGRvbU5vZGVzLCBkb21BdHRyaWJ1dGVzOiBbImFyaWEtbGFiZWwiLCAi YXJpYS1sYWJlbGxlZGJ5IiwgInRpdGxlIl19OwogfTsKIAo=