231017 2021-09-30 03:34:44 -0700 [MSE][GStreamer] Allow infinite duration on MSE 2021-09-30 05:48:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha aboya calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez webkit-bug-importer oldest_to_newest 1798824 0 eocanha 2021-09-30 03:34:44 -0700 Positive infinite duration isn't properly working on MSE in the glib (GStreamer) ports. When such a duration is set, nothing happens and the default zero duration remains. This can break some live streams. My test case was a live stream in a player based on dash.js 4.0.0. The duration is set to infinity (but remains as zero due to the bug) and an initial seek to the current (huge) position is done. The wrong duration has influence in the real seek target time used[1], so the seek may end up being done to the wrong time (before the buffered ranges in my case) and the playback never starts. [1] https://github.com/WebKit/WebKit/blob/a12c487/Source/WebCore/html/HTMLMediaElement.cpp#L3153 1798825 1 439721 eocanha 2021-09-30 03:44:48 -0700 Created attachment 439721 Patch 1798827 2 439721 calvaris 2021-09-30 03:52:42 -0700 Comment on attachment 439721 Patch LGTM, but let's wait for Alicia. 1798844 3 ews-feeder 2021-09-30 05:47:36 -0700 Committed r283309 (242334@main): <https://commits.webkit.org/242334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439721. 1798845 4 webkit-bug-importer 2021-09-30 05:48:16 -0700 <rdar://problem/83715383> 439721 2021-09-30 03:44:48 -0700 2021-09-30 05:47:38 -0700 Patch bug-231017-20210930124447.patch text/plain 5969 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyMjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJmMzhjYWQyN2QxMGYx MjYwODBiOWNkYjk0ZjVhMjE1YTAzYjY0NS4uZDI5YzBjNjcwNTE4MGFiYmIyMjQ0N2NlYzZhMDk0 MDRjNzU0NjNjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA5LTMwICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW01T RV1bR1N0cmVhbWVyXSBBbGxvdyBpbmZpbml0ZSBkdXJhdGlvbiBvbiBNU0UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMTAxNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBvc2l0aXZlIGluZmluaXRlIGR1 cmF0aW9uIGlzbid0IHByb3Blcmx5IHdvcmtpbmcgb24gTVNFIGluIHRoZSBnbGliIChHU3RyZWFt ZXIpIHBvcnRzLiBXaGVuCisgICAgICAgIHN1Y2ggYSBkdXJhdGlvbiBpcyBzZXQsIG5vdGhpbmcg aGFwcGVucyBhbmQgdGhlIGRlZmF1bHQgemVybyBkdXJhdGlvbiByZW1haW5zLiBUaGlzIGNhbiBi cmVhaworICAgICAgICBzb21lIGxpdmUgc3RyZWFtcywgYmVjYXVzZSB0aGUgd3JvbmcgZHVyYXRp b24gaGFzIGluZmx1ZW5jZSBpbiB0aGUgcmVhbCBzZWVrIHRhcmdldCB0aW1lCisgICAgICAgIHVz ZWRbMV0sIHNvIHRoZSBzZWVrIG1heSBlbmQgdXAgYmVpbmcgZG9uZSB0byB0aGUgd3JvbmcgdGlt ZSAoYmVmb3JlIHRoZSBidWZmZXJlZCByYW5nZXMgaW4KKyAgICAgICAgbXkgY2FzZSkgYW5kIHRo ZSBwbGF5YmFjayBuZXZlciBzdGFydHMuCisKKyAgICAgICAgWzFdIGh0dHBzOi8vZ2l0aHViLmNv bS9XZWJLaXQvV2ViS2l0L2Jsb2IvYTEyYzQ4Ny9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwI0wzMTUzCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VQ cml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU291cmNlUHJpdmF0 ZUdTdHJlYW1lcjo6ZHVyYXRpb25DaGFuZ2VkKTogRG9uJ3QgZGlzY2FyZCB0aGUgY2hhbmdlIG9u IGluZmluaXRlIGR1cmF0aW9uLgorCiAyMDIxLTA5LTA5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5kZXJJbmxpbmUgb2Zmc2V0VG9wL0xlZnQgc2hvdWxk IG5vdCBzd2l0Y2ggdG8gbGVnYWN5IGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNvdXJjZVByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9N ZWRpYVNvdXJjZVByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDdkMGU4OWQ0N2NjMzkyMTg4N2Yx YTk1NWZjYjEyYjdlMmYzYjcwMTguLmEzYTEzY2JlNGU1ODllY2U2MGVkMzUxMzRmYjUwMDRjZjA4 YTYxMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9tc2UvTWVkaWFTb3VyY2VQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhU291cmNlUHJpdmF0ZUdT dHJlYW1lci5jcHAKQEAgLTEwNiw3ICsxMDYsNyBAQCB2b2lkIE1lZGlhU291cmNlUHJpdmF0ZUdT dHJlYW1lcjo6ZHVyYXRpb25DaGFuZ2VkKGNvbnN0IE1lZGlhVGltZSYpCiAKICAgICBNZWRpYVRp bWUgZHVyYXRpb24gPSBtX21lZGlhU291cmNlLT5kdXJhdGlvbigpOwogICAgIEdTVF9UUkFDRSgi ZHVyYXRpb246ICVmIiwgZHVyYXRpb24udG9GbG9hdCgpKTsKLSAgICBpZiAoIWR1cmF0aW9uLmlz VmFsaWQoKSB8fCBkdXJhdGlvbi5pc1Bvc2l0aXZlSW5maW5pdGUoKSB8fCBkdXJhdGlvbi5pc05l Z2F0aXZlSW5maW5pdGUoKSkKKyAgICBpZiAoIWR1cmF0aW9uLmlzVmFsaWQoKSB8fCBkdXJhdGlv bi5pc05lZ2F0aXZlSW5maW5pdGUoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9wbGF5ZXJQ cml2YXRlLmR1cmF0aW9uQ2hhbmdlZCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU0YzJmYjc1ZDE3NWUxN2U5NzE4OGM0 ZjQzY2YzNGNkNDc3OTNjZTAuLjkxMmNjY2FkMTNlYzM3ODVjMjI4MmNmNDNiYjEyNjk2ZGFhYjBk MGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0wOS0zMCAgRW5yaXF1ZSBPY2HDsWEgR29u esOhbGV6ICA8ZW9jYW5oYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtNU0VdW0dTdHJlYW1lcl0g QWxsb3cgaW5maW5pdGUgZHVyYXRpb24gb24gTVNFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEwMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9uczog bWVkaWFzb3VyY2Utc2Vla2FibGUuaHRtbCBub3cgcGFzc2VzLgorICAgICAgICAqIHBsYXRmb3Jt L2dsaWIvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvbWVkaWFz b3VyY2UtY2hhbmdldHlwZS1wbGF5LWltcGxpY2l0LWV4cGVjdGVkLnR4dDogQ2hhbmdlZCBleHBl Y3RhdGlvbnMgYmVjYXVzZSB0aGlzIHRlc3Qgbm93IHBhc3NlcyBmb3IgYXVkaW8vbXBlZyA8LT4g YXVkaW8vbXBlZy4KKwogMjAyMS0wOS0wOSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5j b20+CiAKICAgICAgICAgUmVuZGVySW5saW5lIG9mZnNldFRvcC9MZWZ0IHNob3VsZCBub3Qgc3dp dGNoIHRvIGxlZ2FjeSBsYXlvdXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2ds aWIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVj dGF0aW9ucwppbmRleCA1MmJiMTg3NWQ1NjhlZGM0NjU4ODZlZjA3ZjQ5ODYzZTkzNTU2ZWRmLi4y Njk3YjQ2YzQzMjY4NWQyODg5MTNiYWZiMWU5MWM5YjJjODQ0NTE1IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCkBAIC0yMjMxLDcgKzIyMzEsNiBAQCB3ZWJr aXQub3JnL2IvMjExOTQwIGZhc3QvdGV4dC9tdWx0aXBsZS1jb2RldW5pdC12ZXJ0aWNhbC11cHJp Z2h0LTIuaHRtbCBbIEltYWdlTwogd2Via2l0Lm9yZy9iLzIxMTk0MCBmYXN0L3RleHQvbXVsdGlw bGUtY29kZXVuaXQtdmVydGljYWwtdXByaWdodC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAK IHdlYmtpdC5vcmcvYi8xNjcxMDggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRp YS1zb3VyY2UvbWVkaWFzb3VyY2Utc2VxdWVuY2Vtb2RlLWFwcGVuZC1idWZmZXIuaHRtbCBbIEZh aWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2NzEwOCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL21lZGlhLXNvdXJjZS9tZWRpYXNvdXJjZS1zZWVrYWJsZS5odG1sIFsgRmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTk3NzExIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWVkaWEt c291cmNlL21lZGlhc291cmNlLWNvcnJlY3QtZnJhbWVzLmh0bWwgWyBQYXNzIFRpbWVvdXQgRmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMjE0MzQ5IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvbWVkaWEtc291cmNlL21lZGlhc291cmNlLWNoYW5nZXR5cGUtcGxheS1uZWdhdGl2ZS5odG1s IFsgQ3Jhc2ggRmFpbHVyZSBQYXNzIF0KIHdlYmtpdC5vcmcvYi8yMDMwNzggaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvbWVkaWFzb3VyY2Utc2Vlay1iZXlvbmQt ZHVyYXRpb24uaHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ2xpYi9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNvdXJjZS9tZWRp YXNvdXJjZS1jaGFuZ2V0eXBlLXBsYXktaW1wbGljaXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ2xpYi9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNv dXJjZS9tZWRpYXNvdXJjZS1jaGFuZ2V0eXBlLXBsYXktaW1wbGljaXQtZXhwZWN0ZWQudHh0Cmlu ZGV4IDA0ZTMyZTllYmNmYWQ1MGRmYWM0N2Q5OWIzYzIwYmM4ZmYyY2E4NzYuLjJiMzViNTk5ZDIx MTk0ZTQzNDRlMmE2OGI4NDQzMTgzYjUzMWE3YmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2dsaWIvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2Uv bWVkaWFzb3VyY2UtY2hhbmdldHlwZS1wbGF5LWltcGxpY2l0LWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv bWVkaWEtc291cmNlL21lZGlhc291cmNlLWNoYW5nZXR5cGUtcGxheS1pbXBsaWNpdC1leHBlY3Rl ZC50eHQKQEAgLTQsNyArNCw3IEBAIFBBU1MgVGVzdCBhdWRpby1vbmx5IGltcGxpY2l0IGNoYW5n ZVR5cGUgZm9yIGF1ZGlvL3dlYm07IGNvZGVjcz0idm9yYmlzIiA8LT4gYXVkCiBQQVNTIFRlc3Qg YXVkaW8tb25seSBpbXBsaWNpdCBjaGFuZ2VUeXBlIGZvciBhdWRpby93ZWJtOyBjb2RlY3M9InZv cmJpcyIgPC0+IGF1ZGlvL3dlYm07IGNvZGVjcz0idm9yYmlzIiAodXNpbmcgdHlwZXMgd2l0aG91 dCBjb2RlY3MgcGFyYW1ldGVycyBmb3IgYWRkU291cmNlQnVmZmVyKQogUEFTUyBUZXN0IGF1ZGlv LW9ubHkgaW1wbGljaXQgY2hhbmdlVHlwZSBmb3IgYXVkaW8vbXA0OyBjb2RlY3M9Im1wNGEuNDAu MiIgPC0+IGF1ZGlvL21wNDsgY29kZWNzPSJtcDRhLjQwLjIiCiBQQVNTIFRlc3QgYXVkaW8tb25s eSBpbXBsaWNpdCBjaGFuZ2VUeXBlIGZvciBhdWRpby9tcDQ7IGNvZGVjcz0ibXA0YS40MC4yIiA8 LT4gYXVkaW8vbXA0OyBjb2RlY3M9Im1wNGEuNDAuMiIgKHVzaW5nIHR5cGVzIHdpdGhvdXQgY29k ZWNzIHBhcmFtZXRlcnMgZm9yIGFkZFNvdXJjZUJ1ZmZlcikKLUZBSUwgVGVzdCBhdWRpby1vbmx5 IGltcGxpY2l0IGNoYW5nZVR5cGUgZm9yIGF1ZGlvL21wZWcgPC0+IGF1ZGlvL21wZWcgYXNzZXJ0 X2xlc3NfdGhhbjogZXhwZWN0ZWQgYSBudW1iZXIgbGVzcyB0aGFuIDAgYnV0IGdvdCAyLjEKK1BB U1MgVGVzdCBhdWRpby1vbmx5IGltcGxpY2l0IGNoYW5nZVR5cGUgZm9yIGF1ZGlvL21wZWcgPC0+ IGF1ZGlvL21wZWcKIFBBU1MgVGVzdCB2aWRlby1vbmx5IGltcGxpY2l0IGNoYW5nZVR5cGUgZm9y IHZpZGVvL3dlYm07IGNvZGVjcz0idnA4IiA8LT4gdmlkZW8vd2VibTsgY29kZWNzPSJ2cDgiCiBQ QVNTIFRlc3QgdmlkZW8tb25seSBpbXBsaWNpdCBjaGFuZ2VUeXBlIGZvciB2aWRlby93ZWJtOyBj b2RlY3M9InZwOCIgPC0+IHZpZGVvL3dlYm07IGNvZGVjcz0idnA4IiAodXNpbmcgdHlwZXMgd2l0 aG91dCBjb2RlY3MgcGFyYW1ldGVycyBmb3IgYWRkU291cmNlQnVmZmVyKQogRkFJTCBUZXN0IHZp ZGVvLW9ubHkgaW1wbGljaXQgY2hhbmdlVHlwZSBmb3IgdmlkZW8vd2VibTsgY29kZWNzPSJ2cDgi IDwtPiB2aWRlby93ZWJtOyBjb2RlY3M9InZwOSIgYXNzZXJ0X3VucmVhY2hlZDogVW5leHBlY3Rl ZCBldmVudCAnZXJyb3InIFJlYWNoZWQgdW5yZWFjaGFibGUgY29kZQo=