231000 2021-09-29 17:18:45 -0700 Add weakThis check in addition to null check added in r282881 2022-02-12 20:22:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ajuma beidson cdumez webkit-bug-importer oldest_to_newest 1798693 0 achristensen 2021-09-29 17:18:45 -0700 Remove log added in r282881 1798701 1 439685 achristensen 2021-09-29 17:27:37 -0700 Created attachment 439685 Patch 1798704 2 439686 achristensen 2021-09-29 17:32:35 -0700 Created attachment 439686 Patch 1798706 3 439686 cdumez 2021-09-29 17:34:37 -0700 Comment on attachment 439686 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439686&action=review > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:353 > LOADER_RELEASE_LOG("startNetworkLoad: Going to the network (description=%" PUBLIC_LOG_STRING ")", m_networkLoad->description().utf8().data()); What does m_networkLoad->description() return? Hopefully it doesn't contain anything sensitive like URL? Also, why can't we move this LOG line *before* calling start()? 1798709 4 439686 beidson 2021-09-29 17:49:55 -0700 Comment on attachment 439686 Patch This patch isn't about verifying the string returns the right thing. Putting the log line before start() makes it categorically false, as start() may not actually *start* 1798720 5 cdumez 2021-09-29 18:37:30 -0700 (In reply to Brady Eidson from comment #4) > Comment on attachment 439686 [details] > Patch > > This patch isn't about verifying the string returns the right thing. And yet still a good thing to verify and you didn't answer. > Putting the log line before start() makes it categorically false, as start() > may not actually *start* I feel like a safer fix would have been to update the actual code that introduced the regression and have NetworkLoad::start() call didCompleteWithError: asynchronously when it fails due to FTP. There are other clients to NetworkLoad than NetworkResourceLoader and having start() call that may fail synchronously and delete |this| might be an issue for other call sites as well. 1798722 6 cdumez 2021-09-29 18:41:37 -0700 (In reply to Chris Dumez from comment #5) > (In reply to Brady Eidson from comment #4) > > Comment on attachment 439686 [details] > > Patch > > > > This patch isn't about verifying the string returns the right thing. > > And yet still a good thing to verify and you didn't answer. 0x105d74000 - [pageProxyID=21, webPageID=22, frameID=3, resourceID=32, isMainResource=1, destination=3, isSynchronous=0] NetworkResourceLoader::startNetworkLoad: Going to the network (description=LocalDataTask <25187A1B-3324-4E2C-982A-AB468520286C>.<1>) Now I have my answer. 1798727 7 ews-feeder 2021-09-29 19:01:44 -0700 Committed r283294 (242319@main): <https://commits.webkit.org/242319@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439686. 1798728 8 webkit-bug-importer 2021-09-29 19:02:16 -0700 <rdar://problem/83699294> 1840856 9 bfulgham 2022-02-12 20:22:16 -0800 *** Bug 230767 has been marked as a duplicate of this bug. *** 439685 2021-09-29 17:27:37 -0700 2021-09-29 17:32:33 -0700 Patch bug-231000-20210929172736.patch text/plain 2165 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFlZDcxNmYxMjM5ZDJlZTgz OWRmODY5YjE5NjI5NTVlNDhjMjRhNWIuLjEwYjIyMzc1N2M4NjY4YzQ5MTYwMmQ4YTFiODZkYjBl ZjY1N2JmYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDktMjkgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgbG9n IGFkZGVkIGluIHIyODI4ODEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzMTAwMAorICAgICAgICA8cmRhcjovLzgzNjA1NjE0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyODI4ODEgbWFkZSBOZXR3b3Jr TG9hZDo6c3RhcnQgY2FsbCBkaWRDb21wbGV0ZVdpdGhFcnJvciwgd2hpY2ggY2FuIGNhdXNlIHRo ZQorICAgICAgICBOZXR3b3JrUmVzb3VyY2VMb2FkZXIgdG8gYmUgZGVsZXRlZC4gIEl0IGFkZGVk IGEgbnVsbCBjaGVjayBvbiBtX25ldHdvcmtMb2FkIHdoaWNoCisgICAgICAgIHNvbWV0aW1lcyBy ZWFkcyBmcmVlZCBtZW1vcnkuICBUaGlzIGNlcnRhaW5seSBpc24ndCBncmVhdCwgYnV0IGx1Y2tp bHkgd2UgaGF2ZSBhIHdheQorICAgICAgICB0byBjaGVjayBpZiB0aGlzIG9iamVjdCBoYXMgYmVl biBkZWxldGVkLiAgTGV0J3MgZG8gdGhhdC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05l dHdvcmtSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJj ZUxvYWRlcjo6c3RhcnROZXR3b3JrTG9hZCk6CisKIDIwMjEtMDktMjkgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZWR1Y2UgYWxsb2NhdGlv bnMgaW4gRGF0YWJhc2VVdGlsaXRpZXM6OnNvcnRlZFRhYmxlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDQ3 NmQwZmU0YWEyMDgwNzBjNmYxM2M2ZDRkYzk1NTZiNDkyYzExMTQuLjEzZWE5MzBhODdjZWJiZDA0 NzJkZTlmYzE5NGEzM2YwMmQ2NzE4NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTM0MywxMiArMzQzLDEz IEBAIHZvaWQgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzdGFydE5ldHdvcmtMb2FkKFJlc291cmNl UmVxdWVzdCYmIHJlcXVlc3QsIEZpcnN0TG9hCiAgICAgcGFyYW1ldGVycy5pc05hdmlnYXRpbmdU b0FwcEJvdW5kRG9tYWluID0gbV9wYXJhbWV0ZXJzLmlzTmF2aWdhdGluZ1RvQXBwQm91bmREb21h aW47CiAgICAgbV9uZXR3b3JrTG9hZCA9IG1ha2VVbmlxdWU8TmV0d29ya0xvYWQ+KCp0aGlzLCAm bmV0d29ya1Nlc3Npb24tPmJsb2JSZWdpc3RyeSgpLCBXVEZNb3ZlKHBhcmFtZXRlcnMpLCAqbmV0 d29ya1Nlc3Npb24pOwogICAgIAorICAgIGF1dG8gd2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhp cyk7CiAgICAgaWYgKGlzU3luY2hyb25vdXMoKSkKLSAgICAgICAgbV9uZXR3b3JrTG9hZC0+c3Rh cnQoKTsKKyAgICAgICAgbV9uZXR3b3JrTG9hZC0+c3RhcnQoKTsgLy8gTWF5IGRlbGV0ZSB0aGlz IG9iamVjdAogICAgIGVsc2UKICAgICAgICAgbV9uZXR3b3JrTG9hZC0+c3RhcnRXaXRoU2NoZWR1 bGluZygpOwogCi0gICAgaWYgKG1fbmV0d29ya0xvYWQpCisgICAgaWYgKHdlYWtUaGlzICYmIG1f bmV0d29ya0xvYWQpCiAgICAgICAgIExPQURFUl9SRUxFQVNFX0xPRygic3RhcnROZXR3b3JrTG9h ZDogR29pbmcgdG8gdGhlIG5ldHdvcmsgKGRlc2NyaXB0aW9uPSUiIFBVQkxJQ19MT0dfU1RSSU5H ICIpIiwgbV9uZXR3b3JrTG9hZC0+ZGVzY3JpcHRpb24oKS51dGY4KCkuZGF0YSgpKTsKIH0KIAo= 439686 2021-09-29 17:32:35 -0700 2021-09-29 19:01:45 -0700 Patch bug-231000-20210929173234.patch text/plain 2199 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFlZDcxNmYxMjM5ZDJlZTgz OWRmODY5YjE5NjI5NTVlNDhjMjRhNWIuLjE5ODU4ZmU4ZGM0NTVhOWZjOWVmOTg5OTRmZGU3NjMx ZWJhMTA5OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDktMjkgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgd2Vha1Ro aXMgY2hlY2sgaW4gYWRkaXRpb24gdG8gbnVsbCBjaGVjayBhZGRlZCBpbiByMjgyODgxCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzEwMDAKKyAgICAg ICAgPHJkYXI6Ly84MzYwNTYxND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICByMjgyODgxIG1hZGUgTmV0d29ya0xvYWQ6OnN0YXJ0IGNhbGwgZGlkQ29t cGxldGVXaXRoRXJyb3IsIHdoaWNoIGNhbiBjYXVzZSB0aGUKKyAgICAgICAgTmV0d29ya1Jlc291 cmNlTG9hZGVyIHRvIGJlIGRlbGV0ZWQuICBJdCBhZGRlZCBhIG51bGwgY2hlY2sgb24gbV9uZXR3 b3JrTG9hZCB3aGljaAorICAgICAgICBzb21ldGltZXMgcmVhZHMgZnJlZWQgbWVtb3J5LiAgVGhp cyBjZXJ0YWlubHkgaXNuJ3QgZ3JlYXQsIGJ1dCBsdWNraWx5IHdlIGhhdmUgYSB3YXkKKyAgICAg ICAgdG8gY2hlY2sgaWYgdGhpcyBvYmplY3QgaGFzIGJlZW4gZGVsZXRlZC4gIExldCdzIGRvIHRo YXQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnN0YXJ0TmV0d29ya0xv YWQpOgorCiAyMDIxLTA5LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmVkdWNlIGFsbG9jYXRpb25zIGluIERhdGFiYXNlVXRpbGl0aWVz Ojpzb3J0ZWRUYWJsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv TmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCA0NzZkMGZlNGFhMjA4MDcwYzZmMTNjNmQ0 ZGM5NTU2YjQ5MmMxMTE0Li4xM2VhOTMwYTg3Y2ViYmQwNDcyZGU5ZmMxOTRhMzNmMDJkNjcxODcx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJj ZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVz b3VyY2VMb2FkZXIuY3BwCkBAIC0zNDMsMTIgKzM0MywxMyBAQCB2b2lkIE5ldHdvcmtSZXNvdXJj ZUxvYWRlcjo6c3RhcnROZXR3b3JrTG9hZChSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0LCBGaXJz dExvYQogICAgIHBhcmFtZXRlcnMuaXNOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbiA9IG1fcGFy YW1ldGVycy5pc05hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluOwogICAgIG1fbmV0d29ya0xvYWQg PSBtYWtlVW5pcXVlPE5ldHdvcmtMb2FkPigqdGhpcywgJm5ldHdvcmtTZXNzaW9uLT5ibG9iUmVn aXN0cnkoKSwgV1RGTW92ZShwYXJhbWV0ZXJzKSwgKm5ldHdvcmtTZXNzaW9uKTsKICAgICAKKyAg ICBhdXRvIHdlYWtUaGlzID0gbWFrZVdlYWtQdHIoKnRoaXMpOwogICAgIGlmIChpc1N5bmNocm9u b3VzKCkpCi0gICAgICAgIG1fbmV0d29ya0xvYWQtPnN0YXJ0KCk7CisgICAgICAgIG1fbmV0d29y a0xvYWQtPnN0YXJ0KCk7IC8vIE1heSBkZWxldGUgdGhpcyBvYmplY3QKICAgICBlbHNlCiAgICAg ICAgIG1fbmV0d29ya0xvYWQtPnN0YXJ0V2l0aFNjaGVkdWxpbmcoKTsKIAotICAgIGlmIChtX25l dHdvcmtMb2FkKQorICAgIGlmICh3ZWFrVGhpcyAmJiBtX25ldHdvcmtMb2FkKQogICAgICAgICBM T0FERVJfUkVMRUFTRV9MT0coInN0YXJ0TmV0d29ya0xvYWQ6IEdvaW5nIHRvIHRoZSBuZXR3b3Jr IChkZXNjcmlwdGlvbj0lIiBQVUJMSUNfTE9HX1NUUklORyAiKSIsIG1fbmV0d29ya0xvYWQtPmRl c2NyaXB0aW9uKCkudXRmOCgpLmRhdGEoKSk7CiB9CiAK