230995 2021-09-29 15:45:38 -0700 [webkitpy] LOG_CHANNEL is widely used in the codebase and shouldn't be treated as error 2021-09-29 16:54:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 230725 1 basuke basuke basuke darin ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1798633 0 basuke 2021-09-29 15:45:38 -0700 This is the error. > python3 Tools/Scripts/check-webkit-style > in dir /Volumes/Data/worker/Style-EWS/build (timeout 1200 secs) > watching logfiles {} > argv: [b'python3', b'Tools/Scripts/check-webkit-style'] > using PTY: False > ERROR: Source/WTF/wtf/Assertions.h:203: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] > ERROR: Source/WTF/wtf/Assertions.h:609: More than one command on the same line [whitespace/newline] [4] > Total errors found: 2 in 3 files > program finished with exit code 1 > elapsedTime=6.630763 1798635 1 439673 basuke 2021-09-29 15:51:46 -0700 Created attachment 439673 PATCH 1798675 2 ews-feeder 2021-09-29 16:53:39 -0700 Committed r283282 (242309@main): <https://commits.webkit.org/242309@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439673. 1798678 3 webkit-bug-importer 2021-09-29 16:54:23 -0700 <rdar://problem/83695013> 439673 2021-09-29 15:51:46 -0700 2021-09-29 16:53:41 -0700 PATCH patch.diff text/plain 1583 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMzQ0 MTkzZmEwMGEuLmY0ZTZmNWI5NTkzNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA5LTI5ICBCYXN1a2UgU3V6 dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNvbT4KKworICAgICAgICBbd2Via2l0cHldIExPR19D SEFOTkVMIGlzIHdpZGVseSB1c2VkIGluIHRoZSBjb2RlYmFzZSBhbmQgc2hvdWxkbid0IGJlIHRy ZWF0ZWQgYXMgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMDk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIExPR19DSEFOTkVMIGlzIHRoZSBtYWNybyB3aGljaCBpcyBkZWZpbmVkIGluIGVhY2gg ZnJhbWV3b3JrIHRvIGRlZmluZSBsaXN0IG9mIGFsbCBjaGFubmVscworICAgICAgICBpbiB0aGUg ZnJhbWV3b3JrLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHk6CisgICAgICAgIChjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24pOgor CiAyMDIxLTA5LTI4ICBCSiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2Nv YV0gQWRkIFNQSSB0byBzZWxlY3QgYSB0YWIgY3JlYXRlZCBieSBfV0tJbnNwZWN0b3JFeHRlbnNp b24KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXgg NTI4YmU4MjVjYmNiLi44ZjdhZDAyNDk1NzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC00MTA0LDYgKzQxMDQsNyBAQCBkZWYgY2hlY2tfaWRl bnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKGZpbGVuYW1lLCBsaW5lX251bWJlciwgbGluZSwg ZmlsZV9zdGF0ZQogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9 PSAiY29uc3RfaXRlcmF0b3IiCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVu dGlmaWVyID09ICJ2bV90aHJvdyIKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lk ZW50aWZpZXIgPT0gIkRGR19PUEVSQVRJT04iCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2Rp ZmllZF9pZGVudGlmaWVyID09ICJMT0dfQ0hBTk5FTCIKICAgICAgICAgICAgICAgICBhbmQgbm90 IG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnY2hyb25vX2xpdGVyYWxzJykgPj0gMCk6CiAgICAg ICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9uYW1pbmcvdW5kZXJz Y29yZXMnLCA0LCBpZGVudGlmaWVyICsgIiBpcyBpbmNvcnJlY3RseSBuYW1lZC4gRG9uJ3QgdXNl IHVuZGVyc2NvcmVzIGluIHlvdXIgaWRlbnRpZmllciBuYW1lcy4iKQogDQo=