230989 2021-09-29 15:13:53 -0700 Add a default return value in convertToExceptionCode 2021-10-13 18:39:40 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231706 1 sihui_liu sihui_liu cdumez webkit-bug-importer wilander oldest_to_newest 1798598 0 sihui_liu 2021-09-29 15:13:53 -0700 ... 1798599 1 439667 sihui_liu 2021-09-29 15:15:26 -0700 Created attachment 439667 Patch 1798603 2 439667 cdumez 2021-09-29 15:16:57 -0700 Comment on attachment 439667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439667&action=review > Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:53 > return WebCore::ExceptionCode::UnknownError; I think we usually: break; instead of return here. > Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:56 > + ASSERT_NOT_REACHED(); And then not have ASSERT_NOT_REACHED() here. 1798605 3 439668 sihui_liu 2021-09-29 15:22:16 -0700 Created attachment 439668 Patch 1798669 4 ews-feeder 2021-09-29 16:32:02 -0700 Committed r283280 (242307@main): <https://commits.webkit.org/242307@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439668. 1798670 5 webkit-bug-importer 2021-09-29 16:33:52 -0700 <rdar://problem/83694342> 439667 2021-09-29 15:15:26 -0700 2021-09-29 15:22:13 -0700 Patch bug-230989-20210929151525.patch text/plain 1394 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0YjQ4ZmNkZWU1Y2E5YmZk YTU1YTEzNmRmYjBjZGM1ZDdmODllYmQuLjRjYWMzNzAwYzgwYmMyMTU1NmFjNzg1ZTM3YjU4MjQz MmFjMDgzNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDktMjkgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgZGVmYXVsdCByZXR1cm4g dmFsdWUgaW4gY29udmVydFRvRXhjZXB0aW9uQ29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwOTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gZml4IG5vbi1Db2NvYSBidWlsZC4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvRmlsZVN5c3RlbVN0b3JhZ2VFcnJvci5oOgorICAg ICAgICAoV2ViS2l0Ojpjb252ZXJ0VG9FeGNlcHRpb25Db2RlKToKKwogMjAyMS0wOS0yOSAgUGVy IEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgdGVsZW1ldHJ5IHRvIHRo ZSBOZXR3b3JraW5nIHByb2Nlc3Mgc2FuZGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL0ZpbGVTeXN0ZW1TdG9yYWdlRXJyb3IuaCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9GaWxlU3lzdGVtU3RvcmFnZUVycm9yLmgKaW5k ZXggZjdhYmQ0NDEwYzA3NWYxOTMwYzlmZjUyZDg0MWNiMDNhYjc1OTEzNi4uYjQwZmJhMmE5NTM0 MGMzNmI1YTM1NDYyNmE3MWJjMGZiZmZlMDFjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL0ZpbGVTeXN0ZW1TdG9yYWdlRXJyb3IuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvRmlsZVN5c3RlbVN0b3JhZ2VFcnJvci5o CkBAIC01Miw2ICs1Miw5IEBAIGlubGluZSBXZWJDb3JlOjpFeGNlcHRpb25Db2RlIGNvbnZlcnRU b0V4Y2VwdGlvbkNvZGUoRmlsZVN5c3RlbVN0b3JhZ2VFcnJvciBlcnJvCiAgICAgY2FzZSBGaWxl U3lzdGVtU3RvcmFnZUVycm9yOjpVbmtub3duOgogICAgICAgICByZXR1cm4gV2ViQ29yZTo6RXhj ZXB0aW9uQ29kZTo6VW5rbm93bkVycm9yOwogICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOworICAgIHJldHVybiBXZWJDb3JlOjpFeGNlcHRpb25Db2RlOjpVbmtub3duRXJyb3I7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 439668 2021-09-29 15:22:16 -0700 2021-09-29 16:32:03 -0700 Patch bug-230989-20210929152215.patch text/plain 1485 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ0YjQ4ZmNkZWU1Y2E5YmZk YTU1YTEzNmRmYjBjZGM1ZDdmODllYmQuLjRjYWMzNzAwYzgwYmMyMTU1NmFjNzg1ZTM3YjU4MjQz MmFjMDgzNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDktMjkgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgZGVmYXVsdCByZXR1cm4g dmFsdWUgaW4gY29udmVydFRvRXhjZXB0aW9uQ29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwOTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gZml4IG5vbi1Db2NvYSBidWlsZC4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvRmlsZVN5c3RlbVN0b3JhZ2VFcnJvci5oOgorICAg ICAgICAoV2ViS2l0Ojpjb252ZXJ0VG9FeGNlcHRpb25Db2RlKToKKwogMjAyMS0wOS0yOSAgUGVy IEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgdGVsZW1ldHJ5IHRvIHRo ZSBOZXR3b3JraW5nIHByb2Nlc3Mgc2FuZGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL0ZpbGVTeXN0ZW1TdG9yYWdlRXJyb3IuaCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc3RvcmFnZS9GaWxlU3lzdGVtU3RvcmFnZUVycm9yLmgKaW5k ZXggZjdhYmQ0NDEwYzA3NWYxOTMwYzlmZjUyZDg0MWNiMDNhYjc1OTEzNi4uNDQzYzk1MTRjZDkz MjkxM2RkZTM0YzI3ZjZiNWI1NzIwMWEwYTQxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9zdG9yYWdlL0ZpbGVTeXN0ZW1TdG9yYWdlRXJyb3IuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3N0b3JhZ2UvRmlsZVN5c3RlbVN0b3JhZ2VFcnJvci5o CkBAIC01MCw4ICs1MCwxMCBAQCBpbmxpbmUgV2ViQ29yZTo6RXhjZXB0aW9uQ29kZSBjb252ZXJ0 VG9FeGNlcHRpb25Db2RlKEZpbGVTeXN0ZW1TdG9yYWdlRXJyb3IgZXJybwogICAgIGNhc2UgRmls ZVN5c3RlbVN0b3JhZ2VFcnJvcjo6SW52YWxpZE5hbWU6CiAgICAgICAgIHJldHVybiBXZWJDb3Jl OjpFeGNlcHRpb25Db2RlOjpVbmtub3duRXJyb3I7CiAgICAgY2FzZSBGaWxlU3lzdGVtU3RvcmFn ZUVycm9yOjpVbmtub3duOgotICAgICAgICByZXR1cm4gV2ViQ29yZTo6RXhjZXB0aW9uQ29kZTo6 VW5rbm93bkVycm9yOworICAgICAgICBicmVhazsKICAgICB9CisKKyAgICByZXR1cm4gV2ViQ29y ZTo6RXhjZXB0aW9uQ29kZTo6VW5rbm93bkVycm9yOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQK