230963 2021-09-29 09:48:54 -0700 Suppress warnings for implicit copy assignment operator/copy constructor with clang 13 2021-09-29 17:22:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke darin ews-watchlist keith_miller mark.lam mmaxfield msaboff saam stephan.szabo tzagallo webkit-bug-importer oldest_to_newest 1798402 0 basuke 2021-09-29 09:48:54 -0700 Tons of warnings with clang 13 ../../Source/JavaScriptCore/bytecode/Operands.h:52:5: warning: definition of implicit copy assignment operator for 'Operand' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy] Operand(const Operand&) = default; ../../Source/WebCore/platform\LayoutUnit.h:88:17: warning: definition of implicit copy constructor for 'LayoutUnit' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy] LayoutUnit& operator=(const LayoutUnit& other) = default; 1798442 1 439625 basuke 2021-09-29 10:42:20 -0700 Created attachment 439625 PATCH 1798448 2 439625 mark.lam 2021-09-29 10:56:38 -0700 Comment on attachment 439625 PATCH r=me 1798652 3 basuke 2021-09-29 16:07:59 -0700 Thanks Mark! 1798696 4 ews-feeder 2021-09-29 17:21:27 -0700 Committed r283287 (242314@main): <https://commits.webkit.org/242314@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439625. 1798697 5 webkit-bug-importer 2021-09-29 17:22:25 -0700 <rdar://problem/83696087> 439625 2021-09-29 10:42:20 -0700 2021-09-29 17:21:28 -0700 PATCH patch.diff text/plain 5276 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM1MGM0OWExNTZjYy4uMGNhNTk1YTVmOWYwIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wOS0yOSAgQmFz dWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgU3VwcHJlc3Mg d2FybmluZ3MgZm9yIGltcGxpY2l0IGNvcHkgYXNzaWdubWVudCBvcGVyYXRvci9jb3B5IGNvbnN0 cnVjdG9yIHdpdGggY2xhbmcgMTMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGVkIGRlZmF1bHQgY29weSBjb25zdHJ1Y3RvciB0byBzdXBwcmVzcyB3 YXJuaW5nLgorCisgICAgICAgICogYnl0ZWNvZGUvT3BlcmFuZHMuaDoKKwogMjAyMS0wOS0yOCAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEb2VzR0NDaGVjayBk b2VzIG5vdCB1c2UgZW5vdWdoIGJpdHMgZm9yIG5vZGVJbmRleApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wZXJhbmRzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvT3BlcmFuZHMuaAppbmRleCA3ZjUwYWVmMjFhYWQuLmNlMjM5NTQ5ZjI4MSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wZXJhbmRzLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wZXJhbmRzLmgKQEAgLTY4LDYgKzY4 LDggQEAgcHVibGljOgogICAgIH0KICAgICBzdGF0aWMgT3BlcmFuZCB0bXAodWludDMyX3QgaW5k ZXgpIHsgcmV0dXJuIE9wZXJhbmQoT3BlcmFuZEtpbmQ6OlRtcCwgaW5kZXgpOyB9CiAKKyAgICBP cGVyYW5kJiBvcGVyYXRvcj0oY29uc3QgT3BlcmFuZCYpID0gZGVmYXVsdDsKKwogICAgIE9wZXJh bmRLaW5kIGtpbmQoKSBjb25zdCB7IHJldHVybiBtX2tpbmQ7IH0KICAgICBpbnQgdmFsdWUoKSBj b25zdCB7IHJldHVybiBtX29wZXJhbmQ7IH0KICAgICBWaXJ0dWFsUmVnaXN0ZXIgdmlydHVhbFJl Z2lzdGVyKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZDMzNDk2NDA1MWEuLmJiOWU0OGQwNDk0MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA5LTI5ICBCYXN1a2UgU3V6dWtpICA8 YmFzdWtlLnN1enVraUBzb255LmNvbT4KKworICAgICAgICBTdXBwcmVzcyB3YXJuaW5ncyBmb3Ig aW1wbGljaXQgY29weSBhc3NpZ25tZW50IG9wZXJhdG9yL2NvcHkgY29uc3RydWN0b3Igd2l0aCBj bGFuZyAxMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjMwOTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgIEFkZGVkIGRlZmF1bHQgY29weSBjb25zdHJ1Y3RvciAvIGNvcHkgYXNzaWdubWVudCBvcGVy YXRvciB0byBzdXBwcmVzcyB3YXJuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vTGF5b3V0VW5p dC5oOgorICAgICAgICAqIHBsYXRmb3JtL0xlbmd0aEJveC5oOgorICAgICAgICAqIHBsYXRmb3Jt L1JlY3RFZGdlcy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRTZWxlY3Rpb25B bGdvcml0aG0uaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVBhaW50aW5nT3B0 aW9ucy5oOgorCiAyMDIxLTA5LTI5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBs ZS5jb20+CiAKICAgICAgICAgRm9udCBwYWxldHRlIG5hbWVzIGhhdmUgdG8gc3RhcnQgd2l0aCB0 d28gaHlwaGVucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5p dC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCmluZGV4IDc3MDg4NDUz ZTUwYy4uMGM1MjQwYzQ5MTMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9M YXlvdXRVbml0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCkBA IC02NSw2ICs2NSw3IEBAIGNvbnN0IGludCBpbnRNaW5Gb3JMYXlvdXRVbml0ID0gSU5UX01JTiAv IGtGaXhlZFBvaW50RGVub21pbmF0b3I7CiBjbGFzcyBMYXlvdXRVbml0IHsKIHB1YmxpYzoKICAg ICBMYXlvdXRVbml0KCkgOiBtX3ZhbHVlKDApIHsgfQorICAgIExheW91dFVuaXQoY29uc3QgTGF5 b3V0VW5pdCYpID0gZGVmYXVsdDsKICAgICBMYXlvdXRVbml0KGludCB2YWx1ZSkgeyBzZXRWYWx1 ZSh2YWx1ZSk7IH0KICAgICBMYXlvdXRVbml0KHVuc2lnbmVkIHNob3J0IHZhbHVlKSB7IHNldFZh bHVlKHZhbHVlKTsgfQogICAgIExheW91dFVuaXQodW5zaWduZWQgdmFsdWUpIHsgc2V0VmFsdWUo dmFsdWUpOyB9CkBAIC04NSw3ICs4Niw3IEBAIHB1YmxpYzoKICAgICAgICAgbV92YWx1ZSA9IGNs YW1wVG9JbnRlZ2VyKHZhbHVlICoga0ZpeGVkUG9pbnREZW5vbWluYXRvcik7CiAgICAgfQogCi0g ICAgTGF5b3V0VW5pdCYgb3BlcmF0b3I9KGNvbnN0IExheW91dFVuaXQmIG90aGVyKSA9IGRlZmF1 bHQ7CisgICAgTGF5b3V0VW5pdCYgb3BlcmF0b3I9KGNvbnN0IExheW91dFVuaXQmKSA9IGRlZmF1 bHQ7CiAgICAgTGF5b3V0VW5pdCYgb3BlcmF0b3I9KGNvbnN0IGZsb2F0JiBvdGhlcikgeyByZXR1 cm4gKnRoaXMgPSBMYXlvdXRVbml0KG90aGVyKTsgfQogCiAgICAgc3RhdGljIExheW91dFVuaXQg ZnJvbUZsb2F0Q2VpbChmbG9hdCB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0xlbmd0aEJveC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoQm94LmgK aW5kZXggZmQwNTBmYjY1MzFiLi5jMDQ3YTg5OWVmMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0xlbmd0aEJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xl bmd0aEJveC5oCkBAIC01NSw2ICs1NSw3IEBAIHB1YmxpYzoKICAgICB9CiAKICAgICBMZW5ndGhC b3goY29uc3QgTGVuZ3RoQm94JikgPSBkZWZhdWx0OworICAgIExlbmd0aEJveCYgb3BlcmF0b3I9 KGNvbnN0IExlbmd0aEJveCYpID0gZGVmYXVsdDsKIAogICAgIGJvb2wgaXNaZXJvKCkgY29uc3QK ICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZWN0RWRnZXMuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlY3RFZGdlcy5oCmluZGV4IDJkM2I1ZjlhMDEzNC4u MGUxMjMwMTkzMzYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZWN0RWRn ZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZWN0RWRnZXMuaApAQCAtNDYsNiAr NDYsNyBAQCBwdWJsaWM6CiAgICAgUmVjdEVkZ2VzKCkgPSBkZWZhdWx0OwogCiAgICAgUmVjdEVk Z2VzKGNvbnN0IFJlY3RFZGdlcyYpID0gZGVmYXVsdDsKKyAgICBSZWN0RWRnZXMmIG9wZXJhdG9y PShjb25zdCBSZWN0RWRnZXMmKSA9IGRlZmF1bHQ7CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBV PgogICAgIFJlY3RFZGdlcyhVJiYgdG9wLCBVJiYgcmlnaHQsIFUmJiBib3R0b20sIFUmJiBsZWZ0 KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFNlbGVj dGlvbkFsZ29yaXRobS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFNl bGVjdGlvbkFsZ29yaXRobS5oCmluZGV4IDI2MDE0ZTkxZDUxNy4uNGQ1YjgwYTExMWMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250U2VsZWN0aW9uQWxn b3JpdGhtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFNlbGVj dGlvbkFsZ29yaXRobS5oCkBAIC00MjYsNiArNDI2LDggQEAgaW5saW5lIHZvaWQgYWRkKEhhc2hl ciYgaGFzaGVyLCBjb25zdCBGb250U2VsZWN0aW9uUmVxdWVzdCYgcmVxdWVzdCkKIHN0cnVjdCBG b250U2VsZWN0aW9uQ2FwYWJpbGl0aWVzIHsKICAgICB1c2luZyBSYW5nZSA9IEZvbnRTZWxlY3Rp b25SYW5nZTsKIAorICAgIEZvbnRTZWxlY3Rpb25DYXBhYmlsaXRpZXMoKSA9IGRlZmF1bHQ7Cisg ICAgRm9udFNlbGVjdGlvbkNhcGFiaWxpdGllcyhjb25zdCBGb250U2VsZWN0aW9uQ2FwYWJpbGl0 aWVzJikgPSBkZWZhdWx0OwogICAgIEZvbnRTZWxlY3Rpb25DYXBhYmlsaXRpZXMmIG9wZXJhdG9y PShjb25zdCBGb250U2VsZWN0aW9uQ2FwYWJpbGl0aWVzJikgPSBkZWZhdWx0OwogCiAgICAgY29u c3RleHByIHN0ZDo6dHVwbGU8UmFuZ2UsIFJhbmdlLCBSYW5nZT4gdGllZCgpIGNvbnN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVBhaW50aW5nT3B0 aW9ucy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VQYWludGluZ09w dGlvbnMuaAppbmRleCBhOWNjZTU2NDJjYjcuLmVlYjM4ZTg2ZWZiMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VQYWludGluZ09wdGlvbnMuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVBhaW50aW5nT3B0aW9ucy5o CkBAIC00Nyw2ICs0Nyw3IEBAIHN0cnVjdCBJbWFnZVBhaW50aW5nT3B0aW9ucyB7CiAKICAgICBJ bWFnZVBhaW50aW5nT3B0aW9ucygpID0gZGVmYXVsdDsKICAgICBJbWFnZVBhaW50aW5nT3B0aW9u cyhjb25zdCBJbWFnZVBhaW50aW5nT3B0aW9ucyYpID0gZGVmYXVsdDsKKyAgICBJbWFnZVBhaW50 aW5nT3B0aW9ucyYgb3BlcmF0b3I9KGNvbnN0IEltYWdlUGFpbnRpbmdPcHRpb25zJikgPSBkZWZh dWx0OwogCiAgICAgQ29tcG9zaXRlT3BlcmF0b3IgY29tcG9zaXRlT3BlcmF0b3IoKSBjb25zdCB7 IHJldHVybiBtX2NvbXBvc2l0ZU9wZXJhdG9yOyB9CiAgICAgQmxlbmRNb2RlIGJsZW5kTW9kZSgp IGNvbnN0IHsgcmV0dXJuIG1fYmxlbmRNb2RlOyB9DQo=