230954 2021-09-29 07:54:22 -0700 Make WebLocalizedString() thread-safe 2021-09-29 09:13:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren sam simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1798328 0 cdumez 2021-09-29 07:54:22 -0700 Make WebLocalizedString() thread-safe. It takes minimal effort to make it thread-safe given that the NSBundle API is thread-safe and clients keep calling it on the background thread. 1798330 1 439607 cdumez 2021-09-29 07:59:08 -0700 Created attachment 439607 Patch 1798349 2 439607 ap 2021-09-29 08:37:04 -0700 Comment on attachment 439607 Patch Seems like a bad idea to me. This assertion caught thread safety bug in important clients several times in recent memory. One could claim that we shouldn't care because those re client bugs not WebKit ones; I will not agree with that. 1798358 3 439607 ap 2021-09-29 08:49:16 -0700 Comment on attachment 439607 Patch I've been told that all those recent instances were not real bugs, and it was OK to call WebLocalizedString on background threads then. So r+. 1798369 4 ews-feeder 2021-09-29 09:12:39 -0700 Committed r283225 (242267@main): <https://commits.webkit.org/242267@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439607. 1798371 5 webkit-bug-importer 2021-09-29 09:13:15 -0700 <rdar://problem/83673645> 439607 2021-09-29 07:59:08 -0700 2021-09-29 09:12:40 -0700 Patch bug-230954-20210929075907.patch text/plain 2544 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYTM4NTA5MTJkNWRkOGRhNWMxYzRlMDcxZTc5NTBmNGI4ZDJlMGNmOC4uOGUzNTQ4YWM0NmEx YzQxYzEwNTU2YTA1MjViMTliNjJkMzdlZGUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA5LTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKKyAgICAgICAgTWFrZSBXZWJMb2NhbGl6ZWRTdHJpbmcoKSB0aHJlYWQtc2FmZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwOTU0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBXZWJM b2NhbGl6ZWRTdHJpbmcoKSB0aHJlYWQtc2FmZS4gSXQgdGFrZXMgbWluaW1hbCBlZmZvcnQgdG8g bWFrZSBpdCB0aHJlYWQtc2FmZSBnaXZlbgorICAgICAgICB0aGF0IHRoZSBOU0J1bmRsZSBBUEkg aXMgdGhyZWFkLXNhZmUgWzFdIGFuZCBjbGllbnRzIGtlZXAgY2FsbGluZyBpdCBvbiB0aGUgYmFj a2dyb3VuZCB0aHJlYWQuCisKKyAgICAgICAgWzFdIGh0dHBzOi8vZGV2ZWxvcGVyLmFwcGxlLmNv bS9kb2N1bWVudGF0aW9uL2ZvdW5kYXRpb24vbnNsb2NhbGl6ZWRzdHJpbmd3aXRoZGVmYXVsdHZh bHVlCisgICAgICAgICJBcyBvZiBPUyBYIDEwLjExIGFuZCBpT1MgOSwgTlNCdW5kbGUgaXMgdGhy ZWFkLXNhZmUuIEFzIHN1Y2gsIHlvdSBjYW4gc2FmZWx5IGNhbGwKKyAgICAgICAgIE5TTG9jYWxp emVkU3RyaW5nV2l0aERlZmF1bHRWYWx1ZSBmcm9tIGFueSBleGVjdXRpb24gY29udGV4dC4iCisK KyAgICAgICAgKiBNaXNjL1dlYkxvY2FsaXphYmxlU3RyaW5ncy5tbToKKwogMjAyMS0wOS0yOCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgQ3Jvc3MtT3Jp Z2luLU9wZW5lci1Qb2xpY3kgaGFuZGxpbmcgdG8gdGhlIE5ldHdvcmtQcm9jZXNzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9NaXNjL1dlYkxvY2FsaXphYmxlU3RyaW5ncy5t bSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL01pc2MvV2ViTG9jYWxpemFibGVTdHJpbmdzLm1t CmluZGV4IDI5NDBkNGFiNmYyMDk4M2VjODZiOTJhYWEyZjYxNzJjMjE5NTMwZjIuLmFmZmQyMTEx ODY3MDMzOTEwZDNhMmI3NThkOTI3Mjk1ZjNmNWRmNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL01pc2MvV2ViTG9jYWxpemFibGVTdHJpbmdzLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXRMZWdhY3kvbWFjL01pc2MvV2ViTG9jYWxpemFibGVTdHJpbmdzLm1tCkBAIC0zNywxNyAr MzcsMTMgQEAgV2ViTG9jYWxpemFibGVTdHJpbmdzQnVuZGxlIFdlYktpdExvY2FsaXphYmxlU3Ry aW5nc0J1bmRsZSA9IHsgImNvbS5hcHBsZS5XZWJLaXQKIAogTlNTdHJpbmcgKldlYkxvY2FsaXpl ZFN0cmluZyhXZWJMb2NhbGl6YWJsZVN0cmluZ3NCdW5kbGUgKnN0cmluZ3NCdW5kbGUsIGNvbnN0 IGNoYXIgKmtleSkKIHsKLSAgICAvLyBUaGlzIGZ1bmN0aW9uIGlzIG5vdCB0aHJlYWQtc2FmZSBk dWUgYXQgbGVhc3QgdG8gaXRzIHVuZ3VhcmRlZCB1c2Ugb2YgdGhlIG1haW5CdW5kbGUgc3RhdGlj IHZhcmlhYmxlCi0gICAgLy8gYW5kIGl0cyB1c2Ugb2YgW05TQnVuZGxlIGxvY2FsaXplZFN0cmlu Z0ZvcktleTo6Ol0sIHdoaWNoIGlzIG5vdCBndWFyYW50ZWVkIHRvIGJlIHRocmVhZC1zYWZlLiBJ ZgotICAgIC8vIHdlIGRlY2lkZSB3ZSBuZWVkIHRvIHVzZSB0aGlzIG9uIGJhY2tncm91bmQgdGhy ZWFkcywgd2UnbGwgbmVlZCB0byBhZGQgbG9ja2luZyBoZXJlIGFuZCBtYWtlIHN1cmUKLSAgICAv LyBpdCBkb2Vzbid0IGFmZmVjdCBwZXJmb3JtYW5jZS4KLSNpZiAhUExBVEZPUk0oSU9TX0ZBTUlM WSkKLSAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwotI2VuZGlmCi0KICAgICBOU0J1bmRsZSAq YnVuZGxlOwogICAgIGlmIChzdHJpbmdzQnVuZGxlID09IE5VTEwpIHsKLSAgICAgICAgc3RhdGlj IE5ldmVyRGVzdHJveWVkPFJldGFpblB0cjxOU0J1bmRsZT4+IG1haW5CdW5kbGUgPSBbTlNCdW5k bGUgbWFpbkJ1bmRsZV07CisgICAgICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8UmV0YWlu UHRyPE5TQnVuZGxlPj4gbWFpbkJ1bmRsZTsKKyAgICAgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFn IGZsYWc7CisgICAgICAgIHN0ZDo6Y2FsbF9vbmNlKGZsYWcsIFtdICgpIHsKKyAgICAgICAgICAg IG1haW5CdW5kbGUuY29uc3RydWN0KFtOU0J1bmRsZSBtYWluQnVuZGxlXSk7CisgICAgICAgIH0p OwogICAgICAgICBBU1NFUlQobWFpbkJ1bmRsZS5nZXQoKSk7CiAgICAgICAgIGJ1bmRsZSA9IG1h aW5CdW5kbGUuZ2V0KCkuZ2V0KCk7CiAgICAgfSBlbHNlIHsK