230939 2021-09-29 00:59:35 -0700 GraphicsContextGLAttributes::hasFenceSync should be a property of GraphicsContextGLOpenGL 2021-09-30 05:48:44 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen dino ews-watchlist kbr kkinnunen koivisto kondapallykalyan webkit-bug-importer oldest_to_newest 1798209 0 kkinnunen 2021-09-29 00:59:35 -0700 GraphicsContextGLAttributes::hasFenceSync should be a property of GraphicsContextGLOpenGL hasFenceSync is just an internal bool of (Cocoa) GraphicsContextGLOpenGL 1798210 1 439577 kkinnunen 2021-09-29 01:02:48 -0700 Created attachment 439577 Patch 1798238 2 439577 koivisto 2021-09-29 03:34:53 -0700 Comment on attachment 439577 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439577&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:797 > + bool m_useFenceSyncForDisplayRateLimit = false; I'd use the { } initialization syntax 1798843 3 ews-feeder 2021-09-30 05:47:20 -0700 Committed r283308 (242333@main): <https://commits.webkit.org/242333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439577. 1798846 4 webkit-bug-importer 2021-09-30 05:48:44 -0700 <rdar://problem/83715396> 439577 2021-09-29 01:02:48 -0700 2021-09-30 05:47:21 -0700 Patch bug-230939-20210929110247.patch text/plain 4336 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2E0ZDFmMDk0ZTBkZDZm YmY4NzRkOWViMzRhMzRkYjIzYjkwNzg2Zi4uODgxOWIxMzk5MjBiNDQ3M2Y0NjMzMTg0MThiYTY0 ZTZiMjVkMTNjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA5LTI5ICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgR3JhcGhpY3NDb250 ZXh0R0xBdHRyaWJ1dGVzOjpoYXNGZW5jZVN5bmMgc2hvdWxkIGJlIGEgcHJvcGVydHkgb2YgR3Jh cGhpY3NDb250ZXh0R0xPcGVuR0wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzMDkzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1vdmUgaGFzRmVuY2VTeW5jIGZyb20gR3JhcGhpY3NDb250ZXh0R0xBdHRy aWJ1dGVzIHRvIEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgYSByZWZhY3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dEdMQXR0cmlidXRlcy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dy YXBoaWNzQ29udGV4dEdMT3BlbkdMQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHRHTE9wZW5HTDo6R3JhcGhpY3NDb250ZXh0R0xPcGVuR0wpOgorICAgICAgICAoV2Vi Q29yZTo6R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OnByZXBhcmVGb3JEaXNwbGF5KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuaDoK KwogMjAyMS0wOS0yOCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgog CiAgICAgICAgIEZhY3RvciBvdXQgcmFyZSBtZW1iZXJzIG9mIEZvbnRDcmVhdGlvbkNvbnRleHQg aW50byBGb250Q3JlYXRpb25Db250ZXh0UmFyZURhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dEdMQXR0cmlidXRlcy5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0R0xBdHRyaWJ1dGVz LmgKaW5kZXggMGY0ZTJiODcwM2JlNDM5NmIxODVmOTRlYjUzYzVmMTBhODMyYjY1NS4uYTBhZDc3 YmE4ODRiNWIzMzE0NTllNmZmZGVlMjBmNzg1NjQ1NDRmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0R0xBdHRyaWJ1dGVzLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0R0xBdHRy aWJ1dGVzLmgKQEAgLTY0LDcgKzY0LDYgQEAgc3RydWN0IEdyYXBoaWNzQ29udGV4dEdMQXR0cmli dXRlcyB7CiAgICAgYm9vbCBmb3JjZVJlcXVlc3RGb3JIaWdoUGVyZm9ybWFuY2VHUFUgeyBmYWxz ZSB9OwogI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIGJvb2wgdXNlTWV0YWwgeyB0cnVlIH07Ci0g ICAgYm9vbCBoYXNGZW5jZVN5bmMgeyBmYWxzZSB9OwogI2VuZGlmCiAjaWYgRU5BQkxFKFdFQlhS KQogICAgIGJvb2wgeHJDb21wYXRpYmxlIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29j b2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0Nv bnRleHRHTE9wZW5HTENvY29hLm1tCmluZGV4IGU0MTE0YTIwYzRkYTY3YmE5NjgzMzE4MTE2ZTYx OGQxOWIzOWFmNWQuLjkxZGEzZjk1MzIxNjE4MDAxZjcwMmZjNmM3NzI1OWEzMWE4YzEwMGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNz Q29udGV4dEdMT3BlbkdMQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY29jb2EvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbQpAQCAtMzUyLDEyICsz NTIsMTMgQEAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdM KEdyYXBoaWNzQ29udGV4dEdMQXR0cmlidXRlcyBhdHQKICAgICAgICAgZXh0ZW5zaW9ucy5lbnN1 cmVFbmFibGVkKGV4dGVuc2lvbik7CiAgICAgfQogICAgIGlmIChjb250ZXh0QXR0cmlidXRlcygp LnVzZU1ldGFsKSB7Ci0gICAgICAgIC8vIFRoZSBpbXBsZW1lbnRhdGlvbiB1c2VzIEdMc3luYyBv YmplY3RzLiBFbmFibGUgdGhlIGZ1bmN0aW9uYWxpdHkgZm9yIFdlYkdMIDEuMCBjb250ZXh0cwot ICAgICAgICAvLyB0aGF0IHVzZSBPcGVuR0wgRVMgMi4wLgorICAgICAgICAvLyBHcmFwaGljc0Nv bnRleHRHTE9wZW5HTCB1c2VzIHN5bmMgb2JqZWN0cyB0byB0aHJvdHRsZSBkaXNwbGF5IG9uIE1l dGFsIGltcGxlbWVudGF0aW9ucy4KKyAgICAgICAgLy8gT3BlbkdMIHN5bmMgb2JqZWN0cyBhcmUg bm90IHNpZ25hbGluZyB1cG9uIGNvbXBsZXRpb24gb24gQ2F0YWxpbmEtZXJhIGRyaXZlcnMsIHNv CisgICAgICAgIC8vIE9wZW5HTCBjYW5ub3QgdXNlIHRoaXMgbWV0aG9kIG9mIHRocm90dGxpbmcu IE9wZW5HTCBkcml2ZXJzIHR5cGljYWxseSBpbXBsZW1lbnQKKyAgICAgICAgLy8gc29tZSBzb3J0 IG9mIGludGVybmFsIHRocm90dGxpbmcuCiAgICAgICAgIGlmIChleHRlbnNpb25zLnN1cHBvcnRz KCJHTF9BUkJfc3luYyJfcykpIHsKLSAgICAgICAgICAgIGF0dHJzLmhhc0ZlbmNlU3luYyA9IHRy dWU7CisgICAgICAgICAgICBtX3VzZUZlbmNlU3luY0ZvckRpc3BsYXlSYXRlTGltaXQgPSB0cnVl OwogICAgICAgICAgICAgZXh0ZW5zaW9ucy5lbnN1cmVFbmFibGVkKCJHTF9BUkJfc3luYyJfcyk7 Ci0gICAgICAgICAgICBzZXRDb250ZXh0QXR0cmlidXRlcyhhdHRycyk7CiAgICAgICAgIH0KICAg ICB9CiAgICAgdmFsaWRhdGVBdHRyaWJ1dGVzKCk7CkBAIC04MzYsOSArODM3LDcgQEAgdm9pZCBH cmFwaGljc0NvbnRleHRHTE9wZW5HTDo6cHJlcGFyZUZvckRpc3BsYXkoKQogCiAgICAgbWFya0xh eWVyQ29tcG9zaXRlZCgpOwogCi0gICAgaWYgKGNvbnRleHRBdHRyaWJ1dGVzKCkudXNlTWV0YWwg JiYgY29udGV4dEF0dHJpYnV0ZXMoKS5oYXNGZW5jZVN5bmMpIHsKLSAgICAgICAgLy8gT3BlbkdM IHN5bmMgb2JqZWN0cyBhcmUgbm90IHNpZ25hbGluZyB1cG9uIGNvbXBsZXRpb24gb24gQ2F0YWxp bmEtZXJhIGRyaXZlcnMuCi0gICAgICAgIC8vIE9wZW5HTCBkcml2ZXJzIHR5cGljYWxseSBpbXBs ZW1lbnQgc29tZSBzb3J0IG9mIGludGVybmFsIHRocm90dGxpbmcuCisgICAgaWYgKG1fdXNlRmVu Y2VTeW5jRm9yRGlzcGxheVJhdGVMaW1pdCkgewogICAgICAgICBib29sIHN1Y2Nlc3MgPSB3YWl0 QW5kVXBkYXRlT2xkZXN0RnJhbWUoKTsKICAgICAgICAgVU5VU0VEX1ZBUklBQkxFKHN1Y2Nlc3Mp OyAvLyBGSVhNRTogaW1wbGVtZW50IGNvbnRleHQgbG9zdC4KICAgICB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xP cGVuR0wuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGlj c0NvbnRleHRHTE9wZW5HTC5oCmluZGV4IGEyOTRlMzU2MDRlNzdmZGViZDg4NDFjNTU4ZDk0M2Uz NDU4YTFmYmUuLjI3Zjc5NzM1NDcyMTBhMDYwNWQzYmUwY2U3ZDllMzI0YzU5NTc2ODIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0Nv bnRleHRHTE9wZW5HTC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHRHTE9wZW5HTC5oCkBAIC03OTQsNiArNzk0LDcgQEAgcHJpdmF0 ZToKICAgICBzdGQ6OnVuaXF1ZV9wdHI8R3JhcGhpY3NDb250ZXh0R0xDVj4gbV9jdjsKICNlbmRp ZgogI2lmIFVTRShBTkdMRSkKKyAgICBib29sIG1fdXNlRmVuY2VTeW5jRm9yRGlzcGxheVJhdGVM aW1pdCA9IGZhbHNlOwogICAgIHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IG1heFBlbmRpbmdGcmFt ZXMgPSAzOwogICAgIHNpemVfdCBtX29sZGVzdEZyYW1lQ29tcGxldGlvbkZlbmNlIHsgMCB9Owog ICAgIFNjb3BlZEdMRmVuY2UgbV9mcmFtZUNvbXBsZXRpb25GZW5jZXNbbWF4UGVuZGluZ0ZyYW1l c107Cg==