230920 2021-09-28 15:43:33 -0700 iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API 2021-09-29 00:25:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki Alex_fioletov benjamin cdumez cmarcelo ews-watchlist fpizlo thorton webkit-bug-importer oldest_to_newest 1798078 0 ysuzuki 2021-09-28 15:43:33 -0700 iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API 1798080 1 439535 ysuzuki 2021-09-28 15:45:47 -0700 Created attachment 439535 Patch 1798081 2 ysuzuki 2021-09-28 15:45:50 -0700 <rdar://problem/77494871> 1798082 3 439535 ysuzuki 2021-09-28 15:48:33 -0700 Comment on attachment 439535 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439535&action=review > Source/WTF/wtf/PlatformUse.h:331 > + || (PLATFORM(IOS) && PLATFORM(IOS_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) PLATFORM(IOS) is not necessary. Removed. 1798083 4 439536 ysuzuki 2021-09-28 15:49:38 -0700 Created attachment 439536 Patch 1798095 5 ysuzuki 2021-09-28 16:07:23 -0700 *** Bug 228990 has been marked as a duplicate of this bug. *** 1798102 6 thorton 2021-09-28 16:43:15 -0700 Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special about iOS *specifically*? 1798149 7 ysuzuki 2021-09-28 19:46:54 -0700 (In reply to Tim Horton from comment #6) > Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special > about iOS *specifically*? IOS_FAMILY_SIMULATOR is better, changed. 1798151 8 439559 ysuzuki 2021-09-28 19:54:15 -0700 Created attachment 439559 Patch for landing 1798193 9 ysuzuki 2021-09-28 23:23:40 -0700 Committed r283211 (242253@main): <https://commits.webkit.org/242253@main> 1798197 10 thorton 2021-09-28 23:41:52 -0700 FWIW the final patch is a bit overkill, because we don't care about (or even successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have caught this when I said the last thing). Still, your patch is fine. 1798203 11 ysuzuki 2021-09-29 00:25:47 -0700 (In reply to Tim Horton from comment #10) > FWIW the final patch is a bit overkill, because we don't care about (or even > successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have > caught this when I said the last thing). Still, your patch is fine. Ah! I see. Thanks!! 439535 2021-09-28 15:45:47 -0700 2021-09-28 15:49:36 -0700 Patch bug-230920-20210928154547.patch text/plain 1560 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM4NjUxNzNjNjRhZTVjOTE4MzQyNjY5 OTQ2YmJhMWM4N2Y4OGIyNzkuLjQ2OGUzZjk1YjFhMTU2YWY1ZTMxNTkwMjQxM2VhNjBjMjdlMjVl YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDktMjggIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBpT1Mgc2ltdWxhdG9yIGJ1aWxkIHNob3VsZCB1c2Ug UFRIUkVBRF9KSVRfUEVSTUlTU0lPTlNfQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA5MjAKKyAgICAgICAgcmRhcjovLzc3NDk0ODcxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gQXBwbGVTaWxp Y29uIG1hY09TLCB3ZSBzaG91bGQgdXNlIFBUSFJFQURfSklUX1BFUk1JU1NJT05TX0FQSSBmb3Ig T1NTIGJ1aWxkLgorICAgICAgICBIb3dldmVyLCB3ZSBhcmUgbm90IGVuYWJsaW5nIHRoYXQgZm9y IGlPUyBzaW11bGF0b3IgYnVpbGQuIFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGF0LgorICAgICAgICBU aGlzIEFQSSBleGlzdHMgYWZ0ZXIgaU9TIDE0LjAgU0RLLgorCisgICAgICAgICogd3RmL1BsYXRm b3JtVXNlLmg6CisKIDIwMjEtMDktMjggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBNb3N0bHkgZml4IE1hYyBDTWFrZSBidWlsZApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtVXNlLmgKaW5kZXggZGJiMzBhNThhNzI5OGEzYjUwNWM2YmU1YWFjMTAwZTg3MGRhMTIzYi4u NThjMzAwZmRiMzliODhiZjRhZTNmODUwMjIyMmQzYTdmMTY3YjljZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVVz ZS5oCkBAIC0zMjcsNyArMzI3LDggQEAKICNlbmRpZgogCiAjaWYgKFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDApIFwKLSAgICB8fCAoUExB VEZPUk0oTUFDQ0FUQUxZU1QpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDE0MDAwMCkKKyAgICB8fCAoUExBVEZPUk0oTUFDQ0FUQUxZU1QpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkgXAorICAgIHx8IChQTEFURk9STShJT1MpICYm IFBMQVRGT1JNKElPU19TSU1VTEFUT1IpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJ UkVEID49IDE0MDAwMCkKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogLyogQWx3YXlzIHVz ZSB0aGUgbWFjcm8gb24gaW50ZXJuYWwgYnVpbGRzICovCiAjZGVmaW5lIFVTRV9QVEhSRUFEX0pJ VF9QRVJNSVNTSU9OU19BUEkgMCAK 439536 2021-09-28 15:49:38 -0700 2021-09-28 16:05:26 -0700 Patch bug-230920-20210928154938.patch text/plain 1543 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM4NjUxNzNjNjRhZTVjOTE4MzQyNjY5 OTQ2YmJhMWM4N2Y4OGIyNzkuLjQ2OGUzZjk1YjFhMTU2YWY1ZTMxNTkwMjQxM2VhNjBjMjdlMjVl YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDktMjggIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBpT1Mgc2ltdWxhdG9yIGJ1aWxkIHNob3VsZCB1c2Ug UFRIUkVBRF9KSVRfUEVSTUlTU0lPTlNfQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA5MjAKKyAgICAgICAgcmRhcjovLzc3NDk0ODcxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gQXBwbGVTaWxp Y29uIG1hY09TLCB3ZSBzaG91bGQgdXNlIFBUSFJFQURfSklUX1BFUk1JU1NJT05TX0FQSSBmb3Ig T1NTIGJ1aWxkLgorICAgICAgICBIb3dldmVyLCB3ZSBhcmUgbm90IGVuYWJsaW5nIHRoYXQgZm9y IGlPUyBzaW11bGF0b3IgYnVpbGQuIFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGF0LgorICAgICAgICBU aGlzIEFQSSBleGlzdHMgYWZ0ZXIgaU9TIDE0LjAgU0RLLgorCisgICAgICAgICogd3RmL1BsYXRm b3JtVXNlLmg6CisKIDIwMjEtMDktMjggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBNb3N0bHkgZml4IE1hYyBDTWFrZSBidWlsZApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtVXNlLmgKaW5kZXggZGJiMzBhNThhNzI5OGEzYjUwNWM2YmU1YWFjMTAwZTg3MGRhMTIzYi4u NWJhYzg3MDFjZjRmMGI1ODlkODRlYmU4NzYzYzE4Y2ZjYzk2MzZmMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVVz ZS5oCkBAIC0zMjcsNyArMzI3LDggQEAKICNlbmRpZgogCiAjaWYgKFBMQVRGT1JNKE1BQykgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDApIFwKLSAgICB8fCAoUExB VEZPUk0oTUFDQ0FUQUxZU1QpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDE0MDAwMCkKKyAgICB8fCAoUExBVEZPUk0oTUFDQ0FUQUxZU1QpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkgXAorICAgIHx8IChQTEFURk9STShJT1NfU0lN VUxBVE9SKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNDAwMDApCiAj aWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIC8qIEFsd2F5cyB1c2UgdGhlIG1hY3JvIG9uIGlu dGVybmFsIGJ1aWxkcyAqLwogI2RlZmluZSBVU0VfUFRIUkVBRF9KSVRfUEVSTUlTU0lPTlNfQVBJ IDAgCg== 439559 2021-09-28 19:54:15 -0700 2021-09-28 19:54:15 -0700 Patch for landing bug-230920-20210928195415.patch text/plain 1782 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM4NjUxNzNjNjRhZTVjOTE4MzQyNjY5 OTQ2YmJhMWM4N2Y4OGIyNzkuLjQ2OGUzZjk1YjFhMTU2YWY1ZTMxNTkwMjQxM2VhNjBjMjdlMjVl YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDktMjggIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBpT1Mgc2ltdWxhdG9yIGJ1aWxkIHNob3VsZCB1c2Ug UFRIUkVBRF9KSVRfUEVSTUlTU0lPTlNfQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA5MjAKKyAgICAgICAgcmRhcjovLzc3NDk0ODcxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gQXBwbGVTaWxp Y29uIG1hY09TLCB3ZSBzaG91bGQgdXNlIFBUSFJFQURfSklUX1BFUk1JU1NJT05TX0FQSSBmb3Ig T1NTIGJ1aWxkLgorICAgICAgICBIb3dldmVyLCB3ZSBhcmUgbm90IGVuYWJsaW5nIHRoYXQgZm9y IGlPUyBzaW11bGF0b3IgYnVpbGQuIFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGF0LgorICAgICAgICBU aGlzIEFQSSBleGlzdHMgYWZ0ZXIgaU9TIDE0LjAgU0RLLgorCisgICAgICAgICogd3RmL1BsYXRm b3JtVXNlLmg6CisKIDIwMjEtMDktMjggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBNb3N0bHkgZml4IE1hYyBDTWFrZSBidWlsZApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm b3JtVXNlLmgKaW5kZXggZGJiMzBhNThhNzI5OGEzYjUwNWM2YmU1YWFjMTAwZTg3MGRhMTIzYi4u ZmJkOGJkOWFkYzEyNDAyZWNiOGUyNGIyOWY0ZTFlMzQ1NDhjN2ViNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUGxhdGZvcm1Vc2UuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVVz ZS5oCkBAIC0zMjcsNyArMzI3LDEwIEBACiAjZW5kaWYKIAogI2lmIChQTEFURk9STShNQUMpICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMDAwKSBcCi0gICAgfHwgKFBM QVRGT1JNKE1BQ0NBVEFMWVNUKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxNDAwMDApCisgICAgfHwgKFBMQVRGT1JNKE1BQ0NBVEFMWVNUKSAmJiBfX0lQSE9ORV9PU19W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNDAwMDApIFwKKyAgICB8fCAoUExBVEZPUk0oSU9TKSAm JiBQTEFURk9STShJT1NfRkFNSUxZX1NJTVVMQVRPUikgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTQwMDAwKSBcCisgICAgfHwgKFBMQVRGT1JNKFdBVENIT1MpICYmIFBM QVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9SKSAmJiBfX1dBVENIX09TX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDcwMDAwKSBcCisgICAgfHwgKFBMQVRGT1JNKEFQUExFVFYpICYmIFBMQVRGT1JN KElPU19GQU1JTFlfU0lNVUxBVE9SKSAmJiBfX1RWX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDE0MDAwMCkKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogLyogQWx3YXlzIHVzZSB0aGUg bWFjcm8gb24gaW50ZXJuYWwgYnVpbGRzICovCiAjZGVmaW5lIFVTRV9QVEhSRUFEX0pJVF9QRVJN SVNTSU9OU19BUEkgMCAK