230914 2021-09-28 14:21:06 -0700 PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API 2021-09-30 15:42:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham cdumez changseok esprehn+autocc ews-watchlist gsnedders gyuyoung.kim kondapallykalyan webkit-bug-importer oldest_to_newest 1798033 0 wilander 2021-09-28 14:21:06 -0700 We should change Private Click Measurement's anchor attributes from all lowercase to camelcase to match the spec and align with the Attribution Reporting API proposal. 1798034 1 webkit-bug-importer 2021-09-28 14:21:34 -0700 <rdar://problem/83639923> 1798065 2 439529 wilander 2021-09-28 15:19:09 -0700 Created attachment 439529 Patch 1798959 3 gsnedders 2021-09-30 11:40:26 -0700 Non-reviewer r+. That said, I've some slight concern about breakage here, though looking on GitHub doesn't immediately show up usage of the DOM APIs. 1799033 4 439529 bfulgham 2021-09-30 15:02:55 -0700 Comment on attachment 439529 Patch r=me 1799037 5 439529 wilander 2021-09-30 15:14:20 -0700 Comment on attachment 439529 Patch Thanks, Sam and Brent! 1799052 6 ews-feeder 2021-09-30 15:42:25 -0700 Committed r283342 (242358@main): <https://commits.webkit.org/242358@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439529. 439529 2021-09-28 15:19:09 -0700 2021-09-30 15:42:27 -0700 Patch bug-230914-20210928151908.patch text/plain 7289 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk5NzYzMzY3MzJmNjUx MTBlM2RkMThiNDcxYWI5MThkZmNlMmY5My4uZjJkNjgzMGRlNThlNTllZjk1MjNhMzFmNzE0NGRk YzgzNDdjMmVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA5LTI4ICBKb2hu IFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFBDTTogQ2hhbmdlIFdl YklETCBhdHRyaWJ1dGVzIGZyb20gYWxsIGxvd2VyY2FzZSB0byBjYW1lbGNhc2UgdG8gbWF0Y2gg c3BlYyBhbmQgYWxpZ24gd2l0aCBBdHRyaWJ1dGlvbiBSZXBvcnRpbmcgQVBJCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA5MTQKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzgzNjM5OTIzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyBQcml2YXRlIENsaWNrIE1lYXN1cmVt ZW50J3MgV2ViSURMIGF0dHJpYnV0ZXMgZnJvbQorICAgICAgICBhbGwgbG93ZXJjYXNlIHRvIGNh bWVsY2FzZSB0byBtYXRjaCB0aGUgc3BlYyBhbmQgYWxpZ24gd2l0aCB0aGUKKyAgICAgICAgQXR0 cmlidXRpb24gUmVwb3J0aW5nIEFQSSBwcm9wb3NhbC4KKworICAgICAgICBSZWZlcmVuY2VzCisg ICAgICAgIC0gUHJpdmF0ZSBDbGljayBNZWFzdXJlbWVudCBwcm9wb3NhbDogaHR0cHM6Ly9wcml2 YWN5Y2cuZ2l0aHViLmlvL3ByaXZhdGUtY2xpY2stbWVhc3VyZW1lbnQvI2xpbmtmb3JtYXQKKyAg ICAgICAgLSBBdHRyaWJ1dGlvbiBSZXBvcnRpbmcgQVBJIHByb3Bvc2FsOiBodHRwczovL3dpY2cu Z2l0aHViLmlvL2NvbnZlcnNpb24tbWVhc3VyZW1lbnQtYXBpLyNtb25rZXlwYXRjaC1hbmNob3IK KworICAgICAgICBFeGlzdGluZyB0ZXN0cyB1cGRhdGVkLgorCisgICAgICAgICogaHRtbC9IVE1M QW5jaG9yRWxlbWVudC5pZGw6CisKIDIwMjEtMDktMjggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIFtCaWdTdXIgd2syIERlYnVnIGlPUzE0IF0gd2VicnRjL3Zp ZGVvLW11dGUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M QW5jaG9yRWxlbWVudC5pZGwKaW5kZXggMTI5MWFiZmRkMWVjMmVkYmRiYTJhNzQ3ZDI1NDMxNTU5 YTIxZWYzNi4uMzNjMDBmNWNjOGI0NzYyMmZiYzdmYzMxZGQ5OTJiNDI5OTYyNjZmYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5pZGwKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5pZGwKQEAgLTIxLDkgKzIxLDkgQEAK IFsKICAgICBFeHBvc2VkPVdpbmRvdwogXSBpbnRlcmZhY2UgSFRNTEFuY2hvckVsZW1lbnQgOiBI VE1MRWxlbWVudCB7Ci0gICAgW0NFUmVhY3Rpb25zPU5vdE5lZWRlZCwgRW5hYmxlZEJ5U2V0dGlu Zz1Qcml2YXRlQ2xpY2tNZWFzdXJlbWVudCwgUmVmbGVjdF0gYXR0cmlidXRlIHVuc2lnbmVkIGxv bmcgYXR0cmlidXRpb25zb3VyY2VpZDsKLSAgICBbQ0VSZWFjdGlvbnM9Tm90TmVlZGVkLCBFbmFi bGVkQnlTZXR0aW5nPVByaXZhdGVDbGlja01lYXN1cmVtZW50LCBSZWZsZWN0XSBhdHRyaWJ1dGUg RE9NU3RyaW5nIGF0dHJpYnV0aW9uZGVzdGluYXRpb247Ci0gICAgW0NFUmVhY3Rpb25zPU5vdE5l ZWRlZCwgRW5hYmxlZEJ5U2V0dGluZz1Qcml2YXRlQ2xpY2tNZWFzdXJlbWVudEZyYXVkUHJldmVu dGlvbiwgUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0cmluZyBhdHRyaWJ1dGlvbnNvdXJjZW5vbmNl OworICAgIFtDRVJlYWN0aW9ucz1Ob3ROZWVkZWQsIEVuYWJsZWRCeVNldHRpbmc9UHJpdmF0ZUNs aWNrTWVhc3VyZW1lbnQsIFJlZmxlY3RdIGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIGF0dHJpYnV0 aW9uU291cmNlSWQ7CisgICAgW0NFUmVhY3Rpb25zPU5vdE5lZWRlZCwgRW5hYmxlZEJ5U2V0dGlu Zz1Qcml2YXRlQ2xpY2tNZWFzdXJlbWVudCwgUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0cmluZyBh dHRyaWJ1dGlvbkRlc3RpbmF0aW9uOworICAgIFtDRVJlYWN0aW9ucz1Ob3ROZWVkZWQsIEVuYWJs ZWRCeVNldHRpbmc9UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRGcmF1ZFByZXZlbnRpb24sIFJlZmxl Y3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgYXR0cmlidXRpb25Tb3VyY2VOb25jZTsKICAgICBbQ0VS ZWFjdGlvbnM9Tm90TmVlZGVkLCBSZWZsZWN0XSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNoYXJzZXQ7 CiAgICAgW0NFUmVhY3Rpb25zPU5vdE5lZWRlZCwgUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0cmlu ZyBjb29yZHM7CiAgICAgW0NFUmVhY3Rpb25zPU5vdE5lZWRlZCwgQ29uZGl0aW9uYWw9RE9XTkxP QURfQVRUUklCVVRFLCBFbmFibGVkQnlTZXR0aW5nPURvd25sb2FkQXR0cmlidXRlLCBSZWZsZWN0 XSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGRvd25sb2FkOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE5NTI0M2UwZmM1MTA4YzMy YmZiZDUyZDMxYTg2MjQ0YTNkNGE1MTAuLmQ3OWMxYWI4ZjVmZDhjMjc0N2E4YjNkNzA1YWY1YzRh ZTJlMGZiMmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAyMS0wOS0yOCAgSm9obiBXaWxhbmRl ciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KKworICAgICAgICBQQ006IENoYW5nZSBXZWJJREwgYXR0 cmlidXRlcyBmcm9tIGFsbCBsb3dlcmNhc2UgdG8gY2FtZWxjYXNlIHRvIG1hdGNoIHNwZWMgYW5k IGFsaWduIHdpdGggQXR0cmlidXRpb24gUmVwb3J0aW5nIEFQSQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwOTE0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS84MzYzOTkyMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgUHJpdmF0ZSBDbGljayBNZWFzdXJlbWVudCdzIFdl YklETCBhdHRyaWJ1dGVzIGZyb20KKyAgICAgICAgYWxsIGxvd2VyY2FzZSB0byBjYW1lbGNhc2Ug dG8gbWF0Y2ggdGhlIHNwZWMgYW5kIGFsaWduIHdpdGggdGhlCisgICAgICAgIEF0dHJpYnV0aW9u IFJlcG9ydGluZyBBUEkgcHJvcG9zYWwuCisKKyAgICAgICAgUmVmZXJlbmNlcworICAgICAgICAt IFByaXZhdGUgQ2xpY2sgTWVhc3VyZW1lbnQgcHJvcG9zYWw6IGh0dHBzOi8vcHJpdmFjeWNnLmdp dGh1Yi5pby9wcml2YXRlLWNsaWNrLW1lYXN1cmVtZW50LyNsaW5rZm9ybWF0CisgICAgICAgIC0g QXR0cmlidXRpb24gUmVwb3J0aW5nIEFQSSBwcm9wb3NhbDogaHR0cHM6Ly93aWNnLmdpdGh1Yi5p by9jb252ZXJzaW9uLW1lYXN1cmVtZW50LWFwaS8jbW9ua2V5cGF0Y2gtYW5jaG9yCisKKyAgICAg ICAgKiBodHRwL3Rlc3RzL3ByaXZhdGVDbGlja01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmli dXRlcy1yZWZsZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3ByaXZhdGVD bGlja01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmlidXRlcy1yZWZsZWN0Lmh0bWw6CisgICAg ICAgICogaHR0cC90ZXN0cy9wcml2YXRlQ2xpY2tNZWFzdXJlbWVudC9hbmNob3ItdGFnLWF0dHJp YnV0ZXMtdmFsaWRhdGlvbi5odG1sOgorCiAyMDIxLTA5LTI4ICBFcmljIEh1dGNoaXNvbiAgPGVo dXRjaGlzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFsgaU9TLCBNYWMgXSBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtY2FzY2FkZS9sYXllci1jb3VudGVyLXN0eWxlLW92 ZXJyaWRlLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9wcml2YXRlQ2xpY2tNZWFzdXJlbWVudC9hbmNob3ItdGFnLWF0dHJpYnV0ZXMt cmVmbGVjdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByaXZhdGVDbGlj a01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmlidXRlcy1yZWZsZWN0LWV4cGVjdGVkLnR4dApp bmRleCAwMmIwM2IwMjhhY2U0ZDJkZTEzNzI0NjY0M2M3MmQwMDU1ZTQxMDRhLi4zNzBlMDI0NGVi OGFlNzk0ZjJkZTZmODA5NjlhM2Y1ZjcyMmVkZjhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3ByaXZhdGVDbGlja01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmlidXRlcy1y ZWZsZWN0LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByaXZhdGVD bGlja01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmlidXRlcy1yZWZsZWN0LWV4cGVjdGVkLnR4 dApAQCAtMSwxMCArMSwxMCBAQAotVGVzdCBmb3IgdGhlIG5ldyBwcml2YXRlIGNsaWNrIG1lYXN1 cmVtZW50IGF0dHJpYnV0ZXMgb24gYW5jaG9yIHRhZ3MuCitUZXN0IGZvciBwcml2YXRlIGNsaWNr IG1lYXN1cmVtZW50IGF0dHJpYnV0ZXMgb24gYW5jaG9yIHRhZ3MuCiAKIE9uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KIAogCi1QQVNTIGFuY2hvclRhZy5hdHRyaWJ1dGlvbnNvdXJjZWlkIGlzIDQw Ci1QQVNTIGFuY2hvclRhZy5hdHRyaWJ1dGlvbmRlc3RpbmF0aW9uIGlzICJodHRwczovL2Rlc3Rp bmF0aW9uLmV4YW1wbGUiCitQQVNTIGFuY2hvclRhZy5hdHRyaWJ1dGlvblNvdXJjZUlkIGlzIDQw CitQQVNTIGFuY2hvclRhZy5hdHRyaWJ1dGlvbkRlc3RpbmF0aW9uIGlzICJodHRwczovL2Rlc3Rp bmF0aW9uLmV4YW1wbGUiCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1Qg Q09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJpdmF0ZUNsaWNr TWVhc3VyZW1lbnQvYW5jaG9yLXRhZy1hdHRyaWJ1dGVzLXJlZmxlY3QuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvcHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQvYW5jaG9yLXRhZy1hdHRyaWJ1 dGVzLXJlZmxlY3QuaHRtbAppbmRleCBkZDA3ZGQ5NjM3YzBlYjhjNDgxN2E3MTRmZDhkOGRjNzUx OWRhNTlhLi43MDEyMDJhNDAyMTBiZDQwODZjN2NmNTViYmJlZjVmY2JiYjE4NWRlIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByaXZhdGVDbGlja01lYXN1cmVtZW50L2FuY2hv ci10YWctYXR0cmlidXRlcy1yZWZsZWN0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9wcml2YXRlQ2xpY2tNZWFzdXJlbWVudC9hbmNob3ItdGFnLWF0dHJpYnV0ZXMtcmVmbGVjdC5o dG1sCkBAIC03LDExICs3LDExIEBACiA8Ym9keT4KIDxhIGlkPSJ0ZXN0VGFnIiBocmVmPSJodHRw Oi8vbG9jYWxob3N0OjgwMDAiIGF0dHJpYnV0aW9uc291cmNlaWQ9NDAgYXR0cmlidXRpb25kZXN0 aW5hdGlvbj0iaHR0cHM6Ly9kZXN0aW5hdGlvbi5leGFtcGxlIj48L2E+CiA8c2NyaXB0PgotICAg IGRlc2NyaXB0aW9uKCJUZXN0IGZvciB0aGUgbmV3IHByaXZhdGUgY2xpY2sgbWVhc3VyZW1lbnQg YXR0cmlidXRlcyBvbiBhbmNob3IgdGFncy4iKTsKKyAgICBkZXNjcmlwdGlvbigiVGVzdCBmb3Ig cHJpdmF0ZSBjbGljayBtZWFzdXJlbWVudCBhdHRyaWJ1dGVzIG9uIGFuY2hvciB0YWdzLiIpOwog CiAgICAgY29uc3QgYW5jaG9yVGFnID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RUYWci KTsKLSAgICBzaG91bGRCZUVxdWFsVG9OdW1iZXIoImFuY2hvclRhZy5hdHRyaWJ1dGlvbnNvdXJj ZWlkIiwgNDApOwotICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiYW5jaG9yVGFnLmF0dHJpYnV0 aW9uZGVzdGluYXRpb24iLCAiaHR0cHM6Ly9kZXN0aW5hdGlvbi5leGFtcGxlIik7CisgICAgc2hv dWxkQmVFcXVhbFRvTnVtYmVyKCJhbmNob3JUYWcuYXR0cmlidXRpb25Tb3VyY2VJZCIsIDQwKTsK KyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoImFuY2hvclRhZy5hdHRyaWJ1dGlvbkRlc3RpbmF0 aW9uIiwgImh0dHBzOi8vZGVzdGluYXRpb24uZXhhbXBsZSIpOwogPC9zY3JpcHQ+CiA8L2JvZHk+ CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByaXZhdGVDbGlj a01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0cmlidXRlcy12YWxpZGF0aW9uLmh0bWwgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3ByaXZhdGVDbGlja01lYXN1cmVtZW50L2FuY2hvci10YWctYXR0 cmlidXRlcy12YWxpZGF0aW9uLmh0bWwKaW5kZXggYmQzNTZlNGNiODRiNThiYjE0Y2ZkODZhYWQz OTVkZTc2Yjc2OWM1YS4uZTE2N2RmN2ZlNjg0ZTllZjM0OTJlMWIwODVlNGVlMDVmNzJhNjAxNiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wcml2YXRlQ2xpY2tNZWFzdXJlbWVu dC9hbmNob3ItdGFnLWF0dHJpYnV0ZXMtdmFsaWRhdGlvbi5odG1sCisrKyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvcHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQvYW5jaG9yLXRhZy1hdHRyaWJ1dGVz LXZhbGlkYXRpb24uaHRtbApAQCAtMjUsOSArMjUsOSBAQAogICAgICAgICBhbmNob3JFbGVtZW50 LmlkID0gZWxlbWVudElEOwogICAgICAgICBhbmNob3JFbGVtZW50LmNsYXNzTGlzdC5hZGQoIndp ZGUtbGluayIpOwogICAgICAgICBpZiAoc291cmNlSUQgIT09IG51bGwpCi0gICAgICAgICAgICBh bmNob3JFbGVtZW50LmF0dHJpYnV0aW9uc291cmNlaWQgPSBzb3VyY2VJRDsKKyAgICAgICAgICAg IGFuY2hvckVsZW1lbnQuYXR0cmlidXRpb25Tb3VyY2VJZCA9IHNvdXJjZUlEOwogICAgICAgICBp ZiAoZGVzdGluYXRpb24gIT09IG51bGwpCi0gICAgICAgICAgICBhbmNob3JFbGVtZW50LmF0dHJp YnV0aW9uZGVzdGluYXRpb24gPSBkZXN0aW5hdGlvbjsKKyAgICAgICAgICAgIGFuY2hvckVsZW1l bnQuYXR0cmlidXRpb25EZXN0aW5hdGlvbiA9IGRlc3RpbmF0aW9uOwogICAgICAgICBhbmNob3JF bGVtZW50LmhyZWYgPSAiIyI7CiAgICAgICAgIGFuY2hvckVsZW1lbnQuaW5uZXJUZXh0ID0gIkxp bmsiICsgY3VycmVudFRlc3Q7CiAgICAgICAgIHJldHVybiBhbmNob3JFbGVtZW50Owo=