230909 2021-09-28 13:17:49 -0700 Remove redundant sandbox exception rules for registering mach extensions 2021-09-28 14:16:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1798004 0 bfulgham 2021-09-28 13:17:49 -0700 The Sandbox implementation offers a mechanism for applications to extend their sandbox at build time. WebKit does not use those extensions in its sandbox design, so we should remove those powers. They are left-over from importing the global App Sandbox rules long ago and are not used by WebKit. 1798005 1 bfulgham 2021-09-28 13:18:02 -0700 <rdar://problem/66583587> 1798008 2 439510 bfulgham 2021-09-28 13:22:59 -0700 Created attachment 439510 Patch 1798009 3 439510 pvollan 2021-09-28 13:25:30 -0700 Comment on attachment 439510 Patch R=me. 1798024 4 bfulgham 2021-09-28 13:49:37 -0700 Tested on device and confirmed no findings. 1798032 5 ews-feeder 2021-09-28 14:16:36 -0700 Committed r283195 (242242@main): <https://commits.webkit.org/242242@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439510. 439510 2021-09-28 13:22:59 -0700 2021-09-28 14:16:36 -0700 Patch bug-230909-20210928132259.patch text/plain 4733 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJlZWViNDI2OTU3YTBmZmVj NjJjMTUyODkxZDI1MDZiMWJjZDhhYTkuLjk4ZjM3MTNlZDljOGFiYTdkZmFlNTA5ZjE0NGU1NDYz MTE4N2UzMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDktMjggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBz YW5kYm94IGV4Y2VwdGlvbiBydWxlcyBmb3IgcmVnaXN0ZXJpbmcgbWFjaCBleHRlbnNpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA5MDkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2NTgzNTg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBTYW5kYm94IGltcGxlbWVudGF0aW9uIG9mZmVy cyBhIG1lY2hhbmlzbSBmb3IgYXBwcyB0byBleHRlbmQgdGhlaXIgc2FuZGJveCBhdCBjb21waWxl CisgICAgICAgIHRpbWUuIFdlYktpdCBkb2VzIG5vdCB1c2UgdGhvc2UgZXh0ZW5zaW9ucyBpbiBp dHMgc2FuZGJveCBkZXNpZ24sIHNvIHdlIHNob3VsZCByZW1vdmUgdGhvc2UKKyAgICAgICAgdW51 c2VkIHJ1bGVzLiBUaGV5IGFyZSBsZWZ0LW92ZXIgZnJvbSBpbXBvcnRpbmcgdGhlIGdsb2JhbCBB cHAgU2FuZGJveCBydWxlcyBsb25nIGFnbywgYW5kCisgICAgICAgIGFyZSBub3QgbmVlZGVkIGJ5 IFdlYktpdC4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5h cHBsZS5XZWJLaXQuR1BVLnNiOgorICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMv aW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYjoKKyAgICAgICAgKiBSZXNvdXJjZXMv U2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IuaW46CisK IDIwMjEtMDktMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgRXhwbGljaXRseSBkZW55ICdzeXN0ZW0tcHJpdmlsZWdlJyBpbiB0aGUgc2FuZGJveCBwcm9m aWxlIGFzIGEgaGFyZGVuaW5nIG1lYXN1cmUgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jl c291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIvU291 cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LkdQVS5zYgppbmRleCBjYmI1Yjk5ZjBhNDhhMjIwN2JjMjVkZDBlOTM3MmMyZmQ5MzEyNDA3Li4y MjUwYzE5OGY2ODFmYzQzNzAyNjcwZjhmYWI0Zjc3MzYzZWM3ZGEzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu R1BVLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5HUFUuc2IKQEAgLTUwNywxMiArNTA3LDYgQEAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJjb20uYXBwbGUubWVkaWFzZXJ2ZXJkLnJlYWQtd3Jp dGUiKSkpKQogCiAgICAgOzsgPHJkYXI6Ly9wcm9ibGVtLzE2MDc5MzYxPgotICAgICh3aXRoLWZp bHRlciAoZ2xvYmFsLW5hbWUtcHJlZml4ICIiKQotICAgICAgICAoYWxsb3cgbWFjaC1yZWdpc3Rl ciAod2l0aCB0ZWxlbWV0cnkpCi0gICAgICAgICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUu c2VjdXJpdHkuZXhjZXB0aW9uLm1hY2gtcmVnaXN0ZXIuZ2xvYmFsLW5hbWUiKSkpCi0gICAgKHdp dGgtZmlsdGVyIChsb2NhbC1uYW1lLXByZWZpeCAiIikKLSAgICAgICAgKGFsbG93IG1hY2gtcmVn aXN0ZXIgKHdpdGggdGVsZW1ldHJ5KQotICAgICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFw cGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5tYWNoLXJlZ2lzdGVyLmxvY2FsLW5hbWUiKSkpCiAgICAg KGFsbG93LXJlYWQtYW5kLWlzc3VlLWdlbmVyaWMtZXh0ZW5zaW9ucwogICAgICAgICAgICAoZXh0 ZW5zaW9uICJjb20uYXBwbGUuc2VjdXJpdHkuZXhjZXB0aW9uLmZpbGVzLmFic29sdXRlLXBhdGgu cmVhZC1vbmx5IikKICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4 Y2VwdGlvbi5maWxlcy5ob21lLXJlbGF0aXZlLXBhdGgucmVhZC1vbmx5IikpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuTmV0d29ya2luZy5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9m aWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCmluZGV4IDZkYjk4MDAzYTA3 OWJmN2FhOGU5ZTRmMjE5Zjc0N2FkNWNhYjIwYTUuLjk3ZTc4YzkwODdmZmJkZTY0MmMwMGFkNmZi ZTk5NzE4NjQ0MGI2ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCisrKyBiL1NvdXJj ZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5O ZXR3b3JraW5nLnNiCkBAIC0zNjEsMTQgKzM2MSwxMSBAQAogCiAgICAgKHdpdGgtZmlsdGVyIChn bG9iYWwtbmFtZS1wcmVmaXggIiIpCiAgICAgICAgIChhbGxvdyBtYWNoLWxvb2t1cAotICAgICAg ICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5tYWNoLWxv b2t1cC5nbG9iYWwtbmFtZSIpKQotICAgICAgICAoYWxsb3cgbWFjaC1yZWdpc3RlcgotICAgICAg ICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5tYWNoLXJl Z2lzdGVyLmdsb2JhbC1uYW1lIikpKQorICAgICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFw cGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5tYWNoLWxvb2t1cC5nbG9iYWwtbmFtZSIpKSkKICAgICAo d2l0aC1maWx0ZXIgKGxvY2FsLW5hbWUtcHJlZml4ICIiKQogICAgICAgICAoYWxsb3cgbWFjaC1s b29rdXAKICAgICAgICAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5zZWN1cml0eS5leGNl cHRpb24ubWFjaC1sb29rdXAubG9jYWwtbmFtZSIpKQotICAgICAgICAoYWxsb3cgbWFjaC1yZWdp c3RlcgotICAgICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2Vw dGlvbi5tYWNoLXJlZ2lzdGVyLmxvY2FsLW5hbWUiKSkpCisgICAgKQogICAgIChhbGxvdy1yZWFk LWFuZC1pc3N1ZS1nZW5lcmljLWV4dGVuc2lvbnMKICAgICAgICAgICAgKGV4dGVuc2lvbiAiY29t LmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5maWxlcy5hYnNvbHV0ZS1wYXRoLnJlYWQtb25seSIp CiAgICAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBsZS5zZWN1cml0eS5leGNlcHRpb24uZmls ZXMuaG9tZS1yZWxhdGl2ZS1wYXRoLnJlYWQtb25seSIpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9z L2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbgppbmRleCA3YjQyNWE2YmFmZGVmNjI5 ZjRhZjk4NmZmNTcyOGJjNDQyY2VkMzU4Li5kOTZlMDQwMjhlZjMwYTBlN2EzZTFiMDU2MGE3Yjdj MjRjMDU0NTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYi5pbgorKysgYi9Tb3VyY2Uv V2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2Vi Q29udGVudC5zYi5pbgpAQCAtNjI5LDEyICs2MjksNiBAQAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgImNvbS5hcHBsZS5tZWRpYXNlcnZlcmQucmVhZC13cml0ZSIpKSkpCiAK ICAgICA7OyA8cmRhcjovL3Byb2JsZW0vMTYwNzkzNjE+Ci0gICAgKHdpdGgtZmlsdGVyIChnbG9i YWwtbmFtZS1wcmVmaXggIiIpCi0gICAgICAgIChhbGxvdyBtYWNoLXJlZ2lzdGVyCi0gICAgICAg ICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUuc2VjdXJpdHkuZXhjZXB0aW9uLm1hY2gtcmVn aXN0ZXIuZ2xvYmFsLW5hbWUiKSkpCi0gICAgKHdpdGgtZmlsdGVyIChsb2NhbC1uYW1lLXByZWZp eCAiIikKLSAgICAgICAgKGFsbG93IG1hY2gtcmVnaXN0ZXIKLSAgICAgICAgICAgICAgIChleHRl bnNpb24gImNvbS5hcHBsZS5zZWN1cml0eS5leGNlcHRpb24ubWFjaC1yZWdpc3Rlci5sb2NhbC1u YW1lIikpKQogICAgIChhbGxvdy1yZWFkLWFuZC1pc3N1ZS1nZW5lcmljLWV4dGVuc2lvbnMKICAg ICAgICAgICAgKGV4dGVuc2lvbiAiY29tLmFwcGxlLnNlY3VyaXR5LmV4Y2VwdGlvbi5maWxlcy5h YnNvbHV0ZS1wYXRoLnJlYWQtb25seSIpCiAgICAgICAgICAgIChleHRlbnNpb24gImNvbS5hcHBs ZS5zZWN1cml0eS5leGNlcHRpb24uZmlsZXMuaG9tZS1yZWxhdGl2ZS1wYXRoLnJlYWQtb25seSIp KQo=