230871 2021-09-27 18:05:12 -0700 [WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work 2021-09-29 17:01:17 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo don.olmstead ews-watchlist kkinnunen webkit-bug-importer oldest_to_newest 1797725 0 fujii 2021-09-27 18:05:12 -0700 [WinCairo] REGRESSION(r280726): registry keys enabling GPU process mode don't work r270175 (Bug 219294) added registry keys to enable GPU process for WinCairo port. But after r280726 (Bug 228803) changed the function name, they don't work. 1797729 1 fujii 2021-09-27 18:31:26 -0700 1. Set the registry reg add HKEY_CURRENT_USER\Software\WebKit /v gpu_process_canvas_rendering /t REG_DWORD /d 1 /f 2. Start WinCairo WK2 MiniBrowser 3. Go to a web page containing 2D canvas. For example, http://www.kevs3d.co.uk/dev/canvasmark/ 4. Start Windows Task Manager and check if WebKitGPUProcess.exe is spawned 1797732 2 439423 fujii 2021-09-27 18:40:43 -0700 Created attachment 439423 Patch 1798682 3 439423 fujii 2021-09-29 17:00:33 -0700 Comment on attachment 439423 Patch Clearing flags on attachment: 439423 Committed r283284 (242311@main): <https://commits.webkit.org/242311@main> 1798683 4 fujii 2021-09-29 17:00:37 -0700 All reviewed patches have been landed. Closing bug. 1798684 5 webkit-bug-importer 2021-09-29 17:01:17 -0700 <rdar://problem/83695330> 439423 2021-09-27 18:40:43 -0700 2021-09-29 17:00:33 -0700 Patch bug-230871-20210928104042.patch text/plain 4293 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE1ZTJlY2RiNDU1Y2E2NWU2MDZkOWM1 ZmIzMjNiNWFmNTdjMDcyMWEuLmY0MTM2MzdjZDJiNTVlMDkyZjVjZDVjOGQ4Njc2ODVhZjY3MTUy NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDktMjcgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBSRUdSRVNTSU9OKHIy ODA3MjYpOiByZWdpc3RyeSBrZXlzIGVuYWJsaW5nIEdQVSBwcm9jZXNzIG1vZGUgZG9uJ3Qgd29y aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwODcx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYv UGxhdGZvcm1IYXZlLmg6IHIyNzAxNzUgZGVmaW5lZCBIQVZFX1NZU1RFTV9GRUFUVVJFX0ZMQUdT CisgICAgICAgIGZvciBXaW5kb3dzIHRvIHVzZSBXZWJLaXQ6OmlzRmVhdHVyZUZsYWdFbmFibGVk LiBCdXQsIGl0IGlzIG5vCisgICAgICAgIGxvbmdlciBuZWVkZWQuCisKIDIwMjEtMDktMjcgIEpl YW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBWb3JiaXMgZGVjb2Rl ciBjYW4ndCBiZSBpbnN0YW50aWF0ZWQgLSBSZW1vdmUgd29ya2Fyb3VuZCBhZGRlZCBpbiBidWcg MjI4MTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCmluZGV4IDU5Nzg0N2YxNDY0M2VkYmIzYjQ0ZjFkZDJkOTQzMTYyYTVlYTBj YzUuLjdhYmZhNWQ4MmI5NmY3NjM0NTlhZjEwMDM3ZjllMjY2YjMxNDI0ZGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMjEtMDktMjcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVq aWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBSRUdSRVNTSU9OKHIyODA3MjYpOiBy ZWdpc3RyeSBrZXlzIGVuYWJsaW5nIEdQVSBwcm9jZXNzIG1vZGUgZG9uJ3Qgd29yaworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwODcxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI3MDE3NSAoQnVnIDIx OTI5NCkgYWRkZWQgcmVnaXN0cnkga2V5cyB0byBlbmFibGUgR1BVIHByb2Nlc3MKKyAgICAgICAg bW9kZSBmb3IgV2luQ2Fpcm8gcG9ydC4gQnV0IGFmdGVyIHIyODA3MjYgKEJ1ZyAyMjg4MDMpIGNo YW5nZWQgdGhlCisgICAgICAgIGZ1bmN0aW9uIHNpZ25hdHVyZSwgdGhleSBkaWRuJ3Qgd29yay4K KworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuY3BwOgorICAg ICAgICAqIFNoYXJlZC93aW4vV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzV2luLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6aXNGZWF0dXJlRmxhZ0VuYWJsZWQpOgorCiAyMDIxLTA5LTI3ICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgVm9yYmlzIGRlY29kZXIg Y2FuJ3QgYmUgaW5zdGFudGlhdGVkIC0gUmVtb3ZlIHdvcmthcm91bmQgYWRkZWQgaW4gYnVnIDIy ODEzOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmggYi9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAppbmRleCAxOGU0ZDUxMTA2MTA4MGUyZmZhNzIxNTg5YTli ZmI5YjkxNWQxY2FhLi4xOTdmMWJhNzVmNGUwYzJjOWZkNjQwNTg5ZTU1OWMzYzIyNWUzNGNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAorKysgYi9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybUhhdmUuaApAQCAtNjY5LDggKzY2OSw3IEBACiAjaWYgKFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDApIFwKICAgICB8 fCAoUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTUwMDAwKSBcCiAgICAgfHwgKFBMQVRGT1JNKFdBVENIT1MpICYmIF9fV0FUQ0hfT1Nf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gNzAwMDApIFwKLSAgICB8fCAoUExBVEZPUk0oQVBQTEVU VikgJiYgX19UVl9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNDAwMDApIFwKLSAgICB8fCBQ TEFURk9STShXSU4pCisgICAgfHwgKFBMQVRGT1JNKEFQUExFVFYpICYmIF9fVFZfT1NfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTQwMDAwKQogI2RlZmluZSBIQVZFX1NZU1RFTV9GRUFUVVJFX0ZM QUdTIDEKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVm ZXJlbmNlc0RlZmF1bHRWYWx1ZXMuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVy ZW5jZXNEZWZhdWx0VmFsdWVzLmNwcAppbmRleCBmNmZhMTJlODYxZmY0ZjBhZTYxNDViNzM3YWE5 NjI1ODA2NTc5MTk1Li45OGEwNjdiZTIwNGM0MjdkNDc1NjJhY2M1MWQ1NTUwNWQ5MTFiZjNmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1 ZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZh bHVlcy5jcHAKQEAgLTQxLDcgKzQxLDcgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLSNpZiAh UExBVEZPUk0oQ09DT0EpCisjaWYgIVBMQVRGT1JNKENPQ09BKSAmJiAhUExBVEZPUk0oV0lOKQog Ym9vbCBpc0ZlYXR1cmVGbGFnRW5hYmxlZChjb25zdCBjaGFyKiwgYm9vbCBkZWZhdWx0VmFsdWUp CiB7CiAgICAgcmV0dXJuIGRlZmF1bHRWYWx1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL3dpbi9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXNXaW4uY3BwIGIvU291cmNlL1dl YktpdC9TaGFyZWQvd2luL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlc1dpbi5jcHAKaW5kZXgg YWZkNGQ4YTk5YTdiYjhkMzIwNDRlZDJkNzVmZjNkYjE3YzE2Mjk1Ni4uNWUwNGQzNGNkNDgwNjhk NTFlYzk1MzQ0NjA5OTI0Zjk3YWNjNmFlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFy ZWQvd2luL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlc1dpbi5jcHAKKysrIGIvU291cmNlL1dl YktpdC9TaGFyZWQvd2luL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlc1dpbi5jcHAKQEAgLTI2 LDE5ICsyNiwxOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYlByZWZlcmVu Y2VzRGVmYXVsdFZhbHVlcy5oIgogCi0jaWYgSEFWRShTWVNURU1fRkVBVFVSRV9GTEFHUykKLQog I2luY2x1ZGUgPHd0Zi9XaW5kb3dzRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3Ry aW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1ib29sIGlzRmVhdHVyZUZsYWdFbmFibGVk KGNvbnN0IFN0cmluZyYgZmVhdHVyZU5hbWUpCitib29sIGlzRmVhdHVyZUZsYWdFbmFibGVkKGNv bnN0IGNoYXIqIGZlYXR1cmVOYW1lLCBib29sIGRlZmF1bHRWYWx1ZSkKIHsKKyAgICBhdXRvIGZl YXR1cmVOYW1lV2lkZSA9IFN0cmluZyhmZWF0dXJlTmFtZSkud2lkZUNoYXJhY3RlcnMoKTsKICAg ICBEV09SRCBkYXRhOwogICAgIERXT1JEIGRhdGFTaXplID0gc2l6ZW9mIGRhdGE7CiAgICAgRFdP UkQga2V5VHlwZTsKLSAgICBIUkVTVUxUIGhyID0gZ2V0UmVnaXN0cnlWYWx1ZShIS0VZX0NVUlJF TlRfVVNFUiwgTCJTb2Z0d2FyZVxcV2ViS2l0IiwgZmVhdHVyZU5hbWUud2lkZUNoYXJhY3RlcnMo KS5kYXRhKCksICZrZXlUeXBlLCAmZGF0YSwgJmRhdGFTaXplKTsKKyAgICBIUkVTVUxUIGhyID0g Z2V0UmVnaXN0cnlWYWx1ZShIS0VZX0NVUlJFTlRfVVNFUiwgTCJTb2Z0d2FyZVxcV2ViS2l0Iiwg ZmVhdHVyZU5hbWVXaWRlLmRhdGEoKSwgJmtleVR5cGUsICZkYXRhLCAmZGF0YVNpemUpOwogICAg IGlmIChociAhPSBFUlJPUl9TVUNDRVNTKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYg KGtleVR5cGUgIT0gUkVHX0RXT1JEKQpAQCAtNDksNSArNDgsMyBAQCBib29sIGlzRmVhdHVyZUZs YWdFbmFibGVkKGNvbnN0IFN0cmluZyYgZmVhdHVyZU5hbWUpCiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdAotCi0jZW5kaWYK