230851 2021-09-27 11:41:12 -0700 Rename Style::queuePostResolutionCallback to Style::deprecatedQueuePostResolutionCallback 2021-09-27 14:22:16 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 203139 1 ntim ntim cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim mifenton simon.fraser webkit-bug-importer oldest_to_newest 1797574 0 ntim 2021-09-27 11:41:12 -0700 According to the WIP patch in bug 203139, the HTML 5 event loop should be used instead. 1797582 1 439375 ntim 2021-09-27 11:53:08 -0700 Created attachment 439375 Patch 1797586 2 439375 simon.fraser 2021-09-27 12:01:10 -0700 Comment on attachment 439375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439375&action=review > Source/WebCore/style/StyleTreeResolver.h:115 > +void deprecatedQueuePostResolutionCallback(Function<void()>&&); // Integrate with the HTML5 event loop instead. I think this comment could be more helpful. Where in the code should I do stuff instead of calling this function? 1797643 3 ntim 2021-09-27 14:21:49 -0700 Committed r283134 (242191@main): <https://commits.webkit.org/242191@main> 1797644 4 webkit-bug-importer 2021-09-27 14:22:16 -0700 <rdar://problem/83591148> 439375 2021-09-27 11:53:08 -0700 2021-09-27 12:01:10 -0700 Patch bug-230851-20210927205307.patch text/plain 5214 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5NGU5MDM4NmZlNjM5 YWFhZDdlYjBlYTZkZTZjOWMwZDE4YTU3Zi4uYTI4NjM2ZDA2NTA2YjdjNTI5MWIzMWJkZTQ2OTE2 OTBkM2NmMmM0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTA5LTI3ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuYW1lIFN0eWxlOjpxdWV1ZVBv c3RSZXNvbHV0aW9uQ2FsbGJhY2sgdG8gU3R5bGU6OmRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0 aW9uQ2FsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzMDg1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBIVE1MNSBldmVudCBsb29wIHNob3VsZCBiZSB1c2VkIGluc3RlYWQuCisgICAgICAg IEFsc28gZml4IHByZS1leGlzdGluZyB3ZWJraXQtc3R5bGUgZXJyb3JzLgorCisgICAgICAgICog aHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxG b3JtQ29udHJvbEVsZW1lbnQ6OmRpZEF0dGFjaFJlbmRlcmVycyk6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpkaWRSZWNhbGNTdHlsZSk6CisgICAgICAgICogaHRt bC9IVE1MRnJhbWVPd25lckVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZyYW1l T3duZXJFbGVtZW50OjpzY2hlZHVsZUludmFsaWRhdGVTdHlsZUFuZExheWVyQ29tcG9zaXRpb24p OgorICAgICAgICAqIGh0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MUGx1Z0luSW1hZ2VFbGVtZW50OjpzY2hlZHVsZVVwZGF0ZUZvckFmdGVyU3R5 bGVSZXNvbHV0aW9uKToKKyAgICAgICAgKiBzdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZTo6ZGVwcmVjYXRlZFF1ZXVlUG9zdFJlc29sdXRpb25DYWxs YmFjayk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6cXVldWVQb3N0UmVzb2x1dGlvbkNhbGxi YWNrKTogRGVsZXRlZC4KKyAgICAgICAgKiBzdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5oOgorCiAy MDIxLTA5LTI3ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFj ZSBOb2RlOjppc0luZXJ0KCkgd2l0aCBSZW5kZXJTdHlsZTo6ZWZmZWN0aXZlSW5lcnQoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXggYTI2 NjJhNjUwZjJjZDg4NDY2MjNkMGM2MTA4NzY3MDdlYmNiZDMwMS4uODk0ZDJlYTk3NjcwYmRhZTU4 Mjk0NWM2YzFmMmE2NDhmODQ4YjhmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0yNTgsNyArMjU4LDcgQEAgdm9pZCBIVE1MRm9ybUNv bnRyb2xFbGVtZW50OjpkaWRBdHRhY2hSZW5kZXJlcnMoKQogICAgICAgICAgICAgICAgIGVsZW1l bnQtPmZvY3VzKHsgU2VsZWN0aW9uUmVzdG9yYXRpb25Nb2RlOjpQbGFjZUNhcmV0QXRTdGFydCB9 KTsKICAgICAgICAgICAgIH0pOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgU3R5bGU6 OnF1ZXVlUG9zdFJlc29sdXRpb25DYWxsYmFjayhbZWxlbWVudF0geworICAgICAgICAgICAgU3R5 bGU6OmRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2soW2VsZW1lbnRdIHsKICAg ICAgICAgICAgICAgICBlbGVtZW50LT5mb2N1cyh7IFNlbGVjdGlvblJlc3RvcmF0aW9uTW9kZTo6 UGxhY2VDYXJldEF0U3RhcnQgfSk7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQpAQCAtMzY2 LDcgKzM2Niw3IEBAIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlkUmVjYWxjU3R5bGUo U3R5bGU6OkNoYW5nZSkKICAgICAvLyB0cmlnZ2VyIHN5bmNocm9ub3VzIGxheW91dCwgc28gaXQg bXVzdCBub3QgYmUgY2FsbGVkIGR1cmluZyBzdHlsZSByZWNhbGMuCiAgICAgaWYgKHJlbmRlcmVy KCkpIHsKICAgICAgICAgUmVmUHRyPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+IGVsZW1lbnQgPSB0 aGlzOwotICAgICAgICBTdHlsZTo6cXVldWVQb3N0UmVzb2x1dGlvbkNhbGxiYWNrKFtlbGVtZW50 XXsKKyAgICAgICAgU3R5bGU6OmRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2so W2VsZW1lbnRdIHsKICAgICAgICAgICAgIGlmIChhdXRvKiByZW5kZXJlciA9IGVsZW1lbnQtPnJl bmRlcmVyKCkpCiAgICAgICAgICAgICAgICAgcmVuZGVyZXItPnVwZGF0ZUZyb21FbGVtZW50KCk7 CiAgICAgICAgIH0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVP d25lckVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVPd25lckVsZW1l bnQuY3BwCmluZGV4IDYwMTY0OTdmMWMxMDJlOWIwNmQ5MzZiMzc3NDcxMjA3YmI2NDlkOTAuLjIx YmIxY2M0ZGFlOGRjNWFmOGFjNTgwMGQ5MDY4ZGE0ZjgxMWEzOTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lT3duZXJFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGcmFtZU93bmVyRWxlbWVudC5jcHAKQEAgLTEyMCw3ICsxMjAsNyBAQCB2 b2lkIEhUTUxGcmFtZU93bmVyRWxlbWVudDo6c2NoZWR1bGVJbnZhbGlkYXRlU3R5bGVBbmRMYXll ckNvbXBvc2l0aW9uKCkKIHsKICAgICBpZiAoU3R5bGU6OnBvc3RSZXNvbHV0aW9uQ2FsbGJhY2tz QXJlU3VzcGVuZGVkKCkpIHsKICAgICAgICAgUmVmUHRyPEhUTUxGcmFtZU93bmVyRWxlbWVudD4g ZWxlbWVudCA9IHRoaXM7Ci0gICAgICAgIFN0eWxlOjpxdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJh Y2soW2VsZW1lbnRdIHsKKyAgICAgICAgU3R5bGU6OmRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0 aW9uQ2FsbGJhY2soW2VsZW1lbnRdIHsKICAgICAgICAgICAgIGVsZW1lbnQtPmludmFsaWRhdGVT dHlsZUFuZExheWVyQ29tcG9zaXRpb24oKTsKICAgICAgICAgfSk7CiAgICAgfSBlbHNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAppbmRleCBiZTFm ZWIxYjYxYjBmMDc5NDUyMjgxY2ZkNWFiODEzOWI5ODY1YzQwLi4xYWFlYTY5NjFkZmE1NTZhMDdk YjExNjVhYjVlMzZhZTBlMjBlMzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBs dWdJbkltYWdlRWxlbWVudC5jcHAKQEAgLTE5NSw3ICsxOTUsNyBAQCB2b2lkIEhUTUxQbHVnSW5J bWFnZUVsZW1lbnQ6OnNjaGVkdWxlVXBkYXRlRm9yQWZ0ZXJTdHlsZVJlc29sdXRpb24oKQogCiAg ICAgbV9oYXNVcGRhdGVTY2hlZHVsZWRGb3JBZnRlclN0eWxlUmVzb2x1dGlvbiA9IHRydWU7CiAK LSAgICBTdHlsZTo6cXVldWVQb3N0UmVzb2x1dGlvbkNhbGxiYWNrKFtwcm90ZWN0ZWRUaGlzID0g UmVmIHsgKnRoaXMgfV0geworICAgIFN0eWxlOjpkZXByZWNhdGVkUXVldWVQb3N0UmVzb2x1dGlv bkNhbGxiYWNrKFtwcm90ZWN0ZWRUaGlzID0gUmVmIHsgKnRoaXMgfV0gewogICAgICAgICBwcm90 ZWN0ZWRUaGlzLT51cGRhdGVBZnRlclN0eWxlUmVzb2x1dGlvbigpOwogICAgIH0pOwogfQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVUcmVlUmVzb2x2ZXIuY3BwCmluZGV4IDIyZmU4ZGYwNjMy NTc5NTE1ZmU4YWU4MmFiYzFmOWQzODU5M2M2NzguLmQyOTIxYjU2OTRiODJmNTJlOWFkMmEwMDRi NzE4MWU3NzNlMmI3MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJl ZVJlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVRyZWVSZXNvbHZl ci5jcHAKQEAgLTY0OCw3ICs2NDgsNyBAQCBzdGF0aWMgVmVjdG9yPFJlZlB0cjxGcmFtZT4+JiBt ZW1vcnlDYWNoZUNsaWVudENhbGxzUmVzdW1lUXVldWUoKQogICAgIHJldHVybiB2ZWN0b3I7CiB9 CiAKLXZvaWQgcXVldWVQb3N0UmVzb2x1dGlvbkNhbGxiYWNrKEZ1bmN0aW9uPHZvaWQgKCk+JiYg Y2FsbGJhY2spCit2b2lkIGRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2soRnVu Y3Rpb248dm9pZCgpPiYmIGNhbGxiYWNrKQogewogICAgIHBvc3RSZXNvbHV0aW9uQ2FsbGJhY2tR dWV1ZSgpLmFwcGVuZChXVEZNb3ZlKGNhbGxiYWNrKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5oIGIvU291cmNlL1dlYkNvcmUvc3R5bGUv U3R5bGVUcmVlUmVzb2x2ZXIuaAppbmRleCA2N2VhMTc3MjE3YzM0YTliMDUyYTgwMmVlMjZjZjI5 YTVlMjY5MDg1Li4xMzdiMjhiNjJmYTczMjk0ZTM2YmY1ZDYzZTFkY2U4YmVlZjJiNjNmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVRyZWVSZXNvbHZlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlVHJlZVJlc29sdmVyLmgKQEAgLTExMiw3ICsxMTIsNyBA QCBwcml2YXRlOgogICAgIHN0ZDo6dW5pcXVlX3B0cjxVcGRhdGU+IG1fdXBkYXRlOwogfTsKIAot dm9pZCBxdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2soRnVuY3Rpb248dm9pZCAoKT4mJik7Cit2 b2lkIGRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2soRnVuY3Rpb248dm9pZCgp PiYmKTsgLy8gSW50ZWdyYXRlIHdpdGggdGhlIEhUTUw1IGV2ZW50IGxvb3AgaW5zdGVhZC4KIGJv b2wgcG9zdFJlc29sdXRpb25DYWxsYmFja3NBcmVTdXNwZW5kZWQoKTsKIAogY2xhc3MgUG9zdFJl c29sdXRpb25DYWxsYmFja0Rpc2FibGVyIHsK