230829 2021-09-27 07:07:05 -0700 [MSE][GStreamer] Don't create MediaSourceTrackGStreamer objects twice for the same track 2021-09-28 09:32:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia ews-watchlist gustavo menard pnormand vjaquez oldest_to_newest 1797442 0 aboya 2021-09-27 07:07:05 -0700 The existing code in SourceBufferPrivateGStreamer::didReceiveInitializationSegment() was not checking if the track already existing, creating and immediately destroying a MediaSourceTrackGStreamer, which then crashed on an assertion (ASSERTION FAILED: m_isRemoved). This fixes the following two tests which were crashing with the former assertion when running in Debug: - media/media-source/media-mp4-h264-partial-abort.html - media/media-source/media-source-abort-resets-parser.html 1797443 1 439350 aboya 2021-09-27 07:07:54 -0700 Created attachment 439350 Patch 1797817 2 439350 calvaris 2021-09-28 03:20:15 -0700 Comment on attachment 439350 Patch Doesn't this need changing the expectations? 1797903 3 aboya 2021-09-28 08:57:00 -0700 (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 439350 [details] > Patch > > Doesn't this need changing the expectations? No, because the expectations were not updated in the first place, they were appearing as unexpected crashes. 1797919 4 ews-feeder 2021-09-28 09:32:37 -0700 Committed r283176 (242224@main): <https://commits.webkit.org/242224@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439350. 439350 2021-09-27 07:07:54 -0700 2021-09-28 09:32:39 -0700 Patch bug-230829-20210927160753.patch text/plain 3835 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyOTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Y4ZGJjYzhkZDhkNTkz MTMwMzhkM2I1ZmZlNmVhMWFjMWZhOTFhYy4uMGUzOTAxMDRlODExYzZhOWQ0ZDNlNzJiYTA2NWYy YTA0YzM5ZDBmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTA5LTI3ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIERvbid0IGNyZWF0ZSBNZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyIG9iamVjdHMgdHdp Y2UgZm9yIHRoZSBzYW1lIHRyYWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMzA4MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgZXhpc3RpbmcgY29kZSBpbgorICAgICAgICBTb3VyY2VCdWZmZXJQ cml2YXRlR1N0cmVhbWVyOjpkaWRSZWNlaXZlSW5pdGlhbGl6YXRpb25TZWdtZW50KCkKKyAgICAg ICAgd2FzIG5vdCBjaGVja2luZyBpZiB0aGUgdHJhY2sgYWxyZWFkeSBleGlzdGluZywgY3JlYXRp bmcgYW5kCisgICAgICAgIGltbWVkaWF0ZWx5IGRlc3Ryb3lpbmcgYSBNZWRpYVNvdXJjZVRyYWNr R1N0cmVhbWVyLCB3aGljaCB0aGVuIGNyYXNoZWQKKyAgICAgICAgb24gYW4gYXNzZXJ0aW9uIChB U1NFUlRJT04gRkFJTEVEOiBtX2lzUmVtb3ZlZCkuCisKKyAgICAgICAgVGhpcyBmaXhlcyB0aGUg Zm9sbG93aW5nIHR3byB0ZXN0cyB3aGljaCB3ZXJlIGNyYXNoaW5nIHdpdGggdGhlIGZvcm1lcgor ICAgICAgICBhc3NlcnRpb24gd2hlbiBydW5uaW5nIGluIERlYnVnOgorCisgICAgICAgIC0gbWVk aWEvbWVkaWEtc291cmNlL21lZGlhLW1wNC1oMjY0LXBhcnRpYWwtYWJvcnQuaHRtbAorICAgICAg ICAtIG1lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtYWJvcnQtcmVzZXRzLXBhcnNlci5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1 ZmZlclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVy UHJpdmF0ZUdTdHJlYW1lcjo6ZGlkUmVjZWl2ZUluaXRpYWxpemF0aW9uU2VnbWVudCk6CisKIDIw MjEtMDktMjIgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBN YWtlIFNoYXJlZEJ1ZmZlciBpbmhlcml0IGZyb20gVGhyZWFkU2FmZVJlZkNvdW50ZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvU291 cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuY3BwCmlu ZGV4IDNmNTU3MGE2ODI1ODkyNGJmMTJlMmMwYTVkZDdmMjgyMGZjNTNhNDMuLmM5ZTAxZTg1NDc2 OTY2M2RjOGU3NzA0N2FmODkwYzkwYzg0OTM5MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJl YW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L21zZS9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMjA5LDE3ICsyMDksMjAg QEAgdm9pZCBTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyOjpkaWRSZWNlaXZlSW5pdGlhbGl6 YXRpb25TZWdtZW50KFNvdXJjZUJ1ZmZlclAKICAgICBmb3IgKGF1dG8mIHRyYWNrSW5mbyA6IGlu aXRpYWxpemF0aW9uU2VnbWVudC52aWRlb1RyYWNrcykgewogICAgICAgICBHUmVmUHRyPEdzdENh cHM+IGluaXRpYWxDYXBzID0gc3RhdGljX2Nhc3Q8VmlkZW9UcmFja1ByaXZhdGVHU3RyZWFtZXIq Pih0cmFja0luZm8udHJhY2suZ2V0KCkpLT5pbml0aWFsQ2FwcygpOwogICAgICAgICBBU1NFUlQo aW5pdGlhbENhcHMpOwotICAgICAgICBtX3RyYWNrcy5hZGQodHJhY2tJbmZvLnRyYWNrLT5pZCgp LCBNZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyOjpjcmVhdGUoVHJhY2tQcml2YXRlQmFzZUdTdHJl YW1lcjo6VHJhY2tUeXBlOjpWaWRlbywgdHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBXVEZNb3ZlKGlu aXRpYWxDYXBzKSkpOworICAgICAgICBpZiAoIW1fdHJhY2tzLmNvbnRhaW5zKHRyYWNrSW5mby50 cmFjay0+aWQoKSkpCisgICAgICAgICAgICBtX3RyYWNrcy5hZGQodHJhY2tJbmZvLnRyYWNrLT5p ZCgpLCBNZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyOjpjcmVhdGUoVHJhY2tQcml2YXRlQmFzZUdT dHJlYW1lcjo6VHJhY2tUeXBlOjpWaWRlbywgdHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBXVEZNb3Zl KGluaXRpYWxDYXBzKSkpOwogICAgIH0KICAgICBmb3IgKGF1dG8mIHRyYWNrSW5mbyA6IGluaXRp YWxpemF0aW9uU2VnbWVudC5hdWRpb1RyYWNrcykgewogICAgICAgICBHUmVmUHRyPEdzdENhcHM+ IGluaXRpYWxDYXBzID0gc3RhdGljX2Nhc3Q8QXVkaW9UcmFja1ByaXZhdGVHU3RyZWFtZXIqPih0 cmFja0luZm8udHJhY2suZ2V0KCkpLT5pbml0aWFsQ2FwcygpOwogICAgICAgICBBU1NFUlQoaW5p dGlhbENhcHMpOwotICAgICAgICBtX3RyYWNrcy5hZGQodHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBN ZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyOjpjcmVhdGUoVHJhY2tQcml2YXRlQmFzZUdTdHJlYW1l cjo6VHJhY2tUeXBlOjpBdWRpbywgdHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBXVEZNb3ZlKGluaXRp YWxDYXBzKSkpOworICAgICAgICBpZiAoIW1fdHJhY2tzLmNvbnRhaW5zKHRyYWNrSW5mby50cmFj ay0+aWQoKSkpCisgICAgICAgICAgICBtX3RyYWNrcy5hZGQodHJhY2tJbmZvLnRyYWNrLT5pZCgp LCBNZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyOjpjcmVhdGUoVHJhY2tQcml2YXRlQmFzZUdTdHJl YW1lcjo6VHJhY2tUeXBlOjpBdWRpbywgdHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBXVEZNb3ZlKGlu aXRpYWxDYXBzKSkpOwogICAgIH0KICAgICBmb3IgKGF1dG8mIHRyYWNrSW5mbyA6IGluaXRpYWxp emF0aW9uU2VnbWVudC50ZXh0VHJhY2tzKSB7CiAgICAgICAgIEdSZWZQdHI8R3N0Q2Fwcz4gaW5p dGlhbENhcHMgPSBzdGF0aWNfY2FzdDxJbmJhbmRUZXh0VHJhY2tQcml2YXRlR1N0cmVhbWVyKj4o dHJhY2tJbmZvLnRyYWNrLmdldCgpKS0+aW5pdGlhbENhcHMoKTsKICAgICAgICAgQVNTRVJUKGlu aXRpYWxDYXBzKTsKLSAgICAgICAgbV90cmFja3MuYWRkKHRyYWNrSW5mby50cmFjay0+aWQoKSwg TWVkaWFTb3VyY2VUcmFja0dTdHJlYW1lcjo6Y3JlYXRlKFRyYWNrUHJpdmF0ZUJhc2VHU3RyZWFt ZXI6OlRyYWNrVHlwZTo6VGV4dCwgdHJhY2tJbmZvLnRyYWNrLT5pZCgpLCBXVEZNb3ZlKGluaXRp YWxDYXBzKSkpOworICAgICAgICBpZiAoIW1fdHJhY2tzLmNvbnRhaW5zKHRyYWNrSW5mby50cmFj ay0+aWQoKSkpCisgICAgICAgICAgICBtX3RyYWNrcy5hZGQodHJhY2tJbmZvLnRyYWNrLT5pZCgp LCBNZWRpYVNvdXJjZVRyYWNrR1N0cmVhbWVyOjpjcmVhdGUoVHJhY2tQcml2YXRlQmFzZUdTdHJl YW1lcjo6VHJhY2tUeXBlOjpUZXh0LCB0cmFja0luZm8udHJhY2stPmlkKCksIFdURk1vdmUoaW5p dGlhbENhcHMpKSk7CiAgICAgfQogCiAgICAgbV9tZWRpYVNvdXJjZS0+c3RhcnRQbGF5YmFja0lm SGFzQWxsVHJhY2tzKCk7Cg==