230818 2021-09-26 23:16:26 -0700 [Curl] Set CURL_LOCK_DATA_SSL_SESSION option to reduce SSL/TLS handshake time 2021-09-28 20:16:57 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 takashi.komori takashi.komori basuke chris.reid don.olmstead ews-watchlist fujii galpeter ross.kirsling stephan.szabo takashi.komori webkit-bug-importer oldest_to_newest 1797368 0 takashi.komori 2021-09-26 23:16:26 -0700 By setting CURL_LOCK_DATA_SSL_SESSION option, libcurl uses the same Session ID when another connection connects the same server. It reduces SSL/TLS handshake time. https://curl.se/libcurl/c/curl_share_setopt.html 1797371 1 439320 takashi.komori 2021-09-26 23:27:26 -0700 Created attachment 439320 Patch 1797381 2 439320 fujii 2021-09-27 00:34:22 -0700 Comment on attachment 439320 Patch LGTM 1797649 3 ews-feeder 2021-09-27 14:28:25 -0700 Committed r283136 (242193@main): <https://commits.webkit.org/242193@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439320. 1797650 4 webkit-bug-importer 2021-09-27 14:29:17 -0700 <rdar://problem/83591509> 1797860 5 fujii 2021-09-28 06:15:50 -0700 WinCairo-64-bit-WKL-Debug-Tests is crashing. Reopened. https://build.webkit.org/#/builders/32/builds/1031 SHOULD NEVER BE REACHED ..\..\Source\WebCore\platform\network\curl\CurlContext.cpp(211) : WebCore::CurlShareHandle::mutexFor Regressions: Unexpected crashes (34) http/tests/IndexedDB/collect-IDB-objects.https.html [ Crash ] http/tests/IndexedDB/storage-limit-1.https.html [ Crash ] http/tests/IndexedDB/storage-limit-2.https.html [ Crash ] http/tests/IndexedDB/storage-limit.https.html [ Crash ] http/tests/eventloop/documents-with-different-protocols-do-not-share-event-loop.html [ Crash ] http/tests/misc/dns-prefetch-control.html [ Crash ] http/tests/misc/webtiming-ssl.py [ Crash ] [...] 1797863 6 fujii 2021-09-28 06:21:31 -0700 Committed r283166 (242214@main): <https://commits.webkit.org/242214@main> 1797864 7 fujii 2021-09-28 06:22:20 -0700 Reverted. Reopened. 1798020 8 439514 takashi.komori 2021-09-28 13:47:05 -0700 Created attachment 439514 Patch 1798077 9 takashi.komori 2021-09-28 15:43:00 -0700 (In reply to Fujii Hironori from comment #5) > WinCairo-64-bit-WKL-Debug-Tests is crashing. Reopened. > > https://build.webkit.org/#/builders/32/builds/1031 > > SHOULD NEVER BE REACHED > ..\..\Source\WebCore\platform\network\curl\CurlContext.cpp(211) : > WebCore::CurlShareHandle::mutexFor > > Regressions: Unexpected crashes (34) > http/tests/IndexedDB/collect-IDB-objects.https.html [ Crash ] > http/tests/IndexedDB/storage-limit-1.https.html [ Crash ] > http/tests/IndexedDB/storage-limit-2.https.html [ Crash ] > http/tests/IndexedDB/storage-limit.https.html [ Crash ] > > http/tests/eventloop/documents-with-different-protocols-do-not-share-event- > loop.html [ Crash ] > http/tests/misc/dns-prefetch-control.html [ Crash ] > http/tests/misc/webtiming-ssl.py [ Crash ] > [...] The cause of the crash was that we didn't have code for exclusive control for shared SSL session. We fixed it. 1798156 10 439514 takashi.komori 2021-09-28 20:16:53 -0700 Comment on attachment 439514 Patch Clearing flags on attachment: 439514 Committed r283208 (242250@main): <https://commits.webkit.org/242250@main> 1798157 11 takashi.komori 2021-09-28 20:16:57 -0700 All reviewed patches have been landed. Closing bug. 439320 2021-09-26 23:27:26 -0700 2021-09-28 13:47:03 -0700 Patch bug-230818-20210927152704.patch text/plain 1732 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM2ODYyOWE0MWM0ZWY4 ZTg5NWIxOWI1YjVmZTljN2JjMDgxZDhiMC4uMjIwZjA4ZGZkNDM3N2Y0ZDAzNTdmMDQ4Mjg4YjAx YWNlYjIwMzgzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA5LTI2ICBUYWth c2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29tPgorCisgICAgICAgIFtDdXJsXSBT ZXQgQ1VSTF9MT0NLX0RBVEFfU1NMX1NFU1NJT04gb3B0aW9uIHRvIHJlZHVjZSBTU0wvVExTIGhh bmRzaGFrZSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzA4MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTZXQgQ1VSTF9MT0NLX0RBVEFfU1NMX1NFU1NJT04gb3B0aW9uIHRvIHJldXNlIFNlc3Np b24gSUQuCisgICAgICAgIEl0IHJlZHVjZXMgU1NML1RMUyBoYW5kc2hha2UgdGltZS4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0 d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxTaGFyZUhh bmRsZTo6Q3VybFNoYXJlSGFuZGxlKToKKwogMjAyMS0wOS0yNiAgSmVhbi1ZdmVzIEF2ZW5hcmQg IDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIFtNU0VdIGFwcGVuZGluZyB0byB0aGUgc291cmNl IGJ1ZmZlciB3aWxsIG5vdCB0aHJvdyB3aGVuIHRoZSBzb3VyY2UgYnVmZmVyIGlzIGZ1bGwuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRl eHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDb250ZXh0 LmNwcAppbmRleCBkMTRmYzkwODBiMDhkMzA3OTFlOTdjMGUzZDM2MDBiOTlkZWQ1ZTdjLi44NDJl ZGFiYWU3ZTM0NTExN2E1YTE4NzMwMTZlZTU5ODYwOWQwZjc3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5jcHAKQEAgLTE3MSw2 ICsxNzEsNyBAQCBDdXJsU2hhcmVIYW5kbGU6OkN1cmxTaGFyZUhhbmRsZSgpCiAgICAgbV9zaGFy ZUhhbmRsZSA9IGN1cmxfc2hhcmVfaW5pdCgpOwogICAgIGN1cmxfc2hhcmVfc2V0b3B0KG1fc2hh cmVIYW5kbGUsIENVUkxTSE9QVF9TSEFSRSwgQ1VSTF9MT0NLX0RBVEFfQ09PS0lFKTsKICAgICBj dXJsX3NoYXJlX3NldG9wdChtX3NoYXJlSGFuZGxlLCBDVVJMU0hPUFRfU0hBUkUsIENVUkxfTE9D S19EQVRBX0ROUyk7CisgICAgY3VybF9zaGFyZV9zZXRvcHQobV9zaGFyZUhhbmRsZSwgQ1VSTFNI T1BUX1NIQVJFLCBDVVJMX0xPQ0tfREFUQV9TU0xfU0VTU0lPTik7CiAgICAgY3VybF9zaGFyZV9z ZXRvcHQobV9zaGFyZUhhbmRsZSwgQ1VSTFNIT1BUX0xPQ0tGVU5DLCBsb2NrQ2FsbGJhY2spOwog ICAgIGN1cmxfc2hhcmVfc2V0b3B0KG1fc2hhcmVIYW5kbGUsIENVUkxTSE9QVF9VTkxPQ0tGVU5D LCB1bmxvY2tDYWxsYmFjayk7CiB9Cg== 439514 2021-09-28 13:47:05 -0700 2021-09-28 20:16:53 -0700 Patch bug-230818-20210929054632.patch text/plain 2331 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzM1OGZmN2M3MjhkYWYz ZDJjNjdmODdiZTM0MWM0NTg1NzAyZDVlMC4uOTBiZjRlNjIwYzQzYzAzZTNhYjkxYzNmODU0YTc1 ZjQ1ZDg2M2Y1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA5LTI4ICBUYWth c2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29tPgorCisgICAgICAgIFtDdXJsXSBT ZXQgQ1VSTF9MT0NLX0RBVEFfU1NMX1NFU1NJT04gb3B0aW9uIHRvIHJlZHVjZSBTU0wvVExTIGhh bmRzaGFrZSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzA4MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTZXQgQ1VSTF9MT0NLX0RBVEFfU1NMX1NFU1NJT04gb3B0aW9uIHRvIHJldXNlIFNlc3Np b24gSUQuCisgICAgICAgIEl0IHJlZHVjZXMgU1NML1RMUyBoYW5kc2hha2UgdGltZS4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0 d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxTaGFyZUhh bmRsZTo6Q3VybFNoYXJlSGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxTaGFyZUhhbmRs ZTo6bXV0ZXhGb3IpOgorCiAyMDIxLTA5LTI3ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVuYW1lIFN0eWxlOjpxdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2sgdG8g U3R5bGU6OmRlcHJlY2F0ZWRRdWV1ZVBvc3RSZXNvbHV0aW9uQ2FsbGJhY2sKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuY3BwCmluZGV4 IGQxNGZjOTA4MGIwOGQzMDc5MWU5N2MwZTNkMzYwMGI5OWRlZDVlN2MuLjI0ZDFjN2Q3MDY1MDE2 ZTU1MmU5ZmM2ZTllZDkyOGE1MTAyOTJkNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcApAQCAtMTcxLDYgKzE3MSw3IEBA IEN1cmxTaGFyZUhhbmRsZTo6Q3VybFNoYXJlSGFuZGxlKCkKICAgICBtX3NoYXJlSGFuZGxlID0g Y3VybF9zaGFyZV9pbml0KCk7CiAgICAgY3VybF9zaGFyZV9zZXRvcHQobV9zaGFyZUhhbmRsZSwg Q1VSTFNIT1BUX1NIQVJFLCBDVVJMX0xPQ0tfREFUQV9DT09LSUUpOwogICAgIGN1cmxfc2hhcmVf c2V0b3B0KG1fc2hhcmVIYW5kbGUsIENVUkxTSE9QVF9TSEFSRSwgQ1VSTF9MT0NLX0RBVEFfRE5T KTsKKyAgICBjdXJsX3NoYXJlX3NldG9wdChtX3NoYXJlSGFuZGxlLCBDVVJMU0hPUFRfU0hBUkUs IENVUkxfTE9DS19EQVRBX1NTTF9TRVNTSU9OKTsKICAgICBjdXJsX3NoYXJlX3NldG9wdChtX3No YXJlSGFuZGxlLCBDVVJMU0hPUFRfTE9DS0ZVTkMsIGxvY2tDYWxsYmFjayk7CiAgICAgY3VybF9z aGFyZV9zZXRvcHQobV9zaGFyZUhhbmRsZSwgQ1VSTFNIT1BUX1VOTE9DS0ZVTkMsIHVubG9ja0Nh bGxiYWNrKTsKIH0KQEAgLTE5OCw2ICsxOTksNyBAQCBMb2NrKiBDdXJsU2hhcmVIYW5kbGU6Om11 dGV4Rm9yKGN1cmxfbG9ja19kYXRhIGRhdGEpCiAgICAgc3RhdGljIExvY2sgY29va2llTXV0ZXg7 CiAgICAgc3RhdGljIExvY2sgZG5zTXV0ZXg7CiAgICAgc3RhdGljIExvY2sgc2hhcmVNdXRleDsK KyAgICBzdGF0aWMgTG9jayBzc2xTZXNzaW9uTXV0ZXg7CiAKICAgICBzd2l0Y2ggKGRhdGEpIHsK ICAgICBjYXNlIENVUkxfTE9DS19EQVRBX0NPT0tJRToKQEAgLTIwNiw2ICsyMDgsOCBAQCBMb2Nr KiBDdXJsU2hhcmVIYW5kbGU6Om11dGV4Rm9yKGN1cmxfbG9ja19kYXRhIGRhdGEpCiAgICAgICAg IHJldHVybiAmZG5zTXV0ZXg7CiAgICAgY2FzZSBDVVJMX0xPQ0tfREFUQV9TSEFSRToKICAgICAg ICAgcmV0dXJuICZzaGFyZU11dGV4OworICAgIGNhc2UgQ1VSTF9MT0NLX0RBVEFfU1NMX1NFU1NJ T046CisgICAgICAgIHJldHVybiAmc3NsU2Vzc2lvbk11dGV4OwogICAgIGRlZmF1bHQ6CiAgICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsK