230816 2021-09-26 21:35:40 -0700 prepare-ChangeLog does not show the correct result with using --git-commit 2021-10-05 03:36:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dvh webkit-unassigned jbedard webkit-bug-importer youennf oldest_to_newest 1797357 0 dvh 2021-09-26 21:35:40 -0700 After deleting some function in a commit, using the following command won't show the deleted functions in the list of modified functions. $ prepare-ChangeLog --no-write --no-style --only-files -g HEAD The cause of the bug is that the originalFile() function will pick the incorrect reference version of the file to compare with the version of the commit. 1797359 1 439313 dvh 2021-09-26 21:40:19 -0700 Created attachment 439313 Patch 1797365 2 439317 dvh 2021-09-26 22:33:30 -0700 Created attachment 439317 Patch 1797485 3 ews-feeder 2021-09-27 08:50:56 -0700 Committed r283112 (242170@main): <https://commits.webkit.org/242170@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439317. 1797486 4 webkit-bug-importer 2021-09-27 08:51:16 -0700 <rdar://problem/83575118> 1800498 5 youennf 2021-10-05 03:36:29 -0700 When doing Tools/Scripts/prepare-ChangeLog -g HEAD~1..HEAD -b XYZ, I now get some errors like: Use of uninitialized value $first_line in pattern match (m//) at Tools/Scripts/prepare-ChangeLog line 783. Reverting the commit removes the error. 439313 2021-09-26 21:40:19 -0700 2021-09-26 22:33:27 -0700 Patch bug-230816-20210926214019.patch text/plain 1517 dvh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMDk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDhlNWU2NTVkMmMyN2NiNmRjMjZjZDZmM2UzYmYzOGNi NmE5M2RhMi4uMjY2ZDA1MzM2N2RmNDliN2E3ZTRkYmM2NTFhNTFjOGRiYjJhZTVhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA5LTI2ICBIb2EgRGluaCAgPGR2aEBhcHBsZS5jb20+CisKKyAgICAgICAgcHJl cGFyZS1DaGFuZ2VMb2cgZG9lcyBub3Qgc2hvdyB0aGUgY29ycmVjdCByZXN1bHQgd2l0aCB1c2lu ZyAtLWdpdC1jb21taXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMDgxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gd2UgcGFzcyB0aGUgcGFyYW1ldGVyIC0tZ2l0LWNvbW1pdCwgd2UgbmVlZCB0 byB1c2UgdGhlIGNvcnJlY3QgcmVmZXJlbmNlIHZlcnNpb24gd2hlbgorICAgICAgICBjb21wdXRp bmcgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgdmVyc2lvbiBiZWZvcmUgYW5kIGFmdGVyIHRo ZSBjaGFuZ2UuCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgaXQgYnkgcGFzc2luZyB0aGUgdmVy c2lvbiBiZWZvcmUgdGhlIHNwZWNpZmllZCBjb21taXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3By ZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAob3JpZ2luYWxGaWxlKToKKwogMjAyMS0wOS0yNiAg Q29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcmV2ZXJ0aW5nIHIyODMwODMgYW5kIHIyODMwODguCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxv ZwppbmRleCA0NzlkNzc5YTQ0Zjg4NWY3YTE4N2I3YTI4OGJiZDI5OTQwZTRhM2FlLi5kYTg5ODYy OWM2OGZhYzM5NzI5NjM5M2NmMmU0MTI5YWZmYmMxNWI5IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VM b2cKQEAgLTI2OCw3ICsyNjgsOSBAQCBzdWIgb3JpZ2luYWxGaWxlKCQkJCQpCiAgICAgICAgICRj b21tYW5kID0gU1ZOIC4gIiBjYXQgJGVzY2FwZWRQYXRoc1N0cmluZyI7CiAgICAgfSBlbHNpZiAo aXNHaXQoKSkgewogICAgICAgICAkY29tbWFuZCA9IEdJVCAuICIgc2hvdyAiOwotICAgICAgICBp ZiAoJG1lcmdlQmFzZSkgeworICAgICAgICBpZiAoJGdpdENvbW1pdCkgeworICAgICAgICAgICAg JGNvbW1hbmQgLj0gIiRnaXRDb21taXReIjsKKyAgICAgICAgfSBlbHNpZiAoJG1lcmdlQmFzZSkg ewogICAgICAgICAgICAgJGNvbW1hbmQgLj0gIiRtZXJnZUJhc2UiOwogICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgJGNvbW1hbmQgLj0gIkhFQUQiOwo= 439317 2021-09-26 22:33:30 -0700 2021-09-27 08:50:57 -0700 Patch bug-230816-20210926223329.patch text/plain 2284 dvh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgzMDk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDhlNWU2NTVkMmMyN2NiNmRjMjZjZDZmM2UzYmYzOGNi NmE5M2RhMi4uOWZkYjAxM2IzMTZkZTQyMmQzMzZjNWFkY2MxZDY0ZGZhNzU1YTliNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIxLTA5LTI2ICBIb2EgRGluaCAgPGR2aEBhcHBsZS5jb20+CisKKyAgICAgICAgcHJl cGFyZS1DaGFuZ2VMb2cgZG9lcyBub3Qgc2hvdyB0aGUgY29ycmVjdCByZXN1bHQgd2l0aCB1c2lu ZyAtLWdpdC1jb21taXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMDgxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gd2UgcGFzcyB0aGUgcGFyYW1ldGVyIC0tZ2l0LWNvbW1pdCwgd2UgbmVlZCB0 byB1c2UgdGhlIGNvcnJlY3QgcmVmZXJlbmNlIHZlcnNpb24gd2hlbgorICAgICAgICBjb21wdXRp bmcgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiB0aGUgdmVyc2lvbiBiZWZvcmUgYW5kIGFmdGVyIHRo ZSBjaGFuZ2UuCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgaXQgYnkgcGFzc2luZyB0aGUgdmVy c2lvbiBiZWZvcmUgdGhlIHNwZWNpZmllZCBjb21taXQuCisKKyAgICAgICAgQWxzbywgd2hlbiAt LWdpdC1jb21taXQgaXMgdXNlZCwgd2UgbmVlZCBjb21wYXJlIGFnYWluc3QgdGhlIGNvcnJlY3Qg dmVyc2lvbiBvZiB0aGUgZmlsZS4KKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGF0IHBhcnQg YnkgY2FsbGluZyBnaXQgdG8gcmV0cmlldmUgdGhlIGFjY3VyYXRlIHZlcnNpb24uCisKKyAgICAg ICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAob3JpZ2luYWxGaWxlKToK KyAgICAgICAgKGdlbmVyYXRlRnVuY3Rpb25MaXN0cyk6CisKIDIwMjEtMDktMjYgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJl dmVydGluZyByMjgzMDgzIGFuZCByMjgzMDg4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9w cmVwYXJlLUNoYW5nZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXgg NDc5ZDc3OWE0NGY4ODVmN2ExODdiN2EyODhiYmQyOTk0MGU0YTNhZS4uNDEwNjNjMGIxOTcwZjdh MDk1ZDc4ZTAzN2IzZjU3YzBkMmI3YTRmOSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0y NjgsNyArMjY4LDkgQEAgc3ViIG9yaWdpbmFsRmlsZSgkJCQkKQogICAgICAgICAkY29tbWFuZCA9 IFNWTiAuICIgY2F0ICRlc2NhcGVkUGF0aHNTdHJpbmciOwogICAgIH0gZWxzaWYgKGlzR2l0KCkp IHsKICAgICAgICAgJGNvbW1hbmQgPSBHSVQgLiAiIHNob3cgIjsKLSAgICAgICAgaWYgKCRtZXJn ZUJhc2UpIHsKKyAgICAgICAgaWYgKCRnaXRDb21taXQpIHsKKyAgICAgICAgICAgICRjb21tYW5k IC49ICIkZ2l0Q29tbWl0XiI7CisgICAgICAgIH0gZWxzaWYgKCRtZXJnZUJhc2UpIHsKICAgICAg ICAgICAgICRjb21tYW5kIC49ICIkbWVyZ2VCYXNlIjsKICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgICRjb21tYW5kIC49ICJIRUFEIjsKQEAgLTI5MCw3ICsyOTIsMTIgQEAgc3ViIGdlbmVy YXRlRnVuY3Rpb25MaXN0cygkJCQkJCkKICAgICAgICAgfSwKICAgICAgICAgb3BlbkZpbGUgPT4g c3ViICgkKSB7CiAgICAgICAgICAgICBteSAoJGZpbGUpID0gQF87Ci0gICAgICAgICAgICByZXR1 cm4gdW5sZXNzIG9wZW4oU09VUkNFLCAiPCIsICRmaWxlKTsKKyAgICAgICAgICAgIGlmIChpc0dp dCgpICYmICRnaXRDb21taXQgJiYgISRnaXRJbmRleCkgeworICAgICAgICAgICAgICAgIG15ICRj b21tYW5kID0gR0lUIC4gIiBzaG93ICIgLiAiJGdpdENvbW1pdCIgLiAiOickZmlsZSciOworICAg ICAgICAgICAgICAgIHJldHVybiB1bmxlc3Mgb3BlbihTT1VSQ0UsICItfCIsICRjb21tYW5kKTsK KyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgcmV0dXJuIHVubGVzcyBvcGVu KFNPVVJDRSwgIjwiLCAkZmlsZSk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICByZXR1cm4g XCpTT1VSQ0U7CiAgICAgICAgIH0sCiAgICAgICAgIG9wZW5PcmlnaW5hbEZpbGUgPT4gc3ViICgk KSB7Cg==