23071 2009-01-01 19:53:34 -0800 REGRESSION (r39536): New test failures after committing patch in bug 23051 (ICU search) 2009-01-01 20:47:44 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P1 Normal --- 1 simon.fraser darin mitz oldest_to_newest 104016 0 simon.fraser 2009-01-01 19:53:34 -0800 The fix for bug 23051 caused several new test failures: http://build.webkit.org/results/trunk-mac-ppc-pixel/726/results.html Most seem to be whitespace changes: -This tests that a style that affects child elements when hovering over a parent element correctly recalculates the child style. To test manually move the mouse over the red square, it should become green. +This tests that a style that affects child elements when hovering over a parent element correctly recalculates the child style. To test manually move the mouse over the red square, it should become green. 104018 1 darin 2009-01-01 20:13:06 -0800 Oops! I think I can easily roll out the part of the patch that caused these. 104019 2 darin 2009-01-01 20:13:27 -0800 I could have sworn I ran the tests and didn't see those failures. 104020 3 darin 2009-01-01 20:19:30 -0800 I see exactly the mistake I made. The fix is very simple. 104021 4 26359 darin 2009-01-01 20:41:31 -0800 Created attachment 26359 patch 104022 5 darin 2009-01-01 20:47:44 -0800 http://trac.webkit.org/changeset/39541 26359 2009-01-01 20:41:31 -0800 2009-01-01 20:45:07 -0800 patch ICUSearchPatch2.txt text/plain 5600 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTU0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMDEtMDEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAy MzA3MTogUkVHUkVTU0lPTiAocjM5NTM2KTogTmV3IHRlc3QgZmFpbHVyZXMgYWZ0ZXIgY29tbWl0 dGluZyBwYXRjaCBpbiBidWcgMjMwNTEgKElDVSBzZWFyY2gpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA3MQorCisgICAgICAgIEFsc28gZml4IHNv bWUgdGhpbmdzIHRoYXQgRGFuIHN1Z2dlc3RlZCBkdXJpbmcgcmV2aWV3IG9mIHRoZSBJQ1Ugc2Vh cmNoIHBhdGNoIHRoYXQgSSBmb3Jnb3QKKyAgICAgICAgdGhlIGZpcnN0IHRpbWUgYXJvdW5kLgor CisgICAgICAgICogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwOiBVc2UgSUNVIHNlYXJjaCBvbiBh bGwgcGxhdGZvcm1zIHRoYXQgdXNlIElDVSwgbm93IHRoYXQKKyAgICAgICAgd2UndmUgZG91Ymxl IGNoZWNrZWQgaXQgd29ya3MgZXZlcnl3aGVyZSwgcmVtb3ZpbmcgSEFWRV9JQ1VfU0VBUkNIIGVu dGlyZWx5LgorICAgICAgICBSZW1vdmVkIHVudXNlZCBtX2F0QnJlYWsgZGF0YSBtZW1iZXIgZnJv bSB0aGUgbm9uLUlDVSBjb2RlIHBhdGguCisgICAgICAgIChXZWJDb3JlOjpUZXh0SXRlcmF0b3I6 OlRleHRJdGVyYXRvcik6IE1vdmUgbnVsbCBjaGVjayB1cC4KKyAgICAgICAgKFdlYkNvcmU6OlRl eHRJdGVyYXRvcjo6aGFuZGxlVGV4dEJveCk6IEZpeCBtaXN0YWtlIHRoYXQgbWFkZSB0aGUgaXRl cmF0b3IgaW5jbHVkZQorICAgICAgICBjb2xsYXBzZWQgd2hpdGVzcGFjZS4gVGhpcyB3YXMgbGVm dCBvdmVyIGZyb20gYW4gZWFybGllciB2ZXJzaW9uIG9mIHRoZSBwYXRjaC4KKyAgICAgICAgKFdl YkNvcmU6OlNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRlcmF0b3I6OlNpbXBsaWZpZWRCYWNrd2Fy ZHNUZXh0SXRlcmF0b3IpOgorICAgICAgICBNb3ZlIG51bGwgY2hlY2sgdXAuCisKIDIwMDktMDEt MDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIsIE9saXZlciBIdW50CkluZGV4OiBXZWJDb3JlL2VkaXRpbmcv VGV4dEl0ZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJh dG9yLmNwcAkocmV2aXNpb24gMzk1NDApCisrKyBXZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTYgKzQwLDEyIEBACiAjaW5jbHVkZSAiUmVuZGVy VGV4dENvbnRyb2wuaCIKICNpbmNsdWRlICJ2aXNpYmxlX3VuaXRzLmgiCiAKLSNpZiBQTEFURk9S TShNQUMpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1RJR0VSKQotI2RlZmluZSBIQVZFX0lDVV9T RUFSQ0ggMQotI2VuZGlmCi0KLSNpZiBIQVZFKElDVV9TRUFSQ0gpCisjaWYgVVNFKElDVV9VTklD T0RFKQogI2luY2x1ZGUgPHVuaWNvZGUvdXNlYXJjaC5oPgogI2VuZGlmCiAKLXVzaW5nIG5hbWVz cGFjZSBzdGQ7CiB1c2luZyBuYW1lc3BhY2UgV1RGOjpVbmljb2RlOwordXNpbmcgbmFtZXNwYWNl IHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC03Myw3ICs2OSw3IEBAIHB1YmxpYzoK ICAgICBzaXplX3Qgc2VhcmNoKHNpemVfdCYgc3RhcnRPZmZzZXQpOwogICAgIGJvb2wgYXRCcmVh aygpIGNvbnN0OwogCi0jaWYgSEFWRShJQ1VfU0VBUkNIKQorI2lmIFVTRShJQ1VfVU5JQ09ERSkK IAogcHJpdmF0ZToKICAgICBTdHJpbmcgbV90YXJnZXQ7CkBAIC05NSw4ICs5MSw2IEBAIHByaXZh dGU6CiAgICAgYm9vbCBtX2lzQnVmZmVyRnVsbDsKICAgICBzaXplX3QgbV9jdXJzb3I7CiAKLSAg ICBib29sIG1fYXRCcmVhazsKLQogI2VuZGlmCiB9OwogCkBAIC0xMjksMTEgKzEyMywxMSBAQCBU ZXh0SXRlcmF0b3I6OlRleHRJdGVyYXRvcihjb25zdCBSYW5nZSogCiAKICAgICAvLyBnZXQgYW5k IHZhbGlkYXRlIHRoZSByYW5nZSBlbmRwb2ludHMKICAgICBOb2RlKiBzdGFydENvbnRhaW5lciA9 IHItPnN0YXJ0Q29udGFpbmVyKCk7CisgICAgaWYgKCFzdGFydENvbnRhaW5lcikKKyAgICAgICAg cmV0dXJuOwogICAgIGludCBzdGFydE9mZnNldCA9IHItPnN0YXJ0T2Zmc2V0KCk7CiAgICAgTm9k ZSogZW5kQ29udGFpbmVyID0gci0+ZW5kQ29udGFpbmVyKCk7CiAgICAgaW50IGVuZE9mZnNldCA9 IHItPmVuZE9mZnNldCgpOwotICAgIGlmICghc3RhcnRDb250YWluZXIpCi0gICAgICAgIHJldHVy bjsKIAogICAgIC8vIENhbGxlcnMgc2hvdWxkIGJlIGhhbmRpbmcgdXMgd2VsbC1mb3JtZWQgcmFu Z2VzLiBJZiB3ZSBkaXNjb3ZlciB0aGF0IHRoaXMgaXNuJ3QKICAgICAvLyB0aGUgY2FzZSwgd2Ug Y291bGQgY29uc2lkZXIgY2hhbmdpbmcgdGhpcyBhc3NlcnRpb24gdG8gYW4gZWFybHkgcmV0dXJu LgpAQCAtMzU1LDcgKzM0OSw3IEBAIHZvaWQgVGV4dEl0ZXJhdG9yOjpoYW5kbGVUZXh0Qm94KCkK ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBzcGFjZVJ1blN0YXJ0ID0gcnVuU3RhcnQgLSAxOwog ICAgICAgICAgICAgICAgIHdoaWxlIChzcGFjZVJ1blN0YXJ0ID4gMCAmJiBzdHJbc3BhY2VSdW5T dGFydCAtIDFdID09ICcgJykKICAgICAgICAgICAgICAgICAgICAgLS1zcGFjZVJ1blN0YXJ0Owot ICAgICAgICAgICAgICAgIGVtaXRUZXh0KG1fbm9kZSwgc3BhY2VSdW5TdGFydCwgcnVuU3RhcnQp OworICAgICAgICAgICAgICAgIGVtaXRUZXh0KG1fbm9kZSwgc3BhY2VSdW5TdGFydCwgc3BhY2VS dW5TdGFydCArIDEpOwogICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgZW1pdENo YXJhY3RlcignICcsIG1fbm9kZSwgMCwgcnVuU3RhcnQsIHJ1blN0YXJ0KTsKICAgICAgICAgICAg IHJldHVybjsKQEAgLTc4MywxMSArNzc3LDExIEBAIFNpbXBsaWZpZWRCYWNrd2FyZHNUZXh0SXRl cmF0b3I6OlNpbXBsaWYKICAgICAgICAgcmV0dXJuOwogCiAgICAgTm9kZSogc3RhcnROb2RlID0g ci0+c3RhcnRDb250YWluZXIoKTsKKyAgICBpZiAoIXN0YXJ0Tm9kZSkKKyAgICAgICAgcmV0dXJu OwogICAgIE5vZGUqIGVuZE5vZGUgPSByLT5lbmRDb250YWluZXIoKTsKICAgICBpbnQgc3RhcnRP ZmZzZXQgPSByLT5zdGFydE9mZnNldCgpOwogICAgIGludCBlbmRPZmZzZXQgPSByLT5lbmRPZmZz ZXQoKTsKLSAgICBpZiAoIXN0YXJ0Tm9kZSkKLSAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKCFz dGFydE5vZGUtPm9mZnNldEluQ2hhcmFjdGVycygpKSB7CiAgICAgICAgIGlmIChzdGFydE9mZnNl dCA+PSAwICYmIHN0YXJ0T2Zmc2V0IDwgc3RhdGljX2Nhc3Q8aW50PihzdGFydE5vZGUtPmNoaWxk Tm9kZUNvdW50KCkpKSB7CkBAIC0xMTc4LDcgKzExNzIsNyBAQCBjb25zdCBVQ2hhciogV29yZEF3 YXJlSXRlcmF0b3I6OmNoYXJhY3RlCiAKIC8vIC0tLS0tLS0tCiAKLSNpZiBIQVZFKElDVV9TRUFS Q0gpCisjaWYgVVNFKElDVV9VTklDT0RFKQogCiBzdGF0aWMgY29uc3Qgc2l6ZV90IG1pbmltdW1T ZWFyY2hCdWZmZXJTaXplID0gODE5MjsKIApAQCAtMTMyMSw3ICsxMzE1LDcgQEAgaW5saW5lIHNp emVfdCBTZWFyY2hCdWZmZXI6OnNlYXJjaChzaXplXwogICAgIHJldHVybiB1c2VhcmNoX2dldE1h dGNoZWRMZW5ndGgoc2VhcmNoZXIpOwogfQogCi0jZWxzZQorI2Vsc2UgLy8gIUlDVV9VTklDT0RF CiAKIGlubGluZSBTZWFyY2hCdWZmZXI6OlNlYXJjaEJ1ZmZlcihjb25zdCBTdHJpbmcmIHRhcmdl dCwgYm9vbCBpc0Nhc2VTZW5zaXRpdmUpCiAgICAgOiBtX3RhcmdldChpc0Nhc2VTZW5zaXRpdmUg PyB0YXJnZXQgOiB0YXJnZXQuZm9sZENhc2UoKSkKQEAgLTE0MTIsNyArMTQwNiw3IEBAIHNpemVf dCBTZWFyY2hCdWZmZXI6Omxlbmd0aCgpIGNvbnN0CiAgICAgcmV0dXJuIGxlbmd0aDsKIH0KIAot I2VuZGlmCisjZW5kaWYgLy8gIUlDVV9VTklDT0RFCiAKIC8vIC0tLS0tLS0tCiAKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDM5NTQwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1 cm4gb24gdGhlIHJlZ3Jlc3Npb24gdGVzdCBmb3IgSUNVIHNlYXJjaCBvbiBNYWMgT1MgWCBUaWdl ciB0b28uCisgICAgICAgIEl0IHdhcyBhbHJlYWR5IG9uIGZvciBXaW5kb3dzIChieSBhY2NpZGVu dCwgZmFpbGluZyksIGJ1dCBub3cgV2ViQ29yZSBoYXMgYmVlbiBjaGFuZ2VkCisgICAgICAgIHNv IGl0IHNob3VsZCB3b3JrIGZpbmUgb24gYWxsIHBsYXRmb3JtcyB1c2luZyBJQ1UsIHdoaWNoIGlu Y2x1ZGVzIGJvdGggb2YgdGhvc2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtdGlnZXIvZWRp dGluZy9leGVjQ29tbWFuZDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtdGlnZXIv ZWRpdGluZy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLWRpYWNyaXRpY2Fscy1leHBlY3RlZC50eHQ6 IFJlbW92ZWQuCisKIDIwMDktMDEtMDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIsIE9saXZlciBIdW50Cklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIvZWRpdGluZy9leGVjQ29tbWFuZC9m aW5kU3RyaW5nLWRpYWNyaXRpY2Fscy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL2VkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmluZy1k aWFjcml0aWNhbHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAzOTU0MCkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy10aWdlci9lZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRTdHJpbmctZGlhY3Jp dGljYWxzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICswLDAgQEAKLVRlc3Qg Zm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA1MSB3ZWIgcGFn ZSBzZWFyY2hpbmcgc2hvdWxkIHVzZSBJQ1UncyBzZWFyY2ggc28gaXQgY2FuIGlnbm9yZSBkaWFj cml0aWNhbCBkaWZmZXJlbmNlcy4KLQotVGhlIHdvcmQgInPDqWxlY3QiIHNob3VsZCBiZSBzZWxl Y3RlZC4KLQotRkFJTAo=