230702 2021-09-23 11:33:41 -0700 api-ios tests passed (instead of crash or timeout) on buggy patch for Bug 230227 2021-09-27 15:47:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=230227 P2 Normal --- 1 ddkilzer webkit-unassigned aakash_jain ap dewei_zhu thorton oldest_to_newest 1796590 0 ddkilzer 2021-09-23 11:33:41 -0700 api-ios tests in TestWebKitAPI passed (instead of crashing) on patch for Bug 230227. The original commit for Bug 230227 had a bug where `m_weakObserver` was not set on non-macOS platforms (including Mac Catalyst and iOS), which should have caused crashes when running api-ios tests, but did not: Bug 230227: <https://bugs.webkit.org/show_bug.cgi?id=230227> Original commit: <https://commits.webkit.org/changeset/282632/webkit> Commit to fix the bug: <https://trac.webkit.org/changeset/282849/webkit> Test run missing failures: <https://ews-build.webkit.org/#/builders/9/builds/54899> I'm still trying to reproduce the expected failure locally, but I'm filing this to track the issue. 1796591 1 439073 ddkilzer 2021-09-23 11:35:54 -0700 Created attachment 439073 Back out the fix from r282849 This patch should cause crashes in api-ios tests. Posting this to test that theory. 1797306 2 ap 2021-09-26 14:19:25 -0700 Were you able to reproduce locally? 1797672 3 ddkilzer 2021-09-27 15:36:00 -0700 (In reply to Alexey Proskuryakov from comment #2) > Were you able to reproduce locally? No, a ridiculous number of iossim tests timed out even with the bug fixed (on both Big Sur and Monterey), so I gave up trying locally. 1797679 4 thorton 2021-09-27 15:47:56 -0700 (On the other hand, I know of at least 3 people who could reproduce locally, including myself :P so SOMETHING interesting is happening here... but maybe it doesn't matter) 439073 2021-09-23 11:35:54 -0700 2021-09-23 11:35:54 -0700 Back out the fix from r282849 CFNotificationCenter-nullptr-iOS-crash.diff text/plain 1225 ddkilzer ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29s Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENv Y29hLm1tCmluZGV4IGNiODhmZGUyNmI0NC4uNjI2NGI5YjNkM2Y4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KQEAgLTcy NSw4ICs3MjUsNiBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpyZW1vdmVDRk5vdGlmaWNhdGlvbk9i c2VydmVyKENGU3RyaW5nUmVmIG5hbWUsIENGTm90aWZpY2F0aQogCiB2b2lkIFdlYlByb2Nlc3NQ b29sOjpyZWdpc3Rlck5vdGlmaWNhdGlvbk9ic2VydmVycygpCiB7Ci0gICAgbV93ZWFrT2JzZXJ2 ZXIgPSBhZG9wdE5TKFtbV0tQcm9jZXNzUG9vbFdlYWtPYnNlcnZlciBhbGxvY10gaW5pdFdpdGhX ZWFrUHRyOm1ha2VXZWFrUHRyKCp0aGlzKV0pOwotCiAjaWYgIVBMQVRGT1JNKElPU19GQU1JTFkp CiAgICAgbV9wb3dlck9ic2VydmVyID0gbWFrZVVuaXF1ZTxXZWJDb3JlOjpQb3dlck9ic2VydmVy Pihbd2Vha1RoaXMgPSBtYWtlV2Vha1B0cih0aGlzKV0gewogICAgICAgICBpZiAod2Vha1RoaXMp CkBAIC03ODQsNiArNzgyLDggQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6cmVnaXN0ZXJOb3RpZmlj YXRpb25PYnNlcnZlcnMoKQogICAgICAgICBzZXRBcHBsaWNhdGlvbklzQWN0aXZlKGZhbHNlKTsK ICAgICB9XTsKICAgICAKKyAgICBtX3dlYWtPYnNlcnZlciA9IGFkb3B0TlMoW1tXS1Byb2Nlc3NQ b29sV2Vha09ic2VydmVyIGFsbG9jXSBpbml0V2l0aFdlYWtQdHI6bWFrZVdlYWtQdHIoKnRoaXMp XSk7CisKICAgICBhZGRDRk5vdGlmaWNhdGlvbk9ic2VydmVyKGNvbG9yUHJlZmVyZW5jZXNEaWRD aGFuZ2VDYWxsYmFjaywgQXBwbGVDb2xvclByZWZlcmVuY2VzQ2hhbmdlZE5vdGlmaWNhdGlvbiwg Q0ZOb3RpZmljYXRpb25DZW50ZXJHZXREaXN0cmlidXRlZENlbnRlcigpKTsKICNlbGlmICFQTEFU Rk9STShNQUNDQVRBTFlTVCkKICAgICBhZGRDRk5vdGlmaWNhdGlvbk9ic2VydmVyKGJhY2tsaWdo dExldmVsRGlkQ2hhbmdlQ2FsbGJhY2ssIChfX2JyaWRnZSBDRlN0cmluZ1JlZilVSUJhY2tsaWdo dExldmVsQ2hhbmdlZE5vdGlmaWNhdGlvbik7Cg==