230681 2021-09-23 02:12:29 -0700 Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() instead of pointer-events check 2021-09-23 04:56:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 84635 229330 1 ntim ntim bfulgham changseok esprehn+autocc ews-watchlist fred.wang glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1796429 0 ntim 2021-09-23 02:12:29 -0700 visibleToHitTesting() will account for inert as well. 1796430 1 439028 ntim 2021-09-23 02:17:30 -0700 Created attachment 439028 Patch 1796440 2 439028 koivisto 2021-09-23 03:31:25 -0700 Comment on attachment 439028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439028&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1593 > - bool userInteractive = renderer().style().pointerEvents() != PointerEvents::None; > + bool userInteractive = renderer().visibleToHitTesting(); This also adds visibility test but I guess that is fine. 1796456 3 ews-feeder 2021-09-23 04:55:34 -0700 Committed r282957 (242047@main): <https://commits.webkit.org/242047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439028. 1796458 4 webkit-bug-importer 2021-09-23 04:56:42 -0700 <rdar://problem/83442427> 439028 2021-09-23 02:17:30 -0700 2021-09-23 04:55:36 -0700 Patch bug-230681-20210923111728.patch text/plain 1773 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVhZDlmZWQ3N2Q4NzA3 ZTZiM2JjMGUxZGRiMTM2YjlmMDFhNzFiNi4uMTM1Yzc1Y2JiZjA2MDMzNjQ1Mzk0MGI5NjllMzc5 OTYwMGJkNGFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA5LTIzICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHZpc2libGVUb0hpdFRlc3Rp bmcoKSBpbiBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUFmdGVyRGVzY2VuZGFudHMoKSBpbnN0 ZWFkIG9mIHBvaW50ZXItZXZlbnRzIGNoZWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgbmV3IGNoZWNrIHNob3VsZCBhY2NvdW50IGZvciBpbmVy dCBhcyB3ZWxsIG9uY2Ugd2UgaW1wbGVtZW50IGl0IGluIFJlbmRlclN0eWxlLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUFmdGVyRGVzY2VuZGFudHMpOgorCiAyMDIxLTA5LTA5 ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIElt cHJvdmUgdGhlIGhhbmRsaW5nIG9mIENvbXBvc2l0ZUVkaXRDb21tYW5kOjpzcGxpdFRyZWVUb05v ZGUoKSByZXR1cm4gdmFsdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckJhY2tpbmcuY3BwCmluZGV4IDQwNDE0NTY0M2RjNjAwMTBhYTZlZjcyYzYxZjlkYjAyM2E1 OTdkYmMuLmVkZmUwNWFhYzhhM2ZjMjU3M2EwYTNiZGRjY2QyMmRmZWQ4ZmUyYzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0xNTkw LDcgKzE1OTAsNyBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlQWZ0ZXJEZXNjZW5k YW50cygpCiAgICAgaWYgKG1fc2Nyb2xsQ29udGFpbmVyTGF5ZXIpIHsKICAgICAgICAgbV9zY3Jv bGxDb250YWluZXJMYXllci0+c2V0Q29udGVudHNWaXNpYmxlKHJlbmRlcmVyKCkuc3R5bGUoKS52 aXNpYmlsaXR5KCkgPT0gVmlzaWJpbGl0eTo6VmlzaWJsZSk7CiAKLSAgICAgICAgYm9vbCB1c2Vy SW50ZXJhY3RpdmUgPSByZW5kZXJlcigpLnN0eWxlKCkucG9pbnRlckV2ZW50cygpICE9IFBvaW50 ZXJFdmVudHM6Ok5vbmU7CisgICAgICAgIGJvb2wgdXNlckludGVyYWN0aXZlID0gcmVuZGVyZXIo KS52aXNpYmxlVG9IaXRUZXN0aW5nKCk7CiAgICAgICAgIG1fc2Nyb2xsQ29udGFpbmVyTGF5ZXIt PnNldFVzZXJJbnRlcmFjdGlvbkVuYWJsZWQodXNlckludGVyYWN0aXZlKTsKICAgICAgICAgaWYg KG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKQogICAgICAgICAgICAgbV9sYXllckZvckhv cml6b250YWxTY3JvbGxiYXItPnNldFVzZXJJbnRlcmFjdGlvbkVuYWJsZWQodXNlckludGVyYWN0 aXZlKTsK