230680 2021-09-23 02:01:10 -0700 AX: Split out isInert from isAXHidden on AccessibilityObject 2021-09-23 07:25:57 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 230690 84635 165279 1 ntim ntim aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs koivisto samuel_white webkit-bug-importer oldest_to_newest 1796424 0 ntim 2021-09-23 02:01:10 -0700 Reasons to do this are: * Naming of isAXHidden is a bit of a lie * We don't want to inherit inert state from parent to child, like we do for aria-hidden 1796425 1 webkit-bug-importer 2021-09-23 02:01:25 -0700 <rdar://problem/83437885> 1796427 2 439027 ntim 2021-09-23 02:07:18 -0700 Created attachment 439027 Patch 1796455 3 ews-feeder 2021-09-23 04:55:02 -0700 Committed r282956 (242046@main): <https://commits.webkit.org/242046@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439027. 1796470 4 andresg_22 2021-09-23 06:40:45 -0700 (In reply to Tim Nguyen (:ntim) from comment #2) > Created attachment 439027 [details] > Patch Can we add the check for isInert to AccessibilityObject::ignoredFromModalPresence instead? No need to expose isInert in the AXCoreObject interface, so it should be removed from there and from AXIsolatedObject. While you are at it, could you please also remove ignoredFromModalPresence from the AXCoreObject interface and make it a virtual in AccessibilityObject? And also remove it from AXIsolatedObject. Thanks. 439027 2021-09-23 02:07:18 -0700 2021-09-23 04:55:05 -0700 Patch bug-230680-20210923110717.patch text/plain 5733 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVhZDlmZWQ3N2Q4NzA3 ZTZiM2JjMGUxZGRiMTM2YjlmMDFhNzFiNi4uNTRmOGI1NWI0OTQzYjk2NzM3Yjk3MGFlNzg1OWM4 MDQ3YjQ2MTE3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTA5LTIzICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFNwbGl0IG91dCBpc0luZXJ0 IGZyb20gaXNBWEhpZGRlbiBvbiBBY2Nlc3NpYmlsaXR5T2JqZWN0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA2ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWFzb25zIHRvIGRvIHRoaXMgYXJlOgor ICAgICAgICAtIE5hbWluZyBvZiBpc0FYSGlkZGVuIGlzIGEgYml0IG9mIGEgbGllCisgICAgICAg IC0gV2UgZG9uJ3Qgd2FudCB0byBpbmhlcml0IGluZXJ0IHN0YXRlIGZyb20gcGFyZW50IHRvIGNo aWxkIGxpa2Ugd2UgZG8gZm9yIGFyaWEtaGlkZGVuLCBlc3BlY2lhbGx5CisgICAgICAgIGluIHRo ZSBkb2N1bWVudCBpcyBibG9ja2VkIGJ5IG1vZGFsIGRpYWxvZyBjYXNlLCB3aGVyZSB0aGUgbW9k YWwgc2hvdWxkIGJlIGludGVyYWN0YWJsZSB1bmxpa2UgaXRzIGFuY2VzdG9ycy9zaWJsaW5ncy4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Ojppc0FYSGlkZGVuIGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzSW5lcnQgY29uc3QpOgorICAg ICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6ZGVmYXVsdE9iamVjdEluY2x1c2lv biBjb25zdCk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6 CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNlLmg6 CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBWElzb2xhdGVkT2JqZWN0Ojppc0luZXJ0IGNvbnN0KToK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0Lmg6 CisKIDIwMjEtMDktMDkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CiAKICAgICAgICAgSW1wcm92ZSB0aGUgaGFuZGxpbmcgb2YgQ29tcG9zaXRlRWRpdENvbW1hbmQ6 OnNwbGl0VHJlZVRvTm9kZSgpIHJldHVybiB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwCmluZGV4IDJlMTYzZDMzNDYy MjI0ODU3ZmFkMjlmYTBjNjcxOTk2YTMxNDE5ZTIuLjY4MTkzNmY1OGYwZjljOGFkNDNhNDI4NDFi YWMyYTJmMWNmMTIxYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcApAQCAtMzIyNyw5ICszMjI3LDYgQEAgYm9vbCBBY2Nl c3NpYmlsaXR5T2JqZWN0OjphY2Nlc3NpYmlsaXR5SXNJZ25vcmVkQnlEZWZhdWx0KCkgY29uc3QK IC8vIGh0dHA6Ly93d3cudzMub3JnL1RSL3dhaS1hcmlhL3Rlcm1zI2RlZl9oaWRkZW4KIGJvb2wg QWNjZXNzaWJpbGl0eU9iamVjdDo6aXNBWEhpZGRlbigpIGNvbnN0CiB7Ci0gICAgaWYgKG5vZGUo KSAmJiBub2RlKCktPmlzSW5lcnQoKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0KICAgICBpZiAo aXNGb2N1c2VkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKQEAgLTMyNTAsNiArMzI0 NywxMSBAQCBib29sIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmlzRE9NSGlkZGVuKCkgY29uc3QKICAg ICByZXR1cm4gc3R5bGUuZGlzcGxheSgpID09IERpc3BsYXlUeXBlOjpOb25lIHx8IHN0eWxlLnZp c2liaWxpdHkoKSAhPSBWaXNpYmlsaXR5OjpWaXNpYmxlOwogfQogCitib29sIEFjY2Vzc2liaWxp dHlPYmplY3Q6OmlzSW5lcnQoKSBjb25zdAoreworICAgIHJldHVybiBub2RlKCkgJiYgbm9kZSgp LT5pc0luZXJ0KCk7Cit9CisKIGJvb2wgQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNTaG93aW5nVmFs aWRhdGlvbk1lc3NhZ2UoKSBjb25zdAogewogICAgIGlmIChpczxIVE1MRm9ybUNvbnRyb2xFbGVt ZW50Pihub2RlKCkpKQpAQCAtMzI3MSw3ICszMjczLDcgQEAgQWNjZXNzaWJpbGl0eU9iamVjdElu Y2x1c2lvbiBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpkZWZhdWx0T2JqZWN0SW5jbHVzaW9uKCkgY29u c3QKICAgICBpZiAodXNlUGFyZW50RGF0YSA/IG1faXNJZ25vcmVkRnJvbVBhcmVudERhdGEuaXNB WEhpZGRlbiA6IGlzQVhIaWRkZW4oKSkKICAgICAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlPYmpl Y3RJbmNsdXNpb246Oklnbm9yZU9iamVjdDsKICAgICAKLSAgICBpZiAoaWdub3JlZEZyb21Nb2Rh bFByZXNlbmNlKCkpCisgICAgaWYgKGlzSW5lcnQoKSB8fCBpZ25vcmVkRnJvbU1vZGFsUHJlc2Vu Y2UoKSkKICAgICAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlPYmplY3RJbmNsdXNpb246Oklnbm9y ZU9iamVjdDsKICAgICAKICAgICBpZiAodXNlUGFyZW50RGF0YSA/IG1faXNJZ25vcmVkRnJvbVBh cmVudERhdGEuaXNQcmVzZW50YXRpb25hbENoaWxkT2ZBcmlhUm9sZSA6IGlzUHJlc2VudGF0aW9u YWxDaGlsZE9mQXJpYVJvbGUoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKaW5kZXggMjgzOWRhOGQwZTU3MDg4ZTBlYmU3MTg4NTgz ODQwYmZmNWJiOWYwMy4uYTM3NzM4ZTlhMzlhYjYxMDkwOWE1Nzg1NWE4M2QyMzQxMWY3NDZmMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2Jq ZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2Jq ZWN0LmgKQEAgLTcwMCw3ICs3MDAsOCBAQCBwdWJsaWM6CiAgICAgLy8gVmlzaWJpbGl0eS4KICAg ICBib29sIGlzQVhIaWRkZW4oKSBjb25zdCBvdmVycmlkZTsKICAgICBib29sIGlzRE9NSGlkZGVu KCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgYm9vbCBpc0hpZGRlbigpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIGlzQVhIaWRkZW4oKSB8fCBpc0RPTUhpZGRlbigpOyB9CisgICAgYm9vbCBpc0luZXJ0 KCkgY29uc3Qgb3ZlcnJpZGU7CisgICAgYm9vbCBpc0hpZGRlbigpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIGlzQVhIaWRkZW4oKSB8fCBpc0RPTUhpZGRlbigpIHx8IGlzSW5lcnQoKTsgfQogCiAj aWYgUExBVEZPUk0oQ09DT0EpCiAgICAgdm9pZCBvdmVycmlkZUF0dGFjaG1lbnRQYXJlbnQoQVhD b3JlT2JqZWN0KiBwYXJlbnQpIG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0SW50ZXJmYWNlLmggYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZhY2UuaAppbmRleCA4 NTZhZWY5YjE2YTFmM2Q4YTE2NWJkZDFkN2FlYTAzYzRhNDYwOWE5Li5iNDAzNTA3MWRmZmU5ODcz YTQ5MWYxMmZhOWFhN2ZkODMxOWJlYzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZhY2UuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3RJbnRlcmZhY2UuaApAQCAtMTQz OCw2ICsxNDM4LDcgQEAgcHVibGljOgogICAgIC8vIFZpc2liaWxpdHkuCiAgICAgdmlydHVhbCBi b29sIGlzQVhIaWRkZW4oKSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCBib29sIGlzRE9NSGlkZGVu KCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgYm9vbCBpc0luZXJ0KCkgY29uc3QgPSAwOwogICAg IHZpcnR1YWwgYm9vbCBpc0hpZGRlbigpIGNvbnN0ID0gMDsKIAogI2lmIEVOQUJMRShBQ0NFU1NJ QklMSVRZKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRl ZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAppbmRleCAwNjhjYjVkNzAzN2RiOTY1 YjA0MzA2NWQ2MGYwNzIyMzQyZWEwYjg2Li4wNjYzYjgwMTU5OGU4NTAzMWEyMGI2ZDg2ZGJjMzAx OTYxYTczOWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xh dGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcApAQCAtMjMxNyw2ICsyMzE3 LDEyIEBAIGJvb2wgQVhJc29sYXRlZE9iamVjdDo6aXNET01IaWRkZW4oKSBjb25zdAogICAgIHJl dHVybiBmYWxzZTsKIH0KIAorYm9vbCBBWElzb2xhdGVkT2JqZWN0Ojppc0luZXJ0KCkgY29uc3QK K3sKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIGJv b2wgQVhJc29sYXRlZE9iamVjdDo6aXNIaWRkZW4oKSBjb25zdAogewogICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29s YXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5oCmluZGV4IDZhOTM3ZDk4ZDI0OTZhMWQ2 ZDliYjE3OGNiN2NlMTI4YTEwMTg3YjMuLmQ3Y2E3MDc1NWQ5ZjhiYmQ5YmNhN2UxMjhlMDgwZDM0 ZmQ2NTdhNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0 ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmgKQEAgLTY0Miw2ICs2NDIsNyBAQCBw cml2YXRlOgogICAgIGJvb2wgaXNNYXRoTXVsdGlzY3JpcHRPYmplY3QoQWNjZXNzaWJpbGl0eU1h dGhNdWx0aXNjcmlwdE9iamVjdFR5cGUpIGNvbnN0IG92ZXJyaWRlOwogICAgIGJvb2wgaXNBWEhp ZGRlbigpIGNvbnN0IG92ZXJyaWRlOwogICAgIGJvb2wgaXNET01IaWRkZW4oKSBjb25zdCBvdmVy cmlkZTsKKyAgICBib29sIGlzSW5lcnQoKSBjb25zdCBvdmVycmlkZTsKICAgICBib29sIGlzSGlk ZGVuKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdm9pZCBvdmVycmlkZUF0dGFjaG1lbnRQYXJlbnQo QVhDb3JlT2JqZWN0KiBwYXJlbnQpIG92ZXJyaWRlOwogICAgIGJvb2wgYWNjZXNzaWJpbGl0eUln bm9yZUF0dGFjaG1lbnQoKSBjb25zdCBvdmVycmlkZTsK