230678 2021-09-23 01:44:13 -0700 Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()` 2021-09-23 04:51:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 84635 229330 1 ntim ntim ews-watchlist hi inspector-bugzilla-changes joepeck koivisto pangle webkit-bug-importer oldest_to_newest 1796418 0 ntim 2021-09-23 01:44:13 -0700 The definition of isHidden is: bool isHidden() const override { return isAXHidden() || isDOMHidden(); } So it's effectively the same thing. I'm doing this refactoring so I can factor in inert once I split it out from isAXHidden(). 1796421 1 439025 ntim 2021-09-23 01:49:07 -0700 Created attachment 439025 Patch 1796453 2 ews-feeder 2021-09-23 04:50:48 -0700 Committed r282955 (242045@main): <https://commits.webkit.org/242045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439025. 1796454 3 webkit-bug-importer 2021-09-23 04:51:37 -0700 <rdar://problem/83442291> 439025 2021-09-23 01:49:07 -0700 2021-09-23 04:50:49 -0700 Patch bug-230678-20210923104906.patch text/plain 2920 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVhZDlmZWQ3N2Q4NzA3 ZTZiM2JjMGUxZGRiMTM2YjlmMDFhNzFiNi4uMTQ5ODYxODc0NmZlMzYyYjYyYzRiYzEwMmFhNDg1 NDE2OTQ1ODQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA5LTIzICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVwbGFjZSBgYXhPYmplY3QtPmlz QVhIaWRkZW4oKSB8fCBheE9iamVjdC0+aXNET01IaWRkZW4oKWAgd2l0aCBgYXhPYmplY3QtPmlz SGlkZGVuKClgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzA2NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBiZWhhdmlvdXIgY2hhbmdlLiBUaGUgZGVmaW5pdGlvbiBvZiBpc0hpZGRlbiBpczoKKwor ICAgICAgICBgYm9vbCBpc0hpZGRlbigpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIGlzQVhIaWRk ZW4oKSB8fCBpc0RPTUhpZGRlbigpOyB9YAorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv ckF1ZGl0QWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0 b3JBdWRpdEFjY2Vzc2liaWxpdHlPYmplY3Q6OmdldENvbXB1dGVkUHJvcGVydGllcyk6CisgICAg ICAgICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JET01BZ2VudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JBY2Nlc3NpYmlsaXR5UHJv cGVydGllcyk6CisKIDIwMjEtMDktMDkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGln YWxpYS5jb20+CiAKICAgICAgICAgSW1wcm92ZSB0aGUgaGFuZGxpbmcgb2YgQ29tcG9zaXRlRWRp dENvbW1hbmQ6OnNwbGl0VHJlZVRvTm9kZSgpIHJldHVybiB2YWx1ZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBdWRpdEFjY2Vzc2liaWxpdHlPYmplY3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckF1ZGl0QWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKaW5kZXggNjI5ZGYzYzk3Y2MyNTZhYmM0N2IxODE5YzIyMzNmMzY4MmY2ODIz Ni4uMzA5M2Y5YzkyMDMxMjQ5ZGE5Y2M5NGMzMmRlODkxNWMyY2I3OTU5MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckF1ZGl0QWNjZXNzaWJpbGl0eU9iamVj dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckF1ZGl0QWNjZXNz aWJpbGl0eU9iamVjdC5jcHAKQEAgLTE3NSw3ICsxNzUsNyBAQCBFeGNlcHRpb25PcjxzdGQ6Om9w dGlvbmFsPEluc3BlY3RvckF1ZGl0QWNjZXNzaWJpbGl0eU9iamVjdDo6Q29tcHV0ZWRQcm9wZXJ0 aWVzPgogICAgICAgICAgICAgY29tcHV0ZWRQcm9wZXJ0aWVzLmZvY3VzZWQgPSBheE9iamVjdC0+ aXNGb2N1c2VkKCk7CiAKICAgICAgICAgY29tcHV0ZWRQcm9wZXJ0aWVzLmhlYWRpbmdMZXZlbCA9 IGF4T2JqZWN0LT5oZWFkaW5nTGV2ZWwoKTsKLSAgICAgICAgY29tcHV0ZWRQcm9wZXJ0aWVzLmhp ZGRlbiA9IGF4T2JqZWN0LT5pc0FYSGlkZGVuKCkgfHwgYXhPYmplY3QtPmlzRE9NSGlkZGVuKCk7 CisgICAgICAgIGNvbXB1dGVkUHJvcGVydGllcy5oaWRkZW4gPSBheE9iamVjdC0+aXNIaWRkZW4o KTsKICAgICAgICAgY29tcHV0ZWRQcm9wZXJ0aWVzLmhpZXJhcmNoaWNhbExldmVsID0gYXhPYmpl Y3QtPmhpZXJhcmNoaWNhbExldmVsKCk7CiAgICAgICAgIGNvbXB1dGVkUHJvcGVydGllcy5pZ25v cmVkID0gYXhPYmplY3QtPmFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKTsKICAgICAgICAgY29tcHV0 ZWRQcm9wZXJ0aWVzLmlnbm9yZWRCeURlZmF1bHQgPSBheE9iamVjdC0+YWNjZXNzaWJpbGl0eUlz SWdub3JlZEJ5RGVmYXVsdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2FnZW50cy9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv YWdlbnRzL0luc3BlY3RvckRPTUFnZW50LmNwcAppbmRleCBkYWRmYTMwMTIyMDFjMGViMDM2YTE0 MmJhZmE5ZWI1MjhlZmIxYzU2Li5kNDJiNjQ4ZmRkNTg2OTRjYjA1NzM1YjRlOGUwYmRkZjUwYWUz YTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3Rv ckRPTUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3Bl Y3RvckRPTUFnZW50LmNwcApAQCAtMjExNyw3ICsyMTE3LDcgQEAgUmVmPFByb3RvY29sOjpET006 OkFjY2Vzc2liaWxpdHlQcm9wZXJ0aWVzPiBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RG b3JBY2MKICAgICAgICAgICAgIGVsc2UgLy8gRnV0dXJlIHZlcnNpb25zIG9mIEFSSUEgbWF5IGFs bG93IGFkZGl0aW9uYWwgdHJ1dGh5IHZhbHVlcy4gRXguIGZvcm1hdCwgb3JkZXIsIG9yIHNpemUu CiAgICAgICAgICAgICAgICAgaW52YWxpZCA9IFByb3RvY29sOjpET006OkFjY2Vzc2liaWxpdHlQ cm9wZXJ0aWVzOjpJbnZhbGlkOjpUcnVlOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAo YXhPYmplY3QtPmlzQVhIaWRkZW4oKSB8fCBheE9iamVjdC0+aXNET01IaWRkZW4oKSkKKyAgICAg ICAgICAgIGlmIChheE9iamVjdC0+aXNIaWRkZW4oKSkKICAgICAgICAgICAgICAgICBoaWRkZW4g PSB0cnVlOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBsYWJlbCA9IGF4T2JqZWN0LT5jb21w dXRlZExhYmVsKCk7Cg==