23066 2009-01-01 12:02:55 -0800 Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale 2009-01-02 16:21:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 eric.carlson webkit-unassigned oldest_to_newest 103977 0 eric.carlson 2009-01-01 12:02:55 -0800 A <video> element without width and height, like the following, doesn't scale as the page is zoomed with cmd +/-. It will scale properly if width and height attributes are added. <html> <head><title>video without width and height</title></head> <body> <p>Video element with no width and height specified</p> <video src="http://pulsar.esm.psu.edu/Faculty/Gray/graphics/movies/colors00.mov" autoplay></video> </body> </html> 103978 1 26349 eric.carlson 2009-01-01 12:11:04 -0800 Created attachment 26349 proposed fix 103983 2 26349 darin 2009-01-01 12:50:54 -0800 Comment on attachment 26349 proposed fix Fix looks great, but we require a regression test for each fix. I don't know if we have regression test machinery yet for testing zoom. I'm going to say r=me, but please investigate adding a regression test. 104147 3 26378 eric.carlson 2009-01-02 12:32:29 -0800 Created attachment 26378 revised patch It looks like WebKit uses the same code path for css zoom and Safari cmd +/-, so the revised patch includes a layout test that sets 'zoom: 150%' on two video elements. The page renders incorrectly with TOT but does the right thing with the proposed changes to RenderVideo.cpp. 104163 4 26378 darin 2009-01-02 13:04:35 -0800 Comment on attachment 26378 revised patch r=me 104188 5 eric.carlson 2009-01-02 16:21:37 -0800 Committed revision 39562. 26349 2009-01-01 12:11:04 -0800 2009-01-02 12:32:29 -0800 proposed fix videozoom_patch.txt text/plain 1940 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTUzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNjYg JiA8cmRhcjovL3Byb2JsZW0vNjAyODQxNz4gCisgICAgICAgIEZ1bGwgUGFnZSBab29tOiBhIDx2 aWRlbz4gZWxlbWVudCB0aGF0IGRvZXNuJ3QgaW5jbHVkZSB3aWR0aC9oZWlnaHQgYXR0cmlidXRl IGRvZXMgbm90IHNjYWxlCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86OmNhbGNSZXBsYWNlZFdpZHRoKTogTXVsdGlw bHkgYXNwZWN0IHJhdGlvIHdpZHRoIGJ5IHN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKQorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86OmNhbGNSZXBsYWNlZEhlaWdodCk6IE11bHRpcGx5IGFz cGVjdCByYXRpbyBoZWlnaHQgYnkgc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpCisKIDIwMDktMDEt MDEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBDYW1lcm9uIFp3YXJpY2guCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwCShyZXZp c2lvbiAzOTUxOSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVvLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTc0LDcgKzE3NCw3IEBAIGludCBSZW5kZXJWaWRlbzo6Y2FsY1JlcGxhY2Vk V2lkdGgoYm9vbCAKICAgICBpZiAoaXNXaWR0aFNwZWNpZmllZCgpKQogICAgICAgICB3aWR0aCA9 IGNhbGNSZXBsYWNlZFdpZHRoVXNpbmcoc3R5bGUoKS0+d2lkdGgoKSk7CiAgICAgZWxzZQotICAg ICAgICB3aWR0aCA9IGNhbGNBc3BlY3RSYXRpb1dpZHRoKCk7CisgICAgICAgIHdpZHRoID0gY2Fs Y0FzcGVjdFJhdGlvV2lkdGgoKSAqIHN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKTsKIAogICAgIGlu dCBtaW5XID0gY2FsY1JlcGxhY2VkV2lkdGhVc2luZyhzdHlsZSgpLT5taW5XaWR0aCgpKTsKICAg ICBpbnQgbWF4VyA9ICFpbmNsdWRlTWF4V2lkdGggfHwgc3R5bGUoKS0+bWF4V2lkdGgoKS5pc1Vu ZGVmaW5lZCgpID8gd2lkdGggOiBjYWxjUmVwbGFjZWRXaWR0aFVzaW5nKHN0eWxlKCktPm1heFdp ZHRoKCkpOwpAQCAtMTg4LDcgKzE4OCw3IEBAIGludCBSZW5kZXJWaWRlbzo6Y2FsY1JlcGxhY2Vk SGVpZ2h0KCkgY28KICAgICBpZiAoaXNIZWlnaHRTcGVjaWZpZWQoKSkKICAgICAgICAgaGVpZ2h0 ID0gY2FsY1JlcGxhY2VkSGVpZ2h0VXNpbmcoc3R5bGUoKS0+aGVpZ2h0KCkpOwogICAgIGVsc2UK LSAgICAgICAgaGVpZ2h0ID0gY2FsY0FzcGVjdFJhdGlvSGVpZ2h0KCk7CisgICAgICAgIGhlaWdo dCA9IGNhbGNBc3BlY3RSYXRpb0hlaWdodCgpICogc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpOwog CiAgICAgaW50IG1pbkggPSBjYWxjUmVwbGFjZWRIZWlnaHRVc2luZyhzdHlsZSgpLT5taW5IZWln aHQoKSk7CiAgICAgaW50IG1heEggPSBzdHlsZSgpLT5tYXhIZWlnaHQoKS5pc1VuZGVmaW5lZCgp ID8gaGVpZ2h0IDogY2FsY1JlcGxhY2VkSGVpZ2h0VXNpbmcoc3R5bGUoKS0+bWF4SGVpZ2h0KCkp Owo= 26378 2009-01-02 12:32:29 -0800 2009-01-02 13:04:35 -0800 revised patch videozoom_patch.txt text/plain 5573 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTU1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDEtMDIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNjYg JiA8cmRhcjovL3Byb2JsZW0vNjAyODQxNz4gCisgICAgICAgIEZ1bGwgUGFnZSBab29tOiBhIDx2 aWRlbz4gZWxlbWVudCB0aGF0IGRvZXNuJ3QgaW5jbHVkZSB3aWR0aC9oZWlnaHQgYXR0cmlidXRl IGRvZXMgbm90IHNjYWxlCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86OmNhbGNSZXBsYWNlZFdpZHRoKTogTXVsdGlw bHkgYXNwZWN0IHJhdGlvIHdpZHRoIGJ5IHN0eWxlKCktPmVmZmVjdGl2ZVpvb20oKQorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVmlkZW86OmNhbGNSZXBsYWNlZEhlaWdodCk6IE11bHRpcGx5IGFz cGVjdCByYXRpbyBoZWlnaHQgYnkgc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpCisKIDIwMDktMDEt MDIgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIKSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZGVv LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAJKHJl dmlzaW9uIDM5NTUxKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlkZW8uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzQsNyArMTc0LDcgQEAgaW50IFJlbmRlclZpZGVvOjpjYWxjUmVwbGFj ZWRXaWR0aChib29sIAogICAgIGlmIChpc1dpZHRoU3BlY2lmaWVkKCkpCiAgICAgICAgIHdpZHRo ID0gY2FsY1JlcGxhY2VkV2lkdGhVc2luZyhzdHlsZSgpLT53aWR0aCgpKTsKICAgICBlbHNlCi0g ICAgICAgIHdpZHRoID0gY2FsY0FzcGVjdFJhdGlvV2lkdGgoKTsKKyAgICAgICAgd2lkdGggPSBj YWxjQXNwZWN0UmF0aW9XaWR0aCgpICogc3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpOwogCiAgICAg aW50IG1pblcgPSBjYWxjUmVwbGFjZWRXaWR0aFVzaW5nKHN0eWxlKCktPm1pbldpZHRoKCkpOwog ICAgIGludCBtYXhXID0gIWluY2x1ZGVNYXhXaWR0aCB8fCBzdHlsZSgpLT5tYXhXaWR0aCgpLmlz VW5kZWZpbmVkKCkgPyB3aWR0aCA6IGNhbGNSZXBsYWNlZFdpZHRoVXNpbmcoc3R5bGUoKS0+bWF4 V2lkdGgoKSk7CkBAIC0xODgsNyArMTg4LDcgQEAgaW50IFJlbmRlclZpZGVvOjpjYWxjUmVwbGFj ZWRIZWlnaHQoKSBjbwogICAgIGlmIChpc0hlaWdodFNwZWNpZmllZCgpKQogICAgICAgICBoZWln aHQgPSBjYWxjUmVwbGFjZWRIZWlnaHRVc2luZyhzdHlsZSgpLT5oZWlnaHQoKSk7CiAgICAgZWxz ZQotICAgICAgICBoZWlnaHQgPSBjYWxjQXNwZWN0UmF0aW9IZWlnaHQoKTsKKyAgICAgICAgaGVp Z2h0ID0gY2FsY0FzcGVjdFJhdGlvSGVpZ2h0KCkgKiBzdHlsZSgpLT5lZmZlY3RpdmVab29tKCk7 CiAKICAgICBpbnQgbWluSCA9IGNhbGNSZXBsYWNlZEhlaWdodFVzaW5nKHN0eWxlKCktPm1pbkhl aWdodCgpKTsKICAgICBpbnQgbWF4SCA9IHN0eWxlKCktPm1heEhlaWdodCgpLmlzVW5kZWZpbmVk KCkgPyBoZWlnaHQgOiBjYWxjUmVwbGFjZWRIZWlnaHRVc2luZyhzdHlsZSgpLT5tYXhIZWlnaHQo KSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzOTU1MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA5LTAxLTAyICBFcmljIENhcmxzb24g IDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzA2NiAmIDxyZGFyOi8vcHJvYmxlbS82MDI4NDE3PiAKKyAgICAgICAgRnVsbCBQYWdlIFpv b206IGEgPHZpZGVvPiBlbGVtZW50IHRoYXQgZG9lc24ndCBpbmNsdWRlIHdpZHRoL2hlaWdodCBh dHRyaWJ1dGUgZG9lcyBub3Qgc2NhbGUKKyAgICAgICAgCisgICAgICAgIEFkZCB0ZXN0IGZvciA8 dmlkZW8+IHpvb20gd2l0aCBhbmQgd2l0aG91dCB3aWR0aC9oZWlnaHQgYXR0cmlidXRlcworCisg ICAgICAgICogbWVkaWEvdmlkZW8tem9vbS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMvbWVkaWEvdmlkZW8tem9vbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDA5LTAxLTAy ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXpvb20uaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby16b29tLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby16b29tLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMzQgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxlPiB2aWRlbyB7IHpv b206IDE1MCU7IGJvcmRlcjogM3B4IHNvbGlkIHJlZDsgfSA8L3N0eWxlPgorICAgIDxzY3JpcHQ+ CisgICAgICAgIGZ1bmN0aW9uIGluaXQoKQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgdG90 YWxDb3VudCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpLmxlbmd0aDsK KyAgICAgICAgICAgIHZhciBjb3VudCA9IHRvdGFsQ291bnQ7CisgICAgICAgICAgICBkb2N1bWVu dC5hZGRFdmVudExpc3RlbmVyKCJjYW5wbGF5dGhyb3VnaCIsIGZ1bmN0aW9uICgpIHsKKyAgICAg ICAgICAgICAgICBpZiAoIS0tY291bnQpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICAgICAgICAgIHNldFRpbWVv dXQoZnVuY3Rpb24oKSB7IGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsgfSwgdG90 YWxDb3VudCAqIDE1MCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfSwgdHJ1ZSk7 CisKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAg ICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsgCisgICAgICAgICAgICAgICAgICAgIGRv Y3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ0ZBSUwnKSk7 IAorICAgICAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworICAgICAgICAgICAgICAgIH0sIDE1MDApOworICAgICAgICAgICAgfQorICAgICAgICB9Cisg ICAgPC9zY3JpcHQ+CisKKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0iaW5pdCgpIj4KKyAgICA8cD4x NTAlIHpvb20sIHdpdGggd2lkdGggYW5kIGhlaWdodCBhdHRyaWJ1dGVzIDwvcD4KKyAgICAmbmJz cDs8dmlkZW8gc3JjPSJjb250ZW50L3Rlc3QubXA0IiB3aWR0aD0zMjAgaGVpZ2h0PTI0MD48L3Zp ZGVvPjxicj4KKyAgICA8cD4xNTAlIHpvb20sIHdpdGhvdXQgd2lkdGggYW5kIGhlaWdodCBhdHRy aWJ1dGVzIDwvcD4KKyAgICAmbmJzcDs8dmlkZW8gc3JjPSJjb250ZW50L3Rlc3QubXA0IiA+PC92 aWRlbz48YnI+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvbWVkaWEvdmlkZW8tem9vbS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL21lZGlhL3ZpZGVvLXpvb20tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL21lZGlhL3ZpZGVvLXpvb20tZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIxIEBACitsYXllciBhdCAoMCwwKSBzaXplIDc4 NXg4NDQKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDc4NXg2MDAKK2xheWVyIGF0ICgwLDAp IHNpemUgNzg1eDg0NAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA3ODV4ODQ0 CisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3Njl4ODI4CisgICAgICBSZW5k ZXJCbG9jayB7UH0gYXQgKDAsMCkgc2l6ZSA3Njl4MTgKKyAgICAgICAgUmVuZGVyVGV4dCB7I3Rl eHR9IGF0ICgwLDApIHNpemUgMjgzeDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lk dGggMjgzOiAiMTUwJSB6b29tLCB3aXRoIHdpZHRoIGFuZCBoZWlnaHQgYXR0cmlidXRlcyIKKyAg ICAgIFJlbmRlckJsb2NrIChhbm9ueW1vdXMpIGF0ICgwLDM0KSBzaXplIDc2OXgzNzIKKyAgICAg ICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDM1NCkgc2l6ZSA0eDE4CisgICAgICAgICAgdGV4 dCBydW4gYXQgKDAsMzU0KSB3aWR0aCA0OiAiICIKKyAgICAgICAgUmVuZGVyVmlkZW8ge1ZJREVP fSBhdCAoNCwwKSBzaXplIDQ4OHgzNjggW2JvcmRlcjogKDRweCBzb2xpZCAjRkYwMDAwKV0KKyAg ICAgICAgUmVuZGVyQlIge0JSfSBhdCAoNDkyLDM2OCkgc2l6ZSAweDAKKyAgICAgIFJlbmRlckJs b2NrIHtQfSBhdCAoMCw0MjIpIHNpemUgNzY5eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0 fSBhdCAoMCwwKSBzaXplIDMwM3gxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRo IDMwMzogIjE1MCUgem9vbSwgd2l0aG91dCB3aWR0aCBhbmQgaGVpZ2h0IGF0dHJpYnV0ZXMiCisg ICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCw0NTYpIHNpemUgNzY5eDM3MgorICAg ICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMzU0KSBzaXplIDR4MTgKKyAgICAgICAgICB0 ZXh0IHJ1biBhdCAoMCwzNTQpIHdpZHRoIDQ6ICIgIgorICAgICAgICBSZW5kZXJWaWRlbyB7VklE RU99IGF0ICg0LDApIHNpemUgNDg4eDM2OCBbYm9yZGVyOiAoNHB4IHNvbGlkICNGRjAwMDApXQor ICAgICAgICBSZW5kZXJCUiB7QlJ9IGF0ICg0OTIsMzY4KSBzaXplIDB4MAo=