230652 2021-09-22 16:23:21 -0700 [JSC] emoji and eor collations are missing 2021-10-01 16:43:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1796261 0 ysuzuki 2021-09-22 16:23:21 -0700 [JSC] emoji and eor collations are missing 1796262 1 438989 ysuzuki 2021-09-22 16:24:33 -0700 Created attachment 438989 Patch 1796286 2 438989 ross.kirsling 2021-09-22 17:25:13 -0700 Comment on attachment 438989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review r=me with a question > Source/JavaScriptCore/runtime/IntlObject.cpp:1661 > + // ICU ~69 has a bug that does not report "emoji" and "eor" for collation when using ucol_getKeywordValues. There's no concern for older ICU versions here, is there? 1796291 3 438989 ysuzuki 2021-09-22 17:28:15 -0700 Comment on attachment 438989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review >> Source/JavaScriptCore/runtime/IntlObject.cpp:1661 >> + // ICU ~69 has a bug that does not report "emoji" and "eor" for collation when using ucol_getKeywordValues. > > There's no concern for older ICU versions here, is there? Even though it is not supported, it is still OK to have that in available collations, since it just means that we have this collation, but no locale supports that. 1796296 4 ysuzuki 2021-09-22 17:39:31 -0700 Committed r282897 (242025@main): <https://commits.webkit.org/242025@main> 1796299 5 webkit-bug-importer 2021-09-22 17:40:28 -0700 <rdar://problem/83425179> 1799630 6 438989 darin 2021-10-01 16:43:57 -0700 Comment on attachment 438989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438989&action=review > Source/JavaScriptCore/runtime/IntlObject.cpp:1688 > + elements.resize(elements.size() - (elements.end() - end)); Not important, but for slightly more efficient code this can use shrink instead of resize. 438989 2021-09-22 16:24:33 -0700 2021-09-22 17:25:13 -0700 Patch bug-230652-20210922162433.patch text/plain 5933 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MDQwYTRiYjFhM2ZiMTE2Y2Q4MmUyYTQ4MzM3MjNjYWM3MTVjYmRiLi4xY2E3YWQ0NDY5NmI3NmM2 MWVkOTU4ZDI1NTA1NTMyMzQ3NDE4MmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wOS0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIGVtb2ppIGFuZCBlb3IgY29sbGF0aW9ucyBhcmUgbWlzc2luZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNjUyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHVlIHRvIElD VSdzIGJ1ZywgImVtb2ppIiBhbmQgImVvciIgY29sbGF0aW9ucyBhcmUgbWlzc2luZyBmcm9tIGVu dW1lcmF0aW9uLgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMgd29yay1hcm91bmQgZm9yIHRoaXMu CisKKyAgICAgICAgKiBydW50aW1lL0ludGxPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjphdmFp bGFibGVDb2xsYXRpb25zKToKKwogMjAyMS0wOS0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEludGwgdW5pY29kZSBpZGVudGlmaWVyIHR5cGUg d2lsbCByZWplY3QgdW5kZXJzY29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSW50bE9iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9J bnRsT2JqZWN0LmNwcAppbmRleCAyOWRjN2ZiYmZlMTEzMWMxNDMzN2Q5YzBjNTc0NGMzN2M2ZGE5 YWMxLi43NGZmMTcyMjc3OTQzMzU0MzIwZDJlMTJmYTFmNjAyYzI3NTg0MjhjIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsT2JqZWN0LmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsT2JqZWN0LmNwcApAQCAtMTY1Nyw3ICsxNjU3 LDExIEBAIHN0YXRpYyBKU0FycmF5KiBhdmFpbGFibGVDb2xsYXRpb25zKEpTR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QpCiAgICAgfQogCiAgICAgVmVjdG9yPFN0cmluZywgMT4gZWxlbWVudHM7 Ci0gICAgZWxlbWVudHMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShjb3VudCk7CisgICAgZWxlbWVu dHMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShjb3VudCArIDIpOworICAgIC8vIElDVSB+NjkgaGFz IGEgYnVnIHRoYXQgZG9lcyBub3QgcmVwb3J0ICJlbW9qaSIgYW5kICJlb3IiIGZvciBjb2xsYXRp b24gd2hlbiB1c2luZyB1Y29sX2dldEtleXdvcmRWYWx1ZXMuCisgICAgLy8gaHR0cHM6Ly9naXRo dWIuY29tL3VuaWNvZGUtb3JnL2ljdS9jb21taXQvMjQ3NzhkZmM5YmY2N2Y0MzE1MDkzNjFhMTcz YTMzYTFhYjg2MGI1ZAorICAgIGVsZW1lbnRzLmFwcGVuZCgiZW1vamkiX3MpOworICAgIGVsZW1l bnRzLmFwcGVuZCgiZW9yIl9zKTsKICAgICBmb3IgKGludDMyX3QgaW5kZXggPSAwOyBpbmRleCA8 IGNvdW50OyArK2luZGV4KSB7CiAgICAgICAgIGludDMyX3QgbGVuZ3RoID0gMDsKICAgICAgICAg Y29uc3QgY2hhciogcG9pbnRlciA9IHVlbnVtX25leHQoZW51bWVyYXRpb24uZ2V0KCksICZsZW5n dGgsICZzdGF0dXMpOwpAQCAtMTY4MCw2ICsxNjg0LDggQEAgc3RhdGljIEpTQXJyYXkqIGF2YWls YWJsZUNvbGxhdGlvbnMoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKICAgICAgICAgW10o Y29uc3QgU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpIHsKICAgICAgICAgICAgIHJldHVybiBX VEY6OmNvZGVQb2ludENvbXBhcmUoYSwgYikgPCAwOwogICAgICAgICB9KTsKKyAgICBhdXRvIGVu ZCA9IHN0ZDo6dW5pcXVlKGVsZW1lbnRzLmJlZ2luKCksIGVsZW1lbnRzLmVuZCgpKTsKKyAgICBl bGVtZW50cy5yZXNpemUoZWxlbWVudHMuc2l6ZSgpIC0gKGVsZW1lbnRzLmVuZCgpIC0gZW5kKSk7 CiAKICAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIGNyZWF0ZUFycmF5RnJvbVN0cmluZ1Zl Y3RvcihnbG9iYWxPYmplY3QsIFdURk1vdmUoZWxlbWVudHMpKSk7CiB9CmRpZmYgLS1naXQgYS9K U1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU4Mjg5NTUyNGUyNWU0 OGFmYjk3NzM4YjRiZGJjN2FiZWJiMjU4NGEuLjU5MWMxOTA4YzhiOWE5ZDcyYzBhZGI2N2I1NDk0 YmQ3NzZhMmVjMTUgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDktMjIgIFl1c3VrZSBTdXp1a2kgIDx5 c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBlbW9qaSBhbmQgZW9yIGNvbGxhdGlv bnMgYXJlIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzMDY1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogc3RyZXNzL2ludGwtZW51bWVyYXRpb24uanM6CisgICAgICAgICogdGVzdDI2Mi9l eHBlY3RhdGlvbnMueWFtbDoKKwogMjAyMS0wOS0yMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEludGwgdW5pY29kZSBpZGVudGlmaWVyIHR5cGUg d2lsbCByZWplY3QgdW5kZXJzY29yZQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvaW50bC1l bnVtZXJhdGlvbi5qcyBiL0pTVGVzdHMvc3RyZXNzL2ludGwtZW51bWVyYXRpb24uanMKaW5kZXgg ZDEyNTFkYzk2ZjFjYjBmZGVkYTQxMjkwNTQwMWI1ZGI0NmUyOWZmNS4uYzk3YzIyZWEwMjk5YmJl MmMwYWQxZWM0MTFjMTA2MTIwYjRiMWU2ZSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvaW50 bC1lbnVtZXJhdGlvbi5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9pbnRsLWVudW1lcmF0aW9uLmpz CkBAIC0xOSw3ICsxOSw3IEBAIGZ1bmN0aW9uIHNob3VsZFRocm93KGZ1bmMsIGVycm9yVHlwZSkg ewogc2hvdWxkQmUoSlNPTi5zdHJpbmdpZnkoY2FsZW5kYXJzKSwgYFsiYnVkZGhpc3QiLCJjaGlu ZXNlIiwiY29wdGljIiwiZGFuZ2kiLCJldGhpb2FhIiwiZXRoaW9waWMiLCJncmVnb3J5IiwiaGVi cmV3IiwiaW5kaWFuIiwiaXNsYW1pYyIsImlzbGFtaWMtY2l2aWwiLCJpc2xhbWljLXJnc2EiLCJp c2xhbWljLXRibGEiLCJpc2xhbWljLXVtYWxxdXJhIiwiaXNvODYwMSIsImphcGFuZXNlIiwicGVy c2lhbiIsInJvYyJdYCk7CiAKIGxldCBjb2xsYXRpb25zID0gSW50bC5zdXBwb3J0ZWRWYWx1ZXNP ZigiY29sbGF0aW9uIik7Ci1zaG91bGRCZShKU09OLnN0cmluZ2lmeShjb2xsYXRpb25zKSwgYFsi YmlnNWhhbiIsImNvbXBhdCIsImRpY3QiLCJnYjIzMTIiLCJwaG9uZWJrIiwicGhvbmV0aWMiLCJw aW55aW4iLCJyZWZvcm1lZCIsInNlYXJjaGpsIiwic3Ryb2tlIiwidHJhZCIsInVuaWhhbiIsInpo dXlpbiJdYCk7CitzaG91bGRCZShKU09OLnN0cmluZ2lmeShjb2xsYXRpb25zKSwgYFsiYmlnNWhh biIsImNvbXBhdCIsImRpY3QiLCJlbW9qaSIsImVvciIsImdiMjMxMiIsInBob25lYmsiLCJwaG9u ZXRpYyIsInBpbnlpbiIsInJlZm9ybWVkIiwic2VhcmNoamwiLCJzdHJva2UiLCJ0cmFkIiwidW5p aGFuIiwiemh1eWluIl1gKTsKIAogbGV0IGN1cnJlbmNpZXMgPSBJbnRsLnN1cHBvcnRlZFZhbHVl c09mKCJjdXJyZW5jeSIpOwogc2hvdWxkQmUoSlNPTi5zdHJpbmdpZnkoY3VycmVuY2llcyksIGBb IkFFRCIsIkFGTiIsIkFMTCIsIkFNRCIsIkFORyIsIkFPQSIsIkFSUyIsIkFVRCIsIkFXRyIsIkFa TiIsIkJBTSIsIkJCRCIsIkJEVCIsIkJHTiIsIkJIRCIsIkJJRiIsIkJNRCIsIkJORCIsIkJPQiIs IkJSTCIsIkJTRCIsIkJUTiIsIkJXUCIsIkJZTiIsIkJaRCIsIkNBRCIsIkNERiIsIkNIRiIsIkNM UCIsIkNOWSIsIkNPUCIsIkNSQyIsIkNVQyIsIkNVUCIsIkNWRSIsIkNaSyIsIkRKRiIsIkRLSyIs IkRPUCIsIkRaRCIsIkVHUCIsIkVSTiIsIkVUQiIsIkVVUiIsIkZKRCIsIkZLUCIsIkdCUCIsIkdF TCIsIkdIUyIsIkdJUCIsIkdNRCIsIkdORiIsIkdUUSIsIkdZRCIsIkhLRCIsIkhOTCIsIkhSSyIs IkhURyIsIkhVRiIsIklEUiIsIklMUyIsIklOUiIsIklRRCIsIklSUiIsIklTSyIsIkpNRCIsIkpP RCIsIkpQWSIsIktFUyIsIktHUyIsIktIUiIsIktNRiIsIktQVyIsIktSVyIsIktXRCIsIktZRCIs IktaVCIsIkxBSyIsIkxCUCIsIkxLUiIsIkxSRCIsIkxTTCIsIkxZRCIsIk1BRCIsIk1ETCIsIk1H QSIsIk1LRCIsIk1NSyIsIk1OVCIsIk1PUCIsIk1SVSIsIk1VUiIsIk1WUiIsIk1XSyIsIk1YTiIs Ik1ZUiIsIk1aTiIsIk5BRCIsIk5HTiIsIk5JTyIsIk5PSyIsIk5QUiIsIk5aRCIsIk9NUiIsIlBB QiIsIlBFTiIsIlBHSyIsIlBIUCIsIlBLUiIsIlBMTiIsIlBZRyIsIlFBUiIsIlJPTiIsIlJTRCIs IlJVQiIsIlJXRiIsIlNBUiIsIlNCRCIsIlNDUiIsIlNERyIsIlNFSyIsIlNHRCIsIlNIUCIsIlNM TCIsIlNPUyIsIlNSRCIsIlNTUCIsIlNUTiIsIlNZUCIsIlNaTCIsIlRIQiIsIlRKUyIsIlRNVCIs IlRORCIsIlRPUCIsIlRSWSIsIlRURCIsIlRXRCIsIlRaUyIsIlVBSCIsIlVHWCIsIlVTRCIsIlVZ VSIsIlVaUyIsIlZFRiIsIlZORCIsIlZVViIsIldTVCIsIlhBRiIsIlhDRCIsIlhPRiIsIlhQRiIs IllFUiIsIlpBUiIsIlpNVyJdYCk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0 YXRpb25zLnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKaW5kZXggZGJm OGQ3ZTE0NzhiOGRiNjkxYmUyOWNmZDc0ZDg4MjRmZTU1ODFjZS4uZjJkYTMxMWMwM2JiMzgzOWJl NTFkMDc1NzUyYjIwYzYyNWM2OGJmYyAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVj dGF0aW9ucy55YW1sCisrKyBiL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbApAQCAt ODQ5LDkgKzg0OSw2IEBAIHRlc3QvaW50bDQwMi9JbnRsL2dldENhbm9uaWNhbExvY2FsZXMvdW5p Y29kZS1leHQtY2Fub25pY2FsaXplLXJlZ2lvbi5qczoKIHRlc3QvaW50bDQwMi9JbnRsL2dldENh bm9uaWNhbExvY2FsZXMvdW5pY29kZS1leHQtY2Fub25pY2FsaXplLXN1YmRpdmlzaW9uLmpzOgog ICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUowqt1bmQtTk8tdS1z ZC1ubzIzwrssIMKrdW5kLU5PLXUtc2Qtbm81MMK7KSB0byBiZSB0cnVlJwogICBzdHJpY3QgbW9k ZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVlKMKrdW5kLU5PLXUtc2Qtbm8yM8K7 LCDCq3VuZC1OTy11LXNkLW5vNTDCuykgdG8gYmUgdHJ1ZScKLXRlc3QvaW50bDQwMi9JbnRsL3N1 cHBvcnRlZFZhbHVlc09mL2NvbGxhdGlvbnMtYWNjZXB0ZWQtYnktQ29sbGF0b3IuanM6Ci0gIGRl ZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IGVtb2ppIHN1cHBvcnRlZCBidXQgbm90IHJldHVybmVkIGJ5 IHN1cHBvcnRlZFZhbHVlc09mJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogZW1vamkg c3VwcG9ydGVkIGJ1dCBub3QgcmV0dXJuZWQgYnkgc3VwcG9ydGVkVmFsdWVzT2YnCiB0ZXN0L2lu dGw0MDIvSW50bC9zdXBwb3J0ZWRWYWx1ZXNPZi9jdXJyZW5jaWVzLWFjY2VwdGVkLWJ5LURpc3Bs YXlOYW1lcy5qczoKICAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogQURQIHN1cHBvcnRlZCBidXQg bm90IHJldHVybmVkIGJ5IHN1cHBvcnRlZFZhbHVlc09mJwogICBzdHJpY3QgbW9kZTogJ1Rlc3Qy NjJFcnJvcjogQURQIHN1cHBvcnRlZCBidXQgbm90IHJldHVybmVkIGJ5IHN1cHBvcnRlZFZhbHVl c09mJwo=