230647 2021-09-22 16:00:43 -0700 [GPU Process] `DisplayList::Recorder::getCTM` should include the device scale factor 2021-10-26 14:50:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230648 https://bugs.webkit.org/show_bug.cgi?id=230664 https://bugs.webkit.org/show_bug.cgi?id=230781 InRadar P2 Normal --- 1 hi thorton hi sabouhallawa simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1796243 0 hi 2021-09-22 16:00:43 -0700 . 1796245 1 hi 2021-09-22 16:06:55 -0700 (oops I think I changed the title of another bug I was gonna file and hit submit before I realized 🤣) While working on <https://webkit.org/b/230648>, I noticed that `DisplayList::Recorder::getCTM` never seems to include the device scale, meaning that if I try to use `ImageBuffer::compatibleBufferSize` and then `GraphicsContext::drawConsumingImageBuffer` it'll result in a blurry image (since the device scale used for the `ImageBuffer` is just `1`). 1798641 2 webkit-bug-importer 2021-09-29 16:01:20 -0700 <rdar://problem/83692923> 1808665 3 442437 thorton 2021-10-25 16:31:47 -0700 Created attachment 442437 Patch 1809055 4 ews-feeder 2021-10-26 14:50:35 -0700 Committed r284902 (243579@main): <https://commits.webkit.org/243579@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442437. 442437 2021-10-25 16:31:47 -0700 2021-10-26 14:50:36 -0700 Patch bug-230647-20211025163146.patch text/plain 5161 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0ODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRlZjQzZjY4YTk2YjBi MjhhMzI0NzY4ZmFlOTMwYTVkNThmMTA2Ny4uZTM2YjZhZTQ0MTM4YzRmOWE1NDAyZTU5YzhjYmYw MmZiNjdhNTRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTEwLTI1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vz c10gYERpc3BsYXlMaXN0OjpSZWNvcmRlcjo6Z2V0Q1RNYCBzaG91bGQgaW5jbHVkZSB0aGUgZGV2 aWNlIHNjYWxlIGZhY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjMwNjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTmV3IHRlc3Q6IEJpZnVyY2F0ZWRHcmFwaGljc0NvbnRleHRUZXN0cy5BcHBseURl dmljZVNjYWxlRmFjdG9yCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlz dHMvRGlzcGxheUxpc3RSZWNvcmRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlz dDo6UmVjb3JkZXI6OmdldENUTSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5TGlz dDo6UmVjb3JkZXI6OmFwcGx5RGV2aWNlU2NhbGVGYWN0b3IpOgorICAgICAgICBhcHBseURldmlj ZVNjYWxlRmFjdG9yIHByZXZpb3VzbHkgZGlkIG5vdCBhcHBseSB0aGUgc2NhbGUgdG8gdGhlIENU TSwKKyAgICAgICAgY2F1c2luZyB0aGUgRGlzcGxheUxpc3Q6OlJlY29yZGVyJ3MgaWRlYSBvZiB0 aGUgQ1RNIHRvIGdldCBvdXQgb2Ygc3luYworICAgICAgICB3aXRoIHRoZSBjb250ZXh0IGJlaW5n IHJlcGxheWVkIGludG8uCisKKyAgICAgICAgV2UgZG9uJ3QgY2FsbCBHcmFwaGljc0NvbnRleHQ6 OnNjYWxlKCkgZGlyZWN0bHkgKGxpa2UgR3JhcGhpY3NDb250ZXh0Q0cgZG9lcykKKyAgICAgICAg YmVjYXVzZSBhcHBseURldmljZVNjYWxlRmFjdG9yIG9uIHRoZSByZXBsYXkgc2lkZSB3aWxsIGFw cGx5IHRoZSBzY2FsZQorICAgICAgICB0byB0aGUgcmVwbGF5ZWQgY29udGV4dCdzIENUTS4KKwog MjAyMS0xMC0yNSAgQXl1bWkgS29qaW1hICA8YXl1bWlfa29qaW1hQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI4NDc0Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNw bGF5TGlzdFJlY29yZGVyLmNwcAppbmRleCA0Nzc5NDIxZjQzZDZjYTkwOTNmYmM1ZjVmMzMyZmY0 MDk5YTUzYTYxLi5iZjMxMTc0ZTIxM2FhM2Y3N2U2ZTlhNmM2ZTE2MWEwNzAxNWFjOWFmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlz cGxheUxpc3RSZWNvcmRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVjb3JkZXIuY3BwCkBAIC0yMzIsNyArMjMyLDYg QEAgdm9pZCBSZWNvcmRlcjo6c2V0Q1RNKGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgdHJhbnNmb3Jt KQogCiBBZmZpbmVUcmFuc2Zvcm0gUmVjb3JkZXI6OmdldENUTShHcmFwaGljc0NvbnRleHQ6Oklu Y2x1ZGVEZXZpY2VTY2FsZSkgY29uc3QKIHsKLSAgICAvLyBGSVhNRTogPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzIzMDY0Nz4gKFtHUFUgUHJvY2Vzc10gYWRkIHN1cHBvcnQgZm9yIGBJbmNsdWRlRGV2 aWNlU2NhbGVgIGluc2lkZSBgRGlzcGxheUxpc3Q6OlJlY29yZGVyOjpnZXRDVE1gKQogICAgIHJl dHVybiBjdXJyZW50U3RhdGUoKS5jdG07CiB9CiAKQEAgLTQ5MCw2ICs0ODksMTAgQEAgdm9pZCBS ZWNvcmRlcjo6cGFpbnRGcmFtZUZvck1lZGlhKE1lZGlhUGxheWVyJiBwbGF5ZXIsIGNvbnN0IEZs b2F0UmVjdCYgZGVzdGluYXQKIAogdm9pZCBSZWNvcmRlcjo6YXBwbHlEZXZpY2VTY2FsZUZhY3Rv cihmbG9hdCBkZXZpY2VTY2FsZUZhY3RvcikKIHsKKyAgICAvLyBXZSBtb2RpZnkgdGhlIHN0YXRl IGRpcmVjdGx5IGhlcmUgaW5zdGVhZCBvZiBjYWxsaW5nIEdyYXBoaWNzQ29udGV4dDo6c2NhbGUo KQorICAgIC8vIGJlY2F1c2UgdGhlIHJlY29yZGVkIGl0ZW0gd2lsbCBzY2FsZSgpIHdoZW4gcmVw bGF5ZWQuCisgICAgY3VycmVudFN0YXRlKCkuc2NhbGUoeyBkZXZpY2VTY2FsZUZhY3RvciwgZGV2 aWNlU2NhbGVGYWN0b3IgfSk7CisKICAgICAvLyBGSVhNRTogdGhpcyBjaGFuZ2VzIHRoZSBiYXNl Q1RNLCB3aGljaCB3aWxsIGludmFsaWRhdGUgYWxsIG9mIG91ciBjYWNoZWQgZXh0ZW50cy4KICAg ICAvLyBBc3NlcnQgdGhhdCBpdCdzIG9ubHkgY2FsbGVkIGVhcmx5IG9uPwogICAgIHJlY29yZEFw cGx5RGV2aWNlU2NhbGVGYWN0b3IoZGV2aWNlU2NhbGVGYWN0b3IpOwpkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY2MjA1M2M2YWVkZTQzMTVkM2Fk N2Y3ODA2ZGVjM2Y4NGQ3MTk1YjYuLjNmMDc2OGYyMjI5ZWYwZWE4MmY1ZmE0ZTJlZDI5OGYyMWEx NTlmYjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAyMS0xMC0yNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9u QGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIGBEaXNwbGF5TGlzdDo6UmVjb3Jk ZXI6OmdldENUTWAgc2hvdWxkIGluY2x1ZGUgdGhlIGRldmljZSBzY2FsZSBmYWN0b3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMDY0NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJDb3JlL2NnL0JpZnVyY2F0ZWRHcmFwaGljc0NvbnRleHRUZXN0c0NHLmNwcDoK KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICBBZGQgYSB0ZXN0IHRoYXQg Z2V0Q1RNIHJldHVybnMgdGhlIGNvcnJlY3Qgc2NhbGUgYWZ0ZXIgYXBwbHlEZXZpY2VTY2FsZUZh Y3RvciBpcyBjYWxsZWQuCisKIDIwMjEtMTAtMjUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBXZWJLaXQgb3VnaHQgdG8gYmUgYWJsZSB0byBw bGF5IHZpZGVvcyB3aXRob3V0IENvbnRlbnQtTGVuZ3RoIEhUVFAgaGVhZGVyIGZpZWxkcyBhbmQg d2l0aG91dCByYW5nZSBzdXBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvY2cvQmlmdXJjYXRlZEdyYXBoaWNzQ29udGV4dFRlc3RzQ0cuY3BwIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL2NnL0JpZnVyY2F0ZWRHcmFwaGljc0NvbnRl eHRUZXN0c0NHLmNwcAppbmRleCA2MDNiZDc1ZjUxNjU1Y2ZjZWM5YTNiOWMzZDUxMDFkZjFjMzE1 ZTYwLi5hNmJmZDIyYzU1MWU3ODhmZGZjN2FlNjgyZTIzZDg4YTEyNTBlNmU2IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvY2cvQmlmdXJjYXRlZEdyYXBoaWNz Q29udGV4dFRlc3RzQ0cuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y ZS9jZy9CaWZ1cmNhdGVkR3JhcGhpY3NDb250ZXh0VGVzdHNDRy5jcHAKQEAgLTIxOSw2ICsyMTks MzIgQEAgVEVTVChCaWZ1cmNhdGVkR3JhcGhpY3NDb250ZXh0VGVzdHMsIEJvcmRlcnMpCiAgICAg RVhQRUNUX0VRKHByaW1hcnlEYXRhWzNdLCAyNTUpOwogfQogCitURVNUKEJpZnVyY2F0ZWRHcmFw aGljc0NvbnRleHRUZXN0cywgQXBwbHlEZXZpY2VTY2FsZUZhY3RvcikKK3sKKyAgICBhdXRvIGNv bG9yU3BhY2UgPSBEZXN0aW5hdGlvbkNvbG9yU3BhY2U6OlNSR0IoKTsKKyAgICBhdXRvIHByaW1h cnlDR0NvbnRleHQgPSBhZG9wdENGKENHQml0bWFwQ29udGV4dENyZWF0ZShudWxscHRyLCAxMDAs IDEwMCwgOCwgNCAqIDEwMCwgY29sb3JTcGFjZS5wbGF0Zm9ybUNvbG9yU3BhY2UoKSwga0NHSW1h Z2VBbHBoYVByZW11bHRpcGxpZWRMYXN0KSk7CisKKyAgICBHcmFwaGljc0NvbnRleHRDRyBwcmlt YXJ5Q29udGV4dENHKHByaW1hcnlDR0NvbnRleHQuZ2V0KCkpOworICAgIEdyYXBoaWNzQ29udGV4 dCYgcHJpbWFyeUNvbnRleHQgPSBwcmltYXJ5Q29udGV4dENHOworCisgICAgSW5NZW1vcnlEaXNw bGF5TGlzdCBkaXNwbGF5TGlzdDsKKyAgICBSZWNvcmRlckltcGwgc2Vjb25kYXJ5Q29udGV4dERM KGRpc3BsYXlMaXN0LCB7IH0sIEZsb2F0UmVjdCgwLCAwLCAxMDAsIDEwMCksIHsgfSk7CisgICAg R3JhcGhpY3NDb250ZXh0JiBzZWNvbmRhcnlDb250ZXh0ID0gc2Vjb25kYXJ5Q29udGV4dERMOwor CisgICAgQmlmdXJjYXRlZEdyYXBoaWNzQ29udGV4dCBjdHgocHJpbWFyeUNvbnRleHQsIHNlY29u ZGFyeUNvbnRleHQpOworCisgICAgY3R4LmFwcGx5RGV2aWNlU2NhbGVGYWN0b3IoMik7CisKKyAg ICBhdXRvIHByaW1hcnlDVE0gPSBwcmltYXJ5Q29udGV4dC5nZXRDVE0oR3JhcGhpY3NDb250ZXh0 OjpJbmNsdWRlRGV2aWNlU2NhbGU6OkRlZmluaXRlbHlJbmNsdWRlRGV2aWNlU2NhbGUpOworICAg IGF1dG8gc2Vjb25kYXJ5Q1RNID0gc2Vjb25kYXJ5Q29udGV4dC5nZXRDVE0oR3JhcGhpY3NDb250 ZXh0OjpJbmNsdWRlRGV2aWNlU2NhbGU6OkRlZmluaXRlbHlJbmNsdWRlRGV2aWNlU2NhbGUpOwor CisgICAgRVhQRUNUX0VRKHByaW1hcnlDVE0ueFNjYWxlKCksIHNlY29uZGFyeUNUTS54U2NhbGUo KSk7CisgICAgRVhQRUNUX0VRKHByaW1hcnlDVE0ueVNjYWxlKCksIHNlY29uZGFyeUNUTS55U2Nh bGUoKSk7CisKKyAgICBFWFBFQ1RfRVEocHJpbWFyeUNUTS54U2NhbGUoKSwgMik7CisgICAgRVhQ RUNUX0VRKHByaW1hcnlDVE0ueVNjYWxlKCksIDIpOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0 V2ViS2l0QVBJCiAKICNlbmRpZiAvLyBVU0UoQ0cpCg==