23062 2008-12-31 17:44:25 -0800 [jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval 2008-12-31 18:34:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 13638 1 oliver oliver oldest_to_newest 103945 0 oliver 2008-12-31 17:44:25 -0800 delete eval; (function(){ try { eval("") } catch(e) { print("ARGHH!!!") } })() Results in an assertion failure as it fails to find the correct handler offset when resolving eval fails. 103946 1 oliver 2008-12-31 18:07:48 -0800 Have fix, we weren't correctly emitting position information for the resolve of "eval" in the eval call node. Just making tests. 103947 2 26342 oliver 2008-12-31 18:24:21 -0800 Created attachment 26342 Emit expression info for the eval resolve Nice and easy fix 103948 3 oliver 2008-12-31 18:34:14 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/exception-linenums-expected.txt M LayoutTests/fast/js/resources/exception-linenums.js Committed r39533 26342 2008-12-31 18:24:21 -0800 2008-12-31 18:27:57 -0800 Emit expression info for the eval resolve eval-exception-crash.patch text/plain 3660 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlZGQ1ZDhhLi43ZTEwZWRhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMDgtMTItMzEgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbanNmdW5mdXp6XSBDb21w dXRlZCBleGNlcHRpb24gb2Zmc2V0IHdyb25nIHdoZW4gZmlyc3QgaW5zdHJ1Y3Rpb24gaXMgYXR0 ZW1wdCB0byByZXNvbHZlIGRlbGV0ZWQgZXZhbAorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIzMDYyPgorCisgICAgICAgIFRoaXMgd2FzIGNhdXNlZCBi eSB0aGUgZXhwcmVzc2lvbiBpbmZvcm1hdGlvbiBmb3IgdGhlIGluaXRpYWwgcmVzb2x2ZSBvZgor ICAgICAgICBldmFsIG5vdCBiZWluZyBlbWl0dGVkLiAgSWYgdGhpcyByZXNvbHZlIHdhcyB0aGUg Zmlyc3QgaW5zdHJ1Y3Rpb24gdGhhdAorICAgICAgICBjb3VsZCB0aHJvdyBhbiBleGNlcHRpb24g dGhlIGluZm9ybWF0aW9uIHNlYXJjaCB3b3VsZCBmYWlsIGxlYWRpbmcgdG8gYW4KKyAgICAgICAg YXNzZXJ0aW9uIGZhaWx1cmUuICBJZiBpdCB3YXMgbm90IHRoZSBmaXJzdCB0aHJvd2FibGUgb3Bj b2RlIHRoZSB3cm9uZworICAgICAgICBleHByZXNzaW9uIGluZm9ybWF0aW9uIHdvdWxkIHVzZWQu CisKKyAgICAgICAgRml4IGlzIHNpbXBseSB0byBlbWl0IHRoZSBleHByZXNzaW9uIGluZm8uCisK KyAgICAgICAgKiBwYXJzZXIvTm9kZXMuY3BwOgorICAgICAgICAoSlNDOjpFdmFsRnVuY3Rpb25D YWxsTm9kZTo6ZW1pdEJ5dGVjb2RlKToKKwogMjAwOC0xMi0zMSAgQ2FtZXJvbiBad2FyaWNoICA8 Y3d6d2FyaWNoQHV3YXRlcmxvby5jYT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVu dC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5jcHAgYi9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvTm9kZXMuY3BwCmluZGV4IDRkNDQwNmQuLjgyMWE2ZDEgMTAwNjQ0Ci0t LSBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUv cGFyc2VyL05vZGVzLmNwcApAQCAtNTg3LDYgKzU4Nyw3IEBAIFJlZ2lzdGVySUQqIEV2YWxGdW5j dGlvbkNhbGxOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVHZW5lcmF0b3ImIGdlbmVyYXRvciwg UmVnCiB7CiAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IGZ1bmMgPSBnZW5lcmF0b3IudGVtcERlc3Rp bmF0aW9uKGRzdCk7CiAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHRoaXNSZWdpc3RlciA9IGdlbmVy YXRvci5uZXdUZW1wb3JhcnkoKTsKKyAgICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKGRp dm90KCkgLSBzdGFydE9mZnNldCgpICsgNCwgNCwgMCk7CiAgICAgZ2VuZXJhdG9yLmVtaXRSZXNv bHZlV2l0aEJhc2UodGhpc1JlZ2lzdGVyLmdldCgpLCBmdW5jLmdldCgpLCBnZW5lcmF0b3IucHJv cGVydHlOYW1lcygpLmV2YWwpOwogICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdENhbGxFdmFsKGdl bmVyYXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCwgZnVuYy5nZXQoKSksIGZ1bmMuZ2V0KCksIHRo aXNSZWdpc3Rlci5nZXQoKSwgbV9hcmdzLmdldCgpLCBkaXZvdCgpLCBzdGFydE9mZnNldCgpLCBl bmRPZmZzZXQoKSk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjU2OGIwYS4uZjNlYmZkNyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDA4LTEyLTMxICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2pzZnVuZnV6el0g Q29tcHV0ZWQgZXhjZXB0aW9uIG9mZnNldCB3cm9uZyB3aGVuIGZpcnN0IGluc3RydWN0aW9uIGlz IGF0dGVtcHQgdG8gcmVzb2x2ZSBkZWxldGVkIGV2YWwKKyAgICAgICAgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA2Mj4KKworICAgICAgICBBZGQgYW4gYWRkaXRp b25hbCBsaW5lIG51bWJlciB0ZXN0IHRvIGVuc3VyZSB3ZSBnZXQgdGhlIGNvcnJlY3QgZXhjZXB0 aW9uIGluZm9ybWF0aW9uIHdoZW4KKyAgICAgICAgcmVzb2x2ZSBvZiAnZXZhbCcgZmFpbHMuCisK KyAgICAgICAgKiBmYXN0L2pzL2V4Y2VwdGlvbi1saW5lbnVtcy1leHBlY3RlZC50eHQ6CisgICAg ICAgICogZmFzdC9qcy9yZXNvdXJjZXMvZXhjZXB0aW9uLWxpbmVudW1zLmpzOgorCiAyMDA4LTEy LTMxICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNhPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9q cy9leGNlcHRpb24tbGluZW51bXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9l eGNlcHRpb24tbGluZW51bXMtZXhwZWN0ZWQudHh0CmluZGV4IGE3NDhkMTkuLjIyMGRjNGMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvZXhjZXB0aW9uLWxpbmVudW1zLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL2V4Y2VwdGlvbi1saW5lbnVtcy1leHBlY3Rl ZC50eHQKQEAgLTEzLDYgKzEzLDggQEAgUEFTUyB0eXBlb2YgZS5zb3VyY2VVUkwgaXMgInN0cmlu ZyIKIFBBU1MgZS5saW5lIGlzIDQyCiBQQVNTIHR5cGVvZiBlLnNvdXJjZVVSTCBpcyAic3RyaW5n IgogUEFTUyBlLmxpbmUgaXMgNQorUEFTUyB0eXBlb2YgZS5zb3VyY2VVUkwgaXMgInN0cmluZyIK K1BBU1MgZS5saW5lIGlzIDY0CiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRF U1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2V4 Y2VwdGlvbi1saW5lbnVtcy5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2V4Y2Vw dGlvbi1saW5lbnVtcy5qcwppbmRleCA5Yjk4NzBjLi5mMzZmNDVhIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9leGNlcHRpb24tbGluZW51bXMuanMKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZXhjZXB0aW9uLWxpbmVudW1zLmpzCkBAIC01Nyw0 ICs1NywxNyBAQCB0cnkgewogc2hvdWxkQmUoInR5cGVvZiBlLnNvdXJjZVVSTCIsICcic3RyaW5n IicpOwogc2hvdWxkQmUoImUubGluZSIsICc1Jyk7CiAKK3JlYWxFdmFsID0gZXZhbDsKK2RlbGV0 ZSBldmFsOworKGZ1bmN0aW9uKCl7CisgICAgdHJ5IHsKKyAgICAgICAgZXZhbCgiIik7CisgICAg fSBjYXRjaChleGNlcHRpb24pIHsKKyAgICAgICAgZSA9IGV4Y2VwdGlvbjsKKyAgICB9Cit9KSgp OworZXZhbCA9IHJlYWxFdmFsOworc2hvdWxkQmUoInR5cGVvZiBlLnNvdXJjZVVSTCIsICcic3Ry aW5nIicpOworc2hvdWxkQmUoImUubGluZSIsICc2NCcpOworCiB2YXIgc3VjY2Vzc2Z1bGx5UGFy c2VkID0gdHJ1ZTsK