230610 2021-09-22 04:14:22 -0700 REGRESSION(r282082): [GTK] Tests timeout when using xvfb after r282082 2021-09-22 04:30:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229758 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply clopez ews-watchlist glenn jbedard pnormand webkit-bug-importer oldest_to_newest 1796012 0 cgarcia 2021-09-22 04:14:22 -0700 r282082 changed the way xvfb is spawned by providing a PIPE for stdout and stderr instead of redirecting to /dev/null. The problem is that stderr is only read in case of execution failure, so when nothing fails we end up filling the buffer that is never read. We can try to find a better solution to show the stderr output in error messages, but for now we can revert that part to redirect stderr to /dev/null to make the tests work again. 1796013 1 438941 cgarcia 2021-09-22 04:15:55 -0700 Created attachment 438941 Patch 1796016 2 cgarcia 2021-09-22 04:29:09 -0700 Committed r282870 (241999@main): <https://commits.webkit.org/241999@main> 1796017 3 webkit-bug-importer 2021-09-22 04:30:17 -0700 <rdar://problem/83392739> 438941 2021-09-22 04:15:55 -0700 2021-09-22 04:25:24 -0700 Patch wk-xvfb-timeouts.diff text/plain 2853 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NjYw ODllNmExY2IuLmI5ZmM0YWEyOWYzOCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA5LTIyICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy ODIwODIpOiBbR1RLXSBUZXN0cyB0aW1lb3V0IHdoZW4gdXNpbmcgeHZmYiBhZnRlciByMjgyMDgy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA2MTAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjgyMDgy IGNoYW5nZWQgdGhlIHdheSB4dmZiIGlzIHNwYXduZWQgYnkgcHJvdmlkaW5nIGEgUElQRSBmb3Ig c3Rkb3V0IGFuZCBzdGRlcnIgaW5zdGVhZCBvZiByZWRpcmVjdGluZyB0bworICAgICAgICAvZGV2 L251bGwuIFRoZSBwcm9ibGVtIGlzIHRoYXQgc3RkZXJyIGlzIG9ubHkgcmVhZCBpbiBjYXNlIG9m IGV4ZWN1dGlvbiBmYWlsdXJlLCBzbyB3aGVuIG5vdGhpbmcgZmFpbHMgd2UgZW5kIHVwCisgICAg ICAgIGZpbGxpbmcgdGhlIGJ1ZmZlciB0aGF0IGlzIG5ldmVyIHJlYWQuIFdlIGNhbiB0cnkgdG8g ZmluZCBhIGJldHRlciBzb2x1dGlvbiB0byBzaG93IHRoZSBzdGRlcnIgb3V0cHV0IGluIGVycm9y CisgICAgICAgIG1lc3NhZ2VzLCBidXQgZm9yIG5vdyB3ZSBjYW4gcmV2ZXJ0IHRoYXQgcGFydCB0 byByZWRpcmVjdCBzdGRlcnIgdG8gL2Rldi9udWxsIHRvIG1ha2UgdGhlIHRlc3RzIHdvcmsgYWdh aW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQveHZmYmRyaXZlci5weToKKyAg ICAgICAgKFh2ZmJEcml2ZXIuX3h2ZmJfcnVuKToKKyAgICAgICAgKFh2ZmJEcml2ZXIuX3h2ZmJf Y2hlY2tfaWZfcmVhZHkpOgorCiAyMDIxLTA5LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgRHJvcCBtYWtlUmVmUHRyKCkgYW5kIHVzZSBSZWZQdHIgeyB9IGRp cmVjdGx5IGluc3RlYWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC94 dmZiZHJpdmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3h2ZmJkcml2ZXIucHkK aW5kZXggMDMyZGM0NDg5ZDI5Li5kY2Q0MDE3YThiMjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC94dmZiZHJpdmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC94dmZiZHJpdmVyLnB5CkBAIC0xMDYsNyArMTA2LDggQEAgY2xhc3MgWHZmYkRyaXZl cihEcml2ZXIpOgogICAgICAgICAgICAgICAgICAgICAnJXN4JXMnICUgKHNlbGYuX3h2ZmJfc2Ny ZWVuX3NpemUoKSwgc2VsZi5feHZmYl9zY3JlZW5fZGVwdGgoKSldCiAgICAgICAgIGlmIHNlbGYu X3BvcnQuX3Nob3VsZF91c2VfamhidWlsZCgpOgogICAgICAgICAgICAgcnVuX3h2ZmIgPSBzZWxm Ll9wb3J0Ll9qaGJ1aWxkX3dyYXBwZXIgKyBydW5feHZmYgotICAgICAgICBzZWxmLl94dmZiX3By b2Nlc3MgPSBzZWxmLl9wb3J0Lmhvc3QuZXhlY3V0aXZlLnBvcGVuKHJ1bl94dmZiLCBzdGRvdXQ9 c2VsZi5fcG9ydC5ob3N0LmV4ZWN1dGl2ZS5QSVBFLCBzdGRlcnI9c2VsZi5fcG9ydC5ob3N0LmV4 ZWN1dGl2ZS5QSVBFLCBlbnY9ZW52aXJvbm1lbnQsIGNsb3NlX2Zkcz1GYWxzZSkKKyAgICAgICAg d2l0aCBvcGVuKG9zLmRldm51bGwsICd3JykgYXMgZGV2bnVsbDoKKyAgICAgICAgICAgIHNlbGYu X3h2ZmJfcHJvY2VzcyA9IHNlbGYuX3BvcnQuaG9zdC5leGVjdXRpdmUucG9wZW4ocnVuX3h2ZmIs IHN0ZGVycj1kZXZudWxsLCBlbnY9ZW52aXJvbm1lbnQsIGNsb3NlX2Zkcz1GYWxzZSkKICAgICAg ICAgZGlzcGxheV9pZCA9IHNlbGYuX3h2ZmJfcmVhZF9kaXNwbGF5X2lkKHJlYWRfZmQpCiAgICAg ICAgIHNlbGYuX3h2ZmJfY2xvc2VfcGlwZSgocmVhZF9mZCwgd3JpdGVfZmQpKQogICAgICAgICBy ZXR1cm4gZGlzcGxheV9pZApAQCAtMTYxLDggKzE2Miw3IEBAIGNsYXNzIFh2ZmJEcml2ZXIoRHJp dmVyKToKICAgICAgICAgICAgICAgICAgICAgcXVlcnlfZmFpbGVkID0gVHJ1ZQogICAgICAgICAg ICAgaWYgdGltZW91dF9leHBpcmVkIG9yIHF1ZXJ5X2ZhaWxlZDoKICAgICAgICAgICAgICAgICBp ZiBzZWxmLl94dmZiX3Byb2Nlc3MucG9sbCgpOgotICAgICAgICAgICAgICAgICAgICB4dmZiX3N0 ZG91dCwgeHZmYl9zdGRlcnIgPSBzZWxmLl94dmZiX3Byb2Nlc3MuY29tbXVuaWNhdGUoKQotICAg ICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCdUaGUgWHZmYiBkaXNwbGF5IHNlcnZlciBoYXMg ZXhpdGVkIHVuZXhwZWN0ZWRseSB3aXRoIGEgcmV0dXJuIGNvZGUgb2YgJXMuIHN0ZG91dCBpcyAi JXMiIGFuZCBzdGRlcnIgaXMgIiVzIicgJSAoc2VsZi5feHZmYl9wcm9jZXNzLnBvbGwoKSwgeHZm Yl9zdGRvdXQsIHh2ZmJfc3RkZXJyKSkKKyAgICAgICAgICAgICAgICAgICAgX2xvZy5lcnJvcign VGhlIFh2ZmIgZGlzcGxheSBzZXJ2ZXIgaGFzIGV4aXRlZCB1bmV4cGVjdGVkbHkgd2l0aCBhIHJl dHVybiBjb2RlIG9mICVzJyAlIChzZWxmLl94dmZiX3Byb2Nlc3MucG9sbCgpKSkKICAgICAgICAg ICAgICAgICAgICAgYnJlYWsKICAgICAgICAgICAgIGlmIHdhaXRlZF9zZWNvbmRzX2Zvcl94dmZi X3JlYWR5ID4gNToKICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCdUaW1lb3V0IHJlYWNoZWQg bWVhbndoaWxlIHdhaXRpbmcgZm9yIHRoZSBYdmZiIGRpc3BsYXkgc2VydmVyIHRvIGJlIHJlYWR5 JykK