23054 2008-12-31 01:44:36 -0800 Caching of global lookups occurs even when the global object has become a dictionary 2008-12-31 02:17:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 13638 1 zwarich zwarich oldest_to_newest 103882 0 zwarich 2008-12-31 01:44:36 -0800 Both Interpreter::resolveGlobal() and Interpreter::cti_op_resolve_global() will cache even when the global object has transitioned to being a dictionary. This is incorrect. 103883 1 zwarich 2008-12-31 01:45:30 -0800 <rdar://problem/6469905> 103884 2 26333 zwarich 2008-12-31 02:14:25 -0800 Created attachment 26333 Proposed patch There is no change on SunSpider. 103885 3 zwarich 2008-12-31 02:17:26 -0800 Landed in r39525. 26333 2008-12-31 02:14:25 -0800 2008-12-31 02:15:18 -0800 Proposed patch global.diff text/plain 4639 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NTI0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMTItMzEgIENhbWVyb24g WndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIzMDU0OiBDYWNoaW5nIG9mIGdsb2JhbCBs b29rdXBzIG9jY3VycyBldmVuIHdoZW4gdGhlIGdsb2JhbCBvYmplY3QgaGFzIGJlY29tZSBhIGRp Y3Rpb25hcnkKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzA1ND4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0Njk5MDU+CisKKyAgICAgICAgKiBp bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpy ZXNvbHZlR2xvYmFsKTogRG8gbm90IGNhY2hlIGxvb2t1cCBpZiB0aGUgZ2xvYmFsCisgICAgICAg IG9iamVjdCBoYXMgdHJhbnNpdGlvbmVkIHRvIGEgZGljdGlvbmFyeS4KKyAgICAgICAgKEpTQzo6 SW50ZXJwcmV0ZXI6OmN0aV9vcF9yZXNvbHZlX2dsb2JhbCk6IERvIG5vdCBjYWNoZSBsb29rdXAg aWYgdGhlCisgICAgICAgIGdsb2JhbCBvYmplY3QgaGFzIHRyYW5zaXRpb25lZCB0byBhIGRpY3Rp b25hcnkuCisKIDIwMDgtMTItMzAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0ludGVycHJldGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAJKHJldmlzaW9uIDM5NTI0KQorKysgSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTAs NyArMzkwLDcgQEAgTkVWRVJfSU5MSU5FIGJvb2wgSW50ZXJwcmV0ZXI6OnJlc29sdmVHbAogICAg IFByb3BlcnR5U2xvdCBzbG90KGdsb2JhbE9iamVjdCk7CiAgICAgaWYgKGdsb2JhbE9iamVjdC0+ Z2V0UHJvcGVydHlTbG90KGNhbGxGcmFtZSwgaWRlbnQsIHNsb3QpKSB7CiAgICAgICAgIEpTVmFs dWUqIHJlc3VsdCA9IHNsb3QuZ2V0VmFsdWUoY2FsbEZyYW1lLCBpZGVudCk7Ci0gICAgICAgIGlm IChzbG90LmlzQ2FjaGVhYmxlKCkpIHsKKyAgICAgICAgaWYgKHNsb3QuaXNDYWNoZWFibGUoKSAm JiAhZ2xvYmFsT2JqZWN0LT5zdHJ1Y3R1cmUoKS0+aXNEaWN0aW9uYXJ5KCkpIHsKICAgICAgICAg ICAgIGlmICh2UENbNF0udS5zdHJ1Y3R1cmUpCiAgICAgICAgICAgICAgICAgdlBDWzRdLnUuc3Ry dWN0dXJlLT5kZXJlZigpOwogICAgICAgICAgICAgZ2xvYmFsT2JqZWN0LT5zdHJ1Y3R1cmUoKS0+ cmVmKCk7CkBAIC01MzI3LDcgKzUzMjcsNyBAQCBKU1ZhbHVlKiBJbnRlcnByZXRlcjo6Y3RpX29w X3Jlc29sdmVfZ2xvCiAgICAgUHJvcGVydHlTbG90IHNsb3QoZ2xvYmFsT2JqZWN0KTsKICAgICBp ZiAoZ2xvYmFsT2JqZWN0LT5nZXRQcm9wZXJ0eVNsb3QoY2FsbEZyYW1lLCBpZGVudCwgc2xvdCkp IHsKICAgICAgICAgSlNWYWx1ZSogcmVzdWx0ID0gc2xvdC5nZXRWYWx1ZShjYWxsRnJhbWUsIGlk ZW50KTsKLSAgICAgICAgaWYgKHNsb3QuaXNDYWNoZWFibGUoKSkgeworICAgICAgICBpZiAoc2xv dC5pc0NhY2hlYWJsZSgpICYmICFnbG9iYWxPYmplY3QtPnN0cnVjdHVyZSgpLT5pc0RpY3Rpb25h cnkoKSkgewogICAgICAgICAgICAgR2xvYmFsUmVzb2x2ZUluZm8mIGdsb2JhbFJlc29sdmVJbmZv ID0gY2FsbEZyYW1lLT5jb2RlQmxvY2soKS0+Z2xvYmFsUmVzb2x2ZUluZm8oZ2xvYmFsUmVzb2x2 ZUluZm9JbmRleCk7CiAgICAgICAgICAgICBpZiAoZ2xvYmFsUmVzb2x2ZUluZm8uc3RydWN0dXJl KQogICAgICAgICAgICAgICAgIGdsb2JhbFJlc29sdmVJbmZvLnN0cnVjdHVyZS0+ZGVyZWYoKTsK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5NTI0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTItMzEgIENhbWVyb24gWndhcmljaCAg PGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBmb3IgYnVnIDIzMDU0OiBDYWNoaW5nIG9mIGds b2JhbCBsb29rdXBzIG9jY3VycyBldmVuIHdoZW4gdGhlIGdsb2JhbCBvYmplY3QgaGFzIGJlY29t ZSBhIGRpY3Rpb25hcnkKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzA1ND4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0Njk5MDU+CisKKyAgICAg ICAgKiBmYXN0L2pzL3BpYy9kZWxldGUtZ2xvYmFsLW9iamVjdC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvanMvcGljL2RlbGV0ZS1nbG9iYWwtb2JqZWN0Lmh0bWw6IEFkZGVk LgorCiAyMDA4LTEyLTMwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Bp Yy9kZWxldGUtZ2xvYmFsLW9iamVjdC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9qcy9waWMvZGVsZXRlLWdsb2JhbC1vYmplY3QtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9waWMvZGVsZXRlLWdsb2JhbC1vYmplY3Qt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQgQEAKK1RoaXMgcGFnZSB0ZXN0 cyBmb3IgY29ycmVjdCBiZWhhdmlvciBpbiB0aGUgY2FzZSBvZiBhIGdsb2JhbCBvYmplY3QgdGhh dCBoYXMgaGFkIGEgcHJvcGVydHkgZGVsZXRlZC4gSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3UnbGwg c2VlIGEgUEFTUyBtZXNzYWdlIGJlbG93LgorCitQQVNTOiB4IHNob3VsZCBiZSA0MiBhbmQgaXMu CisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvcGljL2RlbGV0ZS1nbG9iYWwtb2JqZWN0Lmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9waWMvZGVsZXRlLWdsb2JhbC1v YmplY3QuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcGljL2RlbGV0 ZS1nbG9iYWwtb2JqZWN0Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzkgQEAKKzxwPgor VGhpcyBwYWdlIHRlc3RzIGZvciBjb3JyZWN0IGJlaGF2aW9yIGluIHRoZSBjYXNlIG9mIGEgZ2xv YmFsIG9iamVjdCB0aGF0IGhhcworaGFkIGEgcHJvcGVydHkgZGVsZXRlZC4gSWYgdGhlIHRlc3Qg cGFzc2VzLCB5b3UnbGwgc2VlIGEgUEFTUyBtZXNzYWdlIGJlbG93LgorPC9wPgorCis8cHJlIGlk PSJjb25zb2xlIj48L3ByZT4KKworPHNjcmlwdD4KKyhmdW5jdGlvbigpIHsKKyAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisKKyAgICBmdW5jdGlvbiBsb2cocykKKyAgICB7CisgICAgICAgIGlmICh0 aGlzLmRvY3VtZW50KQorICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNv bGUiKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShzICsgIlxuIikpOworICAg ICAgICBlbHNlCisgICAgICAgICAgICBwcmludChzICsgIlxuIik7CisgICAgfQorCisgICAgZnVu Y3Rpb24gc2hvdWxkQmUoYSwgYURlc2NyaXB0aW9uLCBiKQorICAgIHsKKyAgICAgICAgaWYgKGEg PT09IGIpIHsKKyAgICAgICAgICAgIGxvZygiUEFTUzogIiArIGFEZXNjcmlwdGlvbiArICIgc2hv dWxkIGJlICIgKyBiICsgIiBhbmQgaXMuIik7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICBsb2coIkZBSUw6ICIgKyBhRGVzY3JpcHRpb24gKyAiIHNob3VsZCBiZSAiICsgYiArICIgYnV0 IGluc3RlYWQgaXMgIiArIGEgKyAiLiIpOworICAgICAgICB9CisgICAgfQorCisgICAgYSA9IDE7 CisgICAgZGVsZXRlIGE7CisgICAgeSA9ICIiOworICAgIF9fZGVmaW5lR2V0dGVyX18oIngiLCBm dW5jdGlvbigpIHsgcmV0dXJuIHk7IH0pOworICAgIHg7CisgICAgX19kZWZpbmVHZXR0ZXJfXygi eSIsIGZ1bmN0aW9uKCkgeyByZXR1cm4gNDI7IH0pOworCisgICAgc2hvdWxkQmUoeCwgIngiLCA0 Mik7Cit9KSgpOworPC9zY3JpcHQ+Cg==