230480 2021-09-20 07:37:17 -0700 REGRESSION(r282735): build failing on gtk/gcc 2021-09-22 08:45:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=230455 P2 Normal --- 1 jmason webkit-unassigned bfulgham koivisto ross.kirsling simon.fraser zalan oldest_to_newest 1795076 0 jmason 2021-09-20 07:37:17 -0700 Building with gcc 10, gtk 3. Still breaking as of r282742. Reversing the commit r282735 makes the build complete normally. Build failure is as follows: In file included from /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/LegacyInlineFlowBox.cpp:44, from WebCore/DerivedSources/unified-sources/UnifiedSource-043dd90b-4.cpp:7: /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:45: error: 'InlineContent' in namespace 'WebCore::LayoutIntegration' does not name a type 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^~~~~~~~~~~~~ /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:67: error: 'Layout' does not name a type; did you mean 'TextLayout'? 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^~~~~~ | TextLayout /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:78: error: expected unqualified-id before '&' token 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^ /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:78: error: expected ')' before '&' token 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ~ ^ | ) /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:78: error: constructors may not be ref-qualified /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:81: warning: ISO C++ forbids declaration of 'PaintInfo' with no type [-fpermissive] 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^~~~~~~~~ /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:81: error: expected ';' at end of member declaration 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^~~~~~~~~ | ; /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:50:91: error: expected unqualified-id before ',' token 50 | TextBoxPainter(const LayoutIntegration::InlineContent&, const Layout::Run&, PaintInfo&, const LayoutPoint& paintOffset); | ^ /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:58:58: error: 'PaintInfo' is not a type 58 | TextBoxPainter(LayoutIntegration::TextRunIterator&&, PaintInfo&, const LayoutPoint& paintOffset); | ^~~~~~~~~ /build/rocketman/components/desktop/webkitgtk4-dev/webkit/Source/WebCore/rendering/TextBoxPainter.h:92:5: error: 'PaintInfo' does not name a type 92 | PaintInfo& m_paintInfo; | ^~~~~~~~~ [2758/5099] Building CXX object Source...sources/UnifiedSource-043dd90b-6.cpp.o ninja: build stopped: subcommand failed. gmake: *** [/build/rocketman/make-rules/justmake.mk:65: /build/rocketman/components/desktop/webkitgtk4-dev/build/amd64/.built] Error 1 1796090 1 jmason 2021-09-22 08:45:29 -0700 This has been fixed by r282788 <ross.kirsling@sony.com>: "Unreviewed build fix for WinCairo with ENABLE_EXPERIMENTAL_FEATURES off" Thank you, Ross!