230459 2021-09-19 06:59:03 -0700 [lFC][Integration] Enable some text painting features 2022-03-15 12:49:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=237898 InRadar P2 Normal --- 1 koivisto koivisto bfulgham sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1794871 0 koivisto 2021-09-19 06:59:03 -0700 some more coverage 1794875 1 438594 koivisto 2021-09-19 07:35:14 -0700 Created attachment 438594 Patch 1794883 2 438594 sam 2021-09-19 09:44:33 -0700 Comment on attachment 438594 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438594&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63 > + // Unused = 1LLU << 23, Are you doing this so you don't have to change all the numbers after this one? Or do these need to stay consistent across builds for serialization reasons? (either is ok, just curious) 1794885 3 zalan 2021-09-19 09:46:35 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 438594 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438594&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63 > > + // Unused = 1LLU << 23, > > Are you doing this so you don't have to change all the numbers after this > one? Or do these need to stay consistent across builds for serialization > reasons? (either is ok, just curious) The former. I tend to collapse it from time to time though. 1794890 4 ews-feeder 2021-09-19 10:04:44 -0700 Committed r282737 (241874@main): <https://commits.webkit.org/241874@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438594. 1794891 5 webkit-bug-importer 2021-09-19 10:05:17 -0700 <rdar://problem/83285459> 1794896 6 koivisto 2021-09-19 10:33:27 -0700 Also makes patches collide less. 438594 2021-09-19 07:35:14 -0700 2021-09-19 10:04:45 -0700 Patch bug-230459-20210919173513.patch text/plain 5509 koivisto U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk0Y2I1YjkzYWM4MTll NGM3NzM5ZGNlMmNlZWU3YmY2NzA3NmI0ZC4uMzIzMDMzNTRlODRiMzllNGUzOWUzMzI2MjU4YTNj NmNiOGE2YTc5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA5LTE5ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBbbEZDXVtJbnRlZ3JhdGlv bl0gRW5hYmxlIHNvbWUgdGV4dCBwYWludGluZyBmZWF0dXJlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwNDU5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIHRleHQtc2hhZG93IGFuZCBiYWNr Z3JvdW5kLWNsaXA6dGV4dC4KKworICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJ bnRlZ3JhdGlvbkNvdmVyYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dEludGVncmF0 aW9uOjpwcmludFJlYXNvbik6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3JhdGlvbjo6 Y2FuVXNlRm9yU3R5bGUpOgorICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRl Z3JhdGlvbkNvdmVyYWdlLmg6CisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dElu dGVncmF0aW9uTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXRJbnRlZ3Jh dGlvbjo6TGluZUxheW91dDo6cGFpbnQpOgorCisgICAgICAgIEFsbG93IFRleHRDbGlwIHBhaW50 IHBoYXNlLgorCiAyMDIxLTA5LTE5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gUGFpbnQgTEZDIHRleHQgcnVucyB3aXRoIFRl eHRCb3hQYWludGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRp b24vTGF5b3V0SW50ZWdyYXRpb25Db3ZlcmFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Db3ZlcmFnZS5jcHAKaW5kZXggYTM1ZDdmYWVj NTM5MTc2ODdmZGNjNDc2MmM5NjdlMzY2YmIwNTc4NS4uYjY4N2M4MDA5YzYzZTIwOWE2YWFkZTcz ZWM5MmVkNzJlOTM5ZDFiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkNvdmVyYWdlLmNwcApAQCAtMTUz LDkgKzE1Myw2IEBAIHN0YXRpYyB2b2lkIHByaW50UmVhc29uKEF2b2lkYW5jZVJlYXNvbiByZWFz b24sIFRleHRTdHJlYW0mIHN0cmVhbSkKICAgICBjYXNlIEF2b2lkYW5jZVJlYXNvbjo6Rmxvd0hh c1RleHRDb21iaW5lOgogICAgICAgICBzdHJlYW0gPDwgInRleHQgY29tYmluZSI7CiAgICAgICAg IGJyZWFrOwotICAgIGNhc2UgQXZvaWRhbmNlUmVhc29uOjpGbG93SGFzVGV4dEZpbGxCb3g6Ci0g ICAgICAgIHN0cmVhbSA8PCAiYmFja2dyb3VuZC1jb2xvciAodGV4dC1maWxsKSI7Ci0gICAgICAg IGJyZWFrOwogICAgIGNhc2UgQXZvaWRhbmNlUmVhc29uOjpGbG93SGFzQm9yZGVyRml0TGluZXM6 CiAgICAgICAgIHN0cmVhbSA8PCAiLXdlYmtpdC1ib3JkZXItZml0IjsKICAgICAgICAgYnJlYWs7 CkBAIC0xOTIsOSArMTg5LDYgQEAgc3RhdGljIHZvaWQgcHJpbnRSZWFzb24oQXZvaWRhbmNlUmVh c29uIHJlYXNvbiwgVGV4dFN0cmVhbSYgc3RyZWFtKQogICAgIGNhc2UgQXZvaWRhbmNlUmVhc29u OjpGbG93SGFzQ29tcGxleEZvbnRDb2RlUGF0aDoKICAgICAgICAgc3RyZWFtIDw8ICJ0ZXh0IHdp dGggY29tcGxleCBmb250IGNvZGVwYXRoIjsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBBdm9p ZGFuY2VSZWFzb246OkZsb3dIYXNUZXh0U2hhZG93OgotICAgICAgICBzdHJlYW0gPDwgInRleHQt c2hhZG93IjsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBBdm9pZGFuY2VSZWFzb246OkZsb3dD aGlsZElzU2VsZWN0ZWQ6CiAgICAgICAgIHN0cmVhbSA8PCAic2VsZWN0ZWQgY29udGVudCI7CiAg ICAgICAgIGJyZWFrOwpAQCAtNTA5LDE2ICs1MDMsMTIgQEAgc3RhdGljIE9wdGlvblNldDxBdm9p ZGFuY2VSZWFzb24+IGNhblVzZUZvclN0eWxlKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSwgSW5j bHUKICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93SGFzUlRMT3Jk ZXJpbmcsIHJlYXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICBpZiAoc3R5bGUudGV4dEVtcGhh c2lzRmlsbCgpICE9IFRleHRFbXBoYXNpc0ZpbGw6OkZpbGxlZCB8fCBzdHlsZS50ZXh0RW1waGFz aXNNYXJrKCkgIT0gVGV4dEVtcGhhc2lzTWFyazo6Tm9uZSkKICAgICAgICAgU0VUX1JFQVNPTl9B TkRfUkVUVVJOX0lGX05FRURFRChGbG93SGFzVGV4dEVtcGhhc2lzRmlsbE9yTWFyaywgcmVhc29u cywgaW5jbHVkZVJlYXNvbnMpOwotICAgIGlmIChzdHlsZS50ZXh0U2hhZG93KCkpCi0gICAgICAg IFNFVF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd0hhc1RleHRTaGFkb3csIHJlYXNv bnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICBpZiAoc3R5bGUuaGFzUHNldWRvU3R5bGUoUHNldWRv SWQ6OkZpcnN0TGluZSkpCiAgICAgICAgIFNFVF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQo Rmxvd0hhc1BzZXVkb0ZpcnN0TGluZSwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogICAgIGlm IChzdHlsZS5oYXNQc2V1ZG9TdHlsZShQc2V1ZG9JZDo6Rmlyc3RMZXR0ZXIpKQogICAgICAgICBT RVRfUkVBU09OX0FORF9SRVRVUk5fSUZfTkVFREVEKEZsb3dIYXNQc2V1ZG9GaXJzdExldHRlciwg cmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogICAgIGlmIChzdHlsZS5oYXNUZXh0Q29tYmluZSgp KQogICAgICAgICBTRVRfUkVBU09OX0FORF9SRVRVUk5fSUZfTkVFREVEKEZsb3dIYXNUZXh0Q29t YmluZSwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwotICAgIGlmIChzdHlsZS5iYWNrZ3JvdW5k Q2xpcCgpID09IEZpbGxCb3g6OlRleHQpCi0gICAgICAgIFNFVF9SRUFTT05fQU5EX1JFVFVSTl9J Rl9ORUVERUQoRmxvd0hhc1RleHRGaWxsQm94LCByZWFzb25zLCBpbmNsdWRlUmVhc29ucyk7CiAK ICAgICAvLyBUaGVzZSBhcmUgbm9uLXN0YW5kYXJkIHByb3BlcnRpZXMuCiAgICAgaWYgKHN0eWxl LmxpbmVCcmVhaygpID09IExpbmVCcmVhazo6QWZ0ZXJXaGl0ZVNwYWNlKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJh Z2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlv bkNvdmVyYWdlLmgKaW5kZXggMjAwZTQxYWY4MzcxOWE5OTBhMWFkNzU2MzcxZWQ2M2Y3YjQwZGVj MS4uNWJiZmUzYjk2MmQ0YTZmN2E2OTE2NjU4NjFkNTRjMDFmOGU4YWUyZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJh Z2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdy YXRpb25Db3ZlcmFnZS5oCkBAIC02MCwxMSArNjAsMTEgQEAgZW51bSBjbGFzcyBBdm9pZGFuY2VS ZWFzb24gOiB1aW50NjRfdCB7CiAgICAgRmxvd0hhc0xpbmVBbGlnbkVkZ2VzICAgICAgICAgICAg ICAgICAgICAgICAgPSAxTExVICA8PCAyMCwKICAgICBGbG93SGFzTGluZVNuYXAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDIxLAogICAgIEZsb3dIYXNUZXh0RW1waGFz aXNGaWxsT3JNYXJrICAgICAgICAgICAgICAgID0gMUxMVSAgPDwgMjIsCi0gICAgRmxvd0hhc1Rl eHRTaGFkb3cgICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAxTExVICA8PCAyMywKKyAgICAv LyBVbnVzZWQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDIz LAogICAgIEZsb3dIYXNQc2V1ZG9GaXJzdExpbmUgICAgICAgICAgICAgICAgICAgICAgID0gMUxM VSAgPDwgMjQsCiAgICAgRmxvd0hhc1BzZXVkb0ZpcnN0TGV0dGVyICAgICAgICAgICAgICAgICAg ICAgPSAxTExVICA8PCAyNSwKICAgICBGbG93SGFzVGV4dENvbWJpbmUgICAgICAgICAgICAgICAg ICAgICAgICAgICA9IDFMTFUgIDw8IDI2LAotICAgIEZsb3dIYXNUZXh0RmlsbEJveCAgICAgICAg ICAgICAgICAgICAgICAgICAgID0gMUxMVSAgPDwgMjcsCisgICAgLy8gVW51c2VkICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgPSAxTExVICA8PCAyNywKICAgICBGbG93SGFzQm9y ZGVyRml0TGluZXMgICAgICAgICAgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDI4LAogICAgIEZs b3dIYXNBZnRlcldoaXRlU3BhY2VMaW5lQnJlYWsgICAgICAgICAgICAgID0gMUxMVSAgPDwgMjks CiAgICAgRmxvd0hhc1RleHRTZWN1cml0eSAgICAgICAgICAgICAgICAgICAgICAgICAgPSAxTExV ICA8PCAzMCwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9M YXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu dGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggMDYyMmJmYjk1 MWNiYzQxYmI2ZDlmZTA4OTQ2OGYzNzExY2U1NmVkZS4uOTJkZjBlY2FjMzNiMTE3ZDJlMzc0NGMx NjgxMGE3YjE0YzgyZDQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKQEAg LTQ5Miw3ICs0OTIsNyBAQCB2b2lkIExpbmVMYXlvdXQ6OnBhaW50KFBhaW50SW5mbyYgcGFpbnRJ bmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQpCiAgICAgaWYgKCFtX2lubGluZUNv bnRlbnQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChwYWludEluZm8ucGhhc2UgIT0gUGFp bnRQaGFzZTo6Rm9yZWdyb3VuZCAmJiBwYWludEluZm8ucGhhc2UgIT0gUGFpbnRQaGFzZTo6RXZl bnRSZWdpb24pCisgICAgaWYgKHBhaW50SW5mby5waGFzZSAhPSBQYWludFBoYXNlOjpGb3JlZ3Jv dW5kICYmIHBhaW50SW5mby5waGFzZSAhPSBQYWludFBoYXNlOjpFdmVudFJlZ2lvbiAmJiBwYWlu dEluZm8ucGhhc2UgIT0gUGFpbnRQaGFzZTo6VGV4dENsaXApCiAgICAgICAgIHJldHVybjsKIAog ICAgIGF1dG8gcGFpbnRSZWN0ID0gcGFpbnRJbmZvLnJlY3Q7Cg==