230423 2021-09-17 12:54:16 -0700 [ Catalina+ Win WK1 ] http/tests/misc/iframe-reparenting-id-collision.html is a flaky text failure 2021-09-17 17:39:42 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jenner cdumez achristensen beidson cdumez ggaren simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1794563 0 jenner 2021-09-17 12:54:16 -0700 http/tests/misc/iframe-reparenting-id-collision.html is a flaky text failure when running on WK1 for Windows and Catalina+ HISTORY: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmisc%2Fiframe-reparenting-id-collision.html TEXT DIFF: --- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-expected.txt +++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-actual.txt @@ -5,4 +5,6 @@ Beginning adoption sequence. PASS: adopted node without id collision PASS: adopted back to original page without id collision +Started loading iframe XHR request. +Beginning adoption sequence. 1794566 1 webkit-bug-importer 2021-09-17 13:01:33 -0700 <rdar://problem/83252545> 1794568 2 jenner 2021-09-17 13:03:16 -0700 I was able to easily reproduce this at Production ToT using the following test: run-webkit-tests http/tests/misc/iframe-reparenting-id-collision.html --iterations 10 -1 1794615 3 jenner 2021-09-17 14:29:51 -0700 I was able to reproduce the failure back to r282609. I then checked out my local repository to r282607, and ran the test again on the same revision, and it was not reproducible at that point. I even took --iterations up to 1000, and was not able to reproduce the failure with my local checkout at r282607, while running tests on r282609. So it appears that r282609 introduced the flaky failure. 1794656 4 438524 cdumez 2021-09-17 15:49:20 -0700 Created attachment 438524 Patch 1794660 5 438524 ggaren 2021-09-17 15:56:04 -0700 Comment on attachment 438524 Patch r=me 1794719 6 ews-feeder 2021-09-17 17:39:39 -0700 Committed r282716 (241853@main): <https://commits.webkit.org/241853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438524. 438524 2021-09-17 15:49:20 -0700 2021-09-17 17:39:40 -0700 Patch bug-230423-20210917154920.patch text/plain 2098 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNjk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjliNmRmZWI3MzM0Zjg2ZDA4YjQ1 ODI5NWYzMzQyNDhlZDhjY2MzYy4uNjNhNjhhZmNlZjc3YWY3Mjc1YTIwZjA1MmU3ZGM5OGEyMjg2 MDc5NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA5LTE3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBDYXRhbGluYSsgV2luIFdLMSBdIGh0dHAvdGVz dHMvbWlzYy9pZnJhbWUtcmVwYXJlbnRpbmctaWQtY29sbGlzaW9uLmh0bWwgaXMgYSBmbGFreSB0 ZXh0IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzMDQyMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODMyNTI1NDU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3Qgb3BlbnMgMiBp ZGVudGljYWwgd2luZG93cy4gRWFjaCBvZiB0aGVzZSB3aW5kb3dzIGhhcyBhbiBpZnJhbWUgd2hp Y2ggc3RhcnRzIGFuIFhIUiBhbmQgdGhlbgorICAgICAgICBjYWxscyBpZnJhbWVYSFJTdGFydGVk KCkgYW5kIGVuZCB1cCBvdXRwdXRpbmcgdGhlIGZvbGxvd2luZyBsaW5lOgorICAgICAgICAiU3Rh cnRlZCBsb2FkaW5nIGlmcmFtZSBYSFIgcmVxdWVzdC4iCisKKyAgICAgICAgV2hlbiB0aGUgdGVz dCBmYWlscywgd2Ugc2VlIHRoaXMgbGluZSBsb2dnZWQgYSB0aGlyZCB0aW1lLCBldmVuIHRob3Vn aCB0aGVyZSBhcmUgMiBwb3B1cCB3aW5kb3dzLgorICAgICAgICBUaGUgcmVhc29uIGZvciB0aGlz IGlzIHRoYXQgaWZyYW1lWEhSU3RhcnRlZCgpIHRyYW5zZmVycyBhbiBpZnJhbWUgZnJvbSBvbmUg cG9wdXAgdG8gYW5vdGhlciBvbmNlCisgICAgICAgIGJvdGggWEhScyBoYXZlIHN0YXJ0ZWQuIFdo ZW4gdHJhbnNmZXJyaW5nIHRoZSBpZnJhbWUgYSBuZXcgWEhSIHN0YXJ0cy4gVGhlIHRlc3QgY2Fs bHMKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCkgcmlnaHQgYXdheSBidXQgaW4gc29t ZSBjYXNlcywgdGhlIFhIUiBzdGlsbCBoYXMgdGltZSB0byBzdGFydCBhbmQgcHJpbnQKKyAgICAg ICAgdGhlIGV4dHJhIGxpbmUuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvaWZyYW1lLXJl cGFyZW50aW5nLWlkLWNvbGxpc2lvbi5odG1sOgorCiAyMDIxLTA5LTE3ICBDYW1lcm9uIE1jQ29y bWFjayAgPGhleWNhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUHJlc2VydmUgY29sb3Igc3BhY2Ug d2hlbiBjcmVhdGluZyBJbWFnZUJ1ZmZlcnMgZm9yIEltYWdlQml0bWFwcwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2lmcmFtZS1yZXBhcmVudGluZy1pZC1jb2xsaXNp b24uaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9pZnJhbWUtcmVwYXJlbnRpbmct aWQtY29sbGlzaW9uLmh0bWwKaW5kZXggNGFlY2U5MDczZTA3NzZmM2FiZGNhMjQ3ZGE1MjZiZGFm YzcyZTYwYy4uNGQ4YWE1YWJiYTJkN2I0MmIwZTE2MThhZTcxMDhjNjFhMjY5MzBjZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2lmcmFtZS1yZXBhcmVudGluZy1pZC1j b2xsaXNpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvaWZyYW1lLXJl cGFyZW50aW5nLWlkLWNvbGxpc2lvbi5odG1sCkBAIC0yMiw5ICsyMiwxMSBAQCBpZnJhbWVYSFJG aW5pc2hlZCA9IGZ1bmN0aW9uKCkKIAogaWZyYW1lWEhSU3RhcnRlZCA9IGZ1bmN0aW9uKCkKIHsK LSAgICBsb2coIlN0YXJ0ZWQgbG9hZGluZyBpZnJhbWUgWEhSIHJlcXVlc3QuIik7CiAgICAgKytp ZnJhbWVYSFJDb3VudDsKKyAgICBpZiAoaWZyYW1lWEhSQ291bnQgPiAyKQorICAgICAgICByZXR1 cm47CiAKKyAgICBsb2coIlN0YXJ0ZWQgbG9hZGluZyBpZnJhbWUgWEhSIHJlcXVlc3QuIik7CiAg ICAgaWYgKGlmcmFtZVhIUkNvdW50IDwgMikKICAgICAgICAgcmV0dXJuOwogCg==