230422 2021-09-17 12:51:24 -0700 Add CustomToJSObject wrapper for CSSStyleValueCustom 2021-09-17 16:16:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175733 1 johnson.zhou.sh johnson.zhou.sh achristensen esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard webkit-bug-importer oldest_to_newest 1794561 0 johnson.zhou.sh 2021-09-17 12:51:24 -0700 Add CustomToJSObject wrapper for CSSStyleValueCustom 1794562 1 438505 johnson.zhou.sh 2021-09-17 12:52:09 -0700 Created attachment 438505 Patch 1794565 2 438505 achristensen 2021-09-17 12:59:13 -0700 Comment on attachment 438505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438505&action=review > Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp:50 > + if (is<CSSUnparsedValue>(value)) Can this use a switch statement instead? switch(value->getType()) That way if someone adds more it'll be a compiler error instead of searching for the places they forgot to add code. 1794589 3 438511 johnson.zhou.sh 2021-09-17 13:46:16 -0700 Created attachment 438511 Patch 1794672 4 ews-feeder 2021-09-17 16:15:53 -0700 Committed r282706 (241843@main): <https://commits.webkit.org/241843@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438511. 1794673 5 webkit-bug-importer 2021-09-17 16:16:24 -0700 <rdar://problem/83259645> 438505 2021-09-17 12:52:09 -0700 2021-09-17 13:46:13 -0700 Patch bug-230422-20210917125209.patch text/plain 3493 johnson.zhou.sh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FhMjdhZDlhZjZhNTlj NmYxMTk3MTg0YTI1MWZiZWUxZmU2NmQ5Ni4uNDBmYmRlNGExMmNiNGU1OGNmM2M4MzJhNDAzNjc1 MGIyN2E4YmVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA5LTE3ICBKb2hu c29uIFpob3UgIDxxaWFvc29uZ196aG91QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgQ3VzdG9t VG9KU09iamVjdCB3cmFwcGVyIGZvciBDU1NTdHlsZVZhbHVlQ3VzdG9tCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA0MjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTU3R5 bGVWYWx1ZUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0pTTmV3bHlDcmVhdGVkKToK KyAgICAgICAgKiBjc3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUuaDoKKyAgICAgICAgKGlzVHlw ZSk6CisKIDIwMjEtMDktMTYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgVGhyb3R0bGUgYSBjb3VwbGUgb2YgZWRpdGluZy1yZWxhdGVkIHRpbWVycyBp biBjYXNlcyB3aGVyZSB0aGUgdXNlciBoYXMgbm90IGludGVyYWN0ZWQgd2l0aCBzdWJmcmFtZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVWYWx1ZUN1 c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlVmFsdWVDdXN0 b20uY3BwCmluZGV4IDUwMzIyYThiMzBkYTE1ZmQ5ZTMwMzFkYTI4YWJmNzU3NzEzNzFmOTUuLmNj Y2NlNTMwOTVjYzZhZDFmMGQ2ODAxZTIxMzg2NWRkYTcyZmMwMmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVWYWx1ZUN1c3RvbS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZVZhbHVlQ3VzdG9tLmNwcApAQCAtMjgs NiArMjgsOSBAQAogCiAjaWYgRU5BQkxFKENTU19UWVBFRF9PTSkKIAorI2luY2x1ZGUgIkpTQ1NT S2V5d29yZFZhbHVlLmgiCisjaW5jbHVkZSAiSlNDU1NNYXRoVmFsdWUuaCIKKyNpbmNsdWRlICJK U0NTU051bWVyaWNWYWx1ZS5oIgogI2luY2x1ZGUgIkpTQ1NTU3R5bGVJbWFnZVZhbHVlLmgiCiAj aW5jbHVkZSAiSlNDU1NVbml0VmFsdWUuaCIKICNpbmNsdWRlICJKU0NTU1VucGFyc2VkVmFsdWUu aCIKQEAgLTM4LDE3ICs0MSwyMCBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogCiBKU1ZhbHVlIHRv SlNOZXdseUNyZWF0ZWQoSlNHbG9iYWxPYmplY3QqLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFs T2JqZWN0LCBSZWY8Q1NTU3R5bGVWYWx1ZT4mJiB2YWx1ZSkKIHsKLSAgICBzd2l0Y2ggKHZhbHVl LT5nZXRUeXBlKCkpIHsKLSAgICBjYXNlIENTU1N0eWxlVmFsdWVUeXBlOjpDU1NVbml0VmFsdWU6 CisgICAgaWYgKGlzPENTU0tleXdvcmRWYWx1ZT4odmFsdWUpKQorICAgICAgICByZXR1cm4gY3Jl YXRlV3JhcHBlcjxDU1NLZXl3b3JkVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkp OworICAgIGlmIChpczxDU1NVbml0VmFsdWU+KHZhbHVlKSkKICAgICAgICAgcmV0dXJuIGNyZWF0 ZVdyYXBwZXI8Q1NTVW5pdFZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUodmFsdWUpKTsKLSAg ICBjYXNlIENTU1N0eWxlVmFsdWVUeXBlOjpDU1NVbnBhcnNlZFZhbHVlOgotICAgICAgICByZXR1 cm4gY3JlYXRlV3JhcHBlcjxDU1NVbnBhcnNlZFZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUo dmFsdWUpKTsKLSAgICBjYXNlIENTU1N0eWxlVmFsdWVUeXBlOjpDU1NTdHlsZUltYWdlVmFsdWU6 CisgICAgaWYgKGlzPENTU1N0eWxlSW1hZ2VWYWx1ZT4odmFsdWUpKQogICAgICAgICByZXR1cm4g Y3JlYXRlV3JhcHBlcjxDU1NTdHlsZUltYWdlVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2 YWx1ZSkpOwotICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENTU1N0 eWxlVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkpOwotICAgIH0KLQorICAgIGlm IChpczxDU1NVbnBhcnNlZFZhbHVlPih2YWx1ZSkpCisgICAgICAgIHJldHVybiBjcmVhdGVXcmFw cGVyPENTU1VucGFyc2VkVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkpOworICAg IGlmIChpczxDU1NOdW1lcmljVmFsdWU+KHZhbHVlKSkKKyAgICAgICAgcmV0dXJuIGNyZWF0ZVdy YXBwZXI8Q1NTTnVtZXJpY1ZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUodmFsdWUpKTsKKyAg ICBpZiAoaXM8Q1NTTWF0aFZhbHVlPih2YWx1ZSkpCisgICAgICAgIHJldHVybiBjcmVhdGVXcmFw cGVyPENTU01hdGhWYWx1ZT4oZ2xvYmFsT2JqZWN0LCBXVEZNb3ZlKHZhbHVlKSk7CisgICAgCisg ICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXI8Q1NTU3R5bGVWYWx1ZT4oZ2xvYmFsT2JqZWN0LCBXVEZN b3ZlKHZhbHVlKSk7CiB9CiAKIEpTVmFsdWUgdG9KUyhKU0dsb2JhbE9iamVjdCogbGV4aWNhbEds b2JhbE9iamVjdCwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ1NTU3R5bGVWYWx1 ZSYgb2JqZWN0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL3R5cGVkb20vQ1NTS2V5 d29yZFZhbHVlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUu aAppbmRleCBjYWI3ZTY0OWIzYWEyMmE2NDRkNTE2MGFjMDNkZGQxMWQ3ZjQwM2ExLi5kY2E0MDlj NjFjMzMxMzVkZDRhNzcwY2U3MTY5YWIwZmY0ZmUwY2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUuaApAQCAtNTMsNyArNTMsNyBAQCBwcml2YXRlOgog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiBTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0JFR0lOKFdl YkNvcmU6OkNTU0tleXdvcmRWYWx1ZSkKLSAgICBzdGF0aWMgYm9vbCBpc1R5cGUoY29uc3QgV2Vi Q29yZTo6Q1NTS2V5d29yZFZhbHVlJiBzdHlsZVZhbHVlKSB7IHJldHVybiBzdHlsZVZhbHVlLmdl dFR5cGUoKSA9PSBXZWJDb3JlOjpDU1NTdHlsZVZhbHVlVHlwZTo6Q1NTS2V5d29yZFZhbHVlOyB9 CisgICAgc3RhdGljIGJvb2wgaXNUeXBlKGNvbnN0IFdlYkNvcmU6OkNTU1N0eWxlVmFsdWUmIHN0 eWxlVmFsdWUpIHsgcmV0dXJuIHN0eWxlVmFsdWUuZ2V0VHlwZSgpID09IFdlYkNvcmU6OkNTU1N0 eWxlVmFsdWVUeXBlOjpDU1NLZXl3b3JkVmFsdWU7IH0KIFNQRUNJQUxJWkVfVFlQRV9UUkFJVFNf RU5EKCkKIAogI2VuZGlmCg== 438511 2021-09-17 13:46:16 -0700 2021-09-17 16:15:54 -0700 Patch bug-230422-20210917134615.patch text/plain 3471 johnson.zhou.sh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FhMjdhZDlhZjZhNTlj NmYxMTk3MTg0YTI1MWZiZWUxZmU2NmQ5Ni4uNDBmYmRlNGExMmNiNGU1OGNmM2M4MzJhNDAzNjc1 MGIyN2E4YmVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA5LTE3ICBKb2hu c29uIFpob3UgIDxxaWFvc29uZ196aG91QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgQ3VzdG9t VG9KU09iamVjdCB3cmFwcGVyIGZvciBDU1NTdHlsZVZhbHVlQ3VzdG9tCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA0MjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTU3R5 bGVWYWx1ZUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0pTTmV3bHlDcmVhdGVkKToK KyAgICAgICAgKiBjc3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUuaDoKKyAgICAgICAgKGlzVHlw ZSk6CisKIDIwMjEtMDktMTYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgVGhyb3R0bGUgYSBjb3VwbGUgb2YgZWRpdGluZy1yZWxhdGVkIHRpbWVycyBp biBjYXNlcyB3aGVyZSB0aGUgdXNlciBoYXMgbm90IGludGVyYWN0ZWQgd2l0aCBzdWJmcmFtZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVWYWx1ZUN1 c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlVmFsdWVDdXN0 b20uY3BwCmluZGV4IDUwMzIyYThiMzBkYTE1ZmQ5ZTMwMzFkYTI4YWJmNzU3NzEzNzFmOTUuLjM4 MzdlODkzYzNiN2UxNDk2OTY3ZjU0NmU5YjgzYjQ3YTkyYTg2MGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVWYWx1ZUN1c3RvbS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZVZhbHVlQ3VzdG9tLmNwcApAQCAtMjgs NiArMjgsOSBAQAogCiAjaWYgRU5BQkxFKENTU19UWVBFRF9PTSkKIAorI2luY2x1ZGUgIkpTQ1NT S2V5d29yZFZhbHVlLmgiCisjaW5jbHVkZSAiSlNDU1NNYXRoVmFsdWUuaCIKKyNpbmNsdWRlICJK U0NTU051bWVyaWNWYWx1ZS5oIgogI2luY2x1ZGUgIkpTQ1NTU3R5bGVJbWFnZVZhbHVlLmgiCiAj aW5jbHVkZSAiSlNDU1NVbml0VmFsdWUuaCIKICNpbmNsdWRlICJKU0NTU1VucGFyc2VkVmFsdWUu aCIKQEAgLTM5LDE2ICs0MiwyMiBAQCB1c2luZyBuYW1lc3BhY2UgSlNDOwogSlNWYWx1ZSB0b0pT TmV3bHlDcmVhdGVkKEpTR2xvYmFsT2JqZWN0KiwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdCwgUmVmPENTU1N0eWxlVmFsdWU+JiYgdmFsdWUpCiB7CiAgICAgc3dpdGNoICh2YWx1ZS0+ Z2V0VHlwZSgpKSB7CisgICAgY2FzZSBDU1NTdHlsZVZhbHVlVHlwZTo6Q1NTU3R5bGVJbWFnZVZh bHVlOgorICAgICAgICByZXR1cm4gY3JlYXRlV3JhcHBlcjxDU1NTdHlsZUltYWdlVmFsdWU+KGds b2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkpOworICAgIGNhc2UgQ1NTU3R5bGVWYWx1ZVR5cGU6 OkNTU051bWVyaWNWYWx1ZToKKyAgICAgICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXI8Q1NTTnVtZXJp Y1ZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUodmFsdWUpKTsKKyAgICBjYXNlIENTU1N0eWxl VmFsdWVUeXBlOjpDU1NNYXRoVmFsdWU6CisgICAgICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENT U01hdGhWYWx1ZT4oZ2xvYmFsT2JqZWN0LCBXVEZNb3ZlKHZhbHVlKSk7CiAgICAgY2FzZSBDU1NT dHlsZVZhbHVlVHlwZTo6Q1NTVW5pdFZhbHVlOgogICAgICAgICByZXR1cm4gY3JlYXRlV3JhcHBl cjxDU1NVbml0VmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkpOwogICAgIGNhc2Ug Q1NTU3R5bGVWYWx1ZVR5cGU6OkNTU1VucGFyc2VkVmFsdWU6CiAgICAgICAgIHJldHVybiBjcmVh dGVXcmFwcGVyPENTU1VucGFyc2VkVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RGTW92ZSh2YWx1ZSkp OwotICAgIGNhc2UgQ1NTU3R5bGVWYWx1ZVR5cGU6OkNTU1N0eWxlSW1hZ2VWYWx1ZToKLSAgICAg ICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXI8Q1NTU3R5bGVJbWFnZVZhbHVlPihnbG9iYWxPYmplY3Qs IFdURk1vdmUodmFsdWUpKTsKLSAgICBkZWZhdWx0OgorICAgIGNhc2UgQ1NTU3R5bGVWYWx1ZVR5 cGU6OkNTU0tleXdvcmRWYWx1ZToKKyAgICAgICAgcmV0dXJuIGNyZWF0ZVdyYXBwZXI8Q1NTS2V5 d29yZFZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUodmFsdWUpKTsKKyAgICBjYXNlIENTU1N0 eWxlVmFsdWVUeXBlOjpDU1NUcmFuc2Zvcm1WYWx1ZToKKyAgICBjYXNlIENTU1N0eWxlVmFsdWVU eXBlOjpDU1NTdHlsZVZhbHVlOgogICAgICAgICByZXR1cm4gY3JlYXRlV3JhcHBlcjxDU1NTdHls ZVZhbHVlPihnbG9iYWxPYmplY3QsIFdURk1vdmUodmFsdWUpKTsKICAgICB9Ci0KIH0KIAogSlNW YWx1ZSB0b0pTKEpTR2xvYmFsT2JqZWN0KiBsZXhpY2FsR2xvYmFsT2JqZWN0LCBKU0RPTUdsb2Jh bE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDU1NTdHlsZVZhbHVlJiBvYmplY3QpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9jc3MvdHlwZWRvbS9DU1NLZXl3b3JkVmFsdWUuaCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy90eXBlZG9tL0NTU0tleXdvcmRWYWx1ZS5oCmluZGV4IGNhYjdlNjQ5YjNhYTIy YTY0NGQ1MTYwYWMwM2RkZDExZDdmNDAzYTEuLmRjYTQwOWM2MWMzMzEzNWRkNGE3NzBjZTcxNjlh YjBmZjRmZTBjZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy90eXBlZG9tL0NTU0tl eXdvcmRWYWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy90eXBlZG9tL0NTU0tleXdvcmRW YWx1ZS5oCkBAIC01Myw3ICs1Myw3IEBAIHByaXZhdGU6CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CiAKIFNQRUNJQUxJWkVfVFlQRV9UUkFJVFNfQkVHSU4oV2ViQ29yZTo6Q1NTS2V5d29yZFZhbHVl KQotICAgIHN0YXRpYyBib29sIGlzVHlwZShjb25zdCBXZWJDb3JlOjpDU1NLZXl3b3JkVmFsdWUm IHN0eWxlVmFsdWUpIHsgcmV0dXJuIHN0eWxlVmFsdWUuZ2V0VHlwZSgpID09IFdlYkNvcmU6OkNT U1N0eWxlVmFsdWVUeXBlOjpDU1NLZXl3b3JkVmFsdWU7IH0KKyAgICBzdGF0aWMgYm9vbCBpc1R5 cGUoY29uc3QgV2ViQ29yZTo6Q1NTU3R5bGVWYWx1ZSYgc3R5bGVWYWx1ZSkgeyByZXR1cm4gc3R5 bGVWYWx1ZS5nZXRUeXBlKCkgPT0gV2ViQ29yZTo6Q1NTU3R5bGVWYWx1ZVR5cGU6OkNTU0tleXdv cmRWYWx1ZTsgfQogU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19FTkQoKQogCiAjZW5kaWYK