230420 2021-09-17 11:54:32 -0700 [GTK] WebKit tries to own org.mpris.MediaPlayer2 bus names even when MEDIA_SESSION disabled 2021-09-18 09:12:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pgriffis pgriffis bugs-noreply eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio oldest_to_newest 1794542 0 pgriffis 2021-09-17 11:54:32 -0700 If you build webkitgtk without `ENABLE_MEDIA_SESSION` defined you will get warnings: > ** (WebKitWebProcess:2): WARNING **: 13:27:52.167: Unable to acquire MPRIS D-Bus session ownership for name org.mpris.MediaPlayer2.org.webkitgtk.MiniBrowser This is because in `BubblewrapLauncher.cpp` the dbus permission is guarded behind `ENABLE(MEDIA_SESSION)`. At a glance I wasn't sure the best place to disable the MPRIS ownership with another guard, most of the PlatformMediaSessionManager code seems to be guarded by `ENABLE(MEDIA_STREAM)` instead. 1794610 1 pnormand 2021-09-17 14:17:43 -0700 MEDIA_SESSION != MEDIA_STREAM. What if you guard MediaSessionManagerGLib and RemoteCommandListenerGLib with ENABLE(MEDIA_SESSION)? 1794772 2 438559 pgriffis 2021-09-18 08:07:19 -0700 Created attachment 438559 Patch 1794773 3 pgriffis 2021-09-18 08:07:51 -0700 That seemed to work, see attached patch. 1794777 4 ews-feeder 2021-09-18 09:12:54 -0700 Committed r282727 (241864@main): <https://commits.webkit.org/241864@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438559. 438559 2021-09-18 08:07:19 -0700 2021-09-18 09:12:55 -0700 Patch bug-230420-20210918100718.patch text/plain 4976 pgriffis U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZmOTMyOThiMjg4YjY0 NjZmYjZjYWFiOTBkMGFiNmE4MDlhNmYwNS4uMDQ3NzgwN2U3MjkwMDk5MTBhNTkyNjhlNmJkYmVh OWY1Yjc4NmI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA5LTE4ICBQYXRy aWNrIEdyaWZmaXMgIDxwZ3JpZmZpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIERpc2Fi bGUgTWVkaWFTZXNzaW9uTWFuYWdlckdMaWIgd2hlbiBNRURJQV9TRVNTSU9OIGRpc2FibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzA0MjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV2aW91c2x5 IFdlYktpdCB3b3VsZCB0cnkgdG8gb3duIHRoZSBNUFJJUyBidXMgbmFtZXMgZXZlbiB0aG91Z2gK KyAgICAgICAgdGhlIGZlYXR1cmUgd2FzIGRpc2FibGVkLgorCisgICAgICAgICogcGxhdGZvcm0v UmVtb3RlQ29tbWFuZExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbW90ZUNvbW1h bmRMaXN0ZW5lcjo6cmVzZXRDcmVhdGlvbkZ1bmN0aW9uKToKKyAgICAgICAgKiBwbGF0Zm9ybS9h dWRpby9QbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAqIHBsYXRmb3Jt L2F1ZGlvL2dsaWIvTWVkaWFTZXNzaW9uTWFuYWdlckdMaWIuY3BwOgorICAgICAgICAqIHBsYXRm b3JtL2F1ZGlvL2dsaWIvTWVkaWFTZXNzaW9uTWFuYWdlckdMaWIuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuY3BwOgorICAgICAgICAqIHBsYXRm b3JtL2dsaWIvUmVtb3RlQ29tbWFuZExpc3RlbmVyR0xpYi5oOgorCiAyMDIxLTA5LTE3ICBTYW0g V2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgTUlNRSB0eXBlIGFuZCBV UkwgdG8gV2ViQ29yZTo6TW9kZWwgdG8gYWxsb3cgcHJvY2Vzc2luZyBkaWZmZXJlbnQgbW9kZWwg dHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlbW90ZUNvbW1hbmRM aXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZW1vdGVDb21tYW5kTGlzdGVu ZXIuY3BwCmluZGV4IGNjNzljODVmYjhkNTEwOWI1ZDI2NjQ0NTI2ZDRiZjA4Y2M4Y2M5OGYuLjk3 ZTkwZmYwZTkyZmNkNTE4NmMwOGU1ZjRhMDI5Zjc5MTFiMTllYTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1JlbW90ZUNvbW1hbmRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vUmVtb3RlQ29tbWFuZExpc3RlbmVyLmNwcApAQCAtNTIsNyArNTIs NyBAQCB2b2lkIFJlbW90ZUNvbW1hbmRMaXN0ZW5lcjo6cmVzZXRDcmVhdGlvbkZ1bmN0aW9uKCkK ICAgICByZW1vdGVDb21tYW5kTGlzdGVuZXJDcmVhdGlvbkZ1bmN0aW9uKCkgPSBbXSAoUmVtb3Rl Q29tbWFuZExpc3RlbmVyQ2xpZW50JiBjbGllbnQpIHsKICNpZiBQTEFURk9STShDT0NPQSkKICAg ICAgICAgcmV0dXJuIFJlbW90ZUNvbW1hbmRMaXN0ZW5lckNvY29hOjpjcmVhdGUoY2xpZW50KTsK LSNlbGlmIFVTRShHTElCKQorI2VsaWYgVVNFKEdMSUIpICYmIEVOQUJMRShNRURJQV9TRVNTSU9O KQogICAgICAgICByZXR1cm4gUmVtb3RlQ29tbWFuZExpc3RlbmVyR0xpYjo6Y3JlYXRlKGNsaWVu dCk7CiAjZWxzZQogICAgICAgICBVTlVTRURfUEFSQU0oY2xpZW50KTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0Zm9ybU1lZGlhU2Vzc2lvbk1h bmFnZXIuY3BwCmluZGV4IDNhZTRmYjhlYWI1NWY0Nzk2MTA5OGRjNjcwZWZmYTVjY2JkNzE4OWEu LjJjN2E5NzY2MjM5NjFiYjQyYjY4MzVhNjM1Nzc0Y2NjMjhhOTM0ZWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZvcm1NZWRpYVNlc3Np b25NYW5hZ2VyLmNwcApAQCAtNzQsMTIgKzc0LDEyIEBAIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFu YWdlciogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMo CiAgICAgcmV0dXJuIHNoYXJlZFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcigpLmdldCgpOwog fQogCi0jaWYgIVBMQVRGT1JNKENPQ09BKSAmJiAhVVNFKEdMSUIpCisjaWYgIVBMQVRGT1JNKENP Q09BKSAmJiAoIVVTRShHTElCKSB8fCAhRU5BQkxFKE1FRElBX1NFU1NJT04pKQogc3RkOjp1bmlx dWVfcHRyPFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcj4gUGxhdGZvcm1NZWRpYVNlc3Npb25N YW5hZ2VyOjpjcmVhdGUoKQogewogICAgIHJldHVybiBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyPihuZXcgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyKTsKIH0K LSNlbmRpZiAvLyAhUExBVEZPUk0oQ09DT0EpICYmICFVU0UoR0xJQikKKyNlbmRpZiAvLyAhUExB VEZPUk0oQ09DT0EpICYmICghVVNFKEdMSUIpIHx8ICFFTkFCTEUoTUVESUFfU0VTU0lPTikpCiAK IHZvaWQgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjp1cGRhdGVOb3dQbGF5aW5nSW5mb0lm TmVjZXNzYXJ5KCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L2dsaWIvTWVkaWFTZXNzaW9uTWFuYWdlckdMaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYXVkaW8vZ2xpYi9NZWRpYVNlc3Npb25NYW5hZ2VyR0xpYi5jcHAKaW5kZXggODE2ZWRlOGQy ZTYwMjU4YWEwNTU3MmM0YThkZmE2Mjg1YzY0OWNmYi4uYzcyZWUxYTFkZTgyZGI0YWMxZjllMGM1 NmU1OGI2ZTQxNmQ3YTZjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vZ2xpYi9NZWRpYVNlc3Npb25NYW5hZ2VyR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vYXVkaW8vZ2xpYi9NZWRpYVNlc3Npb25NYW5hZ2VyR0xpYi5jcHAKQEAgLTE5LDcg KzE5LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJNZWRpYVNlc3Npb25NYW5h Z2VyR0xpYi5oIgogCi0jaWYgVVNFKEdMSUIpCisjaWYgVVNFKEdMSUIpICYmIEVOQUJMRShNRURJ QV9TRVNTSU9OKQogCiAjaW5jbHVkZSAiQXBwbGljYXRpb25HTGliLmgiCiAjaW5jbHVkZSAiQXVk aW9TZXNzaW9uLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9n bGliL01lZGlhU2Vzc2lvbk1hbmFnZXJHTGliLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9nbGliL01lZGlhU2Vzc2lvbk1hbmFnZXJHTGliLmgKaW5kZXggOWU0ZmNhNjRmMmIwNjY3 ZjNmODE4ZDFmYWIyNDA4ODE0N2Y4OTdkNC4uOWI2NDFiMmIzMTYzNTIzMWJiNmFjM2FjZWExNjUw ODQ1OWI3YzVhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ2xp Yi9NZWRpYVNlc3Npb25NYW5hZ2VyR0xpYi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2F1ZGlvL2dsaWIvTWVkaWFTZXNzaW9uTWFuYWdlckdMaWIuaApAQCAtMTgsNyArMTgsNyBAQAog CiAjcHJhZ21hIG9uY2UKIAotI2lmIFVTRShHTElCKQorI2lmIFVTRShHTElCKSAmJiBFTkFCTEUo TUVESUFfU0VTU0lPTikKIAogI2luY2x1ZGUgIk5vd1BsYXlpbmdNYW5hZ2VyLmgiCiAjaW5jbHVk ZSAiUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9SZW1vdGVDb21tYW5kTGlzdGVuZXJHTGliLmNwcAppbmRl eCAxMzMxZGMyY2RiOWIwYTEzZDI0ZWQyM2JiMjdkNzY2NTEwZmU0ZGNiLi5kYmE4MTU5OGYzZTI0 MGEzMTY5ZWRjMmE4ZWYxNjM2YThjNzkxMjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dsaWIvUmVtb3RlQ29tbWFuZExpc3RlbmVyR0xpYi5jcHAKQEAgLTE5 LDcgKzE5LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJSZW1vdGVDb21tYW5k TGlzdGVuZXJHTGliLmgiCiAKLSNpZiBVU0UoR0xJQikKKyNpZiBVU0UoR0xJQikgJiYgRU5BQkxF KE1FRElBX1NFU1NJT04pCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9SZW1vdGVDb21tYW5kTGlzdGVuZXJHTGliLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuaApp bmRleCBkOTk4MDJhNjdkN2M1NWVjMjU1NzAxODdhNmRhMjRiNWU1N2UxYzk1Li4xNDIxZTk0Yzky ZjIxODAyYzI2NTcyYzMyYzFmNzdhZTg4OGFhMWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9nbGliL1JlbW90ZUNvbW1hbmRMaXN0ZW5lckdMaWIuaApAQCAtMjAs NyArMjAsNyBAQAogCiAjaW5jbHVkZSAiUmVtb3RlQ29tbWFuZExpc3RlbmVyLmgiCiAKLSNpZiBV U0UoR0xJQikKKyNpZiBVU0UoR0xJQikgJiYgRU5BQkxFKE1FRElBX1NFU1NJT04pCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAo=