230363 2021-09-16 11:01:23 -0700 Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with changing menu states. 2021-09-16 14:36:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner darin webkit-bug-importer wenson_hsieh oldest_to_newest 1794105 0 megan_gardner 2021-09-16 11:01:23 -0700 Fix TestWebKitAPI.WebKit.AppHighlightsInImageOverlays to work with changing menu states. 1794106 1 438370 megan_gardner 2021-09-16 11:04:21 -0700 Created attachment 438370 Patch 1794109 2 438370 wenson_hsieh 2021-09-16 11:05:16 -0700 Comment on attachment 438370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438370&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:101 > + EXPECT_EQ([contentView targetForAction:createHighlightForCurrentQuickNoteWithRangeSelector withSender:nil], nil); Maybe `EXPECT_NULL` to match the ones above? But this works too. 1794157 3 438383 megan_gardner 2021-09-16 12:23:07 -0700 Created attachment 438383 Patch 1794158 4 438384 megan_gardner 2021-09-16 12:23:30 -0700 Created attachment 438384 Patch for landing 1794160 5 438383 darin 2021-09-16 12:31:19 -0700 Comment on attachment 438383 Patch Not new to this patch, in fact this patch makes things better, but: I think a lot of our tests are using the EXPECT family backwards. It’s expected value first, then test expression. This affects the output when tests fail, and is worth getting right. 1794165 6 wenson_hsieh 2021-09-16 12:35:25 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 438383 [details] > Patch > > Not new to this patch, in fact this patch makes things better, but: I think > a lot of our tests are using the EXPECT family backwards. It’s expected > value first, then test expression. This affects the output when tests fail, > and is worth getting right. Good catch! Filed: <https://bugs.webkit.org/show_bug.cgi?id=230368>. 1794210 7 ews-feeder 2021-09-16 14:35:30 -0700 Committed r282601 (241762@main): <https://commits.webkit.org/241762@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438384. 1794214 8 webkit-bug-importer 2021-09-16 14:36:34 -0700 <rdar://problem/83213601> 438370 2021-09-16 11:04:21 -0700 2021-09-16 12:23:25 -0700 Patch bug-230363-20210916110420.patch text/plain 1870 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIzZjQwY2JhNjhjZTEwYzgyNzlkOGY0NDkzMDBlMmQy YzkxYzI2MS4uYTMxYmVjMTlhMTA2ODA1MmEyN2QyZGM1Mzc1MzRiMmM3NmIwMTMwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA5LTE2ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IFRlc3RXZWJLaXRBUEkuV2ViS2l0LkFwcEhpZ2hsaWdodHNJbkltYWdl T3ZlcmxheXMgdG8gd29yayB3aXRoIGNoYW5naW5nIG1lbnUgc3RhdGVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMzYzCisgICAgICAgIHJkYXI6 Ly84MjA5OTU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSB0ZXN0cyBhc3N1bWVzIHRoYXQgYm90aCBtZW51IGl0ZW1zIHdvdWxkIGJlIGF2YWls YWJsZSwgYnV0IHRoYXQgd2FzIGNoYW5nZWQgdG8gYmUgYmFzZWQgb24gdGhlIHZpc2liaWxpdHkK KyAgICAgICAgb2YgdGhlIHF1aWNrIG5vdGUgd2luZG93LCBzbyB1cGRhdGUgdGhlIHRlc3QgYWNj b3JkaW5nbHkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dL Q29udGVudFZpZXdFZGl0aW5nQWN0aW9ucy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA5 LTE1ICBHZXphIExvcmUgIDxnZXphbG9yZUBnbWFpbC5jb20+CiAKICAgICAgICAgQ2FjaGUgcmVz b3VyY2UgcGF0aHMgaW4gcnVuLWpzYy1zdHJlc3MtdGVzdHMgZm9yIHNwZWVkdXAKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tDb250ZW50Vmlld0Vk aXRpbmdBY3Rpb25zLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KaW5kZXggMjAzM2E1Y2M2NTNlZmViNWEzODlj OGM3OWVhMjJlMDRiZTFlNGY2MC4uMDEwNzlmMDBmZTNhM2Q2YmMzMjc5OTliZjBiNTE1OTFjNzk3 NmZlMSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9XS0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KQEAgLTk4LDcg Kzk4LDcgQEAgVEVTVChXZWJLaXQsIEFwcEhpZ2hsaWdodHNJbkltYWdlT3ZlcmxheXMpCiAgICAg W3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAic2ltcGxlIl07CiAgICAg W3dlYlZpZXcgc2VsZWN0QWxsOm5pbF07CiAgICAgW3dlYlZpZXcgd2FpdEZvck5leHRQcmVzZW50 YXRpb25VcGRhdGVdOwotICAgIEVYUEVDVF9FUShbY29udGVudFZpZXcgdGFyZ2V0Rm9yQWN0aW9u OmNyZWF0ZUhpZ2hsaWdodEZvckN1cnJlbnRRdWlja05vdGVXaXRoUmFuZ2VTZWxlY3RvciB3aXRo U2VuZGVyOm5pbF0sIGNvbnRlbnRWaWV3KTsKKyAgICBFWFBFQ1RfRVEoW2NvbnRlbnRWaWV3IHRh cmdldEZvckFjdGlvbjpjcmVhdGVIaWdobGlnaHRGb3JDdXJyZW50UXVpY2tOb3RlV2l0aFJhbmdl U2VsZWN0b3Igd2l0aFNlbmRlcjpuaWxdLCBuaWwpOwogICAgIEVYUEVDVF9FUShbY29udGVudFZp ZXcgdGFyZ2V0Rm9yQWN0aW9uOmNyZWF0ZUhpZ2hsaWdodEZvck5ld1F1aWNrTm90ZVdpdGhSYW5n ZVNlbGVjdG9yIHdpdGhTZW5kZXI6bmlsXSwgY29udGVudFZpZXcpOwogfQogCg== 438383 2021-09-16 12:23:07 -0700 2021-09-16 12:23:27 -0700 Patch bug-230363-20210916122306.patch text/plain 1867 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIzZjQwY2JhNjhjZTEwYzgyNzlkOGY0NDkzMDBlMmQy YzkxYzI2MS4uYTMxYmVjMTlhMTA2ODA1MmEyN2QyZGM1Mzc1MzRiMmM3NmIwMTMwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA5LTE2ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IFRlc3RXZWJLaXRBUEkuV2ViS2l0LkFwcEhpZ2hsaWdodHNJbkltYWdl T3ZlcmxheXMgdG8gd29yayB3aXRoIGNoYW5naW5nIG1lbnUgc3RhdGVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMzYzCisgICAgICAgIHJkYXI6 Ly84MjA5OTU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSB0ZXN0cyBhc3N1bWVzIHRoYXQgYm90aCBtZW51IGl0ZW1zIHdvdWxkIGJlIGF2YWls YWJsZSwgYnV0IHRoYXQgd2FzIGNoYW5nZWQgdG8gYmUgYmFzZWQgb24gdGhlIHZpc2liaWxpdHkK KyAgICAgICAgb2YgdGhlIHF1aWNrIG5vdGUgd2luZG93LCBzbyB1cGRhdGUgdGhlIHRlc3QgYWNj b3JkaW5nbHkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dL Q29udGVudFZpZXdFZGl0aW5nQWN0aW9ucy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA5 LTE1ICBHZXphIExvcmUgIDxnZXphbG9yZUBnbWFpbC5jb20+CiAKICAgICAgICAgQ2FjaGUgcmVz b3VyY2UgcGF0aHMgaW4gcnVuLWpzYy1zdHJlc3MtdGVzdHMgZm9yIHNwZWVkdXAKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tDb250ZW50Vmlld0Vk aXRpbmdBY3Rpb25zLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KaW5kZXggMjAzM2E1Y2M2NTNlZmViNWEzODlj OGM3OWVhMjJlMDRiZTFlNGY2MC4uNjk2ODA0YWM5M2IwODVkYmRkYzcwYzg4OTA4MTg3YmVkYWE2 MWFkMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9X S0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9XS0NvbnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW0KQEAgLTk4LDcg Kzk4LDcgQEAgVEVTVChXZWJLaXQsIEFwcEhpZ2hsaWdodHNJbkltYWdlT3ZlcmxheXMpCiAgICAg W3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAic2ltcGxlIl07CiAgICAg W3dlYlZpZXcgc2VsZWN0QWxsOm5pbF07CiAgICAgW3dlYlZpZXcgd2FpdEZvck5leHRQcmVzZW50 YXRpb25VcGRhdGVdOwotICAgIEVYUEVDVF9FUShbY29udGVudFZpZXcgdGFyZ2V0Rm9yQWN0aW9u OmNyZWF0ZUhpZ2hsaWdodEZvckN1cnJlbnRRdWlja05vdGVXaXRoUmFuZ2VTZWxlY3RvciB3aXRo U2VuZGVyOm5pbF0sIGNvbnRlbnRWaWV3KTsKKyAgICBFWFBFQ1RfTlVMTChbY29udGVudFZpZXcg dGFyZ2V0Rm9yQWN0aW9uOmNyZWF0ZUhpZ2hsaWdodEZvckN1cnJlbnRRdWlja05vdGVXaXRoUmFu Z2VTZWxlY3RvciB3aXRoU2VuZGVyOm5pbF0pOwogICAgIEVYUEVDVF9FUShbY29udGVudFZpZXcg dGFyZ2V0Rm9yQWN0aW9uOmNyZWF0ZUhpZ2hsaWdodEZvck5ld1F1aWNrTm90ZVdpdGhSYW5nZVNl bGVjdG9yIHdpdGhTZW5kZXI6bmlsXSwgY29udGVudFZpZXcpOwogfQogCg== 438384 2021-09-16 12:23:30 -0700 2021-09-16 14:35:30 -0700 Patch for landing bug-230363-20210916122329.patch text/plain 1865 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjIzZjQwY2JhNjhjZTEwYzgyNzlkOGY0NDkzMDBlMmQy YzkxYzI2MS4uYWNjZWI5NDdhMDVmZTMzNzhiZjVhZGNkMmIxNDJiYzBjYzE1YmY2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA5LTE2ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+ CisKKyAgICAgICAgRml4IFRlc3RXZWJLaXRBUEkuV2ViS2l0LkFwcEhpZ2hsaWdodHNJbkltYWdl T3ZlcmxheXMgdG8gd29yayB3aXRoIGNoYW5naW5nIG1lbnUgc3RhdGVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjMwMzYzCisgICAgICAgIHJkYXI6 Ly84MjA5OTU2MgorCisgICAgICAgIFJldmlld2VkIGJ5IFdlbnNvbiBIc2llaC4KKworICAgICAg ICBUaGUgdGVzdHMgYXNzdW1lcyB0aGF0IGJvdGggbWVudSBpdGVtcyB3b3VsZCBiZSBhdmFpbGFi bGUsIGJ1dCB0aGF0IHdhcyBjaGFuZ2VkIHRvIGJlIGJhc2VkIG9uIHRoZSB2aXNpYmlsaXR5Cisg ICAgICAgIG9mIHRoZSBxdWljayBub3RlIHdpbmRvdywgc28gdXBkYXRlIHRoZSB0ZXN0IGFjY29y ZGluZ2x5LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS0Nv bnRlbnRWaWV3RWRpdGluZ0FjdGlvbnMubW06CisgICAgICAgIChURVNUKToKKwogMjAyMS0wOS0x NSAgR2V6YSBMb3JlICA8Z2V6YWxvcmVAZ21haWwuY29tPgogCiAgICAgICAgIENhY2hlIHJlc291 cmNlIHBhdGhzIGluIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIGZvciBzcGVlZHVwCmRpZmYgLS1naXQg YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLQ29udGVudFZpZXdFZGl0 aW5nQWN0aW9ucy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tD b250ZW50Vmlld0VkaXRpbmdBY3Rpb25zLm1tCmluZGV4IDIwMzNhNWNjNjUzZWZlYjVhMzg5Yzhj NzllYTIyZTA0YmUxZTRmNjAuLjY5NjgwNGFjOTNiMDg1ZGJkZGM3MGM4ODkwODE4N2JlZGFhNjFh ZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tD b250ZW50Vmlld0VkaXRpbmdBY3Rpb25zLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvV0tDb250ZW50Vmlld0VkaXRpbmdBY3Rpb25zLm1tCkBAIC05OCw3ICs5 OCw3IEBAIFRFU1QoV2ViS2l0LCBBcHBIaWdobGlnaHRzSW5JbWFnZU92ZXJsYXlzKQogICAgIFt3 ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1lZDpAInNpbXBsZSJdOwogICAgIFt3 ZWJWaWV3IHNlbGVjdEFsbDpuaWxdOwogICAgIFt3ZWJWaWV3IHdhaXRGb3JOZXh0UHJlc2VudGF0 aW9uVXBkYXRlXTsKLSAgICBFWFBFQ1RfRVEoW2NvbnRlbnRWaWV3IHRhcmdldEZvckFjdGlvbjpj cmVhdGVIaWdobGlnaHRGb3JDdXJyZW50UXVpY2tOb3RlV2l0aFJhbmdlU2VsZWN0b3Igd2l0aFNl bmRlcjpuaWxdLCBjb250ZW50Vmlldyk7CisgICAgRVhQRUNUX05VTEwoW2NvbnRlbnRWaWV3IHRh cmdldEZvckFjdGlvbjpjcmVhdGVIaWdobGlnaHRGb3JDdXJyZW50UXVpY2tOb3RlV2l0aFJhbmdl U2VsZWN0b3Igd2l0aFNlbmRlcjpuaWxdKTsKICAgICBFWFBFQ1RfRVEoW2NvbnRlbnRWaWV3IHRh cmdldEZvckFjdGlvbjpjcmVhdGVIaWdobGlnaHRGb3JOZXdRdWlja05vdGVXaXRoUmFuZ2VTZWxl Y3RvciB3aXRoU2VuZGVyOm5pbF0sIGNvbnRlbnRWaWV3KTsKIH0KIAo=