230346 2021-09-16 06:42:28 -0700 Make sure to use event queue when settling RTCPeerConnection.addIceCandidate promise 2021-09-17 00:08:17 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1794026 0 youennf 2021-09-16 06:42:28 -0700 Make sure to use event queue when settling RTCPeerConnection.addIceCandidate promise 1794027 1 438343 youennf 2021-09-16 06:46:55 -0700 Created attachment 438343 Patch 1794357 2 ews-feeder 2021-09-17 00:07:18 -0700 Committed r282638 (241795@main): <https://commits.webkit.org/241795@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438343. 1794358 3 webkit-bug-importer 2021-09-17 00:08:17 -0700 <rdar://problem/83229244> 438343 2021-09-16 06:46:55 -0700 2021-09-17 00:07:18 -0700 Patch bug-230346-20210916154653.patch text/plain 7358 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgyNDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjc1ZjhmNWZmNTk1NWYx MmMwM2JlOTdjYzNmYTk0OTAxZWEyMjlmMy4uM2I1YTVhYWQyOTBiYzRhOGZmZWYwYjkzYjVhYzUy NTNlZGRmMDZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA5LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHN1cmUgdG8gdXNl IGV2ZW50IHF1ZXVlIHdoZW4gc2V0dGxpbmcgUlRDUGVlckNvbm5lY3Rpb24uYWRkSWNlQ2FuZGlk YXRlIHByb21pc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIzMDM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEJlZm9yZSB0aGUgcGF0Y2gsIHdlIHdlcmUgcmVzb2x2aW5nIHRoZSBwcm9taXNlIGluIGEg Y2FsbE9uTWFpblRocmVhZCBsYW1iZGEuCisgICAgICAgIFdlIG5vdyBkbyBsaWtlIGZvciBvdGhl ciBtZXRob2RzOiBob3AgdG8gbWFpbiB0aHJlYWQsIHRoZW4gcXVldWUgYSB0YXNrIGluIGV2ZW50 IGxvb3AgdG8gcmVzb2x2ZSB0aGUgcHJvbWlzZS4KKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGlu ZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUGVlckNvbm5lY3Rpb25C YWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBlZXJDb25uZWN0aW9uQmFja2VuZDo6YWRk SWNlQ2FuZGlkYXRlKToKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1BlZXJDb25uZWN0 aW9uQmFja2VuZC5oOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmFkZEljZUNh bmRpZGF0ZSk6CisKIDIwMjEtMDktMTYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIENvbXB1dGUgUlRDUGVlckNvbm5lY3Rpb24uY29ubmVjdGlvblN0YXRlIGFz IHBlciBodHRwczovL3czYy5naXRodWIuaW8vd2VicnRjLXBjLyNydGNwZWVyY29ubmVjdGlvbnN0 YXRlLWVudW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v UGVlckNvbm5lY3Rpb25CYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNwcAppbmRleCA1Y2IzYmNiODgxOGYzMjhjM2U4 ZDMyMGJlYzRjM2Y1YjIzMjlkNmNhLi5mNmYwYWFmM2I2YmQ3OWE2NzMxMzA3MzZjODZhOTU3YTQ0 YzQ1MzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1Bl ZXJDb25uZWN0aW9uQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwCkBAIC0yOTQsNDAgKzI5NCwzOSBAQCBz dGF0aWMgaW5saW5lIGJvb2wgc2hvdWxkSWdub3JlSWNlQ2FuZGlkYXRlKGNvbnN0IFJUQ0ljZUNh bmRpZGF0ZSYgaWNlQ2FuZGlkYXRlKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBQZWVy Q29ubmVjdGlvbkJhY2tlbmQ6OmFkZEljZUNhbmRpZGF0ZShSVENJY2VDYW5kaWRhdGUqIGljZUNh bmRpZGF0ZSwgRE9NUHJvbWlzZURlZmVycmVkPHZvaWQ+JiYgcHJvbWlzZSkKK3ZvaWQgUGVlckNv bm5lY3Rpb25CYWNrZW5kOjphZGRJY2VDYW5kaWRhdGUoUlRDSWNlQ2FuZGlkYXRlKiBpY2VDYW5k aWRhdGUsIEZ1bmN0aW9uPHZvaWQoRXhjZXB0aW9uT3I8dm9pZD4mJik+JiYgY2FsbGJhY2spCiB7 CiAgICAgQVNTRVJUKCFtX3BlZXJDb25uZWN0aW9uLmlzQ2xvc2VkKCkpOwogCiAgICAgaWYgKCFp Y2VDYW5kaWRhdGUpIHsKLSAgICAgICAgZW5kT2ZJY2VDYW5kaWRhdGVzKFdURk1vdmUocHJvbWlz ZSkpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgLy8gRklYTUU6IEFzIHBlciBodHRw czovL3czYy5naXRodWIuaW8vd2VicnRjLXBjLyNkb20tcnRjcGVlcmNvbm5lY3Rpb24tYWRkaWNl Y2FuZGlkYXRlKCksIHRoaXMgY2hlY2sgc2hvdWxkIGJlIGRvbmUgYmVmb3JlIGVucXVldWluZyB0 aGUgdGFzay4KLSAgICBpZiAoaWNlQ2FuZGlkYXRlLT5zZHBNaWQoKS5pc051bGwoKSAmJiAhaWNl Q2FuZGlkYXRlLT5zZHBNTGluZUluZGV4KCkpIHsKLSAgICAgICAgcHJvbWlzZS5yZWplY3QoRXhj ZXB0aW9uIHsgVHlwZUVycm9yLCAiVHJ5aW5nIHRvIGFkZCBhIGNhbmRpZGF0ZSB0aGF0IGlzIG1p c3NpbmcgYm90aCBzZHBNaWQgYW5kIHNkcE1MaW5lSW5kZXgiX3MgfSk7CisgICAgICAgIGNhbGxi YWNrKHsgfSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBpZiAoc2hvdWxkSWdub3Jl SWNlQ2FuZGlkYXRlKCppY2VDYW5kaWRhdGUpKSB7Ci0gICAgICAgIHByb21pc2UucmVzb2x2ZSgp OworICAgICAgICBjYWxsYmFjayh7IH0pOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg ZG9BZGRJY2VDYW5kaWRhdGUoKmljZUNhbmRpZGF0ZSwgW3dlYWtUaGlzID0gbWFrZVdlYWtQdHIo dGhpcyksIHByb21pc2UgPSBXVEZNb3ZlKHByb21pc2UpXShhdXRvJiYgcmVzdWx0KSBtdXRhYmxl IHsKLSAgICAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKLSAgICAgICAgaWYgKCF3ZWFrVGhp cyB8fCB3ZWFrVGhpcy0+bV9wZWVyQ29ubmVjdGlvbi5pc0Nsb3NlZCgpKQorICAgIGRvQWRkSWNl Q2FuZGlkYXRlKCppY2VDYW5kaWRhdGUsIFt3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHRoaXMpLCBj YWxsYmFjayA9IFdURk1vdmUoY2FsbGJhY2spXShhdXRvJiYgcmVzdWx0KSBtdXRhYmxlIHsKKyAg ICAgICAgaWYgKCF3ZWFrVGhpcykKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAo cmVzdWx0Lmhhc0V4Y2VwdGlvbigpKSB7Ci0gICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihX ZWJSVEMsICJBZGRpbmcgaWNlIGNhbmRpZGF0ZSBmYWlsZWQgJWQiLCByZXN1bHQuZXhjZXB0aW9u KCkuY29kZSgpKTsKLSAgICAgICAgICAgIHByb21pc2UucmVqZWN0KHJlc3VsdC5yZWxlYXNlRXhj ZXB0aW9uKCkpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9CisgICAgICAgIGF1dG8m IHBlZXJDb25uZWN0aW9uID0gd2Vha1RoaXMtPm1fcGVlckNvbm5lY3Rpb247CisgICAgICAgIHBl ZXJDb25uZWN0aW9uLnF1ZXVlVGFza0tlZXBpbmdPYmplY3RBbGl2ZShwZWVyQ29ubmVjdGlvbiwg VGFza1NvdXJjZTo6TmV0d29ya2luZywgWyZwZWVyQ29ubmVjdGlvbiwgY2FsbGJhY2sgPSBXVEZN b3ZlKGNhbGxiYWNrKSwgcmVzdWx0ID0gV1RGTW92ZShyZXN1bHQpXSgpIG11dGFibGUgeworICAg ICAgICAgICAgaWYgKHBlZXJDb25uZWN0aW9uLmlzQ2xvc2VkKCkpCisgICAgICAgICAgICAgICAg cmV0dXJuOworCisgICAgICAgICAgICBpZiAocmVzdWx0Lmhhc0V4Y2VwdGlvbigpKSB7CisgICAg ICAgICAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiQWRkaW5nIGljZSBjYW5kaWRh dGUgZmFpbGVkICVkIiwgcmVzdWx0LmV4Y2VwdGlvbigpLmNvZGUoKSk7CisgICAgICAgICAgICAg ICAgY2FsbGJhY2socmVzdWx0LnJlbGVhc2VFeGNlcHRpb24oKSk7CisgICAgICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgfQogCi0gICAgICAgIGlmIChhdXRvIGRlc2NyaXB0aW9ucyA9 IHJlc3VsdC5yZWxlYXNlUmV0dXJuVmFsdWUoKSkKLSAgICAgICAgICAgIHdlYWtUaGlzLT5tX3Bl ZXJDb25uZWN0aW9uLnVwZGF0ZURlc2NyaXB0aW9ucyhXVEZNb3ZlKCpkZXNjcmlwdGlvbnMpKTsK LSAgICAgICAgcHJvbWlzZS5yZXNvbHZlKCk7CisgICAgICAgICAgICBpZiAoYXV0byBkZXNjcmlw dGlvbnMgPSByZXN1bHQucmVsZWFzZVJldHVyblZhbHVlKCkpCisgICAgICAgICAgICAgICAgcGVl ckNvbm5lY3Rpb24udXBkYXRlRGVzY3JpcHRpb25zKFdURk1vdmUoKmRlc2NyaXB0aW9ucykpOwor ICAgICAgICAgICAgY2FsbGJhY2soeyB9KTsKKyAgICAgICAgfSk7CiAgICAgfSk7CiB9CiAKQEAg LTM4NiwxMSArMzg1LDYgQEAgdm9pZCBQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OmRvbmVHYXRoZXJp bmdDYW5kaWRhdGVzKCkKICAgICBtX3BlZXJDb25uZWN0aW9uLnVwZGF0ZUljZUdhdGhlcmluZ1N0 YXRlKFJUQ0ljZUdhdGhlcmluZ1N0YXRlOjpDb21wbGV0ZSk7CiB9CiAKLXZvaWQgUGVlckNvbm5l Y3Rpb25CYWNrZW5kOjplbmRPZkljZUNhbmRpZGF0ZXMoRE9NUHJvbWlzZURlZmVycmVkPHZvaWQ+ JiYgcHJvbWlzZSkKLXsKLSAgICBwcm9taXNlLnJlc29sdmUoKTsKLX0KLQogdm9pZCBQZWVyQ29u bmVjdGlvbkJhY2tlbmQ6OnN0b3AoKQogewogICAgIG1fb2ZmZXJBbnN3ZXJDYWxsYmFjayA9IG51 bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1Bl ZXJDb25uZWN0aW9uQmFja2VuZC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9QZWVyQ29ubmVjdGlvbkJhY2tlbmQuaAppbmRleCA1NzBkOTMzMWVmYWVkM2FjNzMxNzc3NTU3 YmVkMWE2ZWQwOGEzN2I1Li5mZTk0NTczZjM2Zjk4ODMwZDcwZWI3N2I1MDg5NTVjZWU3MjgyZDkz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1BlZXJDb25u ZWN0aW9uQmFja2VuZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v UGVlckNvbm5lY3Rpb25CYWNrZW5kLmgKQEAgLTk4LDcgKzk4LDcgQEAgcHVibGljOgogICAgIHZv aWQgY3JlYXRlQW5zd2VyKFJUQ0Fuc3dlck9wdGlvbnMmJiwgQ3JlYXRlQ2FsbGJhY2smJik7CiAg ICAgdm9pZCBzZXRMb2NhbERlc2NyaXB0aW9uKGNvbnN0IFJUQ1Nlc3Npb25EZXNjcmlwdGlvbios IEZ1bmN0aW9uPHZvaWQoRXhjZXB0aW9uT3I8dm9pZD4mJik+JiYpOwogICAgIHZvaWQgc2V0UmVt b3RlRGVzY3JpcHRpb24oY29uc3QgUlRDU2Vzc2lvbkRlc2NyaXB0aW9uJiwgRnVuY3Rpb248dm9p ZChFeGNlcHRpb25Pcjx2b2lkPiYmKT4mJik7Ci0gICAgdm9pZCBhZGRJY2VDYW5kaWRhdGUoUlRD SWNlQ2FuZGlkYXRlKiwgRE9NUHJvbWlzZURlZmVycmVkPHZvaWQ+JiYpOworICAgIHZvaWQgYWRk SWNlQ2FuZGlkYXRlKFJUQ0ljZUNhbmRpZGF0ZSosIEZ1bmN0aW9uPHZvaWQoRXhjZXB0aW9uT3I8 dm9pZD4mJik+JiYpOwogCiAgICAgdmlydHVhbCBzdGQ6OnVuaXF1ZV9wdHI8UlRDRGF0YUNoYW5u ZWxIYW5kbGVyPiBjcmVhdGVEYXRhQ2hhbm5lbEhhbmRsZXIoY29uc3QgU3RyaW5nJiwgY29uc3Qg UlRDRGF0YUNoYW5uZWxJbml0JikgPSAwOwogCkBAIC0yMjksNyArMjI5LDYgQEAgcHJpdmF0ZToK ICAgICB2aXJ0dWFsIHZvaWQgZG9TZXRMb2NhbERlc2NyaXB0aW9uKGNvbnN0IFJUQ1Nlc3Npb25E ZXNjcmlwdGlvbiopID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgZG9TZXRSZW1vdGVEZXNjcmlwdGlv bihjb25zdCBSVENTZXNzaW9uRGVzY3JpcHRpb24mKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRv QWRkSWNlQ2FuZGlkYXRlKFJUQ0ljZUNhbmRpZGF0ZSYsIEFkZEljZUNhbmRpZGF0ZUNhbGxiYWNr JiYpID0gMDsKLSAgICB2aXJ0dWFsIHZvaWQgZW5kT2ZJY2VDYW5kaWRhdGVzKERPTVByb21pc2VE ZWZlcnJlZDx2b2lkPiYmKTsKICAgICB2aXJ0dWFsIHZvaWQgZG9TdG9wKCkgPSAwOwogCiBwcm90 ZWN0ZWQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JU Q1BlZXJDb25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v UlRDUGVlckNvbm5lY3Rpb24uY3BwCmluZGV4IDFhZWIxZTBhZWEzMzJkMzg5NjU4MDhlNTY1MGU1 MTQ3NDZhMjA5ZGIuLjhmNTc4NGVmMDU2YzUwYjhjNTA0ZDRmNGM4ODE5NjE0Y2U5Mjk0YjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVl ckNvbm5lY3Rpb24uY3BwCkBAIC0zNDYsMTcgKzM0NiwyNyBAQCB2b2lkIFJUQ1BlZXJDb25uZWN0 aW9uOjphZGRJY2VDYW5kaWRhdGUoQ2FuZGlkYXRlJiYgcnRjQ2FuZGlkYXRlLCBSZWY8RGVmZXJy ZWRQcgogICAgICAgICB9KTsKICAgICB9CiAKKyAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIs ICJSZWNlaXZlZCBpY2UgY2FuZGlkYXRlOlxuIiwgY2FuZGlkYXRlID8gY2FuZGlkYXRlLT5jYW5k aWRhdGUoKSA6ICJudWxsIik7CisKICAgICBpZiAoZXhjZXB0aW9uKSB7CiAgICAgICAgIHByb21p c2UtPnJlamVjdCgqZXhjZXB0aW9uKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlm IChjYW5kaWRhdGUgJiYgY2FuZGlkYXRlLT5zZHBNaWQoKS5pc051bGwoKSAmJiAhY2FuZGlkYXRl LT5zZHBNTGluZUluZGV4KCkpIHsKKyAgICAgICAgcHJvbWlzZS0+cmVqZWN0KEV4Y2VwdGlvbiB7 IFR5cGVFcnJvciwgIlRyeWluZyB0byBhZGQgYSBjYW5kaWRhdGUgdGhhdCBpcyBtaXNzaW5nIGJv dGggc2RwTWlkIGFuZCBzZHBNTGluZUluZGV4Il9zIH0pOworICAgICAgICByZXR1cm47CisgICAg fQorCiAgICAgaWYgKGlzQ2xvc2VkKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFMV0FZU19M T0coTE9HSURFTlRJRklFUiwgIlJlY2VpdmVkIGljZSBjYW5kaWRhdGU6XG4iLCBjYW5kaWRhdGUg PyBjYW5kaWRhdGUtPmNhbmRpZGF0ZSgpIDogIm51bGwiKTsKICAgICBjaGFpbk9wZXJhdGlvbihX VEZNb3ZlKHByb21pc2UpLCBbdGhpcywgY2FuZGlkYXRlID0gV1RGTW92ZShjYW5kaWRhdGUpXShh dXRvJiYgcHJvbWlzZSkgbXV0YWJsZSB7Ci0gICAgICAgIG1fYmFja2VuZC0+YWRkSWNlQ2FuZGlk YXRlKGNhbmRpZGF0ZS5nZXQoKSwgV1RGTW92ZShwcm9taXNlKSk7CisgICAgICAgIG1fYmFja2Vu ZC0+YWRkSWNlQ2FuZGlkYXRlKGNhbmRpZGF0ZS5nZXQoKSwgW3Byb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKSwgcHJvbWlzZSA9IERPTVByb21pc2VEZWZlcnJlZDx2b2lkPihXVEZNb3ZlKHBy b21pc2UpKV0oYXV0byYmIHJlc3VsdCkgbXV0YWJsZSB7CisgICAgICAgICAgICBpZiAocHJvdGVj dGVkVGhpcy0+aXNDbG9zZWQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAg ICBwcm9taXNlLnNldHRsZShXVEZNb3ZlKHJlc3VsdCkpOworICAgICAgICB9KTsKICAgICB9KTsK IH0KIAo=